Cleanup csproj files (#1865)

Directory.Build.props

@@ -24,6 +24,9 @@
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     <UseArtifactsOutput>true</UseArtifactsOutput>
 
+    <LangVersion>latest</LangVersion>
+    <ImplicitUsings>enable</ImplicitUsings>
+
   </PropertyGroup>
 
   <ItemGroup>

Jint.Benchmark/Jint.Benchmark.csproj

@@ -17,6 +17,7 @@
     <LangVersion>latest</LangVersion>
     <IsPackable>false</IsPackable>
     <ImplicitUsings>enable</ImplicitUsings>
+    <NoWarn>$(NoWarn);CS8002</NoWarn>
   </PropertyGroup>
   <ItemGroup>
     <None Include=".\Scripts\*.*" CopyToOutputDirectory="PreserveNewest" />

Jint.Tests.CommonScripts/Jint.Tests.CommonScripts.csproj

@@ -1,8 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net8.0</TargetFrameworks>
-    <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
+    <TargetFrameworks>net462;net8.0</TargetFrameworks>
     <IsPackable>false</IsPackable>
     <ImplicitUsings>enable</ImplicitUsings>
     <LangVersion>latest</LangVersion>

Jint.Tests.PublicInterface/Jint.Tests.PublicInterface.csproj

@@ -1,8 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFrameworks>net8.0</TargetFrameworks>
-    <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">$(TargetFrameworks);net462</TargetFrameworks>
+    <TargetFrameworks>net462;net8.0</TargetFrameworks>
     <AssemblyOriginatorKeyFile>..\Jint\Jint.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>true</SignAssembly>
     <IsPackable>false</IsPackable>
@@ -17,10 +16,6 @@
     <ProjectReference Include="..\Jint\Jint.csproj" />
   </ItemGroup>
 
-  <ItemGroup>
-    <Reference Include="Microsoft.CSharp" Condition=" '$(TargetFramework)' == 'net462' " />
-  </ItemGroup>
-
   <ItemGroup>
     <PackageReference Include="Acornima.Extras" />
     <PackageReference Include="Flurl.Http.Signed" />

Jint.Tests.Test262/Jint.Tests.Test262.csproj

@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
-    <!--<TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">$(TargetFrameworks);net461</TargetFrameworks>-->
     <AssemblyOriginatorKeyFile>..\Jint\Jint.snk</AssemblyOriginatorKeyFile>
     <SignAssembly>true</SignAssembly>
     <IsPackable>false</IsPackable>

Jint.Tests/Jint.Tests.csproj

@@ -19,10 +19,6 @@
     <ProjectReference Include="..\Jint\Jint.csproj" />
   </ItemGroup>
 
-  <ItemGroup>
-    <Reference Include="Microsoft.CSharp" Condition=" '$(TargetFramework)' == 'net462' " />
-  </ItemGroup>
-
   <ItemGroup>
     <PackageReference Include="Acornima.Extras" />
     <PackageReference Include="FluentAssertions" />

Jint.Tests/Parser/JavascriptParserTests.cs

@@ -1,6 +1,4 @@
-using Jint.Runtime;
-
-namespace Jint.Tests.Parsing;
+namespace Jint.Tests.Parsing;
 
 public class JavascriptParserTests
 {

Jint.Tests/Runtime/InteropTests.MemberAccess.cs

@@ -183,7 +183,9 @@ namespace Jint.Tests.Runtime
 
         private class BaseClassWithStatics
         {
+#pragma warning disable CS0414 // Field is assigned but its value is never used
             public static int a = 42;
+#pragma warning restore CS0414 // Field is assigned but its value is never used
         }
 
         private class InheritingFromClassWithStatics : BaseClassWithStatics

Jint.Tests/Runtime/InteropTests.cs

@@ -3,7 +3,6 @@ using System.Globalization;
 using System.Reflection;
 using System.Runtime.CompilerServices;
 using Jint.Native;
-using Jint.Native.Symbol;
 using Jint.Runtime;
 using Jint.Runtime.Interop;
 using Jint.Tests.Runtime.Converters;

Jint/AstExtensions.cs

@@ -13,7 +13,9 @@ namespace Jint
 {
     public static class AstExtensions
     {
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
         internal static readonly SourceLocation DefaultLocation;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
 
         public static JsValue GetKey<T>(this T property, Engine engine) where T : IProperty => GetKey(property.Key, engine, property.Computed);
 

Jint/Jint.csproj

@@ -7,8 +7,6 @@
     <SignAssembly>true</SignAssembly>
     <IsPackable>true</IsPackable>
 
-    <LangVersion>latest</LangVersion>
-    <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
 

Jint/Native/Generator/GeneratorInstance.cs

@@ -13,7 +13,9 @@ internal sealed class GeneratorInstance : ObjectInstance
 {
     internal GeneratorState _generatorState;
     private ExecutionContext _generatorContext;
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
     private readonly JsValue? _generatorBrand;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
     private JintStatementList _generatorBody = null!;
 
     public JsValue? _nextValue;

Jint/Runtime/Interpreter/Expressions/JintLiteralExpression.cs

@@ -1,4 +1,3 @@
-using System.Numerics;
 using System.Text.RegularExpressions;
 using Jint.Native;
 

Jint/Runtime/Interpreter/Expressions/JintUpdateExpression.cs

@@ -1,6 +1,5 @@
 using Jint.Native;
 using Jint.Runtime.Environments;
-using Environment = Jint.Runtime.Environments.Environment;
 
 namespace Jint.Runtime.Interpreter.Expressions
 {