Improve efficiency with $prep_statement->fetchAll(); to $prep_statement->fetchAll(PDO::FETCH_NAMED);

flashphoner/request_credentials.php

@@ -56,7 +56,7 @@ if (!$prep_statement) {
 
 $prep_statement->execute();
 $x = 0;
-$result = $prep_statement->fetchAll();
+$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 
 // There is probably a better way to do this but this will work on anything
 foreach ($result as &$row) {
@@ -91,7 +91,7 @@ $sql .= "order by extension asc ";
 $prep_statement = $db->prepare(check_sql($sql));
 $prep_statement->execute();
 $x = 0;
-$result = $prep_statement->fetchAll();
+$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 foreach ($result as &$row) {
 	$extension_array[$x]['extension_uuid'] = $row["extension_uuid"];
 	$extension_array[$x]['extension'] = $row["extension"];

invoices/v_invoice_items.php

@@ -57,7 +57,7 @@ require_once "includes/paging.php";
 		$sql .= " limit $rows_per_page offset $offset ";
 		$prep_statement = $db->prepare(check_sql($sql));
 		$prep_statement->execute();
-		$result = $prep_statement->fetchAll();
+		$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 		$result_count = count($result);
 		unset ($prep_statement, $sql);
 

invoices/v_invoice_items_edit.php

@@ -112,7 +112,7 @@ if (count($_POST)>0 && strlen($_POST["persistformvar"]) == 0) {
 		$sql .= "where invoice_item_uuid = '$invoice_item_uuid' ";
 		$prep_statement = $db->prepare(check_sql($sql));
 		$prep_statement->execute();
-		$result = $prep_statement->fetchAll();
+		$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 		foreach ($result as &$row) {
 			$item_qty = $row["item_qty"];
 			$item_desc = $row["item_desc"];

invoices/v_invoice_pdf.php

@@ -77,7 +77,7 @@ else {
 	$sql .= "and contact_uuid = '$contact_uuid_from' ";
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	foreach ($result as &$row) {
 		$from_contact_organization = $row["contact_organization"];
 		$from_contact_name_given = $row["contact_name_given"];
@@ -93,7 +93,7 @@ else {
 	$sql .= "and contact_uuid = '$contact_uuid_from' ";
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	foreach ($result as &$row) {
 		$from_address_type = $row["address_type"];
 		$from_address_street = $row["address_street"];
@@ -131,7 +131,7 @@ else {
 	$sql .= "and contact_uuid = '$contact_uuid_to' ";
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	foreach ($result as &$row) {
 		$to_contact_organization = $row["contact_organization"];
 		$to_contact_name_given = $row["contact_name_given"];
@@ -147,7 +147,7 @@ else {
 	$sql .= "and contact_uuid = '$contact_uuid_to' ";
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	foreach ($result as &$row) {
 		$to_address_type = $row["address_type"];
 		$to_address_street = $row["address_street"];
@@ -236,7 +236,7 @@ else {
 	$sql .= "and invoice_uuid = '$invoice_uuid' ";
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	$fill = false;
 	$total = 0;
 	foreach ($result as &$row) {

invoices/v_invoices.php

@@ -101,7 +101,7 @@ require_once "includes/paging.php";
 		$sql .= " limit $rows_per_page offset $offset ";
 		$prep_statement = $db->prepare(check_sql($sql));
 		$prep_statement->execute();
-		$result = $prep_statement->fetchAll();
+		$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 		$result_count = count($result);
 		unset ($prep_statement, $sql);
 

invoices/v_invoices_edit.php

@@ -142,7 +142,7 @@ if (count($_POST)>0 && strlen($_POST["persistformvar"]) == 0) {
 		$sql .= "and invoice_uuid = '$invoice_uuid' ";
 		$prep_statement = $db->prepare(check_sql($sql));
 		$prep_statement->execute();
-		$result = $prep_statement->fetchAll();
+		$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 		foreach ($result as &$row) {
 			$invoice_number = $row["invoice_number"];
 			$invoice_date = $row["invoice_date"];
@@ -219,7 +219,7 @@ if (count($_POST)>0 && strlen($_POST["persistformvar"]) == 0) {
 	$sql .= " order by contact_organization asc ";
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	unset ($prep_statement, $sql);
 	echo "<select name=\"contact_uuid_from\" id=\"contact_uuid_from\" class=\"formfld\">\n";
 	echo "<option value=\"\"></option>\n";
@@ -262,7 +262,7 @@ if (count($_POST)>0 && strlen($_POST["persistformvar"]) == 0) {
 	$sql .= " order by contact_organization asc ";
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	unset ($prep_statement, $sql);
 	echo "<select name=\"contact_uuid_to\" id=\"contact_uuid_to\" class=\"formfld\">\n";
 	echo "<option value=\"\"></option>\n";

tickets/v_manager.php

@@ -82,7 +82,7 @@ $sql .= "order by status_id ";
 $prep_statement = $db->prepare(check_sql($sql));
 $prep_statement->execute();
 $x = 0;
-$result = $prep_statement->fetchAll();
+$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 foreach ($result as &$row) {
 	$statuses[$row['status_id']] = $row;
 }
@@ -95,7 +95,7 @@ $sql .= "order by queue_id ";
 $prep_statement = $db->prepare(check_sql($sql));
 $prep_statement->execute();
 $x = 0;
-$result = $prep_statement->fetchAll();
+$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 foreach ($result as &$row) {
 	$queues[$row['queue_id']] = $row;
 }

tickets/v_profile_delete.php

@@ -51,7 +51,7 @@ $prep_statement = $db->prepare(check_sql($sql));
 $prep_statement->execute();
 
 $x = 0;
-$result = $prep_statement->fetchAll();
+$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 foreach ($result as &$row) {
 	$profiles_array[$x] = $row;
 	$x++;

tickets/v_ticket_create.php

@@ -50,7 +50,7 @@ $sql .= "order by queue_name ";
 $prep_statement = $db->prepare(check_sql($sql));
 $prep_statement->execute();
 $x = 0; 
-$result = $prep_statement->fetchAll();
+$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 foreach ($result as &$row) { 
         $queues[$x] = $row;
         $x++;
@@ -127,7 +127,7 @@ if ($action == "add" && permission_exists('ticket_add')) {
 	 	$sql .= "RETURNING ticket_id;";
 		$prep_statement = $db->prepare(check_sql($sql));
 		$prep_statement->execute();
-        	$result = $prep_statement->fetchAll();
+        	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 		$ticket_id = $result[0]['ticket_id'];
 	} elseif ($db_type == "sqlite" || $db_type == "mysql" ) {
                 $db->exec(check_sql($sql));
@@ -161,7 +161,7 @@ if ($action == "add" && permission_exists('ticket_add')) {
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
 	$x = 0; 
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	foreach ($result as &$row) { 
         	$queue = $row;
         	break;

tickets/v_ticket_update.php

@@ -86,7 +86,7 @@ if ($action == "update") {
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
 	$x = 0;
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	foreach ($result as &$row) {
 		$ticket_header = $row;
 		$x++;
@@ -106,7 +106,7 @@ if ($action == "update") {
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
 	$x = 0;
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	foreach ($result as &$row) {
 		$ticket_notes[$x] = $row;
 		$x++;
@@ -120,7 +120,7 @@ if ($action == "update") {
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
 	$x = 0;
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	foreach ($result as &$row) {
 		$queue_members[$x] = $row;
 		$x++;
@@ -134,7 +134,7 @@ if ($action == "update") {
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
 	$x = 0;
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	foreach ($result as &$row) {
 		$ticket_statuses[$x] = $row;
 		$x++;
@@ -148,7 +148,7 @@ if ($action == "update") {
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
 	$x = 0;
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	foreach ($result as &$row) {
 		$ticket_queues[$x] = $row;
 		$x++;
@@ -208,7 +208,7 @@ if ($action == "update" && permission_exists('ticket_update')) {
 	        $prep_statement = $db->prepare(check_sql($sql));
 		$prep_statement->execute();
 		$x = 0;
-		$result = $prep_statement->fetchAll();
+		$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 		foreach ($result as &$row) {
 			$user_email = $row['user_email'];
 			break;
@@ -233,7 +233,7 @@ if ($action == "update" && permission_exists('ticket_update')) {
 	        $prep_statement = $db->prepare(check_sql($sql));
 		$prep_statement->execute();
 		$x = 0;
-		$result = $prep_statement->fetchAll();
+		$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 		foreach ($result as &$row) {
 			$user_email = $row['user_email'];
 			break;

tickets/v_tickets.php

@@ -56,7 +56,7 @@ $sql .= "order by ticket_status, queue_id ";
 $prep_statement = $db->prepare(check_sql($sql));
 $prep_statement->execute();
 $x = 0;
-$result = $prep_statement->fetchAll();
+$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 foreach ($result as &$row) {
 	$tickets[$x] = $row;
 	$x++;
@@ -68,7 +68,7 @@ $sql .= "select * from v_ticket_statuses ";
 $prep_statement = $db->prepare(check_sql($sql));
 $prep_statement->execute();
 $x = 0;
-$result = $prep_statement->fetchAll();
+$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 foreach ($result as &$row) {
 	$statuses[$row['status_id']] = $row['status_name'];
 }
@@ -80,7 +80,7 @@ $sql .= "where domain_uuid = $domain_uuid ";
 $prep_statement = $db->prepare(check_sql($sql));
 $prep_statement->execute();
 $x = 0;
-$result = $prep_statement->fetchAll();
+$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 foreach ($result as &$row) {
 	$queues[$row['queue_id']] = $row['queue_name'];
 }

user_contacts/users.php

@@ -60,7 +60,7 @@ require_once "includes/paging.php";
 	if (strlen($order_by)> 0) { $sql .= "order by $order_by $order "; }
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	$num_rows = count($result);
 	unset ($prep_statement, $result, $sql);
 
@@ -78,7 +78,7 @@ require_once "includes/paging.php";
 	$sql .= "limit $rows_per_page offset $offset ";
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	$result_count = count($result);
 	unset ($prep_statement, $sql);
 

user_contacts/users_edit.php

@@ -347,7 +347,7 @@ if (count($_POST)>0 && strlen($_POST["persistformvar"]) == 0) {
 			$sql .= "and id = '$id' ";
 			$prep_statement = $db->prepare(check_sql($sql));
 			$prep_statement->execute();
-			$result = $prep_statement->fetchAll();
+			$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 			foreach ($result as &$row) {
 				//$username = $row["username"];
 				//$password = $row["password"];

user_contacts/users_vcard.php

@@ -45,7 +45,7 @@ if (count($_GET)>0) {
 	$sql .= "and id = '$id' ";
 	$prep_statement = $db->prepare(check_sql($sql));
 	$prep_statement->execute();
-	$result = $prep_statement->fetchAll();
+	$result = $prep_statement->fetchAll(PDO::FETCH_NAMED);
 	foreach ($result as &$row) {
 
 		$vc->data[display_name] = $row["user_first_name"]." ".$row["user_last_name"];