Fix temporary permissions

core/authentication/app_defaults.php

@@ -94,7 +94,7 @@
 		//add the missing email templates
 		if (!empty($array['email_templates'])) {
 			//add the temporary permission
-			$p = new permissions;
+			$p = permissions::new();
 			$p->add("email_template_add", 'temp');
 			$p->add("email_template_edit", 'temp');
 

core/authentication/resources/classes/plugins/database.php

@@ -310,7 +310,7 @@ class plugin_database {
 								$array['user_groups'][0]['user_uuid'] = $this->user_uuid;
 
 							//grant temporary permissions
-								$p = new permissions;
+								$p = permissions::new();
 								$p->add('user_edit', 'temp');
 
 							//execute insert

core/authentication/resources/classes/plugins/email.php

@@ -258,7 +258,7 @@ class plugin_email {
 					$hostname = gethostname();
 
 					//add the temporary permissions
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add("email_queue_add", 'temp');
 					$p->add("email_queue_edit", 'temp');
 

core/authentication/resources/classes/plugins/ldap.php

@@ -178,7 +178,7 @@ class plugin_ldap {
 						$array['user_groups'][0]['user_uuid'] = $this->user_uuid;
 
 					//grant temporary permissions
-						$p = new permissions;
+						$p = permissions::new();
 						$p->add('user_add', 'temp');
 						$p->add('user_group_add', 'temp');
 

core/authentication/resources/classes/plugins/totp.php

@@ -224,7 +224,7 @@ class plugin_totp {
 					$array['users'][$x]['user_totp_secret'] = $this->user_totp_secret;
 
 					//add the user_edit permission
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add("user_edit", "temp");
 
 					//save the data

core/contacts/contact_address_edit.php

@@ -131,7 +131,7 @@
 					$array['contacts'][0]['last_mod_date'] = 'now()';
 					$array['contacts'][0]['last_mod_user'] = $_SESSION['username'];
 
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('contact_edit', 'temp');
 
 					$database = new database;

core/contacts/contact_edit.php

@@ -543,7 +543,7 @@
 		//save the data
 			if (!empty($array)) {
 				//add the permission object
-				$p = new permissions;
+				$p = permissions::new();
 				$p->add('contact_add', 'temp');
 				$p->add('contact_phone_add', 'temp');
 				$p->add('contact_address_add', 'temp');

core/contacts/contact_email_edit.php

@@ -112,7 +112,7 @@ if (!empty($_GET["contact_uuid"]) && is_uuid($_GET["contact_uuid"])) {
 					$array['contacts'][0]['last_mod_date'] = 'now()';
 					$array['contacts'][0]['last_mod_user'] = $_SESSION['username'];
 
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('contact_edit', 'temp');
 
 					$database = new database;

core/contacts/contact_import_google.php

@@ -107,7 +107,7 @@ if ($_POST['a'] == 'import') {
 					unset($duplicate_contact_uuid);
 
 				//grant temporary permissions
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('contact_delete', 'temp');
 
 				//delete duplicate contact

core/contacts/contact_note_edit.php

@@ -102,7 +102,7 @@
 					$array['contacts'][0]['last_mod_date'] = 'now()';
 					$array['contacts'][0]['last_mod_user'] = $_SESSION['username'];
 
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('contact_edit', 'temp');
 
 					$database = new database;

core/contacts/contact_phone_edit.php

@@ -132,7 +132,7 @@
 					$array['contacts'][0]['last_mod_date'] = 'now()';
 					$array['contacts'][0]['last_mod_user'] = $_SESSION['username'];
 
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('contact_edit', 'temp');
 
 					$database = new database;

core/contacts/contact_relation_edit.php

@@ -110,7 +110,7 @@
 					$array['contacts'][0]['last_mod_date'] = 'now()';
 					$array['contacts'][0]['last_mod_user'] = $_SESSION['username'];
 
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('contact_edit', 'temp');
 
 					$database = new database;

core/contacts/contact_setting_edit.php

@@ -129,7 +129,7 @@
 					$array['contacts'][0]['last_mod_date'] = 'now()';
 					$array['contacts'][0]['last_mod_user'] = $_SESSION['username'];
 
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('contact_edit', 'temp');
 
 					$database = new database;

core/contacts/contact_time_edit.php

@@ -102,7 +102,7 @@
 				$array['contacts'][0]['last_mod_date'] = 'now()';
 				$array['contacts'][0]['last_mod_user'] = $_SESSION['username'];
 
-				$p = new permissions;
+				$p = permissions::new();
 				$p->add('contact_edit', 'temp');
 
 				$database = new database;

core/contacts/contact_url_edit.php

@@ -115,7 +115,7 @@
 				$array['contacts'][0]['last_mod_date'] = 'now()';
 				$array['contacts'][0]['last_mod_user'] = $_SESSION['username'];
 
-				$p = new permissions;
+				$p = permissions::new();
 				$p->add('contact_edit', 'temp');
 
 				$database = new database;

core/contacts/resources/classes/contacts.php

@@ -108,7 +108,7 @@ if (!class_exists('contacts')) {
 							if (is_array($array) && @sizeof($array) != 0) {
 
 								//grant temp permissions
-									$p = new permissions;
+									$p = permissions::new();
 									$database = new database;
 									foreach ($this->tables as $table) {
 										$p->add(database::singular($table).'_delete', 'temp');

core/dashboard/app_defaults.php

@@ -98,7 +98,7 @@ if ($domains_processed == 1) {
 		}
 
 	//add the temporary permissions
-		$p = new permissions;
+		$p = permissions::new();
 		$p->add('dashboard_add', 'temp');
 		$p->add('dashboard_group_add', 'temp');
 

core/default_settings/default_setting_edit.php

@@ -159,7 +159,7 @@
 						unset($sql, $parameters);
 
 					//update the timezone
-						$p = new permissions;
+						$p = permissions::new();
 						if ($detail_action == "update") {
 							$array['dialplan_details'][0]['dialplan_detail_uuid'] = $dialplan_detail_uuid;
 							$array['dialplan_details'][0]['dialplan_detail_data'] = 'timezone='.$default_setting_value;

core/domain_settings/domain_setting_edit.php

@@ -155,7 +155,7 @@
 							unset($sql, $parameters);
 
 						//update the timezone
-							$p = new permissions;
+							$p = permissions::new();
 							if ($detail_action == "update") {
 								$array['dialplan_details'][0]['dialplan_detail_uuid'] = $dialplan_detail_uuid;
 								$array['dialplan_details'][0]['dialplan_detail_data'] = 'timezone='.$domain_setting_value;
@@ -280,7 +280,7 @@
 										$array['dialplan_details'][0]['dialplan_detail_group'] = $dialplan_detail_group;
 										$array['dialplan_details'][0]['dialplan_detail_order'] = '15';
 
-										$p = new permissions;
+										$p = permissions::new();
 										$p->add('dialplan_detail_add', 'temp');
 									}
 
@@ -289,7 +289,7 @@
 										$array['dialplan_details'][0]['dialplan_detail_uuid'] = $dialplan_detail_uuid;
 										$array['dialplan_details'][0]['dialplan_detail_data'] = 'timezone='.$domain_setting_value;
 
-										$p = new permissions;
+										$p = permissions::new();
 										$p->add('dialplan_detail_edit', 'temp');
 									}
 

core/email_queue/resources/jobs/email_send.php

@@ -443,7 +443,7 @@
 			$array['email_queue'][0]['email_status'] = 'sent';
 
 		//grant temporary permissions
-			$p = new permissions;
+			$p = permissions::new();
 			$p->add('email_queue_add', 'temp');
 			$p->add('email_queue_update', 'temp');
 		//execute insert
@@ -474,7 +474,7 @@
 		$array['email_queue'][0]['email_status'] = 'failed';
 
 		//grant temporary permissions
-		$p = new permissions;
+		$p = permissions::new();
 		$p->add('email_queue_add', 'temp');
 
 		//execute insert
@@ -528,7 +528,7 @@
 					$array['email_logs'][0]['status'] = 'failed';
 					$array['email_logs'][0]['email'] = str_replace("'", "''", $msg);
 				//grant temporary permissions
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('email_log_add', 'temp');
 				//execute insert
 					$database->app_name = 'v_mailto';

core/groups/group_member_add.php

@@ -68,7 +68,7 @@
 		$array['user_groups'][0]['group_name'] = $group_name;
 		$array['user_groups'][0]['user_uuid'] = $user_uuid;
 
-		$p = new permissions;
+		$p = permissions::new();
 		$p->add('user_group_add', 'temp');
 
 		$database->app_name = 'groups';

core/groups/permissions_copy.php

@@ -113,7 +113,7 @@
 				}
 				if (is_array($array) && sizeof($array) != 0) {
 					//grant temporary permissions
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('group_permission_add', 'temp');
 
 					//execute insert

core/groups/resources/classes/permission.php

@@ -95,7 +95,7 @@
 						}
 						if (is_array($array) && @sizeof($array) != 0) {
 							//grant temporary permissions
-								$p = new permissions;
+								$p = permissions::new();
 								$p->add('group_permission_delete', 'temp');
 							//execute delete
 								$database = new database;
@@ -185,7 +185,7 @@
 
 					if (is_array($array) && @sizeof($array)) {
 						//grant temporary permissions
-							$p = new permissions;
+							$p = permissions::new();
 							$p->add('group_permission_add', 'temp');
 
 						//execute insert

core/install/install.php

@@ -205,7 +205,7 @@
 			//if the domain name does not exist then add the domain name
 			if (!$domain_exists) {
 				//add the domain permission
-				$p = new permissions;
+				$p = permissions::new();
 				$p->add("domain_add", "temp");
 
 				//prepare the array
@@ -271,7 +271,7 @@
 			unset($parameters);
 
 			//add the user permission
-			$p = new permissions;
+			$p = permissions::new();
 			$p->add("user_add", "temp");
 			$p->add("user_edit", "temp");
 			$p->add("user_group_add", "temp");

core/notifications/app_defaults.php

@@ -36,7 +36,7 @@ if ($domains_processed == 1) {
 	//			$array['notifications'][0]['notification_uuid'] = uuid();
 	//			$array['notifications'][0]['project_notifications'] = 'false';
 	//		//grant temporary permissions
-	//			$p = new permissions;
+	//			$p = permissions::new();
 	//			$p->add('notification_add', 'temp');
 	//		//execute insert
 	//			$database->app_name = 'notifications';

core/permissions/app_defaults.php

@@ -45,7 +45,7 @@ if ($domains_processed == 1) {
 	//save the data to the database
 		if (!empty($array)) {
 			//grant temporary permissions
-				$p = new permissions;
+				$p = permissions::new();
 				$p->add('permission_add', 'temp');
 
 			//execute insert

core/software/app_defaults.php

@@ -46,7 +46,7 @@ if ($domains_processed == 1) {
 	//save the data in the array
 		if (!empty($array)) {
 			//add the temporary permission
-			$p = new permissions;
+			$p = permissions::new();
 			$p->add("software_add", 'temp');
 			$p->add("software_edit", 'temp');
 

core/user_logs/resources/classes/user_logs.php

@@ -84,7 +84,7 @@ if (!class_exists('user_logs')) {
 				}
 
 			//add the dialplan permission
-				$p = new permissions;
+				$p = permissions::new();
 				$p->add("user_log_add", 'temp');
 
 			//save to the data

core/user_settings/user_setting_edit.php

@@ -156,14 +156,14 @@ if (!empty($_POST) && empty($_POST["persistformvar"])) {
 
 					//update the timezone
 						if ($detail_action == "update") {
-							$p = new permissions;
+							$p = permissions::new();
 							$p->add('dialplan_detail_edit', 'temp');
 
 							$array['dialplan_details'][0]['dialplan_detail_uuid'] = $dialplan_detail_uuid;
 							$array['dialplan_details'][0]['dialplan_detail_data'] = 'timezone='.$user_setting_value;
 						}
 						else {
-							$p = new permissions;
+							$p = permissions::new();
 							$p->add('dialplan_detail_add', 'temp');
 
 							$array['dialplan_details'][0]['domain_uuid'] = $domain_uuid;
@@ -266,7 +266,7 @@ if (!empty($_POST) && empty($_POST["persistformvar"])) {
 									$array['dialplan_details'][0]['dialplan_detail_group'] = !empty($dialplan_detail_group) ? $dialplan_detail_group : 'null';
 									$array['dialplan_details'][0]['dialplan_detail_order'] = '15';
 
-									$p = new permissions;
+									$p = permissions::new();
 									$p->add('dialplan_detail_add', 'temp');
 
 									$database->app_name = 'user_settings';
@@ -284,7 +284,7 @@ if (!empty($_POST) && empty($_POST["persistformvar"])) {
 									$array['dialplan_details'][0]['domain_uuid'] = $_SESSION["domain_uuid"];
 									$array['dialplan_details'][0]['dialplan_uuid'] = $dialplan_uuid;
 
-									$p = new permissions;
+									$p = permissions::new();
 									$p->add('dialplan_detail_edit', 'temp');
 
 									$database->app_name = 'user_settings';

core/user_settings/user_setting_set.php

@@ -97,7 +97,7 @@ Mark J Crane <[email protected]>
 						$array['user_settings'][0]['user_uuid'] = $_SESSION['user_uuid'];
 						$array['user_settings'][0]['domain_uuid'] = $_SESSION['domain_uuid'];
 					//grant temporary permissions
-						$p = new permissions;
+						$p = permissions::new();
 						$p->add('user_setting_delete', 'temp');
 					//execute
 						$database->app_name = 'user_settings';
@@ -132,7 +132,7 @@ Mark J Crane <[email protected]>
 					$array['user_settings'][0]['user_setting_enabled'] = $user_setting_enabled;
 
 				//grant temporary permissions
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('user_setting_add', 'temp');
 					$p->add('user_setting_edit', 'temp');
 

core/users/app_defaults.php

@@ -151,7 +151,7 @@ if ($domains_processed == 1) {
 			$array['default_settings'][$x]['default_setting_subcategory'] = "password_special";
 
 			//add the temporary permission
-			$p = new permissions;
+			$p = permissions::new();
 			$p->add("default_setting_edit", 'temp');
 
 			//save to the data
@@ -200,7 +200,7 @@ if ($domains_processed == 1) {
 				$x++;
 
 				//add the temporary permission
-				$p = new permissions;
+				$p = permissions::new();
 				$p->add("email_template_add", 'temp');
 				$p->add("email_template_edit", 'temp');
 

core/users/resources/classes/users.php

@@ -130,7 +130,7 @@ if (!class_exists('users')) {
 						//delete the checked rows
 							if (is_array($array) && @sizeof($array) != 0) {
 								//execute
-									$p = new permissions;
+									$p = permissions::new();
 									$p->add('user_setting_delete', 'temp');
 									$p->add('user_group_delete', 'temp');
 

core/users/user_edit.php

@@ -88,7 +88,7 @@
 			$array['user_groups'][0]['group_uuid'] = $group_uuid;
 			$array['user_groups'][0]['user_uuid'] = $user_uuid;
 
-			$p = new permissions;
+			$p = permissions::new();
 			$p->add('user_group_delete', 'temp');
 
 			$database->delete($array);
@@ -297,7 +297,7 @@
 					$array_delete['user_settings'][0]['user_setting_subcategory'] = 'language';
 					$array_delete['user_settings'][0]['user_uuid'] = $user_uuid;
 
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('user_setting_delete', 'temp');
 
 					$database->delete($array_delete);
@@ -345,7 +345,7 @@
 					$array_delete['user_settings'][0]['user_setting_subcategory'] = 'time_zone';
 					$array_delete['user_settings'][0]['user_uuid'] = $user_uuid;
 
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('user_setting_delete', 'temp');
 
 					$database->delete($array_delete);
@@ -394,7 +394,7 @@
 						$array_delete['user_settings'][0]['user_setting_subcategory'] = 'key';
 						$array_delete['user_settings'][0]['user_uuid'] = $user_uuid;
 
-						$p = new permissions;
+						$p = permissions::new();
 						$p->add('user_setting_delete', 'temp');
 
 						$database->delete($array_delete);
@@ -555,7 +555,7 @@
 			$x++;
 
 		//add the user_edit permission
-			$p = new permissions;
+			$p = permissions::new();
 			$p->add("user_setting_add", "temp");
 			$p->add("user_setting_edit", "temp");
 			$p->add("user_edit", "temp");

logout.php

@@ -89,7 +89,7 @@
 							$array['user_settings'][0]['user_setting_value'] = $referrer;
 							$array['user_settings'][0]['user_setting_enabled'] = 'true';
 						//grant temporary permissions
-							$p = new permissions;
+							$p = permissions::new();
 							$p->add('user_setting_add', 'temp');
 						//execute insert
 							$database = new database;

resources/classes/domains.php

@@ -707,7 +707,7 @@ if (!class_exists('domains')) {
 			//add the missing default settings
 				if (isset($array) && is_array($array) && count($array) > 0) {
 					//grant temporary permissions
-						$p = new permissions;
+						$p = permissions::new();
 						$p->add('default_setting_add', 'temp');
 
 					//execute insert

resources/classes/email.php

@@ -335,7 +335,7 @@ if (!class_exists('email')) {
 				}
 
 				//add temporary permissions
-				$p = new permissions;
+				$p = permissions::new();
 				$p->add("email_queue_add", 'temp');
 				$p->add("email_queue_attachment_add", 'temp');
 

resources/classes/groups.php

@@ -141,7 +141,7 @@ if (!class_exists('groups')) {
 							if (is_array($array) && @sizeof($array) != 0) {
 
 								//grant temporary permissions
-									$p = new permissions;
+									$p = permissions::new();
 									$p->add('group_permission_delete', 'temp');
 
 								//execute delete
@@ -193,7 +193,7 @@ if (!class_exists('groups')) {
 							if (is_array($array) && @sizeof($array) != 0) {
 
 								//grant temporary permissions
-									$p = new permissions;
+									$p = permissions::new();
 									$p->add('user_group_delete', 'temp');
 
 								//execute delete
@@ -437,7 +437,7 @@ if (!class_exists('groups')) {
 					$group_uuids[$array['groups'][$x]['group_name']] = $array['groups'][$x]['group_uuid'];
 
 					//add the temporary permissions
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add("group_add", "temp");
 					$p->add("group_edit", "temp");
 
@@ -482,7 +482,7 @@ if (!class_exists('groups')) {
 					unset($group_uuids);
 
 					//add the temporary permissions
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add("group_permission_add", "temp");
 					$p->add("group_permission_edit", "temp");
 

resources/classes/menu.php

@@ -120,7 +120,7 @@ if (!class_exists('menu')) {
 						//delete the checked rows
 							if (is_array($array) && @sizeof($array) != 0) {
 								//grant temporary permissions
-									$p = new permissions;
+									$p = permissions::new();
 									$p->add('menu_item_delete', 'temp');
 									$p->add('menu_item_group_delete', 'temp');
 									$p->add('menu_language_delete', 'temp');
@@ -205,7 +205,7 @@ if (!class_exists('menu')) {
 							if (!empty($array) && is_array($array) && @sizeof($array) != 0) {
 
 								//grant temporary permissions
-									$p = new permissions;
+									$p = permissions::new();
 									$p->add('menu_language_delete', 'temp');
 									$p->add('menu_item_group_delete', 'temp');
 
@@ -493,7 +493,7 @@ if (!class_exists('menu')) {
 					}
 					if (is_array($array) && @sizeof($array) != 0) {
 						//grant temporary permissions
-							$p = new permissions;
+							$p = permissions::new();
 							$p->add('menu_item_add', 'temp');
 							$p->add('menu_language_add', 'temp');
 						//execute insert
@@ -558,7 +558,7 @@ if (!class_exists('menu')) {
 
 					if (is_array($array) && @sizeof($array) != 0) {
 						//grant temporary permissions
-							$p = new permissions;
+							$p = permissions::new();
 							$p->add('menu_item_group_add', 'temp');
 						//execute insert
 							$this->database->app_name = 'menu';
@@ -887,7 +887,7 @@ if (!class_exists('menu')) {
 						$array['menus'][0]['menu_description'] = 'Default Menu';
 
 					//grant temporary permissions
-						$p = new permissions;
+						$p = permissions::new();
 						$p->add('menu_add', 'temp');
 
 					//execute insert

resources/classes/permissions.php

@@ -211,9 +211,9 @@ if (!class_exists('permissions')) {
 //examples
 	/*
 	//add the permission
-		$p = new permissions;
+		$p = permissions::new();
 		$p->add($permission);
 	//delete the permission
-		$p = new permissions;
+		$p = permissions::new();
 		$p->delete($permission);
 	*/

resources/classes/settings.php

@@ -188,7 +188,7 @@ class settings {
 		$record[$table_name][0][$table_prefix.'_setting_description'] = $description;
 
 		//grant temporary permissions
-		$p = new permissions;
+		$p = permissions::new();
 		$p->add($table_prefix.'_setting_add', 'temp');
 		$p->add($table_prefix.'_setting_edit', 'temp');
 

resources/classes/switch_settings.php

@@ -248,7 +248,7 @@ if (!class_exists('switch_settings')) {
 					}
 					if (is_array($array) && @sizeof($array) != 0) {
 						//grant temporary permissions
-							$p = new permissions;
+							$p = permissions::new();
 							$p->add('default_setting_add', 'temp');
 
 						//execute insert

resources/functions.php

@@ -723,7 +723,7 @@
 					$array['extension_users'][$x]['extension_uuid'] = $extension_uuid;
 					$array['extension_users'][$x]['user_uuid'] = $row["user_uuid"];
 					//grant temporary permissions
-					$p = new permissions;
+					$p = permissions::new();
 					$p->add('extension_user_add', 'temp');
 					//execute insert
 					$database = database::new();
@@ -772,7 +772,7 @@
 				$array['user_groups'][0]['user_uuid'] = $user_uuid;
 
 				//grant temporary permissions
-				$p = new permissions;
+				$p = permissions::new();
 				$p->add('user_add', 'temp');
 				$p->add('user_group_add', 'temp');
 				//execute insert