浏览代码

Merge pull request #3677 from gravitl/release-v1.1.0

simplify create egress checks
Abhishek K 1 周之前
父节点
当前提交
3f5bf5f3c2
共有 1 个文件被更改,包括 12 次插入11 次删除
  1. 12 11
      controllers/egress.go

+ 12 - 11
controllers/egress.go

@@ -45,22 +45,23 @@ func createEgress(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	var egressRange string
-	var cidrErr error
 	if !req.IsInetGw {
 		if req.Range != "" {
-			egressRange, cidrErr = logic.NormalizeCIDR(req.Range)
+			var err error
+			egressRange, err = logic.NormalizeCIDR(req.Range)
+			if err != nil {
+				logic.ReturnErrorResponse(w, r, logic.FormatError(err, "badrequest"))
+				return
+			}
 		}
-		isDomain := logic.IsFQDN(req.Range)
-		if cidrErr != nil && !isDomain {
-			if cidrErr != nil {
-				logic.ReturnErrorResponse(w, r, logic.FormatError(cidrErr, "badrequest"))
-			} else {
+
+		if req.Domain != "" {
+			isDomain := logic.IsFQDN(req.Domain)
+			if !isDomain {
 				logic.ReturnErrorResponse(w, r, logic.FormatError(errors.New("bad domain name"), "badrequest"))
+				return
 			}
-			return
-		}
-		if isDomain {
-			req.Domain = req.Range
+
 			egressRange = ""
 		}
 	} else {