Browse Source

fix(NET-486): change client name length validation (#2498)

set limit to 5<=x<=32
Aceix 2 years ago
parent
commit
96683c8aff
2 changed files with 18 additions and 4 deletions
  1. 1 1
      controllers/regex.go
  2. 17 3
      controllers/regex_test.go

+ 1 - 1
controllers/regex.go

@@ -22,7 +22,7 @@ func validName(name string) bool {
 	if !reg.MatchString(name) {
 	if !reg.MatchString(name) {
 		return false
 		return false
 	}
 	}
-	if len(name) > 15 {
+	if len(name) < 5 || len(name) > 32 {
 		return false
 		return false
 	}
 	}
 	return true
 	return true

+ 17 - 3
controllers/regex_test.go

@@ -27,19 +27,33 @@ func TestValidName(t *testing.T) {
 			Want: false,
 			Want: false,
 		},
 		},
 		{
 		{
-			Name: "nametoolong",
+			Name: "longname",
 			Args: args{
 			Args: args{
 				Name: "TestvalidNameTestvalidName",
 				Name: "TestvalidNameTestvalidName",
 			},
 			},
-			Want: false,
+			Want: true,
 		},
 		},
 		{
 		{
-			Name: "maxlength",
+			Name: "max length",
 			Args: args{
 			Args: args{
 				Name: "123456789012345",
 				Name: "123456789012345",
 			},
 			},
 			Want: true,
 			Want: true,
 		},
 		},
+		{
+			Name: "min length",
+			Args: args{
+				Name: "ama",
+			},
+			Want: false,
+		},
+		{
+			Name: "toolong",
+			Args: args{
+				Name: "123456789012345123123123123123123123123123123",
+			},
+			Want: false,
+		},
 	}
 	}
 	for _, tt := range tests {
 	for _, tt := range tests {
 		t.Run(tt.Name, func(t *testing.T) {
 		t.Run(tt.Name, func(t *testing.T) {