Browse Source

changing private to local for clarity

afeiszli 4 years ago
parent
commit
976c1847bf
5 changed files with 34 additions and 26 deletions
  1. 17 17
      controllers/networkHttpController.go
  2. 1 0
      go.mod
  3. 1 1
      main.go
  4. 2 2
      models/network.go
  5. 13 6
      netclient/functions/common.go

+ 17 - 17
controllers/networkHttpController.go

@@ -111,8 +111,8 @@ func validateNetwork(operation string, network models.Network) error {
                 return isvalid
                 return isvalid
         })
         })
 
 
-        _ = v.RegisterValidation("privaterange_valid", func(fl validator.FieldLevel) bool {
-                isvalid := !*network.IsPrivate || functions.IsIpv4CIDR(fl.Field().String())
+        _ = v.RegisterValidation("localrange_valid", func(fl validator.FieldLevel) bool {
+                isvalid := !*network.IsLocal || functions.IsIpv4CIDR(fl.Field().String())
                 return isvalid
                 return isvalid
         })
         })
 
 
@@ -269,7 +269,7 @@ func updateNetwork(w http.ResponseWriter, r *http.Request) {
 
 
 	haschange := false
 	haschange := false
 	hasrangeupdate := false
 	hasrangeupdate := false
-	hasprivaterangeupdate := false
+	haslocalrangeupdate := false
 
 
 	_ = json.NewDecoder(r.Body).Decode(&networkChange)
 	_ = json.NewDecoder(r.Body).Decode(&networkChange)
 
 
@@ -304,20 +304,20 @@ func updateNetwork(w http.ResponseWriter, r *http.Request) {
 	     hasrangeupdate = true
 	     hasrangeupdate = true
 
 
         }
         }
-	if networkChange.PrivateRange != "" {
-            network.PrivateRange = networkChange.PrivateRange
+	if networkChange.LocalRange != "" {
+            network.LocalRange = networkChange.LocalRange
 
 
-            var isAddressOK bool = functions.IsIpv4CIDR(networkChange.PrivateRange)
+            var isAddressOK bool = functions.IsIpv4CIDR(networkChange.LocalRange)
             if !isAddressOK {
             if !isAddressOK {
-		    err := errors.New("Invalid Range of " +  networkChange.PrivateRange + " for internal addresses.")
+		    err := errors.New("Invalid Range of " +  networkChange.LocalRange + " for internal addresses.")
                     returnErrorResponse(w,r,formatError(err, "internal"))
                     returnErrorResponse(w,r,formatError(err, "internal"))
                     return
                     return
             }
             }
              haschange = true
              haschange = true
-             hasprivaterangeupdate = true
+             haslocalrangeupdate = true
 	}
 	}
-	if networkChange.IsPrivate != nil {
-		network.IsPrivate = networkChange.IsPrivate
+	if networkChange.IsLocal != nil {
+		network.IsLocal = networkChange.IsLocal
 	}
 	}
 	if networkChange.DefaultListenPort != 0 {
 	if networkChange.DefaultListenPort != 0 {
 		network.DefaultListenPort = networkChange.DefaultListenPort
 		network.DefaultListenPort = networkChange.DefaultListenPort
@@ -374,8 +374,8 @@ func updateNetwork(w http.ResponseWriter, r *http.Request) {
                         {"nodeslastmodified", network.NodesLastModified},
                         {"nodeslastmodified", network.NodesLastModified},
                         {"networklastmodified", network.NetworkLastModified},
                         {"networklastmodified", network.NetworkLastModified},
                         {"allowmanualsignup", network.AllowManualSignUp},
                         {"allowmanualsignup", network.AllowManualSignUp},
-                        {"privaterange", network.PrivateRange},
-                        {"isprivate", network.IsPrivate},
+                        {"localrange", network.LocalRange},
+                        {"islocal", network.IsLocal},
                         {"defaultcheckininterval", network.DefaultCheckInInterval},
                         {"defaultcheckininterval", network.DefaultCheckInInterval},
 		}},
 		}},
         }
         }
@@ -397,7 +397,7 @@ func updateNetwork(w http.ResponseWriter, r *http.Request) {
 			return
 			return
 		}
 		}
 	}
 	}
-	if hasprivaterangeupdate {
+	if haslocalrangeupdate {
                 err = functions.UpdateNetworkPrivateAddresses(params["networkname"])
                 err = functions.UpdateNetworkPrivateAddresses(params["networkname"])
                 if err != nil {
                 if err != nil {
                         returnErrorResponse(w,r,formatError(err, "internal"))
                         returnErrorResponse(w,r,formatError(err, "internal"))
@@ -470,9 +470,9 @@ func createNetwork(w http.ResponseWriter, r *http.Request) {
 
 
 	//TODO: Not really doing good validation here. Same as createNode, updateNode, and updateNetwork
 	//TODO: Not really doing good validation here. Same as createNode, updateNode, and updateNetwork
 	//Need to implement some better validation across the board
 	//Need to implement some better validation across the board
-        if network.IsPrivate == nil {
+        if network.IsLocal == nil {
                 falsevar := false
                 falsevar := false
-                network.IsPrivate = &falsevar
+                network.IsLocal = &falsevar
         }
         }
 
 
         err = validateNetwork("create", network)
         err = validateNetwork("create", network)
@@ -545,8 +545,8 @@ func createAccessKey(w http.ResponseWriter, r *http.Request) {
         }
         }
 
 
 	privAddr := ""
 	privAddr := ""
-	if *network.IsPrivate {
-		privAddr = network.PrivateRange
+	if *network.IsLocal {
+		privAddr = network.LocalRange
 	}
 	}
 
 
 
 

+ 1 - 0
go.mod

@@ -3,6 +3,7 @@ module github.com/gravitl/netmaker
 go 1.15
 go 1.15
 
 
 require (
 require (
+	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/dgrijalva/jwt-go v3.2.0+incompatible
 	github.com/dgrijalva/jwt-go v3.2.0+incompatible
 	github.com/go-playground/universal-translator v0.17.0 // indirect
 	github.com/go-playground/universal-translator v0.17.0 // indirect
 	github.com/golang/protobuf v1.4.3
 	github.com/golang/protobuf v1.4.3

+ 1 - 1
main.go

@@ -239,7 +239,7 @@ func createDefaultNetwork() (bool, error) {
         network.SetNetworkLastModified()
         network.SetNetworkLastModified()
         network.KeyUpdateTimeStamp = time.Now().Unix()
         network.KeyUpdateTimeStamp = time.Now().Unix()
 	priv := false
 	priv := false
-	network.IsPrivate = &priv
+	network.IsLocal = &priv
         network.KeyUpdateTimeStamp = time.Now().Unix()
         network.KeyUpdateTimeStamp = time.Now().Unix()
 	allow := true
 	allow := true
 	network.AllowManualSignUp = &allow
 	network.AllowManualSignUp = &allow

+ 2 - 2
models/network.go

@@ -24,8 +24,8 @@ type Network struct {
         DefaultSaveConfig      *bool `json:"defaultsaveconfig" bson:"defaultsaveconfig"`
         DefaultSaveConfig      *bool `json:"defaultsaveconfig" bson:"defaultsaveconfig"`
 	AccessKeys	[]AccessKey `json:"accesskeys" bson:"accesskeys"`
 	AccessKeys	[]AccessKey `json:"accesskeys" bson:"accesskeys"`
 	AllowManualSignUp *bool `json:"allowmanualsignup" bson:"allowmanualsignup"`
 	AllowManualSignUp *bool `json:"allowmanualsignup" bson:"allowmanualsignup"`
-	IsPrivate *bool `json:"isprivate" bson:"isprivate"`
-	PrivateRange string `json:"privaterange" bson:"privaterange" validate:"privaterange_valid"`
+	IsLocal *bool `json:"islocal" bson:"islocal"`
+	LocalRange string `json:"localrange" bson:"localrange" validate:"localrange_valid"`
 	DefaultCheckInInterval int32 `json:"checkininterval,omitempty" bson:"checkininterval,omitempty" validate:"omitempty,numeric,min=1,max=100000"`
 	DefaultCheckInInterval int32 `json:"checkininterval,omitempty" bson:"checkininterval,omitempty" validate:"omitempty,numeric,min=1,max=100000"`
 }
 }
 
 

+ 13 - 6
netclient/functions/common.go

@@ -1,7 +1,7 @@
 package functions
 package functions
 
 
 import (
 import (
-	//"github.com/davecgh/go-spew/spew"
+	"github.com/davecgh/go-spew/spew"
 	"fmt"
 	"fmt"
 	"time"
 	"time"
 	"errors"
 	"errors"
@@ -1244,17 +1244,24 @@ func getPeers(macaddress string, network string, server string) ([]wgtypes.PeerC
 
 
         stream, err := wcclient.GetPeers(ctx, req, grpc.Header(&header))
         stream, err := wcclient.GetPeers(ctx, req, grpc.Header(&header))
 	if err != nil {
 	if err != nil {
-                return nil, err
+                fmt.Println("Error retrieving peers")
+                fmt.Println(err)
+		return nil, err
         }
         }
-	fmt.Println("Parsing  peers response")
-        for {
-                // stream.Recv returns a pointer to a ListBlogRes at the current iteration
+	fmt.Println("Parsing peers response")
+	for {
 		res, err := stream.Recv()
 		res, err := stream.Recv()
                 // If end of stream, break the loop
                 // If end of stream, break the loop
 
 
+
 		if err == io.EOF {
 		if err == io.EOF {
-                        break
+                        fmt.Println("ERROR ENCOUNTERED WITH peer")
+                        fmt.Println(res)
+                        fmt.Println(err)
+			break
                 }
                 }
+			spew.Dump(res)
+
                 // if err, return an error
                 // if err, return an error
                 if err != nil {
                 if err != nil {
 			if strings.Contains(err.Error(), "mongo: no documents in result") {
 			if strings.Contains(err.Error(), "mongo: no documents in result") {