|
@@ -4,52 +4,53 @@ import (
|
|
"testing"
|
|
"testing"
|
|
|
|
|
|
"github.com/gravitl/netmaker/database"
|
|
"github.com/gravitl/netmaker/database"
|
|
|
|
+ "github.com/gravitl/netmaker/logic"
|
|
"github.com/gravitl/netmaker/models"
|
|
"github.com/gravitl/netmaker/models"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
)
|
|
|
|
|
|
func deleteAllUsers() {
|
|
func deleteAllUsers() {
|
|
- users, _ := GetUsers()
|
|
|
|
|
|
+ users, _ := logic.GetUsers()
|
|
for _, user := range users {
|
|
for _, user := range users {
|
|
- DeleteUser(user.UserName)
|
|
|
|
|
|
+ logic.DeleteUser(user.UserName)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
|
|
func TestHasAdmin(t *testing.T) {
|
|
func TestHasAdmin(t *testing.T) {
|
|
//delete all current users
|
|
//delete all current users
|
|
database.InitializeDatabase()
|
|
database.InitializeDatabase()
|
|
- users, _ := GetUsers()
|
|
|
|
|
|
+ users, _ := logic.GetUsers()
|
|
for _, user := range users {
|
|
for _, user := range users {
|
|
- success, err := DeleteUser(user.UserName)
|
|
|
|
|
|
+ success, err := logic.DeleteUser(user.UserName)
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.True(t, success)
|
|
assert.True(t, success)
|
|
}
|
|
}
|
|
t.Run("NoUser", func(t *testing.T) {
|
|
t.Run("NoUser", func(t *testing.T) {
|
|
- found, err := HasAdmin()
|
|
|
|
|
|
+ found, err := logic.HasAdmin()
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.False(t, found)
|
|
assert.False(t, found)
|
|
})
|
|
})
|
|
t.Run("No admin user", func(t *testing.T) {
|
|
t.Run("No admin user", func(t *testing.T) {
|
|
var user = models.User{"noadmin", "password", nil, false}
|
|
var user = models.User{"noadmin", "password", nil, false}
|
|
- _, err := CreateUser(user)
|
|
|
|
|
|
+ _, err := logic.CreateUser(user)
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
- found, err := HasAdmin()
|
|
|
|
|
|
+ found, err := logic.HasAdmin()
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.False(t, found)
|
|
assert.False(t, found)
|
|
})
|
|
})
|
|
t.Run("admin user", func(t *testing.T) {
|
|
t.Run("admin user", func(t *testing.T) {
|
|
var user = models.User{"admin", "password", nil, true}
|
|
var user = models.User{"admin", "password", nil, true}
|
|
- _, err := CreateUser(user)
|
|
|
|
|
|
+ _, err := logic.CreateUser(user)
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
- found, err := HasAdmin()
|
|
|
|
|
|
+ found, err := logic.HasAdmin()
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.True(t, found)
|
|
assert.True(t, found)
|
|
})
|
|
})
|
|
t.Run("multiple admins", func(t *testing.T) {
|
|
t.Run("multiple admins", func(t *testing.T) {
|
|
var user = models.User{"admin1", "password", nil, true}
|
|
var user = models.User{"admin1", "password", nil, true}
|
|
- _, err := CreateUser(user)
|
|
|
|
|
|
+ _, err := logic.CreateUser(user)
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
- found, err := HasAdmin()
|
|
|
|
|
|
+ found, err := logic.HasAdmin()
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.True(t, found)
|
|
assert.True(t, found)
|
|
})
|
|
})
|
|
@@ -60,12 +61,12 @@ func TestCreateUser(t *testing.T) {
|
|
deleteAllUsers()
|
|
deleteAllUsers()
|
|
user := models.User{"admin", "password", nil, true}
|
|
user := models.User{"admin", "password", nil, true}
|
|
t.Run("NoUser", func(t *testing.T) {
|
|
t.Run("NoUser", func(t *testing.T) {
|
|
- admin, err := CreateUser(user)
|
|
|
|
|
|
+ admin, err := logic.CreateUser(user)
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, user.UserName, admin.UserName)
|
|
assert.Equal(t, user.UserName, admin.UserName)
|
|
})
|
|
})
|
|
t.Run("UserExists", func(t *testing.T) {
|
|
t.Run("UserExists", func(t *testing.T) {
|
|
- _, err := CreateUser(user)
|
|
|
|
|
|
+ _, err := logic.CreateUser(user)
|
|
assert.NotNil(t, err)
|
|
assert.NotNil(t, err)
|
|
assert.EqualError(t, err, "user exists")
|
|
assert.EqualError(t, err, "user exists")
|
|
})
|
|
})
|
|
@@ -78,14 +79,14 @@ func TestCreateAdmin(t *testing.T) {
|
|
t.Run("NoAdmin", func(t *testing.T) {
|
|
t.Run("NoAdmin", func(t *testing.T) {
|
|
user.UserName = "admin"
|
|
user.UserName = "admin"
|
|
user.Password = "password"
|
|
user.Password = "password"
|
|
- admin, err := CreateAdmin(user)
|
|
|
|
|
|
+ admin, err := logic.CreateAdmin(user)
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, user.UserName, admin.UserName)
|
|
assert.Equal(t, user.UserName, admin.UserName)
|
|
})
|
|
})
|
|
t.Run("AdminExists", func(t *testing.T) {
|
|
t.Run("AdminExists", func(t *testing.T) {
|
|
user.UserName = "admin2"
|
|
user.UserName = "admin2"
|
|
user.Password = "password1"
|
|
user.Password = "password1"
|
|
- admin, err := CreateAdmin(user)
|
|
|
|
|
|
+ admin, err := logic.CreateAdmin(user)
|
|
assert.EqualError(t, err, "admin user already exists")
|
|
assert.EqualError(t, err, "admin user already exists")
|
|
assert.Equal(t, admin, models.User{})
|
|
assert.Equal(t, admin, models.User{})
|
|
})
|
|
})
|
|
@@ -95,14 +96,14 @@ func TestDeleteUser(t *testing.T) {
|
|
database.InitializeDatabase()
|
|
database.InitializeDatabase()
|
|
deleteAllUsers()
|
|
deleteAllUsers()
|
|
t.Run("NonExistent User", func(t *testing.T) {
|
|
t.Run("NonExistent User", func(t *testing.T) {
|
|
- deleted, err := DeleteUser("admin")
|
|
|
|
|
|
+ deleted, err := logic.DeleteUser("admin")
|
|
assert.EqualError(t, err, "user does not exist")
|
|
assert.EqualError(t, err, "user does not exist")
|
|
assert.False(t, deleted)
|
|
assert.False(t, deleted)
|
|
})
|
|
})
|
|
t.Run("Existing User", func(t *testing.T) {
|
|
t.Run("Existing User", func(t *testing.T) {
|
|
user := models.User{"admin", "password", nil, true}
|
|
user := models.User{"admin", "password", nil, true}
|
|
- CreateUser(user)
|
|
|
|
- deleted, err := DeleteUser("admin")
|
|
|
|
|
|
+ logic.CreateUser(user)
|
|
|
|
+ deleted, err := logic.DeleteUser("admin")
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.True(t, deleted)
|
|
assert.True(t, deleted)
|
|
})
|
|
})
|
|
@@ -114,44 +115,44 @@ func TestValidateUser(t *testing.T) {
|
|
t.Run("Valid Create", func(t *testing.T) {
|
|
t.Run("Valid Create", func(t *testing.T) {
|
|
user.UserName = "admin"
|
|
user.UserName = "admin"
|
|
user.Password = "validpass"
|
|
user.Password = "validpass"
|
|
- err := ValidateUser("create", user)
|
|
|
|
|
|
+ err := logic.ValidateUser(user)
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
})
|
|
})
|
|
t.Run("Valid Update", func(t *testing.T) {
|
|
t.Run("Valid Update", func(t *testing.T) {
|
|
user.UserName = "admin"
|
|
user.UserName = "admin"
|
|
user.Password = "password"
|
|
user.Password = "password"
|
|
- err := ValidateUser("update", user)
|
|
|
|
|
|
+ err := logic.ValidateUser(user)
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
})
|
|
})
|
|
t.Run("Invalid UserName", func(t *testing.T) {
|
|
t.Run("Invalid UserName", func(t *testing.T) {
|
|
t.Skip()
|
|
t.Skip()
|
|
user.UserName = "*invalid"
|
|
user.UserName = "*invalid"
|
|
- err := ValidateUser("create", user)
|
|
|
|
|
|
+ err := logic.ValidateUser(user)
|
|
assert.Error(t, err)
|
|
assert.Error(t, err)
|
|
//assert.Contains(t, err.Error(), "Field validation for 'UserName' failed")
|
|
//assert.Contains(t, err.Error(), "Field validation for 'UserName' failed")
|
|
})
|
|
})
|
|
t.Run("Short UserName", func(t *testing.T) {
|
|
t.Run("Short UserName", func(t *testing.T) {
|
|
t.Skip()
|
|
t.Skip()
|
|
user.UserName = "1"
|
|
user.UserName = "1"
|
|
- err := ValidateUser("create", user)
|
|
|
|
|
|
+ err := logic.ValidateUser(user)
|
|
assert.NotNil(t, err)
|
|
assert.NotNil(t, err)
|
|
//assert.Contains(t, err.Error(), "Field validation for 'UserName' failed")
|
|
//assert.Contains(t, err.Error(), "Field validation for 'UserName' failed")
|
|
})
|
|
})
|
|
t.Run("Empty UserName", func(t *testing.T) {
|
|
t.Run("Empty UserName", func(t *testing.T) {
|
|
t.Skip()
|
|
t.Skip()
|
|
user.UserName = ""
|
|
user.UserName = ""
|
|
- err := ValidateUser("create", user)
|
|
|
|
|
|
+ err := logic.ValidateUser(user)
|
|
assert.EqualError(t, err, "some string")
|
|
assert.EqualError(t, err, "some string")
|
|
//assert.Contains(t, err.Error(), "Field validation for 'UserName' failed")
|
|
//assert.Contains(t, err.Error(), "Field validation for 'UserName' failed")
|
|
})
|
|
})
|
|
t.Run("EmptyPassword", func(t *testing.T) {
|
|
t.Run("EmptyPassword", func(t *testing.T) {
|
|
user.Password = ""
|
|
user.Password = ""
|
|
- err := ValidateUser("create", user)
|
|
|
|
|
|
+ err := logic.ValidateUser(user)
|
|
assert.EqualError(t, err, "Key: 'User.Password' Error:Field validation for 'Password' failed on the 'required' tag")
|
|
assert.EqualError(t, err, "Key: 'User.Password' Error:Field validation for 'Password' failed on the 'required' tag")
|
|
})
|
|
})
|
|
t.Run("ShortPassword", func(t *testing.T) {
|
|
t.Run("ShortPassword", func(t *testing.T) {
|
|
user.Password = "123"
|
|
user.Password = "123"
|
|
- err := ValidateUser("create", user)
|
|
|
|
|
|
+ err := logic.ValidateUser(user)
|
|
assert.EqualError(t, err, "Key: 'User.Password' Error:Field validation for 'Password' failed on the 'min' tag")
|
|
assert.EqualError(t, err, "Key: 'User.Password' Error:Field validation for 'Password' failed on the 'min' tag")
|
|
})
|
|
})
|
|
}
|
|
}
|
|
@@ -160,14 +161,14 @@ func TestGetUser(t *testing.T) {
|
|
database.InitializeDatabase()
|
|
database.InitializeDatabase()
|
|
deleteAllUsers()
|
|
deleteAllUsers()
|
|
t.Run("NonExistantUser", func(t *testing.T) {
|
|
t.Run("NonExistantUser", func(t *testing.T) {
|
|
- admin, err := GetUser("admin")
|
|
|
|
|
|
+ admin, err := logic.GetUser("admin")
|
|
assert.EqualError(t, err, "could not find any records")
|
|
assert.EqualError(t, err, "could not find any records")
|
|
assert.Equal(t, "", admin.UserName)
|
|
assert.Equal(t, "", admin.UserName)
|
|
})
|
|
})
|
|
t.Run("UserExisits", func(t *testing.T) {
|
|
t.Run("UserExisits", func(t *testing.T) {
|
|
user := models.User{"admin", "password", nil, true}
|
|
user := models.User{"admin", "password", nil, true}
|
|
- CreateUser(user)
|
|
|
|
- admin, err := GetUser("admin")
|
|
|
|
|
|
+ logic.CreateUser(user)
|
|
|
|
+ admin, err := logic.GetUser("admin")
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, user.UserName, admin.UserName)
|
|
assert.Equal(t, user.UserName, admin.UserName)
|
|
})
|
|
})
|
|
@@ -183,7 +184,7 @@ func TestGetUserInternal(t *testing.T) {
|
|
})
|
|
})
|
|
t.Run("UserExisits", func(t *testing.T) {
|
|
t.Run("UserExisits", func(t *testing.T) {
|
|
user := models.User{"admin", "password", nil, true}
|
|
user := models.User{"admin", "password", nil, true}
|
|
- CreateUser(user)
|
|
|
|
|
|
+ logic.CreateUser(user)
|
|
admin, err := GetUserInternal("admin")
|
|
admin, err := GetUserInternal("admin")
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, user.UserName, admin.UserName)
|
|
assert.Equal(t, user.UserName, admin.UserName)
|
|
@@ -194,21 +195,21 @@ func TestGetUsers(t *testing.T) {
|
|
database.InitializeDatabase()
|
|
database.InitializeDatabase()
|
|
deleteAllUsers()
|
|
deleteAllUsers()
|
|
t.Run("NonExistantUser", func(t *testing.T) {
|
|
t.Run("NonExistantUser", func(t *testing.T) {
|
|
- admin, err := GetUsers()
|
|
|
|
|
|
+ admin, err := logic.GetUsers()
|
|
assert.EqualError(t, err, "could not find any records")
|
|
assert.EqualError(t, err, "could not find any records")
|
|
assert.Equal(t, []models.ReturnUser(nil), admin)
|
|
assert.Equal(t, []models.ReturnUser(nil), admin)
|
|
})
|
|
})
|
|
t.Run("UserExisits", func(t *testing.T) {
|
|
t.Run("UserExisits", func(t *testing.T) {
|
|
user := models.User{"admin", "password", nil, true}
|
|
user := models.User{"admin", "password", nil, true}
|
|
- CreateUser(user)
|
|
|
|
- admins, err := GetUsers()
|
|
|
|
|
|
+ logic.CreateUser(user)
|
|
|
|
+ admins, err := logic.GetUsers()
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, user.UserName, admins[0].UserName)
|
|
assert.Equal(t, user.UserName, admins[0].UserName)
|
|
})
|
|
})
|
|
t.Run("MulipleUsers", func(t *testing.T) {
|
|
t.Run("MulipleUsers", func(t *testing.T) {
|
|
user := models.User{"user", "password", nil, true}
|
|
user := models.User{"user", "password", nil, true}
|
|
- CreateUser(user)
|
|
|
|
- admins, err := GetUsers()
|
|
|
|
|
|
+ logic.CreateUser(user)
|
|
|
|
+ admins, err := logic.GetUsers()
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
for _, u := range admins {
|
|
for _, u := range admins {
|
|
if u.UserName == "admin" {
|
|
if u.UserName == "admin" {
|
|
@@ -227,14 +228,14 @@ func TestUpdateUser(t *testing.T) {
|
|
user := models.User{"admin", "password", nil, true}
|
|
user := models.User{"admin", "password", nil, true}
|
|
newuser := models.User{"hello", "world", []string{"wirecat, netmaker"}, true}
|
|
newuser := models.User{"hello", "world", []string{"wirecat, netmaker"}, true}
|
|
t.Run("NonExistantUser", func(t *testing.T) {
|
|
t.Run("NonExistantUser", func(t *testing.T) {
|
|
- admin, err := UpdateUser(newuser, user)
|
|
|
|
|
|
+ admin, err := logic.UpdateUser(newuser, user)
|
|
assert.EqualError(t, err, "could not find any records")
|
|
assert.EqualError(t, err, "could not find any records")
|
|
assert.Equal(t, "", admin.UserName)
|
|
assert.Equal(t, "", admin.UserName)
|
|
})
|
|
})
|
|
|
|
|
|
t.Run("UserExists", func(t *testing.T) {
|
|
t.Run("UserExists", func(t *testing.T) {
|
|
- CreateUser(user)
|
|
|
|
- admin, err := UpdateUser(newuser, user)
|
|
|
|
|
|
+ logic.CreateUser(user)
|
|
|
|
+ admin, err := logic.UpdateUser(newuser, user)
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, newuser.UserName, admin.UserName)
|
|
assert.Equal(t, newuser.UserName, admin.UserName)
|
|
})
|
|
})
|
|
@@ -271,43 +272,43 @@ func TestVerifyAuthRequest(t *testing.T) {
|
|
t.Run("EmptyUserName", func(t *testing.T) {
|
|
t.Run("EmptyUserName", func(t *testing.T) {
|
|
authRequest.UserName = ""
|
|
authRequest.UserName = ""
|
|
authRequest.Password = "Password"
|
|
authRequest.Password = "Password"
|
|
- jwt, err := VerifyAuthRequest(authRequest)
|
|
|
|
|
|
+ jwt, err := logic.VerifyAuthRequest(authRequest)
|
|
assert.Equal(t, "", jwt)
|
|
assert.Equal(t, "", jwt)
|
|
assert.EqualError(t, err, "username can't be empty")
|
|
assert.EqualError(t, err, "username can't be empty")
|
|
})
|
|
})
|
|
t.Run("EmptyPassword", func(t *testing.T) {
|
|
t.Run("EmptyPassword", func(t *testing.T) {
|
|
authRequest.UserName = "admin"
|
|
authRequest.UserName = "admin"
|
|
authRequest.Password = ""
|
|
authRequest.Password = ""
|
|
- jwt, err := VerifyAuthRequest(authRequest)
|
|
|
|
|
|
+ jwt, err := logic.VerifyAuthRequest(authRequest)
|
|
assert.Equal(t, "", jwt)
|
|
assert.Equal(t, "", jwt)
|
|
assert.EqualError(t, err, "password can't be empty")
|
|
assert.EqualError(t, err, "password can't be empty")
|
|
})
|
|
})
|
|
t.Run("NonExistantUser", func(t *testing.T) {
|
|
t.Run("NonExistantUser", func(t *testing.T) {
|
|
authRequest.UserName = "admin"
|
|
authRequest.UserName = "admin"
|
|
authRequest.Password = "password"
|
|
authRequest.Password = "password"
|
|
- jwt, err := VerifyAuthRequest(authRequest)
|
|
|
|
|
|
+ jwt, err := logic.VerifyAuthRequest(authRequest)
|
|
assert.Equal(t, "", jwt)
|
|
assert.Equal(t, "", jwt)
|
|
assert.EqualError(t, err, "incorrect credentials")
|
|
assert.EqualError(t, err, "incorrect credentials")
|
|
})
|
|
})
|
|
t.Run("Non-Admin", func(t *testing.T) {
|
|
t.Run("Non-Admin", func(t *testing.T) {
|
|
user := models.User{"nonadmin", "somepass", nil, false}
|
|
user := models.User{"nonadmin", "somepass", nil, false}
|
|
- CreateUser(user)
|
|
|
|
|
|
+ logic.CreateUser(user)
|
|
authRequest := models.UserAuthParams{"nonadmin", "somepass"}
|
|
authRequest := models.UserAuthParams{"nonadmin", "somepass"}
|
|
- jwt, err := VerifyAuthRequest(authRequest)
|
|
|
|
|
|
+ jwt, err := logic.VerifyAuthRequest(authRequest)
|
|
assert.NotNil(t, jwt)
|
|
assert.NotNil(t, jwt)
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
})
|
|
})
|
|
t.Run("WrongPassword", func(t *testing.T) {
|
|
t.Run("WrongPassword", func(t *testing.T) {
|
|
user := models.User{"admin", "password", nil, false}
|
|
user := models.User{"admin", "password", nil, false}
|
|
- CreateUser(user)
|
|
|
|
|
|
+ logic.CreateUser(user)
|
|
authRequest := models.UserAuthParams{"admin", "badpass"}
|
|
authRequest := models.UserAuthParams{"admin", "badpass"}
|
|
- jwt, err := VerifyAuthRequest(authRequest)
|
|
|
|
|
|
+ jwt, err := logic.VerifyAuthRequest(authRequest)
|
|
assert.Equal(t, "", jwt)
|
|
assert.Equal(t, "", jwt)
|
|
assert.EqualError(t, err, "incorrect credentials")
|
|
assert.EqualError(t, err, "incorrect credentials")
|
|
})
|
|
})
|
|
t.Run("Success", func(t *testing.T) {
|
|
t.Run("Success", func(t *testing.T) {
|
|
authRequest := models.UserAuthParams{"admin", "password"}
|
|
authRequest := models.UserAuthParams{"admin", "password"}
|
|
- jwt, err := VerifyAuthRequest(authRequest)
|
|
|
|
|
|
+ jwt, err := logic.VerifyAuthRequest(authRequest)
|
|
assert.Nil(t, err)
|
|
assert.Nil(t, err)
|
|
assert.NotNil(t, jwt)
|
|
assert.NotNil(t, jwt)
|
|
})
|
|
})
|