2
0
Эх сурвалжийг харах

fix(go): error on invalid auth provider;

Vishal Dalwadi 4 сар өмнө
parent
commit
e54f440d72

+ 5 - 5
pro/auth/sync.go

@@ -1,6 +1,7 @@
 package auth
 package auth
 
 
 import (
 import (
+	"fmt"
 	"github.com/gravitl/netmaker/database"
 	"github.com/gravitl/netmaker/database"
 	"github.com/gravitl/netmaker/logger"
 	"github.com/gravitl/netmaker/logger"
 	"github.com/gravitl/netmaker/logic"
 	"github.com/gravitl/netmaker/logic"
@@ -37,9 +38,6 @@ func ResetSyncHook() {
 
 
 func SyncFromIDP() error {
 func SyncFromIDP() error {
 	settings := logic.GetServerSettings()
 	settings := logic.GetServerSettings()
-	if !settings.SyncEnabled {
-		return nil
-	}
 
 
 	var idpClient idp.Client
 	var idpClient idp.Client
 	var idpUsers []idp.User
 	var idpUsers []idp.User
@@ -55,10 +53,12 @@ func SyncFromIDP() error {
 	case "azure-ad":
 	case "azure-ad":
 		idpClient = azure.NewAzureEntraIDClient()
 		idpClient = azure.NewAzureEntraIDClient()
 	default:
 	default:
-		return nil
+		if settings.AuthProvider != "" {
+			return fmt.Errorf("invalid auth provider: %s", settings.AuthProvider)
+		}
 	}
 	}
 
 
-	if settings.AuthProvider != "" {
+	if settings.AuthProvider != "" && idpClient != nil {
 		idpUsers, err = idpClient.GetUsers()
 		idpUsers, err = idpClient.GetUsers()
 		if err != nil {
 		if err != nil {
 			return err
 			return err