networkHttpController_test.go 12 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406
  1. package controller
  2. import (
  3. "testing"
  4. "time"
  5. "github.com/gravitl/netmaker/models"
  6. "github.com/stretchr/testify/assert"
  7. )
  8. type NetworkValidationTestCase struct {
  9. testname string
  10. network models.Network
  11. errMessage string
  12. }
  13. func deleteNet() {
  14. _, err := GetNetwork("skynet")
  15. if err == nil {
  16. _, _ = DeleteNetwork("skynet")
  17. }
  18. }
  19. func createNet() {
  20. var network models.Network
  21. network.NetID = "skynet"
  22. network.AddressRange = "10.0.0.1/24"
  23. network.DisplayName = "mynetwork"
  24. _, err := GetNetwork("skynet")
  25. if err != nil {
  26. CreateNetwork(network)
  27. }
  28. }
  29. func TestGetNetworks(t *testing.T) {
  30. //calls functions.ListNetworks --- nothing to be done
  31. }
  32. func TestCreateNetwork(t *testing.T) {
  33. deleteNet()
  34. var network models.Network
  35. network.NetID = "skynet"
  36. network.AddressRange = "10.0.0.1/24"
  37. network.DisplayName = "mynetwork"
  38. err := CreateNetwork(network)
  39. assert.Nil(t, err)
  40. }
  41. func TestGetDeleteNetwork(t *testing.T) {
  42. createNet()
  43. //create nodes
  44. t.Run("NetworkwithNodes", func(t *testing.T) {
  45. })
  46. t.Run("GetExistingNetwork", func(t *testing.T) {
  47. network, err := GetNetwork("skynet")
  48. assert.Nil(t, err)
  49. assert.Equal(t, "skynet", network.NetID)
  50. })
  51. t.Run("DeleteExistingNetwork", func(t *testing.T) {
  52. result, err := DeleteNetwork("skynet")
  53. assert.Nil(t, err)
  54. assert.Equal(t, int64(1), result.DeletedCount)
  55. t.Log(result.DeletedCount)
  56. })
  57. t.Run("GetNonExistantNetwork", func(t *testing.T) {
  58. network, err := GetNetwork("skynet")
  59. assert.NotNil(t, err)
  60. assert.Equal(t, "mongo: no documents in result", err.Error())
  61. assert.Equal(t, "", network.NetID)
  62. })
  63. t.Run("NonExistantNetwork", func(t *testing.T) {
  64. result, err := DeleteNetwork("skynet")
  65. assert.Nil(t, err)
  66. assert.Equal(t, int64(0), result.DeletedCount)
  67. t.Log(result.DeletedCount)
  68. })
  69. }
  70. func TestGetNetwork(t *testing.T) {
  71. createNet()
  72. t.Run("NoNetwork", func(t *testing.T) {
  73. network, err := GetNetwork("badnet")
  74. assert.NotNil(t, err)
  75. assert.Equal(t, "mongo: no documents in result", err.Error())
  76. assert.Equal(t, models.Network{}, network)
  77. })
  78. t.Run("Valid", func(t *testing.T) {
  79. network, err := GetNetwork("skynet")
  80. assert.Nil(t, err)
  81. assert.Equal(t, "skynet", network.NetID)
  82. })
  83. }
  84. func TestUpdateNetwork(t *testing.T) {
  85. }
  86. func TestKeyUpdate(t *testing.T) {
  87. createNet()
  88. existing, err := GetNetwork("skynet")
  89. assert.Nil(t, err)
  90. time.Sleep(time.Second * 1)
  91. network, err := KeyUpdate("skynet")
  92. assert.Nil(t, err)
  93. network, err = GetNetwork("skynet")
  94. assert.Nil(t, err)
  95. assert.Greater(t, network.KeyUpdateTimeStamp, existing.KeyUpdateTimeStamp)
  96. }
  97. func TestCreateKey(t *testing.T) {
  98. createNet()
  99. var accesskey models.AccessKey
  100. var network models.Network
  101. network.NetID = "skynet"
  102. t.Run("InvalidName", func(t *testing.T) {
  103. network, err := GetNetwork("skynet")
  104. assert.Nil(t, err)
  105. accesskey.Name = "bad-name"
  106. _, err = CreateAccessKey(accesskey, network)
  107. assert.NotNil(t, err)
  108. assert.Contains(t, err.Error(), "Field validation for 'Name' failed on the 'alphanum' tag")
  109. })
  110. t.Run("NameTooLong", func(t *testing.T) {
  111. network, err := GetNetwork("skynet")
  112. assert.Nil(t, err)
  113. accesskey.Name = "Thisisareallylongkeynamethatwillfail"
  114. _, err = CreateAccessKey(accesskey, network)
  115. assert.NotNil(t, err)
  116. assert.Contains(t, err.Error(), "Field validation for 'Name' failed on the 'max' tag")
  117. })
  118. t.Run("BlankName", func(t *testing.T) {
  119. network, err := GetNetwork("skynet")
  120. assert.Nil(t, err)
  121. accesskey.Name = ""
  122. key, err := CreateAccessKey(accesskey, network)
  123. assert.Nil(t, err)
  124. assert.NotEqual(t, "", key.Name)
  125. })
  126. t.Run("InvalidValue", func(t *testing.T) {
  127. network, err := GetNetwork("skynet")
  128. assert.Nil(t, err)
  129. accesskey.Value = "bad-value"
  130. _, err = CreateAccessKey(accesskey, network)
  131. assert.NotNil(t, err)
  132. assert.Contains(t, err.Error(), "Field validation for 'Value' failed on the 'alphanum' tag")
  133. })
  134. t.Run("BlankValue", func(t *testing.T) {
  135. network, err := GetNetwork("skynet")
  136. assert.Nil(t, err)
  137. accesskey.Name = "mykey"
  138. accesskey.Value = ""
  139. key, err := CreateAccessKey(accesskey, network)
  140. assert.Nil(t, err)
  141. assert.NotEqual(t, "", key.Value)
  142. assert.Equal(t, accesskey.Name, key.Name)
  143. })
  144. t.Run("ValueTooLong", func(t *testing.T) {
  145. network, err := GetNetwork("skynet")
  146. assert.Nil(t, err)
  147. accesskey.Name = "keyname"
  148. accesskey.Value = "AccessKeyValuethatistoolong"
  149. _, err = CreateAccessKey(accesskey, network)
  150. assert.NotNil(t, err)
  151. assert.Contains(t, err.Error(), "Field validation for 'Value' failed on the 'max' tag")
  152. })
  153. t.Run("BlankUses", func(t *testing.T) {
  154. network, err := GetNetwork("skynet")
  155. assert.Nil(t, err)
  156. accesskey.Uses = 0
  157. accesskey.Value = ""
  158. key, err := CreateAccessKey(accesskey, network)
  159. assert.Nil(t, err)
  160. assert.Equal(t, 1, key.Uses)
  161. })
  162. t.Run("DuplicateKey", func(t *testing.T) {
  163. network, err := GetNetwork("skynet")
  164. assert.Nil(t, err)
  165. accesskey.Name = "mykey"
  166. _, err = CreateAccessKey(accesskey, network)
  167. assert.NotNil(t, err)
  168. assert.Equal(t, "Duplicate AccessKey Name", err.Error())
  169. })
  170. }
  171. func TestGetKeys(t *testing.T) {
  172. deleteNet()
  173. createNet()
  174. network, err := GetNetwork("skynet")
  175. assert.Nil(t, err)
  176. var key models.AccessKey
  177. key.Name = "mykey"
  178. _, err = CreateAccessKey(key, network)
  179. assert.Nil(t, err)
  180. t.Run("KeyExists", func(t *testing.T) {
  181. keys, err := GetKeys(network.NetID)
  182. assert.Nil(t, err)
  183. assert.NotEqual(t, models.AccessKey{}, keys)
  184. })
  185. t.Run("NonExistantKey", func(t *testing.T) {
  186. err := DeleteKey("mykey", "skynet")
  187. assert.Nil(t, err)
  188. keys, err := GetKeys(network.NetID)
  189. assert.Nil(t, err)
  190. assert.Equal(t, []models.AccessKey(nil), keys)
  191. })
  192. }
  193. func TestDeleteKey(t *testing.T) {
  194. createNet()
  195. network, err := GetNetwork("skynet")
  196. assert.Nil(t, err)
  197. var key models.AccessKey
  198. key.Name = "mykey"
  199. _, err = CreateAccessKey(key, network)
  200. assert.Nil(t, err)
  201. t.Run("ExistingKey", func(t *testing.T) {
  202. err := DeleteKey("mykey", "skynet")
  203. assert.Nil(t, err)
  204. })
  205. t.Run("NonExistantKey", func(t *testing.T) {
  206. err := DeleteKey("mykey", "skynet")
  207. assert.NotNil(t, err)
  208. assert.Equal(t, "key mykey does not exist", err.Error())
  209. })
  210. }
  211. func TestSecurityCheck(t *testing.T) {
  212. }
  213. func TestValidateNetworkUpdate(t *testing.T) {
  214. }
  215. func TestValidateNetworkCreate(t *testing.T) {
  216. yes := true
  217. no := false
  218. deleteNet()
  219. //DeleteNetworks
  220. cases := []NetworkValidationTestCase{
  221. NetworkValidationTestCase{
  222. testname: "InvalidAddress",
  223. network: models.Network{
  224. AddressRange: "10.0.0.256",
  225. NetID: "skynet",
  226. IsDualStack: &no,
  227. },
  228. errMessage: "Field validation for 'AddressRange' failed on the 'cidr' tag",
  229. },
  230. NetworkValidationTestCase{
  231. testname: "BadDisplayName",
  232. network: models.Network{
  233. AddressRange: "10.0.0.1/24",
  234. NetID: "skynet",
  235. DisplayName: "skynet*",
  236. IsDualStack: &no,
  237. },
  238. errMessage: "Field validation for 'DisplayName' failed on the 'alphanum' tag",
  239. },
  240. NetworkValidationTestCase{
  241. testname: "DisplayNameTooLong",
  242. network: models.Network{
  243. AddressRange: "10.0.0.1/24",
  244. NetID: "skynet",
  245. DisplayName: "Thisisareallylongdisplaynamethatistoolong",
  246. IsDualStack: &no,
  247. },
  248. errMessage: "Field validation for 'DisplayName' failed on the 'max' tag",
  249. },
  250. NetworkValidationTestCase{
  251. testname: "DisplayNameTooShort",
  252. network: models.Network{
  253. AddressRange: "10.0.0.1/24",
  254. NetID: "skynet",
  255. DisplayName: "1",
  256. IsDualStack: &no,
  257. },
  258. errMessage: "Field validation for 'DisplayName' failed on the 'min' tag",
  259. },
  260. NetworkValidationTestCase{
  261. testname: "NetIDMissing",
  262. network: models.Network{
  263. AddressRange: "10.0.0.1/24",
  264. IsDualStack: &no,
  265. },
  266. errMessage: "Field validation for 'NetID' failed on the 'required' tag",
  267. },
  268. NetworkValidationTestCase{
  269. testname: "InvalidNetID",
  270. network: models.Network{
  271. AddressRange: "10.0.0.1/24",
  272. NetID: "contains spaces",
  273. IsDualStack: &no,
  274. },
  275. errMessage: "Field validation for 'NetID' failed on the 'alphanum' tag",
  276. },
  277. NetworkValidationTestCase{
  278. testname: "NetIDTooShort",
  279. network: models.Network{
  280. AddressRange: "10.0.0.1/24",
  281. NetID: "",
  282. IsDualStack: &no,
  283. },
  284. errMessage: "Field validation for 'NetID' failed on the 'required' tag",
  285. },
  286. NetworkValidationTestCase{
  287. testname: "NetIDTooLong",
  288. network: models.Network{
  289. AddressRange: "10.0.0.1/24",
  290. NetID: "LongNetIDName",
  291. IsDualStack: &no,
  292. },
  293. errMessage: "Field validation for 'NetID' failed on the 'max' tag",
  294. },
  295. NetworkValidationTestCase{
  296. testname: "ListenPortTooLow",
  297. network: models.Network{
  298. AddressRange: "10.0.0.1/24",
  299. NetID: "skynet",
  300. DefaultListenPort: 1023,
  301. IsDualStack: &no,
  302. },
  303. errMessage: "Field validation for 'DefaultListenPort' failed on the 'min' tag",
  304. },
  305. NetworkValidationTestCase{
  306. testname: "ListenPortTooHigh",
  307. network: models.Network{
  308. AddressRange: "10.0.0.1/24",
  309. NetID: "skynet",
  310. DefaultListenPort: 65536,
  311. IsDualStack: &no,
  312. },
  313. errMessage: "Field validation for 'DefaultListenPort' failed on the 'max' tag",
  314. },
  315. NetworkValidationTestCase{
  316. testname: "KeepAliveTooBig",
  317. network: models.Network{
  318. AddressRange: "10.0.0.1/24",
  319. NetID: "skynet",
  320. DefaultKeepalive: 1010,
  321. IsDualStack: &no,
  322. },
  323. errMessage: "Field validation for 'DefaultKeepalive' failed on the 'max' tag",
  324. },
  325. NetworkValidationTestCase{
  326. testname: "InvalidLocalRange",
  327. network: models.Network{
  328. AddressRange: "10.0.0.1/24",
  329. NetID: "skynet",
  330. LocalRange: "192.168.0.1",
  331. IsDualStack: &no,
  332. },
  333. errMessage: "Field validation for 'LocalRange' failed on the 'cidr' tag",
  334. },
  335. NetworkValidationTestCase{
  336. testname: "DualStackWithoutIPv6",
  337. network: models.Network{
  338. AddressRange: "10.0.0.1/24",
  339. NetID: "skynet",
  340. IsDualStack: &yes,
  341. },
  342. errMessage: "Field validation for 'AddressRange6' failed on the 'addressrange6_valid' tag",
  343. },
  344. NetworkValidationTestCase{
  345. testname: "CheckInIntervalTooBig",
  346. network: models.Network{
  347. AddressRange: "10.0.0.1/24",
  348. NetID: "skynet",
  349. IsDualStack: &no,
  350. DefaultCheckInInterval: 100001,
  351. },
  352. errMessage: "Field validation for 'DefaultCheckInInterval' failed on the 'max' tag",
  353. },
  354. NetworkValidationTestCase{
  355. testname: "CheckInIntervalTooSmall",
  356. network: models.Network{
  357. AddressRange: "10.0.0.1/24",
  358. NetID: "skynet",
  359. IsDualStack: &no,
  360. DefaultCheckInInterval: 1,
  361. },
  362. errMessage: "Field validation for 'DefaultCheckInInterval' failed on the 'min' tag",
  363. },
  364. }
  365. for _, tc := range cases {
  366. t.Run(tc.testname, func(t *testing.T) {
  367. err := ValidateNetworkCreate(tc.network)
  368. assert.NotNil(t, err)
  369. assert.Contains(t, err.Error(), tc.errMessage)
  370. })
  371. }
  372. t.Run("DuplicateNetID", func(t *testing.T) {
  373. var net1, net2 models.Network
  374. net1.NetID = "skynet"
  375. net1.AddressRange = "10.0.0.1/24"
  376. net1.DisplayName = "mynetwork"
  377. net2.NetID = "skynet"
  378. net2.AddressRange = "10.0.1.1/24"
  379. net2.IsDualStack = &no
  380. err := CreateNetwork(net1)
  381. assert.Nil(t, err)
  382. err = ValidateNetworkCreate(net2)
  383. assert.NotNil(t, err)
  384. assert.Contains(t, err.Error(), "Field validation for 'NetID' failed on the 'netid_valid' tag")
  385. })
  386. t.Run("DuplicateDisplayName", func(t *testing.T) {
  387. var network models.Network
  388. network.NetID = "wirecat"
  389. network.AddressRange = "10.0.100.1/24"
  390. network.IsDualStack = &no
  391. network.DisplayName = "mynetwork"
  392. err := ValidateNetworkCreate(network)
  393. assert.NotNil(t, err)
  394. assert.Contains(t, err.Error(), "Field validation for 'DisplayName' failed on the 'displayname_unique' tag")
  395. })
  396. }