[nullsafety] respect @:nullSafety(false) meta on getters/setters

src/typing/nullSafety.ml

@@ -1244,10 +1244,14 @@ class class_checker cls immediate_execution report  =
 							with Not_found -> None
 						in
 						match accessor with
-							| Some { cf_expr = Some ({ eexpr = TFunction fn } as accessor_expr) } ->
-								let fn = { fn with tf_type = field.cf_type } in
-								checker#check_root_expr { accessor_expr with eexpr = TFunction fn }
-							| _ -> ()
+							| None -> ()
+							| Some accessor ->
+								if self#is_in_safety accessor then
+									match accessor.cf_expr with
+										| Some ({ eexpr = TFunction fn } as accessor_expr) ->
+											let fn = { fn with tf_type = field.cf_type } in
+											checker#check_root_expr { accessor_expr with eexpr = TFunction fn }
+										| _ -> ()
 					in
 					if read_access = AccCall then check_accessor "get_";
 					if write_access = AccCall then check_accessor "set_"

tests/nullsafety/src/cases/Test.hx

@@ -45,6 +45,10 @@ class UnsafeFields {
 		var s:String;
 		@:nullSafety(false) cast(null, String);
 	}
+
+	var str(get,set):String;
+	@:nullSafety(false) function get_str() return (null:Null<String>);
+	@:nullSafety(false) function set_str(v) return (v:Null<String>);
 }
 
 /** Test `@:nullSafety(false)` is respected on a class */