Fixed some warnings, added @Overrides, removed unused imports and such

jme3-materialeditor/src/com/jme3/gde/materialdefinition/dialog/AddNodeDialog.java

@@ -8,8 +8,6 @@ import com.jme3.asset.ShaderNodeDefinitionKey;
 import com.jme3.gde.core.assets.ProjectAssetManager;
 import com.jme3.gde.core.util.TreeUtil;
 import com.jme3.gde.materialdefinition.editor.Diagram;
-import com.jme3.gde.materialdefinition.editor.NodePanel;
-import com.jme3.gde.materialdefinition.fileStructure.ShaderNodeBlock;
 import com.jme3.gde.materialdefinition.icons.Icons;
 import com.jme3.gde.materialdefinition.utils.DocFormatter;
 import com.jme3.shader.Shader;
@@ -33,8 +31,8 @@ import javax.swing.tree.TreeSelectionModel;
 public class AddNodeDialog extends javax.swing.JDialog {
 
     private List<ShaderNodeDefinition> defList = new ArrayList<ShaderNodeDefinition>();
-    private Diagram diagram;
-    private Point clickPosition;
+    private final Diagram diagram;
+    private final Point clickPosition;
     private String path;
 
     /**
@@ -226,6 +224,7 @@ public class AddNodeDialog extends javax.swing.JDialog {
         TreeUtil.expandTree(jTree1, (TreeNode) jTree1.getModel().getRoot(), 10);
         jTree1.getSelectionModel().setSelectionMode(TreeSelectionModel.SINGLE_TREE_SELECTION);
         jTree1.addTreeSelectionListener(new TreeSelectionListener() {
+            @Override
             public void valueChanged(TreeSelectionEvent e) {
 
                 DefaultMutableTreeNode node = (DefaultMutableTreeNode) jTree1.getLastSelectedPathComponent();
@@ -241,7 +240,7 @@ public class AddNodeDialog extends javax.swing.JDialog {
                     path = path.substring(0, path.lastIndexOf("/"));
                     ShaderNodeDefinitionKey k = new ShaderNodeDefinitionKey(path);
                     k.setLoadDocumentation(true);
-                    defList = (List<ShaderNodeDefinition>) mgr.loadAsset(k);
+                    defList = mgr.loadAsset(k);
 
                     for (ShaderNodeDefinition def : defList) {
                         createDoc(def);

jme3-materialeditor/src/com/jme3/gde/materialdefinition/editor/ConnectionCurve.java

@@ -104,6 +104,7 @@ public class ConnectionCurve extends JPanel implements ComponentListener, MouseI
     private final Point p3 = new Point();
     private final Point p4 = new Point();
 
+    @Override
     public String getKey() {
         return key;
     }
@@ -341,7 +342,7 @@ public class ConnectionCurve extends JPanel implements ComponentListener, MouseI
     }
 
     private Diagram getDiagram() {
-        return (Diagram) start.getDiagram();
+        return start.getDiagram();
     }
 
     @Override
@@ -415,19 +416,24 @@ public class ConnectionCurve extends JPanel implements ComponentListener, MouseI
     public void keyReleased(KeyEvent e) {
     }
 
+    @Override
     public void componentResized(ComponentEvent e) {
     }
 
+    @Override
     public void componentMoved(ComponentEvent e) {
         resize(start, end);
     }
 
+    @Override
     public void componentShown(ComponentEvent e) {
     }
 
+    @Override
     public void componentHidden(ComponentEvent e) {
     }
 
+    @Override
     public void propertyChange(PropertyChangeEvent evt) {
         MappingBlock map = (MappingBlock) evt.getSource();
         key = MaterialUtils.makeKey(map, getDiagram().getCurrentTechniqueName());
@@ -441,5 +447,4 @@ public class ConnectionCurve extends JPanel implements ComponentListener, MouseI
         return end;
     }
     
-    
 }

jme3-materialeditor/src/com/jme3/gde/materialdefinition/editor/ConnectionStraight.java

@@ -33,9 +33,9 @@ public class ConnectionStraight extends JPanel implements ComponentListener, Mou
 
     protected Dot start;
     protected Dot end;
-    private Point[] points = new Point[6];
+    private final Point[] points = new Point[6];
     private int pointsSize = 6;
-    private Corner[] corners = new Corner[6];
+    private final Corner[] corners = new Corner[6];
     private String key = "";
     protected MappingBlock mapping;
 
@@ -107,12 +107,12 @@ public class ConnectionStraight extends JPanel implements ComponentListener, Mou
         store.x = p.x - getLocation().x - 1;
         store.y = p.y - getLocation().y - 1;
     }
-    private Point p1 = new Point();
-    private Point p2 = new Point();
-    private Point tp1 = new Point();
-    private Point bp1 = new Point();
-    private Point tp2 = new Point();
-    private Point bp2 = new Point();
+    private final Point p1 = new Point();
+    private final Point p2 = new Point();
+    private final Point tp1 = new Point();
+    private final Point bp1 = new Point();
+    private final Point tp2 = new Point();
+    private final Point bp2 = new Point();
 
     @Override
     protected void paintBorder(Graphics g) {
@@ -125,6 +125,7 @@ public class ConnectionStraight extends JPanel implements ComponentListener, Mou
 //        g.drawLine(0, getHeight() - 1, 0, 0);
     }
 
+    @Override
     public String getKey() {
         return key;
     }
@@ -423,7 +424,7 @@ public class ConnectionStraight extends JPanel implements ComponentListener, Mou
     }
 
     private Diagram getDiagram() {
-        return (Diagram) start.getDiagram();
+        return start.getDiagram();
     }
 
     @Override
@@ -432,7 +433,7 @@ public class ConnectionStraight extends JPanel implements ComponentListener, Mou
     }
 
     private void dispatchEventToDiagram(MouseEvent e) {
-        MouseEvent me = null;
+        MouseEvent me;
         me = convertEvent(e);
         getDiagram().dispatchEvent(me);
     }

jme3-materialeditor/src/com/jme3/gde/materialdefinition/utils/MaterialUtils.java

@@ -10,7 +10,6 @@ import com.jme3.gde.materialdefinition.fileStructure.ShaderNodeBlock;
 import com.jme3.gde.materialdefinition.fileStructure.leaves.InputMappingBlock;
 import com.jme3.gde.materialdefinition.fileStructure.leaves.MappingBlock;
 import com.jme3.gde.materialdefinition.fileStructure.leaves.MatParamBlock;
-import com.jme3.gde.materialdefinition.fileStructure.leaves.WorldParamBlock;
 import com.jme3.shader.ShaderNodeDefinition;
 import com.jme3.shader.ShaderNodeVariable;
 import com.jme3.shader.ShaderUtils;
@@ -76,7 +75,7 @@ public class MaterialUtils {
     public static ShaderNodeDefinition loadShaderNodeDefinition(String path, String name, ProjectAssetManager manager) {
         ShaderNodeDefinitionKey k = new ShaderNodeDefinitionKey(path);
         k.setLoadDocumentation(true);
-        List<ShaderNodeDefinition> defs = (List<ShaderNodeDefinition>) manager.loadAsset(k);
+        List<ShaderNodeDefinition> defs = manager.loadAsset(k);
         for (ShaderNodeDefinition shaderNodeDefinition : defs) {
             if (shaderNodeDefinition.getName().equals(name)) {
                 return shaderNodeDefinition;

jme3-materialeditor/src/com/jme3/gde/materials/MaterialPreviewRenderer.java

@@ -21,7 +21,6 @@ import com.jme3.scene.Geometry;
 import com.jme3.scene.shape.Box;
 import com.jme3.scene.shape.Quad;
 import com.jme3.scene.shape.Sphere;
-import com.jme3.util.MaterialDebugAppState;
 import com.jme3.util.TangentBinormalGenerator;
 import java.util.concurrent.Callable;
 import java.util.concurrent.ScheduledThreadPoolExecutor;
@@ -87,10 +86,11 @@ public class MaterialPreviewRenderer implements SceneListener {
         }
         exec.execute(new Runnable() {
 
+            @Override
             public void run() {
                 MaterialKey key = new MaterialKey(assetManager.getRelativeAssetPath(materialFileName));
                 assetManager.deleteFromCache(key);
-                Material mat = (Material) assetManager.loadAsset(key);
+                Material mat = assetManager.loadAsset(key);
                 if (mat != null) {
                     showMaterial(mat);
                 }
@@ -110,6 +110,7 @@ public class MaterialPreviewRenderer implements SceneListener {
         }
         SceneApplication.getApplication().enqueue(new Callable<Material>() {
 
+            @Override
             public Material call() throws Exception {
                 if (techniqueName != null) {
                     try {
@@ -121,6 +122,7 @@ public class MaterialPreviewRenderer implements SceneListener {
                 final Material mat = reloadMaterial(m);
                 if (mat != null) {
                     java.awt.EventQueue.invokeLater(new Runnable() {
+                        @Override
                         public void run() {
                             currentMaterial = mat;
                             currentGeom.setMaterial(mat);
@@ -133,6 +135,7 @@ public class MaterialPreviewRenderer implements SceneListener {
                                 }
                             } catch (Exception e) {
                                 java.awt.EventQueue.invokeLater(new Runnable() {
+                                    @Override
                                     public void run() {
                                         label.setIcon(Icons.error);
                                     }
@@ -187,6 +190,7 @@ public class MaterialPreviewRenderer implements SceneListener {
             smartLog("{0}", e.getMessage());
 
             java.awt.EventQueue.invokeLater(new Runnable() {
+                @Override
                 public void run() {
                     label.setIcon(Icons.error);
                 }
@@ -219,16 +223,20 @@ public class MaterialPreviewRenderer implements SceneListener {
         showMaterial(currentMaterial);
     }
 
+    @Override
     public void sceneOpened(SceneRequest request) {
     }
 
+    @Override
     public void sceneClosed(SceneRequest request) {
     }
 
+    @Override
     public void previewCreated(PreviewRequest request) {
         if (request.getRequester() == this) {
             final ImageIcon icon = new ImageIcon(request.getImage());
             java.awt.EventQueue.invokeLater(new Runnable() {
+                @Override
                 public void run() {
                     label.setIcon(icon);
                 }

jme3-materialeditor/src/com/jme3/gde/materials/multiview/MaterialEditorTopComponent.java

@@ -40,7 +40,6 @@ import org.openide.filesystems.FileUtil;
 import org.openide.loaders.DataObject;
 import org.openide.nodes.Node;
 import org.openide.util.HelpCtx;
-import org.openide.util.Lookup;
 import org.openide.util.lookup.InstanceContent;
 import org.openide.windows.CloneableTopComponent;
 
@@ -56,7 +55,7 @@ public final class MaterialEditorTopComponent extends CloneableTopComponent impl
     /** path to the icon used by the component and its open action */
 //    static final String ICON_PATH = "SET/PATH/TO/ICON/HERE";
     private static final String PREFERRED_ID = "MaterialEditorTopComponent";
-    private Lookup lookup;
+    //private Lookup lookup;
     private final InstanceContent lookupContents = new InstanceContent();
 //    private SaveNode saveNode;
     private DataObject dataObject;
@@ -100,8 +99,6 @@ public final class MaterialEditorTopComponent extends CloneableTopComponent impl
         materialPreviewWidget1.showMaterial(manager, materialFileName);
 
         relativeMaterialFileName = manager.getRelativeAssetPath(materialFileName);
-
-
     }
 
     /** This method is called from within the constructor to
@@ -438,23 +435,28 @@ public final class MaterialEditorTopComponent extends CloneableTopComponent impl
         return PREFERRED_ID;
     }
 
+    @Override
     public String getKey() {
         return relativeMaterialFileName;
     }
 
+    @Override
     public void addMaterialChangeListener(MaterialChangeListener listener) {
         materialListeners.add(listener);
     }
 
+    @Override
     public void removeMaterialChangeListener(MaterialChangeListener listener) {
         materialListeners.remove(listener);
     }
 
+    @Override
     public void clearMaterialChangeListeners() {
         materialListeners.clear();
 
     }
 
+    @Override
     public void addAllMaterialChangeListener(List<MaterialChangeListener> listeners) {
         materialListeners.addAll(listeners);
     }
@@ -463,14 +465,17 @@ public final class MaterialEditorTopComponent extends CloneableTopComponent impl
 
         String newline = "\n";
 
+        @Override
         public void insertUpdate(DocumentEvent e) {
             checkSave();
         }
 
+        @Override
         public void removeUpdate(DocumentEvent e) {
             checkSave();
         }
 
+        @Override
         public void changedUpdate(DocumentEvent e) {
             checkSave();
         }
@@ -497,6 +502,7 @@ public final class MaterialEditorTopComponent extends CloneableTopComponent impl
 
     private class SaveCookieImpl implements SaveCookie {
 
+        @Override
         public void save() throws IOException {
             String text = jTextArea1.getText();
             materialFile.setAsText(text);
@@ -605,13 +611,14 @@ public final class MaterialEditorTopComponent extends CloneableTopComponent impl
         }
     }
 
+    @Override
     public void propertyChanged(MaterialProperty property) {
         String string = materialFile.getUpdatedContent();
         jTextArea1.setText(string);
         try {
             MaterialKey key = new MaterialKey(manager.getRelativeAssetPath(materialFileName));
             manager.deleteFromCache(key);
-            Material material = (Material) manager.loadAsset(key);
+            Material material = manager.loadAsset(key);
             if (material != null) {
                 for (MaterialChangeListener listener : materialListeners) {
                     listener.setMaterial(material);

jme3-materialeditor/src/com/jme3/gde/materials/multiview/widgets/TexturePanel.form

@@ -57,8 +57,8 @@
           <Group type="102" alignment="0" attributes="0">
               <EmptySpace max="-2" attributes="0"/>
               <Group type="103" groupAlignment="0" attributes="0">
-                  <Component id="jLabel1" pref="25" max="32767" attributes="1"/>
-                  <Component id="jButton2" alignment="1" pref="25" max="32767" attributes="1"/>
+                  <Component id="jLabel1" max="32767" attributes="1"/>
+                  <Component id="jButton2" alignment="1" max="32767" attributes="1"/>
                   <Component id="jCheckBox2" alignment="0" max="32767" attributes="1"/>
                   <Component id="jCheckBox1" alignment="0" max="32767" attributes="1"/>
                   <Component id="jButton1" alignment="0" max="32767" attributes="1"/>

jme3-materialeditor/src/com/jme3/gde/materials/multiview/widgets/TexturePanel.java

@@ -92,7 +92,7 @@ public class TexturePanel extends MaterialPropertyWidget {
         if (ratio <= 1) {
             height = (int) ((float) width * ratio);
         } else {
-            width = (int) ((float) height * (float) ratio);
+            width = (int) ((float) height * ratio);
         }
         BufferedImage resizedImage = new BufferedImage(width, height, type);
         Graphics2D g = resizedImage.createGraphics();

jme3-model-importer/src/com/jme3/gde/modelimporter/ImportKeyNode.java

@@ -23,7 +23,7 @@ import org.openide.util.Exceptions;
  */
 @SuppressWarnings({"unchecked", "rawtypes"})
 public class ImportKeyNode extends AbstractNode {
-    private AssetKey key;
+    private final AssetKey key;
 
     public ImportKeyNode(AssetKey key) {
         super(Children.LEAF);
@@ -33,7 +33,7 @@ public class ImportKeyNode extends AbstractNode {
     @Override
     protected Sheet createSheet() {
         Sheet sheet = super.createSheet();
-        Sheet.Set set = sheet.createPropertiesSet();
+        Sheet.Set set = Sheet.createPropertiesSet();
         set.setName("AssetKey");
         set.setDisplayName("Conversion Settings");
         for (Field field : key.getClass().getDeclaredFields()) {

jme3-navmesh-gen/src/com/jme3/gde/nmgen/wizard/NavMeshGeneratorNode.java

@@ -23,7 +23,7 @@ import org.openide.util.Exceptions;
 @SuppressWarnings({"unchecked", "rawtypes"})
 public class NavMeshGeneratorNode extends AbstractNode {
 
-    private NavMeshGenerator key;
+    private final NavMeshGenerator key;
 
     public NavMeshGeneratorNode(NavMeshGenerator key) {
         super(Children.LEAF);
@@ -33,7 +33,7 @@ public class NavMeshGeneratorNode extends AbstractNode {
     @Override
     protected Sheet createSheet() {
         Sheet sheet = super.createSheet();
-        Sheet.Set set = sheet.createPropertiesSet();
+        Sheet.Set set = Sheet.createPropertiesSet();
         set.setName("NavMeshGenerator");
         set.setDisplayName("Settings");
         for (Field field : key.getClass().getDeclaredFields()) {