Browse Source

fixing codacy issues

rickard 3 years ago
parent
commit
84a9b5a1c1

+ 3 - 3
jme3-core/src/com/jme3/gde/core/assets/ExternalChangeScanner.java

@@ -66,9 +66,9 @@ public class ExternalChangeScanner implements AssetDataPropertyChangeListener,
     private static final Logger LOGGER =
     private static final Logger LOGGER =
             Logger.getLogger(ExternalChangeScanner.class.getName());
             Logger.getLogger(ExternalChangeScanner.class.getName());
     private static final AtomicBoolean userNotified = new AtomicBoolean(false);
     private static final AtomicBoolean userNotified = new AtomicBoolean(false);
-    protected final AssetDataObject assetDataObject;
-    protected final AssetData assetData;
-    protected final FileObject originalObject;
+    private final AssetDataObject assetDataObject;
+    private final AssetData assetData;
+    private final FileObject originalObject;
 
 
     public ExternalChangeScanner(AssetDataObject assetDataObject) {
     public ExternalChangeScanner(AssetDataObject assetDataObject) {
         this.assetDataObject = assetDataObject;
         this.assetDataObject = assetDataObject;

+ 1 - 2
jme3-core/src/com/jme3/gde/core/util/TaggedSpatialFinder.java

@@ -1,7 +1,6 @@
 package com.jme3.gde.core.util;
 package com.jme3.gde.core.util;
 
 
 import com.jme3.scene.Spatial;
 import com.jme3.scene.Spatial;
-
 import java.util.logging.Level;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import java.util.logging.Logger;
 
 
@@ -19,7 +18,7 @@ public class TaggedSpatialFinder {
      * the name and path to be looked for from the given needle Spatial.
      * the name and path to be looked for from the given needle Spatial.
      *
      *
      * @param root   supplied root Spatial
      * @param root   supplied root Spatial
-     * @param needle
+     * @param needle spatial to look for
      * @return found spatial
      * @return found spatial
      */
      */
     public Spatial find(final Spatial root, final Spatial needle) {
     public Spatial find(final Spatial root, final Spatial needle) {

+ 5 - 5
jme3-core/src/com/jme3/gde/core/util/datatransfer/AnimationDataFromOriginal.java

@@ -57,7 +57,7 @@ public final class AnimationDataFromOriginal implements SpatialDataTransferInter
         });
         });
     }
     }
 
 
-    private AnimComposer getAndRemoveControl(Spatial spatial) {
+    private AnimComposer getAndRemoveControl(final Spatial mySpatial) {
         final AnimComposer myAnimControl =
         final AnimComposer myAnimControl =
                 mySpatial.getControl(AnimComposer.class);
                 mySpatial.getControl(AnimComposer.class);
         if (myAnimControl != null) {
         if (myAnimControl != null) {
@@ -66,11 +66,11 @@ public final class AnimationDataFromOriginal implements SpatialDataTransferInter
         return myAnimControl;
         return myAnimControl;
     }
     }
 
 
-    private void updateAndAddControl(Spatial spatial, AnimComposer newControl
-            , AnimComposer originalCOntrol) {
+    private void updateAndAddControl(final Spatial spatial, final AnimComposer newControl
+            , final AnimComposer originalControl) {
         newControl.cloneFields(new Cloner(),
         newControl.cloneFields(new Cloner(),
-                originalCOntrol.jmeClone());
-        copyAnimClips(newControl, originalCOntrol);
+                originalControl.jmeClone());
+        copyAnimClips(newControl, originalControl);
         if (spatial.getControl(AnimComposer.class) == null) {
         if (spatial.getControl(AnimComposer.class) == null) {
             LOGGER.log(Level.FINE, "Adding control for {0}",
             LOGGER.log(Level.FINE, "Adding control for {0}",
                     spatial.getName());
                     spatial.getName());

+ 2 - 3
jme3-core/src/com/jme3/gde/core/util/datatransfer/MaterialDataFromOriginal.java

@@ -5,7 +5,6 @@ import com.jme3.gde.core.util.TaggedSpatialFinder;
 import com.jme3.scene.Geometry;
 import com.jme3.scene.Geometry;
 import com.jme3.scene.SceneGraphVisitorAdapter;
 import com.jme3.scene.SceneGraphVisitorAdapter;
 import com.jme3.scene.Spatial;
 import com.jme3.scene.Spatial;
-
 import java.util.logging.Logger;
 import java.util.logging.Logger;
 
 
 /**
 /**
@@ -13,7 +12,7 @@ import java.util.logging.Logger;
  */
  */
 public final class MaterialDataFromOriginal implements SpatialDataTransferInterface {
 public final class MaterialDataFromOriginal implements SpatialDataTransferInterface {
 
 
-    private static final Logger logger =
+    private static final Logger LOGGER =
             Logger.getLogger(MaterialDataFromOriginal.class.getName());
             Logger.getLogger(MaterialDataFromOriginal.class.getName());
 
 
     private final TaggedSpatialFinder finder;
     private final TaggedSpatialFinder finder;
@@ -33,7 +32,7 @@ public final class MaterialDataFromOriginal implements SpatialDataTransferInterf
                 final Geometry spat = (Geometry) finder.find(root, geom);
                 final Geometry spat = (Geometry) finder.find(root, geom);
                 if (spat != null && spat.getMaterial() != null && geom.getMaterial() != null) {
                 if (spat != null && spat.getMaterial() != null && geom.getMaterial() != null) {
                     spat.setMaterial(geom.getMaterial());
                     spat.setMaterial(geom.getMaterial());
-                    logger.log(ApplicationLogHandler.LogLevel.FINE,
+                    LOGGER.log(ApplicationLogHandler.LogLevel.FINE,
                             "Updated material for Geometry {0}",
                             "Updated material for Geometry {0}",
                             geom.getName());
                             geom.getName());
                 }
                 }

+ 0 - 1
jme3-core/src/com/jme3/gde/core/util/datatransfer/TransformDataFromOriginal.java

@@ -5,7 +5,6 @@ import com.jme3.gde.core.util.TaggedSpatialFinder;
 import com.jme3.scene.Geometry;
 import com.jme3.scene.Geometry;
 import com.jme3.scene.Node;
 import com.jme3.scene.Node;
 import com.jme3.scene.Spatial;
 import com.jme3.scene.Spatial;
-
 import java.util.logging.Logger;
 import java.util.logging.Logger;
 
 
 /**
 /**