Browse Source

Fixed some Codacity issues

Toni Helenius 2 years ago
parent
commit
86d040c564

+ 2 - 2
jme3-templates/src/com/jme3/gde/templates/gradledesktop/options/CachedOptionsContainer.java

@@ -98,7 +98,7 @@ public class CachedOptionsContainer {
         physicsLibraries = initLibaries(mavenVersionChecker, PhysicsLibrary.values());
     }
 
-    private List<TemplateLibrary> initLibaries(MavenVersionChecker mavenVersionChecker, TemplateLibrary[] libraries) {
+    private List<TemplateLibrary> initLibaries(final MavenVersionChecker mavenVersionChecker, TemplateLibrary[] libraries) {
         List<TemplateLibrary> libs = new ArrayList<>(libraries.length);
         for (TemplateLibrary templateLibrary : libraries) {
             libs.add(new TemplateLibrary() {
@@ -214,7 +214,7 @@ public class CachedOptionsContainer {
         }
 
         // Compile the results
-        SortedSet<LibraryVersion<T>> allVersions = new TreeSet<>(versionComparator);
+        final SortedSet<LibraryVersion<T>> allVersions = new TreeSet<>(versionComparator);
         allVersions.addAll(Arrays.asList(versions));
         for (String v : vList) {
             allVersions.add(new LibraryVersion<T>() {

+ 3 - 0
jme3-templates/src/com/jme3/gde/templates/gradledesktop/options/VersionInfo.java

@@ -34,6 +34,9 @@ package com.jme3.gde.templates.gradledesktop.options;
 /**
  * Represents version information that can be compared between each other (which
  * one is more new etc.)
+ *
+ * @param <T> The concrete class should be passed as type for correct comparable
+ * implementation
  */
 public interface VersionInfo<T extends VersionInfo> extends Comparable<T> {
 

+ 2 - 2
jme3-templates/src/com/jme3/gde/templates/utils/mavensearch/MavenApiVersionChecker.java

@@ -129,11 +129,11 @@ public class MavenApiVersionChecker implements MavenVersionChecker {
         return result;
     }
 
-    private static String encodeValue(String value) {
+    private static String encodeValue(final String value) {
         try {
             return URLEncoder.encode(value, StandardCharsets.UTF_8.name());
         } catch (UnsupportedEncodingException ex) {
-            throw new RuntimeException("Failed to encode value!", ex);
+            throw new MavenVersionCheckException("Failed to encode value!", ex);
         }
     }