Explorar o código

AbstractShadowRenderer.setRenderBackFacesShadows(): Change input type Boolean -> boolean (#2206)

AbstractShadowFilter.setRenderBackFacesShadows: change input type from Boolean to boolean
Wyatt Gillette hai 1 ano
pai
achega
56fecab1ae

+ 3 - 5
jme3-core/src/main/java/com/jme3/shadow/AbstractShadowFilter.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2009-2021 jMonkeyEngine
+ * Copyright (c) 2009-2024 jMonkeyEngine
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -108,7 +108,6 @@ public abstract class AbstractShadowFilter<T extends AbstractShadowRenderer> ext
         material.setMatrix4("ViewProjectionMatrixInverse", viewPort.getCamera().getViewProjectionMatrix().invert());
         Matrix4f m = viewPort.getCamera().getViewProjectionMatrix();
         material.setVector4("ViewProjectionMatrixRow2", tmpv.set(m.m20, m.m21, m.m22, m.m23));
-
     }
 
     @Override
@@ -258,7 +257,7 @@ public abstract class AbstractShadowFilter<T extends AbstractShadowRenderer> ext
     /**
      *
      * !! WARNING !! this parameter is defaulted to true for the ShadowFilter.
-     * Setting it to true, may produce edges artifacts on shadows.     *
+     * Setting it to true, may produce edges artifacts on shadows.
      *
      * Set to true if you want back faces shadows on geometries.
      * Note that back faces shadows will be blended over dark lighten areas and may produce overly dark lighting.
@@ -272,7 +271,7 @@ public abstract class AbstractShadowFilter<T extends AbstractShadowRenderer> ext
      *
      * @param renderBackFacesShadows true or false.
      */
-    public void setRenderBackFacesShadows(Boolean renderBackFacesShadows) {
+    public void setRenderBackFacesShadows(boolean renderBackFacesShadows) {
         shadowRenderer.setRenderBackFacesShadows(renderBackFacesShadows);
     }
 
@@ -294,7 +293,6 @@ public abstract class AbstractShadowFilter<T extends AbstractShadowRenderer> ext
         return shadowRenderer.getPreShadowForcedRenderState();
     }
 
-
     /**
      * returns the edge filtering mode
      *

+ 4 - 8
jme3-core/src/main/java/com/jme3/shadow/AbstractShadowRenderer.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2009-2021 jMonkeyEngine
+ * Copyright (c) 2009-2024 jMonkeyEngine
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -145,12 +145,10 @@ public abstract class AbstractShadowRenderer implements SceneProcessor, Savable,
      * maps the more quality, the fewer fps).
      */
     protected AbstractShadowRenderer(AssetManager assetManager, int shadowMapSize, int nbShadowMaps) {
-
         this.assetManager = assetManager;
         this.nbShadowMaps = nbShadowMaps;
         this.shadowMapSize = shadowMapSize;
         init(assetManager, nbShadowMaps, shadowMapSize);
-
     }
 
     private void init(AssetManager assetManager, int nbShadowMaps, int shadowMapSize) {
@@ -430,7 +428,6 @@ public abstract class AbstractShadowRenderer implements SceneProcessor, Savable,
         renderManager.setForcedMaterial(null);
         renderManager.setForcedTechnique(null);
         renderManager.setCamera(viewPort.getCamera(), false);
-
     }
 
     protected void renderShadowMap(int shadowMapIndex) {
@@ -806,12 +803,12 @@ public abstract class AbstractShadowRenderer implements SceneProcessor, Savable,
      *
      * @param renderBackFacesShadows true or false.
      */
-    public void setRenderBackFacesShadows(Boolean renderBackFacesShadows) {
+    public void setRenderBackFacesShadows(boolean renderBackFacesShadows) {
         this.renderBackFacesShadows = renderBackFacesShadows;
-        if(renderBackFacesShadows) {
+        if (renderBackFacesShadows) {
             getPreShadowForcedRenderState().setPolyOffset(5, 3);
             getPreShadowForcedRenderState().setFaceCullMode(RenderState.FaceCullMode.Back);
-        }else{
+        } else {
             getPreShadowForcedRenderState().setPolyOffset(0, 0);
             getPreShadowForcedRenderState().setFaceCullMode(RenderState.FaceCullMode.Front);
         }
@@ -864,7 +861,6 @@ public abstract class AbstractShadowRenderer implements SceneProcessor, Savable,
         init(assetManager, nbShadowMaps, (int) shadowMapSize);
         edgesThickness = ic.readFloat("edgesThickness", 1.0f);
         postshadowMat.setFloat("PCFEdge", edgesThickness);
-
     }
 
     /**