Przeglądaj źródła

dont handle sizing options differently in .setOption

Adam Shaw 6 lat temu
rodzic
commit
053ea107ea
1 zmienionych plików z 2 dodań i 7 usunięć
  1. 2 7
      packages/core/src/Calendar.tsx

+ 2 - 7
packages/core/src/Calendar.tsx

@@ -436,8 +436,7 @@ export default class Calendar {
     let specialUpdates = {}
     let specialUpdates = {}
     let oldDateEnv = this.dateEnv // do this before onOptionsChange
     let oldDateEnv = this.dateEnv // do this before onOptionsChange
     let isTimeZoneDirty = false
     let isTimeZoneDirty = false
-    let isSizeDirty = false
-    let anyDifficultOptions = Boolean(removals.length)
+    let anyDifficultOptions = Boolean(removals.length) // pretty much all options are "difficult" :(
 
 
     for (let name in updates) {
     for (let name in updates) {
       if (changeHandlers[name]) {
       if (changeHandlers[name]) {
@@ -448,9 +447,7 @@ export default class Calendar {
     }
     }
 
 
     for (let name in normalUpdates) {
     for (let name in normalUpdates) {
-      if (/^(height|contentHeight|aspectRatio)$/.test(name)) {
-        isSizeDirty = true
-      } else if (/^(defaultDate|defaultView)$/.test(name)) {
+      if (/^(defaultDate|defaultView)$/.test(name)) {
         // can't change date this way. use gotoDate instead
         // can't change date this way. use gotoDate instead
       } else {
       } else {
         anyDifficultOptions = true // I guess all options are "difficult" ?
         anyDifficultOptions = true // I guess all options are "difficult" ?
@@ -487,8 +484,6 @@ export default class Calendar {
           viewType: this.state.viewType
           viewType: this.state.viewType
         })
         })
 
 
-      } else if (isSizeDirty) {
-        this.updateSize()
       }
       }
 
 
       // special updates
       // special updates