Prechádzať zdrojové kódy

hitdragging doesnt do destroy

Adam Shaw 7 rokov pred
rodič
commit
270842133f

+ 4 - 4
src/interactions-external/Draggable.ts

@@ -8,15 +8,15 @@ export interface ExternalDraggableEventSettings {
 
 export default class ExternalDraggableEvent {
 
-  externalDragging: ExternalElementDragging
+  dragging: FeaturefulElementDragging
 
   constructor(settings: ExternalDraggableEventSettings) {
-    let dragging = new FeaturefulElementDragging(settings.el)
-    this.externalDragging = new ExternalElementDragging(dragging, settings.event)
+    this.dragging = new FeaturefulElementDragging(settings.el)
+    new ExternalElementDragging(this.dragging, settings.event)
   }
 
   destroy() {
-    this.externalDragging.destroy()
+    this.dragging.destroy()
   }
 
 }

+ 0 - 4
src/interactions-external/ExternalElementDragging.ts

@@ -28,10 +28,6 @@ export default class ExternalElementDragging {
     this.explicitEventCreationData = rawEventCreationData ? processExplicitData(rawEventCreationData) : null
   }
 
-  destroy() {
-    this.hitDragging.destroy() // should not be responsible for destroying something not belonged!
-  }
-
   onDragStart = (ev: PointerDragEvent) => {
 
     // TODO: nicer accessors in GlobalContext for this?

+ 4 - 4
src/interactions/DateClicking.ts

@@ -17,6 +17,10 @@ export default class DateClicking {
     this.hitDragging.on('dragend', this.onDragEnd)
   }
 
+  destroy() {
+    this.dragging.destroy()
+  }
+
   onPointerDown = (ev: PointerDragEvent) => {
     let { dragging } = this
 
@@ -42,8 +46,4 @@ export default class DateClicking {
     }
   }
 
-  destroy() {
-    this.hitDragging.destroy()
-  }
-
 }

+ 1 - 1
src/interactions/DateSelecting.ts

@@ -31,7 +31,7 @@ export default class DateSelecting {
   }
 
   destroy() {
-    this.hitDragging.destroy()
+    this.dragging.destroy()
   }
 
   onPointerDown = (ev: PointerDragEvent) => {

+ 1 - 1
src/interactions/EventDragging.ts

@@ -34,7 +34,7 @@ export default class EventDragging {
   }
 
   destroy() {
-    this.hitDragging.destroy()
+    this.dragging.destroy()
   }
 
   onPointerDown = (ev: PointerDragEvent) => {

+ 1 - 1
src/interactions/EventResizing.ts

@@ -30,7 +30,7 @@ export default class EventDragging {
   }
 
   destroy() {
-    this.hitDragging.destroy()
+    this.dragging.destroy()
   }
 
   onPointerDown = (ev) => {

+ 0 - 4
src/interactions/HitDragging.ts

@@ -52,10 +52,6 @@ export default class HitDragging {
     this.emitter = new EmitterMixin()
   }
 
-  destroy() {
-    this.dragging.destroy() // should not be responsible for destroying!
-  }
-
   on(name, handler) {
     this.emitter.on(name, handler)
   }