isRtl -> in tests and demos

locale/ar-dz.js

@@ -5,7 +5,7 @@ defineLocale("ar-dz", {
     dow: 0, // Sunday is the first day of the week.
     doy: 4  // The week that contains Jan 1st is the first week of the year.
   },
-  isRtl: true,
+  dir: 'rtl',
   buttonText: {
     prev: "السابق",
     next: "التالي",

locale/ar-kw.js

@@ -5,7 +5,7 @@ defineLocale("ar-kw", {
     dow: 0, // Sunday is the first day of the week.
     doy: 12  // The week that contains Jan 1st is the first week of the year.
   },
-  isRtl: true,
+  dir: 'rtl',
   buttonText: {
     prev: "السابق",
     next: "التالي",

locale/ar-ly.js

@@ -5,7 +5,7 @@ defineLocale("ar-ly", {
     dow: 6, // Saturday is the first day of the week.
     doy: 12  // The week that contains Jan 1st is the first week of the year.
   },
-  isRtl: true,
+  dir: 'rtl',
   buttonText: {
     prev: "السابق",
     next: "التالي",

locale/ar-ma.js

@@ -5,7 +5,7 @@ defineLocale("ar-ma", {
     dow: 6, // Saturday is the first day of the week.
     doy: 12  // The week that contains Jan 1st is the first week of the year.
   },
-  isRtl: true,
+  dir: 'rtl',
   buttonText: {
     prev: "السابق",
     next: "التالي",

locale/ar-sa.js

@@ -5,7 +5,7 @@ defineLocale("ar-sa", {
     dow: 0, // Sunday is the first day of the week.
     doy: 6  // The week that contains Jan 1st is the first week of the year.
   },
-  isRtl: true,
+  dir: 'rtl',
   buttonText: {
     prev: "السابق",
     next: "التالي",

locale/ar-tn.js

@@ -5,7 +5,7 @@ defineLocale("ar-tn", {
     dow: 1, // Monday is the first day of the week.
     doy: 4 // The week that contains Jan 4th is the first week of the year.
   },
-  isRtl: true,
+  dir: 'rtl',
   buttonText: {
     prev: "السابق",
     next: "التالي",

locale/ar.js

@@ -5,7 +5,7 @@ defineLocale("ar", {
     dow: 6, // Saturday is the first day of the week.
     doy: 12  // The week that contains Jan 1st is the first week of the year.
   },
-  isRtl: true,
+  dir: 'rtl',
   buttonText: {
     prev: "السابق",
     next: "التالي",

locale/fa.js

@@ -5,7 +5,7 @@ defineLocale("fa", {
     dow: 6, // Saturday is the first day of the week.
     doy: 12 // The week that contains Jan 1st is the first week of the year.
   },
-  isRtl: true,
+  dir: 'rtl',
   buttonText: {
     prev: "قبلی",
     nex: "بعدی",

locale/he.js

@@ -1,7 +1,7 @@
 import { defineLocale } from 'fullcalendar';
 
 defineLocale("he", {
-  isRtl: true,
+  dir: 'rtl',
   buttonText: {
     prev: "הקודם",
     next: "הבא",

tests/automated/legacy/Agenda-render.js

@@ -11,7 +11,7 @@ describe('Agenda view rendering', function() {
 
   describe('when LTR', function() {
     pushOptions({
-      isRtl: false
+      dir: 'ltr'
     })
 
     it('renders the axis on the left', function() {
@@ -25,7 +25,7 @@ describe('Agenda view rendering', function() {
 
   describe('when RTL', function() {
     pushOptions({
-      isRtl: true
+      dir: 'rtl'
     })
 
     it('renders the axis on the right', function() {

tests/automated/legacy/DayGrid-events.js

@@ -8,13 +8,13 @@ describe('DayGrid event rendering', function() {
   })
 
   describe('when LTR', function() {
-    initMonthTesting(false)
+    initMonthTesting('ltr')
   })
   describe('when RTL', function() {
-    initMonthTesting(true)
+    initMonthTesting('rtl')
   })
 
-  function initMonthTesting(isRtl) {
+  function initMonthTesting(dir) {
     it('correctly renders an event starting before view\'s start', function() {
       var options = {}
       options.events = [
@@ -184,9 +184,9 @@ describe('DayGrid event rendering', function() {
     })
 
     function testSeg(calendarOptions, testSegOptions) {
-      calendarOptions.isRtl = isRtl
+      calendarOptions.dir = dir
       initCalendar(calendarOptions)
-      directionallyTestSeg(testSegOptions, isRtl)
+      directionallyTestSeg(testSegOptions, dir)
     }
   }
 
@@ -250,7 +250,7 @@ describe('DayGrid event rendering', function() {
     - isStart
     - isEnd
   */
-  function directionallyTestSeg(opts, isRtl) {
+  function directionallyTestSeg(opts, dir) {
     var el = opts.el ? $(opts.el) : getFirstEventEl()
 
     var row = opts.row || 0
@@ -259,7 +259,7 @@ describe('DayGrid event rendering', function() {
 
     var leftCol
     var rightCol
-    if (isRtl) {
+    if (dir === 'rtl') {
       leftCol = rowTds.length - opts.lastCol - 1
       rightCol = rowTds.length - opts.firstCol - 1
     } else {

tests/automated/legacy/agenda-view.js

@@ -12,10 +12,10 @@ const AXIS_CLASS = 'fc-axis'
 
 describe('agenda view rendering', function() {
 
-  describe('when isRtl is false', function() {
+  describe('when dir is ltr', function() {
     pushOptions({
       defaultView: 'agendaWeek',
-      isRtl: false
+      dir: 'ltr'
     })
 
     it('should have have days ordered sun to sat', function() {
@@ -32,10 +32,10 @@ describe('agenda view rendering', function() {
     })
   })
 
-  describe('when isRtl is true', function() {
+  describe('when dir is rtl', function() {
     pushOptions({
       defaultView: 'agendaWeek',
-      isRtl: true
+      dir: 'rtl'
     })
 
     it('should have have days ordered sat to sun', function() {

tests/automated/legacy/background-events.js

@@ -122,7 +122,7 @@ describe('background events', function() {
     })
 
     describe('when RTL', function() {
-      pushOptions({isRtl: true})
+      pushOptions({dir: 'rtl'})
 
       it('render correctly on a single day', function(done) {
         var options = {}
@@ -320,7 +320,7 @@ describe('background events', function() {
       })
 
       describe('when RTL', function() {
-        pushOptions({ isRtl: true })
+        pushOptions({ dir: 'rtl' })
 
         it('render correctly on a single day', function(done) {
           var options = {}
@@ -485,7 +485,7 @@ describe('background events', function() {
       })
     })
     describe('when RTL', function() {
-      pushOptions({ isRtl: true })
+      pushOptions({ dir: 'rtl' })
       it('render correctly on one day', function(done) {
         var options = {}
         options.events = [ {
@@ -699,7 +699,7 @@ describe('background events', function() {
       })
 
       describe('when RTL', function() {
-        pushOptions({ isRtl: true })
+        pushOptions({ dir: 'rtl' })
         it('render correctly on one day', function(done) {
           var options = {}
           options.events = [ {

tests/automated/legacy/basic-view.js

@@ -5,10 +5,10 @@ describe('basic view rendering', function() {
     defaultView: 'month'
   })
 
-  describe('when isRtl is false', function() {
+  describe('when dir is ltr', function() {
 
     pushOptions({
-      isRtl: false
+      dir: 'ltr'
     })
 
     it('should have days ordered sun to sat', function() {
@@ -24,10 +24,10 @@ describe('basic view rendering', function() {
     })
   })
 
-  describe('when isRtl is true', function() {
+  describe('when dir is rtl', function() {
 
     pushOptions({
-      isRtl: true
+      dir: 'rtl'
     })
 
     it('should have days ordered sat to sun', function() {

tests/automated/legacy/dateClick.js

@@ -5,10 +5,10 @@ describe('dateClick', function() {
     timeZone: 'UTC'
   });
 
-  [ false, true ].forEach(function(isRtl) {
-    describe('when isRtl is ' + isRtl, function() {
+  [ 'ltr', 'rtl' ].forEach(function(dir) {
+    describe('when dir is ' + dir, function() {
 
-      pushOptions({ isRtl: isRtl });
+      pushOptions({ dir });
 
       [ false, true ].forEach(function(selectable) {
         describe('when selectable is ' + selectable, function() {
@@ -30,7 +30,7 @@ describe('dateClick', function() {
 
               initCalendar(options)
 
-              var dayCell = $('.fc-day:eq(10)') // 2014-05-07 (regardless of isRtl)
+              var dayCell = $('.fc-day:eq(10)') // 2014-05-07 (regardless of dir)
 
               // for simulating the mousedown/mouseup/click (relevant for selectable)
               dayCell.simulate('drag')
@@ -54,7 +54,7 @@ describe('dateClick', function() {
 
               initCalendar(options)
 
-              // 2014-05-28 (regardless of isRtl)
+              // 2014-05-28 (regardless of dir)
               var dayContent = $('.fc-agenda-view .fc-day-grid .fc-day:eq(3)')
 
               // for simulating the mousedown/mouseup/click (relevant for selectable)
@@ -79,7 +79,7 @@ describe('dateClick', function() {
 
               initCalendar(options)
 
-              // the middle is 2014-05-28T09:00:00 (regardless of isRtl)
+              // the middle is 2014-05-28T09:00:00 (regardless of dir)
               var slotRow = $('.fc-slats tr:eq(18) td:not(.fc-time)')
 
               // for simulating the mousedown/mouseup/click (relevant for selectable)
@@ -106,7 +106,7 @@ describe('dateClick', function() {
 
               initCalendar(options)
 
-              // the middle is 2014-05-28T11:00:00 (regardless of isRtl)
+              // the middle is 2014-05-28T11:00:00 (regardless of dir)
               var slotRow = $('.fc-slats tr:eq(18) td:not(.fc-time)')
 
               // for simulating the mousedown/mouseup/click (relevant for selectable)
@@ -134,7 +134,7 @@ describe('dateClick', function() {
 
       initCalendar(options)
 
-      var dayCell = $('.fc-day:eq(10)') // 2014-05-07 (regardless of isRtl)
+      var dayCell = $('.fc-day:eq(10)') // 2014-05-07 (regardless of dir)
 
       // for simulating the mousedown/mouseup/click (relevant for selectable)
       dayCell.simulate('drag', {
@@ -178,7 +178,7 @@ describe('dateClick', function() {
 
       initCalendar(options)
 
-      var dayCell = $('.fc-day:eq(10)') // 2014-05-07 (regardless of isRtl)
+      var dayCell = $('.fc-day:eq(10)') // 2014-05-07 (regardless of dir)
       $.simulateTouchClick(dayCell)
     })
   })

tests/automated/legacy/destroy.js

@@ -5,7 +5,7 @@ describe('destroy', function() {
   describe('when calendar is LTR', function() {
     it('cleans up all classNames on the root element', function() {
       initCalendar({
-        isRtl: false
+        dir: 'ltr'
       })
       currentCalendar.destroy()
       expect($('#calendar')[0].className).toBe('')
@@ -15,7 +15,7 @@ describe('destroy', function() {
   describe('when calendar is RTL', function() {
     it('cleans up all classNames on the root element', function() {
       initCalendar({
-        isRtl: true
+        dir: 'rtl'
       })
       currentCalendar.destroy()
       expect($('#calendar')[0].className).toBe('')

tests/automated/legacy/isRTL.js → tests/automated/legacy/dir.js

@@ -1,10 +1,10 @@
-describe('isRtl', function() {
+describe('dir', function() {
 
   it('has it\'s default value computed differently based off of the locale', function() {
     initCalendar({
       locale: 'ar' // Arabic is RTL
     })
-    expect(currentCalendar.getOption('isRtl')).toEqual(true)
+    expect(currentCalendar.getOption('dir')).toEqual('rtl')
   })
 
   // NOTE: don't put tests related to other options in here!
@@ -12,14 +12,14 @@ describe('isRtl', function() {
 
   it('adapts to dynamic option change', function() {
     initCalendar({
-      isRtl: false
+      dir: 'ltr'
     })
     var $el = $(currentCalendar.el)
 
     expect($el).toHaveClass('fc-ltr')
     expect($el).not.toHaveClass('fc-rtl')
 
-    currentCalendar.setOption('isRtl', true)
+    currentCalendar.setOption('dir', 'rtl')
 
     expect($el).toHaveClass('fc-rtl')
     expect($el).not.toHaveClass('fc-ltr')

tests/automated/legacy/eventLimit-popover.js

@@ -29,7 +29,7 @@ describe('eventLimit popover', function() {
 
     it('aligns horizontally with left edge of cell if LTR', function() {
       initCalendar({
-        isRtl: false
+        dir: 'ltr'
       })
       init()
       var cellLeft = $('.fc-day-grid .fc-row:eq(0) .fc-bg td:not(.fc-axis):eq(2)').offset().left
@@ -40,7 +40,7 @@ describe('eventLimit popover', function() {
 
     it('aligns horizontally with left edge of cell if RTL', function() {
       initCalendar({
-        isRtl: true
+        dir: 'rtl'
       })
       init()
       var cell = $('.fc-day-grid .fc-row:eq(0) .fc-bg td:not(.fc-axis):eq(4)')

tests/automated/legacy/firstDay.js

@@ -159,10 +159,10 @@ describe('First Day', function() {
     })
   })
 
-  describe('when first day is set to Tuesday and isRtl is true', function() {
+  describe('when first day is set to Tuesday and dir is rtl', function() {
     pushOptions({
       firstDay: 2,
-      isRtl: true
+      dir: 'rtl'
     })
     it('should put days mon, sun, sat ...', function() {
       initCalendar()

tests/automated/legacy/header-rendering.js

@@ -69,15 +69,15 @@ describe('header rendering', function() {
   })
 
   describe('renders left and right literally', function() {
-    [ true, false ].forEach(function(isRtl) {
-      describe('when isRtl is ' + isRtl, function() {
+    [ 'ltr', 'rtl' ].forEach(function(dir) {
+      describe('when dir is ' + dir, function() {
         pushOptions({
           header: {
             left: 'prev',
             center: 'today',
             right: 'next'
           },
-          isRtl: isRtl
+          dir
         })
         it('should have prev in left', function() {
           initCalendar()

tests/automated/legacy/nowIndicator.js

@@ -38,11 +38,11 @@ describe('now indicator', function() {
         options.nowIndicator = true
       });
 
-      [ false, true ].forEach(function(isRtl) {
+      [ 'ltr', 'rtl' ].forEach(function(dir) {
 
-        describe('when ' + (isRtl ? 'RTL' : 'LTR'), function() {
+        describe('when ' + dir, function() {
           beforeEach(function() {
-            options.isRtl = isRtl
+            options.dir = dir
           })
 
           it('doesn\'t render when out of view', function() {

tests/automated/legacy/select-callback.js

@@ -14,10 +14,12 @@ describe('select callback', function() {
     currentCalendar.destroy()
   });
 
-  [ false, true ].forEach(function(isRtl) {
-    describe('when isRtl is ' + isRtl, function() {
+  [ 'ltr', 'rtl' ].forEach(function(dir) {
+    let dirSign = dir === 'rtl' ? -1 : 1
+
+    describe('when dir is ' + dir, function() {
       beforeEach(function() {
-        options.isRtl = isRtl
+        options.dir = dir
       })
       describe('when in month view', function() {
         beforeEach(function() {
@@ -115,7 +117,7 @@ describe('select callback', function() {
             spyOn(options, 'select').and.callThrough()
             initCalendar(options)
             $('.fc-agenda-view .fc-day-grid .fc-day:eq(3)').simulate('drag', { // will be 2014-05-28 for LTR and RTL
-              dx: $('.fc-sun').outerWidth() * (isRtl ? -1 : 1), // the width of one column
+              dx: $('.fc-sun').outerWidth() * dirSign, // the width of one column
               callback: function() {
                 expect(options.select).toHaveBeenCalled()
                 done()
@@ -208,7 +210,7 @@ describe('select callback', function() {
             spyOn(options, 'select').and.callThrough()
             initCalendar(options)
             $('.fc-slats tr:eq(18) td:not(.fc-time)').simulate('drag', { // middle will be 2014-05-28T09:00:00
-              dx: $('.fc-day-header:first').outerWidth() * 0.9 * (isRtl ? -1 : 1), // one day ahead
+              dx: $('.fc-day-header:first').outerWidth() * 0.9 * dirSign, // one day ahead
               dy: $('.fc-slats tr:eq(18)').outerHeight() * 2, // move down two slots
               callback: function() {
                 expect(options.select).toHaveBeenCalled()

tests/automated/legacy/select-method.js

@@ -17,10 +17,10 @@ describe('select method', function() {
     - for basic/month views, when given timed dates, should really be all-day
   */
 
-  [ false, true ].forEach(function(isRtl) {
-    describe('when isRtl is ' + isRtl, function() {
+  [ 'ltr', 'rtl' ].forEach(function(dir) {
+    describe('when dir is ' + dir, function() {
       beforeEach(function() {
-        options.isRtl = isRtl
+        options.dir = dir
       })
       describe('when in month view', function() {
         beforeEach(function() {

tests/automated/legacy/weekLabel.js

@@ -31,7 +31,7 @@ describe('weekLabel', function() {
 
       it('renders correctly when customized and LTR', function() {
         initCalendar({
-          isRtl: false,
+          dir: 'ltr',
           weekLabel: 'YO'
         })
         expect(getRenderedWeekNumberTitle()).toBe('YO')
@@ -39,7 +39,7 @@ describe('weekLabel', function() {
 
       it('renders correctly when customized and RTL', function() {
         initCalendar({
-          isRtl: true,
+          dir: 'rtl',
           weekLabel: 'YO'
         })
         expect(getRenderedWeekNumberTitle()).toBe('YO')

tests/automated/lib/dom-geom.js

@@ -33,7 +33,7 @@ export function getBoundingRect(el) {
 }
 
 
-export function getLeadingBoundingRect(els, isRtl) {
+export function getLeadingBoundingRect(els, dir = 'ltr') {
   els = $(els)
   expect(els.length).toBeGreaterThan(0)
   let best = null
@@ -41,7 +41,7 @@ export function getLeadingBoundingRect(els, isRtl) {
     const rect = getBoundingRect(node)
     if (!best) {
       best = rect
-    } else if (isRtl) {
+    } else if (dir === 'rtl') {
       if (rect.right > best.right) {
         best = rect
       }
@@ -55,7 +55,7 @@ export function getLeadingBoundingRect(els, isRtl) {
 }
 
 
-export function getTrailingBoundingRect(els, isRtl) {
+export function getTrailingBoundingRect(els, dir = 'ltr') {
   els = $(els)
   expect(els.length).toBeGreaterThan(0)
   let best = null
@@ -63,7 +63,7 @@ export function getTrailingBoundingRect(els, isRtl) {
     const rect = getBoundingRect(node)
     if (!best) {
       best = rect
-    } else if (isRtl) {
+    } else if (dir === 'rtl') {
       if (rect.left < best.left) {
         best = rect
       }
@@ -77,12 +77,12 @@ export function getTrailingBoundingRect(els, isRtl) {
 }
 
 
-export function sortBoundingRects(els, isRtl) {
+export function sortBoundingRects(els, dir) {
   const rects = els.map(function(i, node) {
     return getBoundingRect(node)
   })
   rects.sort(function(a, b) {
-    if (isRtl) {
+    if (dir === 'rtl') {
       return b.right - a.right
     } else {
       return a.left - b.left

tests/manual/day_render.html

@@ -27,7 +27,7 @@
       },
       weekNumbers: true,
       //selectable: true,
-      //isRtl: true,
+      //dir: 'rtl',
 
       header: {
         left: 'prev,next today',

tests/manual/droppable.html

@@ -27,7 +27,7 @@
 
       //firstDay: 1,
       //hiddenDays: [ 4, 6 ], // hide thursday and saturday
-      //isRtl: true,
+      //dir: 'rtl',
       //minTime: '6:30am',
 
       header: {
@@ -92,7 +92,7 @@
     $('#sortable-events').sortable();
 
     $('#calendar2').fullCalendar({
-      //isRtl: true,
+      //dir: 'rtl',
       droppable: true,
       dropAccept: '.for-calendar2',
       /*

tests/manual/dynamic-options.html

@@ -12,17 +12,17 @@
 
   $(document).ready(function() {
     var theme = false;
-    var isRtl = false;
+    var dir = 'ltr';
     var businessHours = false;
 
     $('#change-theme-button').on('click', function() {
-      theme = !theme;
+      theme = theme ? false : 'jquery-ui';
       $('#calendar').fullCalendar('option', 'theme', theme);
     });
 
     $('#change-dir-button').on('click', function() {
-      isRtl = !isRtl;
-      $('#calendar').fullCalendar('option', 'isRtl', isRtl);
+      dir = dir === 'ltr' ? 'rtl' : 'ltr';
+      $('#calendar').fullCalendar('option', 'dir', dir);
     });
 
     $('#change-businessHours-button').on('click', function() {
@@ -31,19 +31,19 @@
     });
 
     $('#change-all-button').on('click', function() {
-      theme = !theme;
-      isRtl = !isRtl;
+      theme = theme ? false : 'jquery-ui';
+      dir = dir === 'ltr' ? 'rtl' : 'ltr';
       businessHours = !businessHours;
       $('#calendar').fullCalendar('option', {
         theme: theme,
-        isRtl: isRtl,
+        dir: dir,
         businessHours: businessHours
       });
     });
 
     $('#calendar').fullCalendar({
       theme: theme,
-      isRtl: isRtl,
+      dir: dir,
       businessHours: businessHours,
       header: {
         left: 'prev,next today',

tests/manual/hiddenDays.html

@@ -27,7 +27,7 @@
       month: 6, // july
 
       //weekNumbers: true,
-      isRtl: true,
+      dir: 'rtl',
       //selectable: true,
       //firstDay: 2,
       //weekends: false,

tests/manual/issue_740_event_resizing.html

@@ -23,7 +23,7 @@
       },
       weekends: false,
       //firstDay: 1,
-      //isRtl: true,
+      //dir: 'rtl',
       editable: true,
       events: [
         {

tests/manual/issue_757_removeEvents.html

@@ -22,7 +22,7 @@
         right: 'month,agendaWeek,basicWeek,agendaDay,basicDay'
       },
       editable: true,
-      //isRtl: true,
+      //dir: 'rtl',
       year: 2011,
       month: 0,
       events: [

tests/manual/locale.html

@@ -30,7 +30,7 @@
       
       editable: true,
       
-      isRtl: true,
+      dir: 'rtl',
       firstDay: 1,
       //weekends: false,
       //hiddenDays: [ 4 ], // hide thursday

tests/manual/options.html

@@ -74,7 +74,7 @@
       //dayClick: function(date) {
       //  console.log(date);
       //},
-      //isRtl: true,
+      //dir: 'rtl',
 
       eventColor: 'green',
       eventTextColor: 'yellow',

tests/manual/selectable.html

@@ -28,7 +28,7 @@
       defaultView: 'month',
       
       //firstDay: 1,
-      //isRtl: true,
+      //dir: 'rtl',
       //minTime: 7,
       //weekends: false,
       //allDaySlot: false,

tests/manual/slot_event_overlap.html

@@ -60,7 +60,7 @@
       month: 6, // July
       date: 31,
       events: 'slot_event_overlap.json',
-      isRtl: true,
+      dir: 'rtl',
       _eventsPositioned: function() {
         testOverlap($('#calendar-rtl'), true, true);
       }
@@ -79,7 +79,7 @@
       month: 6, // July
       date: 31,
       events: 'slot_event_overlap.json',
-      isRtl: true,
+      dir: 'rtl',
       slotEventOverlap: false,
       _eventsPositioned: function() {
         testOverlap($('#calendar-rtl-nooverlap'), false, true);

tests/manual/stacking.html

@@ -28,7 +28,7 @@
 
       editable: true,
 
-      //isRtl: true,
+      //dir: 'rtl',
       //hiddenDays: [ 3 ],
 
       /*

tests/manual/triggers.html

@@ -33,7 +33,7 @@
         right: 'month,agendaWeek,basicWeek,agendaDay,basicDay'
       },
       editable: true,
-      //isRtl: true,
+      //dir: 'rtl',
 
       viewDisplay: function(view) {
         console.log('viewDisplay');

tests/manual/week_numbers.html

@@ -26,7 +26,7 @@
 
       firstDay: 1,
       selectable: true,
-      //isRtl: true,
+      //dir: 'rtl',
       //theme: true,
 
       editable: true,