Bladeren bron

html strings should usually close tags

Adam Shaw 8 jaren geleden
bovenliggende
commit
4765fc7075

+ 2 - 2
src/Calendar.ts

@@ -387,7 +387,7 @@ export default class Calendar {
       el.toggleClass('fc-rtl', opts.isRTL)
     })
 
-    this.contentEl = $("<div class='fc-view-container'/>").prependTo(el)
+    this.contentEl = $("<div class='fc-view-container'></div>").prependTo(el)
 
     this.initToolbars()
     this.renderHeader()
@@ -488,7 +488,7 @@ export default class Calendar {
 
       newView.startBatchRender() // so that setElement+setDate rendering are joined
       newView.setElement(
-        $("<div class='fc-view fc-" + viewType + "-view' />").appendTo(this.contentEl)[0]
+        $("<div class='fc-view fc-" + viewType + "-view'></div>").appendTo(this.contentEl)[0]
       )
 
       this.toolbarsManager.proxyCall('activateButton', viewType)

+ 4 - 4
src/Toolbar.ts

@@ -32,14 +32,14 @@ export default class Toolbar {
 
     if (sections) {
       if (!el) {
-        el = this.el = $("<div class='fc-toolbar " + this.toolbarOptions.extraClasses + "'/>")
+        el = this.el = $("<div class='fc-toolbar " + this.toolbarOptions.extraClasses + "'></div>")
       } else {
         el.empty()
       }
       el.append(this.renderSection('left'))
         .append(this.renderSection('right'))
         .append(this.renderSection('center'))
-        .append('<div class="fc-clear"/>')
+        .append('<div class="fc-clear"></div>')
     } else {
       this.removeElement()
     }
@@ -59,7 +59,7 @@ export default class Toolbar {
     let theme = calendar.theme
     let optionsManager = calendar.optionsManager
     let viewSpecManager = calendar.viewSpecManager
-    let sectionEl = $('<div class="fc-' + position + '"/>')
+    let sectionEl = $('<div class="fc-' + position + '"></div>')
     let buttonStr = this.toolbarOptions.layout[position]
     let calendarCustomButtons = optionsManager.get('customButtons') || {}
     let calendarButtonTextOverrides = optionsManager.overrides.buttonText || {}
@@ -192,7 +192,7 @@ export default class Toolbar {
         }
 
         if (groupChildren.length > 1) {
-          groupEl = $('<div/>')
+          groupEl = $('<div></div>')
           if (isOnlyButtons) {
             groupEl.addClass(theme.getClass('buttonGroup'))
           }

+ 2 - 2
src/agenda/AgendaView.ts

@@ -135,8 +135,8 @@ export default class AgendaView extends View {
           '<tr>' +
             '<td class="' + theme.getClass('widgetContent') + '">' +
               (this.dayGrid ?
-                '<div class="fc-day-grid"/>' +
-                '<hr class="fc-divider ' + theme.getClass('widgetHeader') + '"/>' :
+                '<div class="fc-day-grid"></div>' +
+                '<hr class="fc-divider ' + theme.getClass('widgetHeader') + '" />' :
                 ''
                 ) +
             '</td>' +

+ 1 - 1
src/agenda/TimeGrid.ts

@@ -262,7 +262,7 @@ export default class TimeGrid extends InteractiveDateComponent {
           (isLabeled ? '' : ' class="fc-minor"') +
           '>' +
           (!isRTL ? axisHtml : '') +
-          '<td class="' + theme.getClass('widgetContent') + '"/>' +
+          '<td class="' + theme.getClass('widgetContent') + '"></td>' +
           (isRTL ? axisHtml : '') +
         '</tr>'
 

+ 3 - 3
src/agenda/TimeGridEventRenderer.ts

@@ -122,15 +122,15 @@ export default class TimeGridEventRenderer extends EventRenderer {
             ''
             ) +
         '</div>' +
-        '<div class="fc-bg"/>' +
+        '<div class="fc-bg"></div>' +
         /* TODO: write CSS for this
         (isResizableFromStart ?
-          '<div class="fc-resizer fc-start-resizer" />' :
+          '<div class="fc-resizer fc-start-resizer"></div>' :
           ''
           ) +
         */
         (isResizableFromEnd ?
-          '<div class="fc-resizer fc-end-resizer" />' :
+          '<div class="fc-resizer fc-end-resizer"></div>' :
           ''
           ) +
       '</a>'

+ 1 - 1
src/basic/DayGrid.ts

@@ -232,7 +232,7 @@ export default class DayGrid extends InteractiveDateComponent {
 
     if (!isDayNumberVisible && !this.cellWeekNumbersVisible) {
       // no numbers in day cell (week number must be along the side)
-      return '<td/>' //  will create an empty space above events :(
+      return '<td></td>' //  will create an empty space above events :(
     }
 
     classes = this.getDayClasses(date)

+ 2 - 2
src/basic/DayGridEventRenderer.ts

@@ -278,11 +278,11 @@ export default class DayGridEventRenderer extends EventRenderer {
             ) +
         '</div>' +
         (isResizableFromStart ?
-          '<div class="fc-resizer fc-start-resizer" />' :
+          '<div class="fc-resizer fc-start-resizer"></div>' :
           ''
           ) +
         (isResizableFromEnd ?
-          '<div class="fc-resizer fc-end-resizer" />' :
+          '<div class="fc-resizer fc-end-resizer"></div>' :
           ''
           ) +
       '</a>'

+ 1 - 1
src/basic/DayGridFillRenderer.ts

@@ -44,7 +44,7 @@ export default class DayGridFillRenderer extends FillRenderer {
 
     skeletonEl = htmlToElement(
       '<div class="fc-' + className + '-skeleton">' +
-        '<table><tr/></table>' +
+        '<table><tr></tr></table>' +
       '</div>'
     )
     trEl = skeletonEl.getElementsByTagName('tr')[0]

+ 1 - 1
src/basic/DayGridHelperRenderer.ts

@@ -19,7 +19,7 @@ export default class DayGridHelperRenderer extends HelperRenderer {
 
     // inject each new event skeleton into each associated row
     this.component.rowEls.forEach(function(rowNode, row) {
-      let skeletonEl = htmlToElement('<div class="fc-helper-skeleton"><table/></div>') // will be absolutely positioned
+      let skeletonEl = htmlToElement('<div class="fc-helper-skeleton"><table></table></div>') // will be absolutely positioned
       let skeletonTopEl: HTMLElement
       let skeletonTop
 

+ 1 - 1
src/component/renderers/FillRenderer.ts

@@ -99,7 +99,7 @@ export default class FillRenderer { // use for highlight, background events, bus
     return '<' + this.fillSegTag +
       (classes.length ? ' class="' + classes.join(' ') + '"' : '') +
       (css ? ' style="' + css + '"' : '') +
-      ' />'
+      '></' + this.fillSegTag + '>'
   }
 
 

+ 1 - 1
src/list/ListView.ts

@@ -156,7 +156,7 @@ export default class ListView extends View {
     let dayIndex
     let daySegs
     let i
-    let tableEl = htmlToElement('<table class="fc-list-table ' + this.calendar.theme.getClass('tableList') + '"><tbody/></table>')
+    let tableEl = htmlToElement('<table class="fc-list-table ' + this.calendar.theme.getClass('tableList') + '"><tbody></tbody></table>')
     let tbodyEl = tableEl.getElementsByTagName('tbody')[0]
 
     for (dayIndex = 0; dayIndex < segsByDay.length; dayIndex++) {

+ 1 - 1
src/util.ts

@@ -249,7 +249,7 @@ function getIsLeftRtlScrollbars() { // responsible for caching the computation
 }
 
 function computeIsLeftRtlScrollbars() { // creates an offscreen test element, then removes it
-  let el = $('<div><div/></div>')
+  let el = $('<div><div></div></div>')
     .css({
       position: 'absolute',
       top: -1000,