better tests for visibleRange

tests/automated-better/view-dates/visibleRange.js

@@ -1,359 +1,147 @@
 
-describe('visibleRange function', function() {
-	pushOptions({
-		defaultDate: '2017-06-08'
-	});
-
-	describe('for 3-day centered view', function() {
-
-		var receivedDate;
-		beforeEach(function() {
-			receivedDate = null;
-		});
-
-		pushOptions({
-			visibleRange: function(date) {
-				receivedDate = date.clone();
-				return {
-					start: date.clone().subtract(1, 'days'),
-					end: date.clone().add(2, 'days')
-				};
-			}
-		});
-
-		xit('renders the correct range', function() {
-			initCalendar();
-			ViewDateUtils.expectVisibleRange('2017-06-07', '2017-06-10');
-		});
-
-		describe('when visibleRange is specified', function() {
-			pushOptions({
-				visibleRange: { // wtf
-					start: '2018-06-08',
-					end: '2018-06-11'
-				}
-			});
-			xit('does not get called', function() {
-				initCalendar();
-				expect(receivedDate).toBe(null);
-			});
-		});
-
-		describe('when defaultDate is before validRange', function() {
-			pushOptions({
-				validRange: { start: '2017-07-01' }
-			});
-			xit('receives validRange\'s start', function() {
-				initCalendar();
-				expect(receivedDate).toEqualMoment('2017-07-01');
-			});
-		});
-
-		describe('when defaultDate is after validRange', function() {
-			pushOptions({
-				validRange: { end: '2017-06-02' }
-			});
-			xit('receives the millisecond before validRange\'s end', function() {
-				initCalendar();
-				expect(receivedDate).toEqualMoment(
-					$.fullCalendar.moment('2017-07-01T00:00:00').subtract(1)
-				);
-			});
-		});
-	});
-
-	describe('for far-future view', function() {
-		pushOptions({
-			visibleRange: function(date) {
-				return {
-					start: date.clone().add(1, 'years'),
-					end: date.clone().add(2, 'years')
-				};
-			}
-		});
-
-		describe('when returned range is beyond validRange', function() {
-			pushOptions({
-				validRange: { start: '2017-07-01' }
-			});
-			xit('renders the day before validRange\'s start', function() {
-				initCalendar();
-				ViewDateUtils.expectVisibleRange('2017-06-30', '2017-07-01');
-			});
-		});
-	});
-
-	describe('when it returns a string start and end', function() {
-		var initialStartVal = '2017-03-01';
-		var initialEndVal = '2017-03-05';
+describe('visibleRange', function() {
 
+	describe('when custom view with a flexible range', function() {
 		pushOptions({
-			defaultView: 'agenda',
-			visibleRange: function() {
-				return {
-					start: initialStartVal,
-					end: initialEndVal
-				};
-			}
-		})
-
-		xit('is respected by initial render', function() {
-			initCalendar();
-			ViewDateUtils.expectVisibleRange(initialStartVal, initialEndVal);
-		})
-	});
-
-	// invalid inputs
-
-	describeValues({
-		'when it has no start': { end: '2017-06-02' },
-		'when it has no end': { start: '2017-06-09' },
-		'when it has end <= start': { start: '2017-06-09', end: '2017-06-02' }
-	}, function(badRange) {
-
-		describe('defaultDate', function() {
-			pushOptions({
-				defaultView: 'agenda',
-				defaultDate: '2017-06-29',
-				visibleRange: function() {
-					return badRange;
-				}
-			})
-
-			xit('reports a warning and renders single day at defaultDate', function() {
-				initCalendar()
-				ViewDateUtils.expectVisibleRange('2017-06-29', '2017-06-30');
-				// TODO: detect console.warn
-			});
+			defaultView: 'agenda'
 		});
 
-		describe('gotoDate', function() {
-			var initialStartVal = '2017-03-01';
-			var initialEndVal = '2017-03-05';
+		describe('when given a valid date range', function() {
+			var startInput = '2017-06-26';
+			var endInput = '2017-06-29';
 
-			pushOptions({
-				defaultView: 'agenda',
-				visibleRange: {
-					start: initialStartVal,
-					end: initialEndVal
+			describeOptions('visibleRange', {
+				'of moment objects': {
+					start: $.fullCalendar.moment(startInput),
+					end: $.fullCalendar.moment(endInput)
 				},
-				visibleRange: function() {
-					return badRange;
-				}
-			});
-
-			xit('resports a warning and does not navigate', function() {
-				initCalendar()
-				currentCalendar.gotoDate('2017-06-01');
-				ViewDateUtils.expectVisibleRange(initialStartVal, initialEndVal);
-				// TODO: detect console.warn
+				'of strings': {
+					start: startInput,
+					end: endInput
+				},
+				'of a function that returns moment objects': function() {
+					return {
+						start: $.fullCalendar.moment(startInput),
+						end: $.fullCalendar.moment(endInput)
+					};
+				},
+				'of a function that returns strings': function() {
+					return {
+						start: startInput,
+						end: endInput
+					};
+				},
+			}, function() {
+				it('gets set to the given range', function() {
+					initCalendar();
+					ViewDateUtils.expectVisibleRange(startInput, endInput);
+				});
 			});
 		});
-	});
-});
-
-describe('visibleRange value', function() {
-
-	describe('when custom view with a flexible range', function() {
-		pushOptions({
-			defaultView: 'agenda'
-		});
 
-		describe('when given moment objects', function() {
-			pushOptions({
-				visibleRange: {
-					start: $.fullCalendar.moment('2017-06-26'),
-					end: $.fullCalendar.moment('2017-06-29')
-				}
-			});
-			xit('displays the range', function() {
-				initCalendar();
-				ViewDateUtils.expectVisibleRange('2017-06-26', '2017-06-29');
-			});
-		});
+		describe('when a function', function() {
+			it('receives the calendar\'s defaultDate', function() {
+				var defaultDateInput = '2017-06-08T12:30:00';
+				var matched = false;
 
-		describe('when given strings', function() {
-			pushOptions({
-				visibleRange: {
-					start: '2017-06-26',
-					end: '2017-06-29'
-				}
-			});
+				initCalendar({
+					defaultDate: defaultDateInput,
+					visibleRange: function(date) {
+						// this function will receive the date for prev/next,
+						// which should be ignored. make sure just one call matches.
+						if (date.format() === defaultDateInput) {
+							matched = true;
+						}
+					}
+				});
 
-			xit('displays the range', function() {
-				initCalendar();
-				ViewDateUtils.expectVisibleRange('2017-06-26', '2017-06-29');
+				expect(matched).toBe(true);
 			});
 		});
 
 		describe('when given an invalid range', function() {
-			pushOptions({
-				visibleRange: {
+
+			describeOptions('visibleRange', {
+				'with end before start': {
 					start: '2017-06-18',
 					end: '2017-06-15'
-				}
-			});
-
-			xit('reports an error and defaults to the now date', function() {
-				initCalendar({
-					now: '2017-08-01'
-				})
-				ViewDateUtils.expectVisibleRange('2017-08-01', '2017-08-02');
-				// TODO: detect error reporting
-			});
-		});
-
-		xit('causes a visibleRange function to be ignored', function() {
-			var visibleRangeCalled = false;
-
-			initCalendar({
-				visibleRange: {
-					start: '2017-06-26',
-					end: '2017-06-29'
 				},
-				visibleRange: function() {
-					visibleRangeCalled = true;
+				'with no end': {
+					start: '2017-06-18'
+				},
+				'with no start': {
+					end: '2017-06-15'
 				}
+			}, function() {
+				it('defaults to the defaultDate', function() { // TODO: have it report an warning
+					initCalendar({
+						defaultDate: '2017-08-01'
+					})
+					ViewDateUtils.expectVisibleRange('2017-08-01', '2017-08-02');
+				});
 			});
-			expect(visibleRangeCalled).toBe(false);
 		});
 
 		describe('when later switching to a one-day view', function() {
-			xit('shows the view at the range\'s start', function() {
+
+			it('constrains the current date to the start of visibleRange', function() {
 				initCalendar({
+					defaultDate: '2017-06-25',
 					visibleRange: {
 						start: '2017-06-26',
 						end: '2017-06-29'
 					}
 				});
-				calendar.changeView('agendaDay');
+				currentCalendar.changeView('agendaDay');
 				ViewDateUtils.expectVisibleRange('2017-06-26', '2017-06-27');
 			});
-		});
-
-		describe('when range is partially before validRange', function() {
-			pushOptions({
-				visibleRange: {
-					start: '2017-05-30',
-					end: '2017-06-03'
-				},
-				validRange: { start: '2017-06-01' }
-			});
-
-			xit('navigates to specified range', function() {
-				initCalendar();
-				ViewDateUtils.expectVisibleRange('2017-05-30', '2017-06-03');
-			});
 
-			describe('when later switching to a one-day view', function() {
-				xit('shows the view at validRange\'s start', function() {
-					initCalendar();
-					calendar.changeView('agendaDay');
-					ViewDateUtils.expectVisibleRange('2017-06-01', '2017-06-02');
-				});
-			});
-		});
-
-		describe('when range is partially after validRange', function() {
-			pushOptions({
-				visibleRange: {
-					start: '2017-06-29',
-					end: '2017-07-04',
-				},
-				validRange: { end: '2017-07-01' }
-			});
-
-			xit('navigates to specified range', function() {
-				initCalendar();
-				ViewDateUtils.expectVisibleRange('2017-06-29', '2017-07-04');
-			});
-
-			describe('when later switching to a one-day view', function() {
-				xit('shows the view at the ms before validRange\'s end', function() {
-					initCalendar();
-					calendar.changeView('agendaDay');
-					ViewDateUtils.expectVisibleRange('2017-06-30', '2017-07-01');
-				});
-			});
-		});
-
-		describe('when range is completely before validRange', function() {
-			pushOptions({
-				visibleRange: {
-					start: '2017-05-25',
-					end: '2017-05-28',
-				},
-				validRange: { end: '2017-07-01' }
-			});
-
-			xit('navigates to validRange\'s end', function() {
-				initCalendar();
-				ViewDateUtils.expectVisibleRange('2017-06-01', '2017-06-02');
-			});
-
-			describe('when later switching to a one-day view', function() {
-				xit('shows the view at validRange\'s end', function() {
-					initCalendar();
-					calendar.changeView('agendaDay');
-					ViewDateUtils.expectVisibleRange('2017-06-01', '2017-06-02');
-				});
-			});
-		});
-
-		describe('when range is completely after validRange', function() {
-			pushOptions({
-				visibleRange: {
-					start: '2017-07-01',
-					end: '2017-07-04'
-				},
-				validRange: { end: '2017-06-01' }
-			});
-
-			xit('navigates to validRange\'s end', function() {
-				initCalendar();
-				ViewDateUtils.expectVisibleRange('2017-06-30', '2017-07-01');
-			});
-
-			describe('when later switching to a one-day view', function() {
-				xit('shows the view at validRange\'s end', function() {
-					initCalendar();
-					calendar.changeView('agendaDay');
-					ViewDateUtils.expectVisibleRange('2017-06-30', '2017-07-01');
+			it('constrains the current date to the end of visibleRange', function() {
+				initCalendar({
+					defaultDate: '2017-07-01',
+					visibleRange: {
+						start: '2017-06-26',
+						end: '2017-06-29'
+					}
 				});
+				currentCalendar.changeView('agendaDay');
+				ViewDateUtils.expectVisibleRange('2017-06-28', '2017-06-29');
 			});
 		});
 	});
 
 	describe('when custom view with fixed duration', function() {
 		pushOptions({
+			defaultDate: '2015-06-08',
 			defaultView: 'agenda',
 			duration: { days: 3 }
 		});
 
-		xit('uses the start date but does not respect the range', function() {
+		it('ignores the given visibleRange', function() {
 			initCalendar({
 				visibleRange: {
 					start: '2017-06-29',
 					end: '2017-07-04'
 				}
 			});
-			ViewDateUtils.expectVisibleRange('2017-06-29', '2017-07-01');
+			ViewDateUtils.expectVisibleRange('2015-06-08', '2015-06-11');
 		});
 	});
 
 	describe('when standard view', function() {
 		pushOptions({
+			defaultDate: '2015-06-08',
 			defaultView: 'agendaWeek'
 		});
 
-		xit('uses the start date but does not respect the range', function() {
+		it('ignores the given visibleRange', function() {
 			initCalendar({
 				visibleRange: {
 					start: '2017-06-29',
 					end: '2017-07-04'
 				}
 			});
-			ViewDateUtils.expectVisibleRange('2017-06-29', '2017-06-30');
+			ViewDateUtils.expectVisibleRange('2015-06-07', '2015-06-14');
 		});
 	});
-});
+});