move back to allDay

demos/selectable.html

@@ -27,7 +27,7 @@
             title: title,
             start: arg.start,
             end: arg.end,
-            isAllDay: arg.isAllDay
+            allDay: arg.allDay
           })
         }
         calendar.unselect()

plugins/rrule/main.ts

@@ -19,7 +19,7 @@ registerRecurringType({
 
       if (parsed) {
         return {
-          isAllDay: parsed.isAllDay,
+          allDay: parsed.allDay,
           duration: props.duration,
           typeData: parsed.rrule
         }
@@ -40,19 +40,19 @@ function parseRRule(input, dateEnv: DateEnv) {
   if (typeof input === 'string') {
     return {
       rrule: rrulestr(input),
-      isAllDay: false
+      allDay: false
     }
 
   } else if (typeof input === 'object' && input) { // non-null object
     let refined = assignTo({}, input) // copy
-    let isAllDay = false
+    let allDay = false
 
     if (typeof refined.dtstart === 'string') {
       let dtstartMeta = dateEnv.createMarkerMeta(refined.dtstart)
 
       if (dtstartMeta) {
         refined.dtstart = dtstartMeta.marker
-        isAllDay = dtstartMeta.isTimeUnspecified
+        allDay = dtstartMeta.isTimeUnspecified
       } else {
         delete refined.dtstart
       }
@@ -78,7 +78,7 @@ function parseRRule(input, dateEnv: DateEnv) {
 
     return {
       rrule: new RRule(refined),
-      isAllDay
+      allDay
     }
   }
 

src/Calendar.ts

@@ -1101,8 +1101,8 @@ export default class Calendar {
     this.publiclyTrigger('dateClick', [
       {
         date: this.dateEnv.toDate(dateSpan.range.start),
-        dateStr: this.dateEnv.formatIso(dateSpan.range.start, { omitTime: dateSpan.isAllDay }),
-        isAllDay: dateSpan.isAllDay,
+        dateStr: this.dateEnv.formatIso(dateSpan.range.start, { omitTime: dateSpan.allDay }),
+        allDay: dateSpan.allDay,
         dayEl,
         jsEvent: ev,
         view

src/agenda/AgendaView.ts

@@ -185,7 +185,7 @@ export default class AgendaView extends View {
     let allDaySeletion = null
     let timedSelection = null
     if (renderState.dateSelection) {
-      if (renderState.dateSelection.isAllDay) {
+      if (renderState.dateSelection.allDay) {
         allDaySeletion = renderState.dateSelection
       } else {
         timedSelection = renderState.dateSelection
@@ -423,13 +423,13 @@ agendaDayGridMethods = {
 
 function filterEventsForTimeGrid(eventStore: EventStore, eventUis: EventUiHash): EventStore {
   return filterEventStoreDefs(eventStore, function(eventDef) {
-    return !eventDef.isAllDay || hasBgRendering(eventUis[eventDef.defId])
+    return !eventDef.allDay || hasBgRendering(eventUis[eventDef.defId])
   })
 }
 
 function filterEventsForDayGrid(eventStore: EventStore, eventUis: EventUiHash): EventStore {
   return filterEventStoreDefs(eventStore, function(eventDef) {
-    return eventDef.isAllDay
+    return eventDef.allDay
   })
 }
 

src/agenda/TimeGrid.ts

@@ -619,7 +619,7 @@ export default class TimeGrid extends DateComponent {
           component: this,
           dateSpan: {
             range: { start, end },
-            isAllDay: false
+            allDay: false
           },
           dayEl: this.colEls[colIndex],
           rect: {

src/agenda/TimeGridEventRenderer.ts

@@ -97,7 +97,7 @@ export default class TimeGridEventRenderer extends EventRenderer {
     let eventRange = seg.eventRange
     let eventDef = eventRange.def
     let eventUi = eventRange.ui
-    let isAllDay = eventDef.isAllDay
+    let allDay = eventDef.allDay
     let isDraggable = eventUi.startEditable
     let isResizableFromStart = seg.isStart && eventUi.durationEditable && this.opt('eventResizableFromStart')
     let isResizableFromEnd = seg.isEnd && eventUi.durationEditable
@@ -117,9 +117,9 @@ export default class TimeGridEventRenderer extends EventRenderer {
       if (seg.isStart || seg.isEnd) {
         let unzonedStart = seg.start
         let unzonedEnd = seg.end
-        timeText = this._getTimeText(unzonedStart, unzonedEnd, isAllDay) // TODO: give the timezones
-        fullTimeText = this._getTimeText(unzonedStart, unzonedEnd, isAllDay, this.fullTimeFormat)
-        startTimeText = this._getTimeText(unzonedStart, unzonedEnd, isAllDay, null, false) // displayEnd=false
+        timeText = this._getTimeText(unzonedStart, unzonedEnd, allDay) // TODO: give the timezones
+        fullTimeText = this._getTimeText(unzonedStart, unzonedEnd, allDay, this.fullTimeFormat)
+        startTimeText = this._getTimeText(unzonedStart, unzonedEnd, allDay, null, false) // displayEnd=false
       }
     } else {
       // Display the normal time text for the *event's* times

src/api/EventApi.ts

@@ -30,7 +30,7 @@ export default class EventApi implements EventTuple {
   }
 
   setProp(name: string, val: string) {
-    if (name.match(/^(start|end|date|isAllDay)$/)) {
+    if (name.match(/^(start|end|date|allDay)$/)) {
       // error. date-related props need other methods
     } else {
       let props
@@ -97,9 +97,9 @@ export default class EventApi implements EventTuple {
     }
   }
 
-  setDates(startInput: DateInput, endInput: DateInput | null, options: { isAllDay?: boolean, granularity?: string } = {}) {
+  setDates(startInput: DateInput, endInput: DateInput | null, options: { allDay?: boolean, granularity?: string } = {}) {
     let dateEnv = this.calendar.dateEnv
-    let standardProps = { isAllDay: options.isAllDay } as any
+    let standardProps = { allDay: options.allDay } as any
     let start = dateEnv.createMarker(startInput)
     let end
 
@@ -120,7 +120,7 @@ export default class EventApi implements EventTuple {
 
       // when computing the diff for an event being converted to all-day,
       // compute diff off of the all-day values the way event-mutation does.
-      if (options.isAllDay === true) {
+      if (options.allDay === true) {
         instanceRange = computeAlignedDayRange(instanceRange)
       }
 
@@ -160,15 +160,15 @@ export default class EventApi implements EventTuple {
     }
   }
 
-  setIsAllDay(isAllDay: boolean, options: { maintainDuration?: boolean } = {}) {
-    let standardProps = { isAllDay } as any
+  setIsAllDay(allDay: boolean, options: { maintainDuration?: boolean } = {}) {
+    let standardProps = { allDay } as any
     let maintainDuration = options.maintainDuration
 
     if (maintainDuration == null) {
-      maintainDuration = this.calendar.opt('isAllDayMaintainDuration')
+      maintainDuration = this.calendar.opt('allDayMaintainDuration')
     }
 
-    if (this.def.isAllDay !== isAllDay) {
+    if (this.def.allDay !== allDay) {
       standardProps.hasEnd = maintainDuration
     }
 
@@ -231,7 +231,7 @@ export default class EventApi implements EventTuple {
   // TODO: find a TypeScript-compatible way to do this at scale
   get id(): string { return this.def.publicId }
   get groupId(): string { return this.def.groupId }
-  get isAllDay(): boolean { return this.def.isAllDay }
+  get allDay(): boolean { return this.def.allDay }
   get title(): string { return this.def.title }
   get url(): string { return this.def.url }
   get startEditable(): boolean { return this.def.startEditable }

src/basic/DayGrid.ts

@@ -164,7 +164,7 @@ export default class DayGrid extends DateComponent {
         this.publiclyTrigger('dayRender', [
           {
             date: dateEnv.toDate(this.getCellDate(row, col)),
-            isAllDay: true,
+            allDay: true,
             el: this.getCellEl(row, col),
             view
           }
@@ -339,7 +339,7 @@ export default class DayGrid extends DateComponent {
           component: this,
           dateSpan: {
             range: this.getCellRange(row, col),
-            isAllDay: true
+            allDay: true
           },
           dayEl: this.getCellEl(row, col),
           rect: {
@@ -609,7 +609,7 @@ export default class DayGrid extends DateComponent {
         clickOption = this.publiclyTrigger('eventLimitClick', [
           {
             date: dateEnv.toDate(date),
-            isAllDay: true,
+            allDay: true,
             dayEl: dayEl,
             moreEl: moreEl,
             segs: reslicedAllSegs,

src/basic/DayGridEventRenderer.ts

@@ -23,7 +23,7 @@ export default class DayGridEventRenderer extends EventRenderer {
   renderBgSegs(segs: Seg[]) {
     // don't render timed background events
     segs = segs.filter(function(seg) {
-      return seg.eventRange.def.isAllDay
+      return seg.eventRange.def.allDay
     })
 
     return super.renderBgSegs(segs)
@@ -240,10 +240,10 @@ export default class DayGridEventRenderer extends EventRenderer {
     let eventRange = seg.eventRange
     let eventDef = eventRange.def
     let eventUi = eventRange.ui
-    let isAllDay = eventDef.isAllDay
+    let allDay = eventDef.allDay
     let isDraggable = eventUi.startEditable
-    let isResizableFromStart = isAllDay && seg.isStart && eventUi.durationEditable && this.opt('eventResizableFromStart')
-    let isResizableFromEnd = isAllDay && seg.isEnd && eventUi.durationEditable
+    let isResizableFromStart = allDay && seg.isStart && eventUi.durationEditable && this.opt('eventResizableFromStart')
+    let isResizableFromEnd = allDay && seg.isEnd && eventUi.durationEditable
     let classes = this.getSegClasses(seg, isDraggable, isResizableFromStart || isResizableFromEnd)
     let skinCss = cssToStr(this.getSkinCss(eventUi))
     let timeHtml = ''

src/basic/DayTile.ts

@@ -71,7 +71,7 @@ export default class DayTile extends DateComponent {
       return {
         component: this,
         dateSpan: {
-          isAllDay: true,
+          allDay: true,
           range: { start: this.date, end: addDays(this.date, 1) }
         },
         dayEl: this.el,

src/component/DateComponent.ts

@@ -913,7 +913,7 @@ export default abstract class DateComponent extends Component {
     let allSegs: Seg[] = []
 
     for (let eventRenderRange of eventRenderRanges) {
-      let segs = this.rangeToSegs(eventRenderRange.range, eventRenderRange.def.isAllDay)
+      let segs = this.rangeToSegs(eventRenderRange.range, eventRenderRange.def.allDay)
 
       for (let seg of segs) {
         seg.eventRange = eventRenderRange
@@ -929,7 +929,7 @@ export default abstract class DateComponent extends Component {
 
 
   selectionToSegs(selection: DateSpan, fabricateEvents: boolean): Seg[] {
-    let segs = this.rangeToSegs(selection.range, selection.isAllDay)
+    let segs = this.rangeToSegs(selection.range, selection.allDay)
 
     if (fabricateEvents) {
 
@@ -938,7 +938,7 @@ export default abstract class DateComponent extends Component {
       let def = parseEventDef(
         { editable: false },
         '', // sourceId
-        selection.isAllDay,
+        selection.allDay,
         true, // hasEnd
         this.getCalendar()
       )
@@ -961,7 +961,7 @@ export default abstract class DateComponent extends Component {
 
 
   // must implement if want to use many of the rendering utils
-  rangeToSegs(range: DateRange, isAllDay: boolean): Seg[] {
+  rangeToSegs(range: DateRange, allDay: boolean): Seg[] {
     return []
   }
 

src/component/event-rendering.ts

@@ -63,7 +63,7 @@ export function sliceEventStore(eventStore: EventStore, eventUis: EventUiHash, f
 
     if (slicedRange) {
 
-      visibleRange = (!def.isAllDay && nextDayThreshold) ?
+      visibleRange = (!def.allDay && nextDayThreshold) ?
         computeVisibleDayRange(slicedRange, nextDayThreshold) :
         slicedRange
 

src/component/renderers/EventRenderer.ts

@@ -259,7 +259,7 @@ export default class EventRenderer {
     return this._getTimeText(
       instance.range.start,
       def.hasEnd ? instance.range.end : null,
-      def.isAllDay,
+      def.allDay,
       formatter,
       displayEnd,
       instance.forcedStartTzo,
@@ -271,7 +271,7 @@ export default class EventRenderer {
   _getTimeText(
     start: DateMarker,
     end: DateMarker,
-    isAllDay,
+    allDay,
     formatter?,
     displayEnd?,
     forcedStartTzo?: number,
@@ -287,7 +287,7 @@ export default class EventRenderer {
       displayEnd = this.displayEventEnd
     }
 
-    if (this.displayEventTime && !isAllDay) {
+    if (this.displayEventTime && !allDay) {
       if (displayEnd && end) {
         return dateEnv.formatRange(start, end, formatter, {
           forcedStartTzo,
@@ -381,7 +381,7 @@ export function buildSegCompareObj(seg: Seg) {
       start,
       end,
       duration: end - start,
-      isAllDay: Number(eventDef.isAllDay),
+      allDay: Number(eventDef.allDay),
       _seg: seg // for later retrieval
     }
   )

src/interactions-external/ExternalElementDragging.ts

@@ -127,7 +127,7 @@ export default class ExternalElementDragging {
         {
           draggedEl: pev.subjectEl,
           date: receivingCalendar.dateEnv.toDate(finalHit.dateSpan.range.start),
-          isAllDay: finalHit.dateSpan.isAllDay,
+          allDay: finalHit.dateSpan.allDay,
           jsEvent: pev.origEvent,
           view: finalView
         }
@@ -204,7 +204,7 @@ function computeEventForDateSpan(dateSpan: DateSpan, dragMeta: DragMeta, calenda
   let def = parseEventDef(
     dragMeta.leftoverProps,
     dragMeta.sourceId,
-    dateSpan.isAllDay,
+    dateSpan.allDay,
     Boolean(dragMeta.duration), // hasEnd
     calendar
   )
@@ -213,13 +213,13 @@ function computeEventForDateSpan(dateSpan: DateSpan, dragMeta: DragMeta, calenda
 
   // only rely on time info if drop zone is all-day,
   // otherwise, we already know the time
-  if (dateSpan.isAllDay && dragMeta.time) {
+  if (dateSpan.allDay && dragMeta.time) {
     start = calendar.dateEnv.add(start, dragMeta.time)
   }
 
   let end = dragMeta.duration ?
     calendar.dateEnv.add(start, dragMeta.duration) :
-    calendar.getDefaultEventEnd(dateSpan.isAllDay, start)
+    calendar.getDefaultEventEnd(dateSpan.allDay, start)
 
   let instance = createEventInstance(def.defId, { start, end })
 

src/interactions/DateSelecting.ts

@@ -119,6 +119,6 @@ function computeSelection(dateSpan0: DateSpan, dateSpan1: DateSpan): DateSpan {
 
   return {
     range: { start: ms[0], end: ms[3] },
-    isAllDay: dateSpan0.isAllDay
+    allDay: dateSpan0.allDay
   }
 }

src/interactions/EventDragging.ts

@@ -339,13 +339,13 @@ function computeEventMutation(hit0: Hit, hit1: Hit): EventMutation {
   let date1 = dateSpan1.range.start
   let standardProps = null
 
-  if (dateSpan0.isAllDay !== dateSpan1.isAllDay) {
+  if (dateSpan0.allDay !== dateSpan1.allDay) {
     standardProps = {
-      isAllDay: dateSpan1.isAllDay,
-      hasEnd: hit1.component.opt('isAllDayMaintainDuration')
+      allDay: dateSpan1.allDay,
+      hasEnd: hit1.component.opt('allDayMaintainDuration')
     }
 
-    if (dateSpan1.isAllDay) {
+    if (dateSpan1.allDay) {
       // means date1 is already start-of-day,
       // but date0 needs to be converted
       date0 = startOfDay(date0)

src/list/ListEventRenderer.ts

@@ -31,20 +31,20 @@ export default class ListEventRenderer extends EventRenderer {
     let bgColor = eventUi.backgroundColor
     let timeHtml
 
-    if (eventDef.isAllDay) {
+    if (eventDef.allDay) {
       timeHtml = view.getAllDayHtml()
     } else if (isMultiDayRange(eventRange.range)) {
       if (seg.isStart) {
         timeHtml = htmlEscape(this._getTimeText(
           eventInstance.range.start,
           seg.end,
-          false // isAllDay
+          false // allDay
         ))
       } else if (seg.isEnd) {
         timeHtml = htmlEscape(this._getTimeText(
           seg.start,
           eventInstance.range.end,
-          false // isAllDay
+          false // allDay
         ))
       } else { // inner segment that lasts the whole day
         timeHtml = view.getAllDayHtml()

src/list/ListView.ts

@@ -99,7 +99,7 @@ export default class ListView extends View {
 
 
   // slices by day
-  rangeToSegs(range: DateRange, isAllDay: boolean) {
+  rangeToSegs(range: DateRange, allDay: boolean) {
     let dateEnv = this.getDateEnv()
     let dayRanges = this.dayRanges
     let dayIndex
@@ -125,7 +125,7 @@ export default class ListView extends View {
         // detect when range won't go fully into the next day,
         // and mutate the latest seg to the be the end.
         if (
-          !seg.isEnd && !isAllDay &&
+          !seg.isEnd && !allDay &&
           dayIndex + 1 < dayRanges.length &&
           range.end <
             dateEnv.add(

src/options.ts

@@ -61,7 +61,7 @@ export const globalDefaults = {
   dragRevertDuration: 500,
   dragScroll: true,
 
-  isAllDayMaintainDuration: false,
+  allDayMaintainDuration: false,
 
   // selectable: false,
   unselectAuto: true,
@@ -69,7 +69,7 @@ export const globalDefaults = {
 
   dropAccept: '*',
 
-  eventOrder: 'start,-duration,isAllDay,title',
+  eventOrder: 'start,-duration,allDay,title',
   // ^ if start tie, longer events go before shorter. final tie-breaker is title text
 
   // rerenderDelay: null,

src/reducers/eventStore.ts

@@ -127,7 +127,7 @@ function rezoneDates(eventStore: EventStore, oldDateEnv: DateEnv, newDateEnv: Da
   let instances = mapHash(eventStore.instances, function(instance: EventInstance): EventInstance {
     let def = defs[instance.defId]
 
-    if (def.isAllDay || def.recurringDef) {
+    if (def.allDay || def.recurringDef) {
       return instance // isn't dependent on timezone
     } else {
       return assignTo({}, instance, {

src/structs/date-span.ts

@@ -6,7 +6,7 @@ import { assignTo } from '../util/object'
 
 /*
 A data-structure for a date-range that will be visually displayed.
-Contains other metadata like isAllDay, and anything else Components might like to store.
+Contains other metadata like allDay, and anything else Components might like to store.
 
 TODO: in future, put otherProps in own object.
 */
@@ -14,7 +14,7 @@ TODO: in future, put otherProps in own object.
 export interface OpenDateSpanInput {
   start?: DateInput
   end?: DateInput
-  isAllDay?: boolean
+  allDay?: boolean
   [otherProp: string]: any
 }
 
@@ -25,7 +25,7 @@ export interface DateSpanInput extends OpenDateSpanInput {
 
 export interface OpenDateSpan {
   range: OpenDateRange
-  isAllDay: boolean
+  allDay: boolean
   [otherProp: string]: any
 }
 
@@ -36,14 +36,14 @@ export interface DateSpan extends OpenDateSpan {
 export interface DateSpanApi {
   start: Date
   end: Date
-  isAllDay: boolean
+  allDay: boolean
   [otherProp: string]: any
 }
 
 const STANDARD_PROPS = {
   start: null,
   end: null,
-  isAllDay: Boolean
+  allDay: Boolean
 }
 
 export function parseDateSpan(raw: DateSpanInput, dateEnv: DateEnv, defaultDuration?: Duration): DateSpan | null {
@@ -74,10 +74,10 @@ export function parseOpenDateSpan(raw: OpenDateSpanInput, dateEnv: DateEnv): Ope
   let standardProps = refineProps(raw, STANDARD_PROPS, {}, leftovers)
   let startMeta = standardProps.start ? dateEnv.createMarkerMeta(standardProps.start) : null
   let endMeta = standardProps.end ? dateEnv.createMarkerMeta(standardProps.end) : null
-  let isAllDay = standardProps.isAllDay
+  let allDay = standardProps.allDay
 
-  if (isAllDay == null) {
-    isAllDay = (startMeta && startMeta.isTimeUnspecified) &&
+  if (allDay == null) {
+    allDay = (startMeta && startMeta.isTimeUnspecified) &&
       (!endMeta || endMeta.isTimeUnspecified)
   }
 
@@ -86,14 +86,14 @@ export function parseOpenDateSpan(raw: OpenDateSpanInput, dateEnv: DateEnv): Ope
     start: startMeta ? startMeta.marker : null,
     end: endMeta ? endMeta.marker : null
   }
-  leftovers.isAllDay = isAllDay
+  leftovers.allDay = allDay
 
   return leftovers
 }
 
 export function isDateSpansEqual(span0: DateSpan, span1: DateSpan): boolean {
   return rangesEqual(span0.range, span1.range) &&
-    span0.isAllDay === span1.isAllDay &&
+    span0.allDay === span1.allDay &&
     isSpanPropsEqual(span0, span1)
 }
 
@@ -120,7 +120,7 @@ export function isSpanPropsEqual(span0: DateSpan, span1: DateSpan): boolean {
 export function isSpanPropsMatching(subjectSpan: DateSpan, matchSpan: DateSpan): boolean {
 
   for (let propName in matchSpan) {
-    if (propName !== 'range' && propName !== 'isAllDay') {
+    if (propName !== 'range' && propName !== 'allDay') {
       if (subjectSpan[propName] !== matchSpan[propName]) {
         return false
       }
@@ -137,8 +137,8 @@ export function buildDateSpanApi(span: DateSpan, dateEnv: DateEnv): DateSpanApi
   props.start = dateEnv.toDate(span.range.start)
   props.end = dateEnv.toDate(span.range.end)
 
-  props.startStr = dateEnv.formatIso(span.range.start, { omitTime: span.isAllDay })
-  props.endStr = dateEnv.formatIso(span.range.end, { omitTime: span.isAllDay })
+  props.startStr = dateEnv.formatIso(span.range.start, { omitTime: span.allDay })
+  props.endStr = dateEnv.formatIso(span.range.end, { omitTime: span.allDay })
 
   return props
 }

src/structs/event-mutation.ts

@@ -80,7 +80,7 @@ function applyMutationToEventInstance(
   calendar: Calendar
 ): EventInstance {
   let dateEnv = calendar.dateEnv
-  let forceAllDay = mutation.standardProps && mutation.standardProps.isAllDay === true
+  let forceAllDay = mutation.standardProps && mutation.standardProps.allDay === true
   let clearEnd = mutation.standardProps && mutation.standardProps.hasEnd === false
   let copy = assignTo({}, eventInstance) as EventInstance
 
@@ -98,7 +98,7 @@ function applyMutationToEventInstance(
   if (clearEnd) {
     copy.range = {
       start: copy.range.start,
-      end: calendar.getDefaultEventEnd(eventDef.isAllDay, copy.range.start)
+      end: calendar.getDefaultEventEnd(eventDef.allDay, copy.range.start)
     }
   } else if (mutation.endDelta) {
     copy.range = {
@@ -109,7 +109,7 @@ function applyMutationToEventInstance(
 
   // in case event was all-day but the supplied deltas were not
   // better util for this?
-  if (eventDef.isAllDay) {
+  if (eventDef.allDay) {
     copy.range = {
       start: startOfDay(copy.range.start),
       end: startOfDay(copy.range.end)
@@ -118,7 +118,7 @@ function applyMutationToEventInstance(
 
   // handle invalid durations
   if (copy.range.end < copy.range.start) {
-    copy.range.end = calendar.getDefaultEventEnd(eventDef.isAllDay, copy.range.start)
+    copy.range.end = calendar.getDefaultEventEnd(eventDef.allDay, copy.range.start)
   }
 
   return copy

src/structs/event-store.ts

@@ -74,7 +74,7 @@ export function expandRecurring(eventStore: EventStore, framingRange: DateRange,
       let duration = def.recurringDef.duration
 
       if (!duration) {
-        duration = def.isAllDay ?
+        duration = def.allDay ?
           calendar.defaultAllDayEventDuration :
           calendar.defaultTimedEventDuration
       }

src/structs/event.ts

@@ -41,7 +41,7 @@ export interface EventDateInput {
   start?: DateInput
   end?: DateInput
   date?: DateInput
-  isAllDay?: boolean
+  allDay?: boolean
 }
 
 export type EventInput = EventNonDateInput & EventDateInput
@@ -51,7 +51,7 @@ export interface EventDef {
   sourceId: string
   publicId: string
   groupId: string
-  isAllDay: boolean
+  allDay: boolean
   hasEnd: boolean
   recurringDef: { typeId: number, typeData: any, duration: Duration | null } | null
   title: string
@@ -108,7 +108,7 @@ const DATE_PROPS = {
   start: null,
   date: null, // alias for start
   end: null,
-  isAllDay: null
+  allDay: null
 }
 
 let uid = 0
@@ -116,11 +116,11 @@ let uid = 0
 
 export function parseEvent(raw: EventInput, sourceId: string, calendar: Calendar): EventTuple | null {
   let leftovers0 = {}
-  let isAllDayDefault = computeIsAllDayDefault(sourceId, calendar)
-  let singleRes = parseSingle(raw, isAllDayDefault, calendar, leftovers0)
+  let allDayDefault = computeIsAllDayDefault(sourceId, calendar)
+  let singleRes = parseSingle(raw, allDayDefault, calendar, leftovers0)
 
   if (singleRes) {
-    let def = parseEventDef(leftovers0, sourceId, singleRes.isAllDay, singleRes.hasEnd, calendar)
+    let def = parseEventDef(leftovers0, sourceId, singleRes.allDay, singleRes.hasEnd, calendar)
     let instance = createEventInstance(def.defId, singleRes.range, singleRes.forcedStartTzo, singleRes.forcedEndTzo)
 
     return { def, instance }
@@ -134,12 +134,12 @@ export function parseEvent(raw: EventInput, sourceId: string, calendar: Calendar
     )
 
     if (recurringRes) {
-      let isAllDay =
-        (raw.isAllDay != null) ? Boolean(raw.isAllDay) : // need to get this from `raw` because already stripped out of `leftovers0`
-          (isAllDayDefault != null ? isAllDayDefault :
-            recurringRes.isAllDay) // fall back to the recurring date props LAST
+      let allDay =
+        (raw.allDay != null) ? Boolean(raw.allDay) : // need to get this from `raw` because already stripped out of `leftovers0`
+          (allDayDefault != null ? allDayDefault :
+            recurringRes.allDay) // fall back to the recurring date props LAST
 
-      let def = parseEventDef(leftovers1, sourceId, isAllDay, Boolean(recurringRes.duration), calendar)
+      let def = parseEventDef(leftovers1, sourceId, allDay, Boolean(recurringRes.duration), calendar)
 
       def.recurringDef = { // TODO: more efficient way to do this
         typeId: recurringRes.typeId,
@@ -160,13 +160,13 @@ Will NOT populate extendedProps with the leftover properties.
 Will NOT populate date-related props.
 The EventNonDateInput has been normalized (id => publicId, etc).
 */
-export function parseEventDef(raw: EventNonDateInput, sourceId: string, isAllDay: boolean, hasEnd: boolean, calendar: Calendar): EventDef {
+export function parseEventDef(raw: EventNonDateInput, sourceId: string, allDay: boolean, hasEnd: boolean, calendar: Calendar): EventDef {
   let leftovers = {}
   let def = pluckNonDateProps(raw, calendar, leftovers) as EventDef
 
   def.defId = String(uid++)
   def.sourceId = sourceId
-  def.isAllDay = isAllDay
+  def.allDay = allDay
   def.hasEnd = hasEnd
   def.extendedProps = assignTo(leftovers, def.extendedProps || {})
 
@@ -193,9 +193,9 @@ export function createEventInstance(
 }
 
 
-function parseSingle(raw: EventInput, isAllDayDefault: boolean | null, calendar: Calendar, leftovers?) {
+function parseSingle(raw: EventInput, allDayDefault: boolean | null, calendar: Calendar, leftovers?) {
   let props = pluckDateProps(raw, leftovers)
-  let isAllDay = props.isAllDay
+  let allDay = props.allDay
   let startMeta
   let startMarker
   let hasEnd = false
@@ -212,18 +212,18 @@ function parseSingle(raw: EventInput, isAllDayDefault: boolean | null, calendar:
     endMeta = calendar.dateEnv.createMarkerMeta(props.end)
   }
 
-  if (isAllDay == null) {
-    if (isAllDayDefault != null) {
-      isAllDay = isAllDayDefault
+  if (allDay == null) {
+    if (allDayDefault != null) {
+      allDay = allDayDefault
     } else {
       // fall back to the date props LAST
-      isAllDay = startMeta.isTimeUnspecified && (!endMeta || endMeta.isTimeUnspecified)
+      allDay = startMeta.isTimeUnspecified && (!endMeta || endMeta.isTimeUnspecified)
     }
   }
 
   startMarker = startMeta.marker
 
-  if (isAllDay) {
+  if (allDay) {
     startMarker = startOfDay(startMarker)
   }
 
@@ -232,7 +232,7 @@ function parseSingle(raw: EventInput, isAllDayDefault: boolean | null, calendar:
 
     if (endMarker <= startMarker) {
       endMarker = null
-    } else if (isAllDay) {
+    } else if (allDay) {
       endMarker = startOfDay(endMarker)
     }
   }
@@ -244,14 +244,14 @@ function parseSingle(raw: EventInput, isAllDayDefault: boolean | null, calendar:
 
     endMarker = calendar.dateEnv.add(
       startMarker,
-      isAllDay ?
+      allDay ?
         calendar.defaultAllDayEventDuration :
         calendar.defaultTimedEventDuration
     )
   }
 
   return {
-    isAllDay,
+    allDay,
     hasEnd,
     range: { start: startMarker, end: endMarker },
     forcedStartTzo: startMeta.forcedTzo,

src/structs/recurring-event-simple.ts

@@ -38,7 +38,7 @@ registerRecurringType({
       let props = refineProps(rawEvent, SIMPLE_RECURRING_PROPS, {}, leftoverProps) as SimpleRecurringData
 
       return {
-        isAllDay: !props.startTime && !props.endTime,
+        allDay: !props.startTime && !props.endTime,
         duration: (props.startTime && props.endTime) ?
           subtractDurations(props.endTime, props.startTime) :
           null,

src/structs/recurring-event.ts

@@ -9,7 +9,7 @@ The plugin system for defining how a recurring event is expanded into individual
 */
 
 export interface ParsedRecurring {
-  isAllDay: boolean // last fallback to be used
+  allDay: boolean // last fallback to be used
   duration: Duration | null // signals hasEnd
   typeData: any
 }
@@ -33,7 +33,7 @@ export function parseRecurring(eventInput: EventInput, dateEnv: DateEnv, leftove
 
     if (parsed) {
       return { // more efficient way to do this?
-        isAllDay: parsed.isAllDay,
+        allDay: parsed.allDay,
         duration: parsed.duration,
         typeData: parsed.typeData,
         typeId: i
@@ -58,7 +58,7 @@ export function expandRecurringRanges(eventDef: EventDef, framingRange: DateRang
   )
 
   // the recurrence plugins don't guarantee that all-day events are start-of-day, so we have to
-  if (eventDef.isAllDay) {
+  if (eventDef.allDay) {
     markers = markers.map(startOfDay)
   }
 

src/types/input-types.ts

@@ -174,13 +174,13 @@ export interface OptionsInputBase {
 
   datesRender?(arg: { view: View, el: HTMLElement }): void
   datesDestroy?(arg: { view: View, el: HTMLElement }): void
-  dayRender?(arg: { view: View, date: Date, isAllDay: boolean, el: HTMLElement }): void
+  dayRender?(arg: { view: View, date: Date, allDay: boolean, el: HTMLElement }): void
   windowResize?(view: View): void
-  dateClick?(arg: { date: Date, isAllDay: boolean, resource: any, el: HTMLElement, jsEvent: MouseEvent, view: View }): void // resource for Scheduler
+  dateClick?(arg: { date: Date, allDay: boolean, resource: any, el: HTMLElement, jsEvent: MouseEvent, view: View }): void // resource for Scheduler
   eventClick?(arg: { el: HTMLElement, event: EventApi, jsEvent: MouseEvent, view: View }): boolean | void
   eventMouseEnter?(arg: { el: HTMLElement, event: EventApi, jsEvent: MouseEvent, view: View }): void
   eventMouseLeave?(arg: { el: HTMLElement, event: EventApi, jsEvent: MouseEvent, view: View }): void
-  select?(arg: { start: Date, end: Date, isAllDay: boolean, resource: any, jsEvent: MouseEvent, view: View }): void // resource for Scheduler
+  select?(arg: { start: Date, end: Date, allDay: boolean, resource: any, jsEvent: MouseEvent, view: View }): void // resource for Scheduler
   unselect?(arg: { view: View, jsEvent: Event }): void
   eventDataTransform?(eventData: any): EventInput
   loading?(isLoading: boolean, view: View): void
@@ -194,7 +194,7 @@ export interface OptionsInputBase {
   eventResizeStart?(arg: { el: HTMLElement, event: EventApi, jsEvent: MouseEvent, view: View }): void
   eventResizeStop?(arg: { el: HTMLElement, event: EventApi, jsEvent: MouseEvent, view: View }): void
   eventResize?(arg: { el: HTMLElement, event: EventApi, delta: Duration, revert: () => void, jsEvent: Event, view: View }): void
-  drop?(arg: { date: DateInput, isAllDay: boolean, jsEvent: MouseEvent }): void
+  drop?(arg: { date: DateInput, allDay: boolean, jsEvent: MouseEvent }): void
   eventReceive?(event: EventApi): void
 }
 

src/validation.ts

@@ -223,7 +223,7 @@ function eventStoreToDateSpans(store: EventStore): DateSpan[] {
 // TODO: plugin
 export function eventToDateSpan(def: EventDef, instance: EventInstance): DateSpan {
   return {
-    isAllDay: def.isAllDay,
+    allDay: def.allDay,
     range: instance.range
   }
 }

tests/automated/datelib/rrule.js

@@ -84,7 +84,7 @@ describe('rrule plugin', function() {
     expect(events[0].end).toEqualDate('2018-09-04T16:00:00Z')
   })
 
-  it('expands events with guessed isAllDay', function() {
+  it('expands events with guessed allDay', function() {
     initCalendar({
       events: [
         {
@@ -99,7 +99,7 @@ describe('rrule plugin', function() {
     expect(events.length).toBe(5)
     expect(events[0].start).toEqualDate('2018-09-04')
     expect(events[0].end).toBe(null)
-    expect(events[0].isAllDay).toBe(true)
+    expect(events[0].allDay).toBe(true)
   })
 
   it('inherits allDayDefault from source', function() {
@@ -118,7 +118,7 @@ describe('rrule plugin', function() {
     expect(events.length).toBe(5)
     expect(events[0].start).toEqualDate('2018-09-04')
     expect(events[0].end).toBe(null)
-    expect(events[0].isAllDay).toBe(false)
+    expect(events[0].allDay).toBe(false)
   })
 
   it('inherits allDayDefault from source setting', function() {
@@ -139,7 +139,7 @@ describe('rrule plugin', function() {
     expect(events.length).toBe(5)
     expect(events[0].start).toEqualDate('2018-09-04')
     expect(events[0].end).toBe(null)
-    expect(events[0].isAllDay).toBe(false)
+    expect(events[0].allDay).toBe(false)
   })
 
   it('can generate local dates', function() {
@@ -158,7 +158,7 @@ describe('rrule plugin', function() {
     expect(events.length).toBe(5)
     expect(events[0].start).toEqualDate('2018-09-04T05:00:00') // local
     expect(events[0].end).toBe(null)
-    expect(events[0].isAllDay).toBe(false)
+    expect(events[0].allDay).toBe(false)
   })
 
 

tests/automated/event-data/Event.mutation.js

@@ -33,7 +33,7 @@ describe('event mutations on non-instances', function() {
       let event = currentCalendar.getEventById('1')
       expect(event.start).toEqualDate('2018-09-04')
       expect(event.end).toBe(null)
-      expect(event.isAllDay).toBe(true)
+      expect(event.allDay).toBe(true)
     })
   })
 

tests/automated/event-data/Event.setDates.js

@@ -66,16 +66,16 @@ describe('Event::setDates', function() {
     })
   })
 
-  it('can set isAllDay to true', function() {
+  it('can set allDay to true', function() {
     initCalendar() // { id: '1', start: '2018-09-05T12:00:00' }
     let event = currentCalendar.getEventById('1')
-    event.setDates('2018-09-06', '2018-09-10', { isAllDay: true })
+    event.setDates('2018-09-06', '2018-09-10', { allDay: true })
     expect(event.start).toEqualDate('2018-09-06')
     expect(event.end).toEqualDate('2018-09-10')
-    expect(event.isAllDay).toBe(true)
+    expect(event.allDay).toBe(true)
   })
 
-  it('can set isAllDay to false', function() {
+  it('can set allDay to false', function() {
     initCalendar({
       events: [
         { id: '1', start: '2018-09-05', end: '2018-09-08' }
@@ -83,10 +83,10 @@ describe('Event::setDates', function() {
     })
 
     let event = currentCalendar.getEventById('1')
-    event.setDates('2018-09-06T10:00:00', '2018-09-10T02:00:00', { isAllDay: false })
+    event.setDates('2018-09-06T10:00:00', '2018-09-10T02:00:00', { allDay: false })
     expect(event.start).toEqualDate('2018-09-06T10:00:00Z')
     expect(event.end).toEqualDate('2018-09-10T02:00:00Z')
-    expect(event.isAllDay).toBe(false)
+    expect(event.allDay).toBe(false)
   })
 
   it('shortens related events of different duration by same delta', function() {

tests/automated/event-data/Event.setIsAllDay.js

@@ -4,14 +4,14 @@ describe('Event::setIsAllDay', function() {
     it('causes no change', function() {
       initCalendar({
         events: [
-          { id: '1', start: '2018-09-03', end: '2018-09-05', isAllDay: true }
+          { id: '1', start: '2018-09-03', end: '2018-09-05', allDay: true }
         ]
       })
       let event = currentCalendar.getEventById('1')
       event.setIsAllDay(true)
       expect(event.start).toEqualDate('2018-09-03')
       expect(event.end).toEqualDate('2018-09-05')
-      expect(event.isAllDay).toBe(true)
+      expect(event.allDay).toBe(true)
     })
   })
 
@@ -19,14 +19,14 @@ describe('Event::setIsAllDay', function() {
     it('causes no change', function() {
       initCalendar({
         events: [
-          { id: '1', start: '2018-09-03T09:00:00', end: '2018-09-05T09:00:00', isAllDay: false }
+          { id: '1', start: '2018-09-03T09:00:00', end: '2018-09-05T09:00:00', allDay: false }
         ]
       })
       let event = currentCalendar.getEventById('1')
       event.setIsAllDay(false)
       expect(event.start).toEqualDate('2018-09-03T09:00:00Z')
       expect(event.end).toEqualDate('2018-09-05T09:00:00Z')
-      expect(event.isAllDay).toBe(false)
+      expect(event.allDay).toBe(false)
     })
   })
 
@@ -36,14 +36,14 @@ describe('Event::setIsAllDay', function() {
       it('removes the end', function() {
         initCalendar({
           events: [
-            { id: '1', start: '2018-09-03', end: '2018-09-05', isAllDay: true }
+            { id: '1', start: '2018-09-03', end: '2018-09-05', allDay: true }
           ]
         })
         let event = currentCalendar.getEventById('1')
         event.setIsAllDay(false)
         expect(event.start).toEqualDate('2018-09-03')
         expect(event.end).toBe(null)
-        expect(event.isAllDay).toBe(false)
+        expect(event.allDay).toBe(false)
       })
     })
 
@@ -51,14 +51,14 @@ describe('Event::setIsAllDay', function() {
       it('keeps exact duration', function() {
         initCalendar({
           events: [
-            { id: '1', start: '2018-09-03', end: '2018-09-05', isAllDay: true }
+            { id: '1', start: '2018-09-03', end: '2018-09-05', allDay: true }
           ]
         })
         let event = currentCalendar.getEventById('1')
         event.setIsAllDay(false, { maintainDuration: true })
         expect(event.start).toEqualDate('2018-09-03')
         expect(event.end).toEqualDate('2018-09-05')
-        expect(event.isAllDay).toBe(false)
+        expect(event.allDay).toBe(false)
       })
     })
 
@@ -70,14 +70,14 @@ describe('Event::setIsAllDay', function() {
       it('removes the end', function() {
         initCalendar({
           events: [
-            { id: '1', start: '2018-09-03T09:00:00', end: '2018-09-05T09:00:00', isAllDay: false }
+            { id: '1', start: '2018-09-03T09:00:00', end: '2018-09-05T09:00:00', allDay: false }
           ]
         })
         let event = currentCalendar.getEventById('1')
         event.setIsAllDay(true)
         expect(event.start).toEqualDate('2018-09-03')
         expect(event.end).toBe(null)
-        expect(event.isAllDay).toBe(true)
+        expect(event.allDay).toBe(true)
       })
     })
 
@@ -85,30 +85,30 @@ describe('Event::setIsAllDay', function() {
       it('rounds the end down to the prev whole day', function() {
         initCalendar({
           events: [
-            { id: '1', start: '2018-09-03T09:00:00', end: '2018-09-05T10:00:00', isAllDay: false }
+            { id: '1', start: '2018-09-03T09:00:00', end: '2018-09-05T10:00:00', allDay: false }
           ]
         })
         let event = currentCalendar.getEventById('1')
         event.setIsAllDay(true, { maintainDuration: true })
         expect(event.start).toEqualDate('2018-09-03')
         expect(event.end).toEqualDate('2018-09-05')
-        expect(event.isAllDay).toBe(true)
+        expect(event.allDay).toBe(true)
       })
     })
 
     describe('when maintaining duration (from calendar setting)', function() {
       it('rounds the end to the next whole day', function() {
         initCalendar({
-          isAllDayMaintainDuration: true,
+          allDayMaintainDuration: true,
           events: [
-            { id: '1', start: '2018-09-03T09:00:00', end: '2018-09-05T10:00:00', isAllDay: false }
+            { id: '1', start: '2018-09-03T09:00:00', end: '2018-09-05T10:00:00', allDay: false }
           ]
         })
         let event = currentCalendar.getEventById('1')
         event.setIsAllDay(true)
         expect(event.start).toEqualDate('2018-09-03')
         expect(event.end).toEqualDate('2018-09-05')
-        expect(event.isAllDay).toBe(true)
+        expect(event.allDay).toBe(true)
       })
     })
 

tests/automated/event-data/Event.setStart.js

@@ -66,7 +66,7 @@ describe('Event::setStart', function() {
   describe('when event is all-day', function() {
     pushOptions({
       events: [
-        { id: '1', start: '2018-09-05', end: '2018-09-07', isAllDay: true }
+        { id: '1', start: '2018-09-05', end: '2018-09-07', allDay: true }
       ]
     })
 
@@ -77,7 +77,7 @@ describe('Event::setStart', function() {
         event.setStart('2018-09-01')
         expect(event.start).toEqualDate('2018-09-01')
         expect(event.end).toEqualDate('2018-09-07')
-        expect(event.isAllDay).toBe(true)
+        expect(event.allDay).toBe(true)
       })
     })
 
@@ -88,7 +88,7 @@ describe('Event::setStart', function() {
         event.setStart('2018-09-01T23:00:00')
         expect(event.start).toEqualDate('2018-09-01')
         expect(event.end).toEqualDate('2018-09-07')
-        expect(event.isAllDay).toBe(true)
+        expect(event.allDay).toBe(true)
       })
     })
 

tests/automated/event-drag/all-day-change.js

@@ -2,7 +2,7 @@ import { drag } from './EventDragUtils'
 import { computeSpanRects } from '../event-render/TimeGridEventRenderUtils'
 import { getDayEl } from '../view-render/DayGridRenderUtils'
 
-describe('isAllDay change', function() {
+describe('allDay change', function() {
   pushOptions({
     timeZone: 'UTC',
     defaultView: 'agendaWeek',
@@ -29,9 +29,9 @@ describe('isAllDay change', function() {
       return drag(startRect, endRect, false)
     }
 
-    it('discards duration when isAllDayMaintainDuration:false', function(done) {
+    it('discards duration when allDayMaintainDuration:false', function(done) {
       initCalendar({
-        isAllDayMaintainDuration: false
+        allDayMaintainDuration: false
       })
       doDrag().then(function() {
         let event = currentCalendar.getEventById('1')
@@ -40,9 +40,9 @@ describe('isAllDay change', function() {
       }).then(done)
     })
 
-    it('keeps duration when isAllDayMaintainDuration:true', function(done) {
+    it('keeps duration when allDayMaintainDuration:true', function(done) {
       initCalendar({
-        isAllDayMaintainDuration: true
+        allDayMaintainDuration: true
       })
       doDrag().then(function() {
         let event = currentCalendar.getEventById('1')

tests/automated/legacy/allDayDefault.js

@@ -12,7 +12,7 @@ describe('allDayDefault', function() {
         ]
       })
       var eventObj = currentCalendar.getEventById('1')
-      expect(eventObj.isAllDay).toEqual(false)
+      expect(eventObj.allDay).toEqual(false)
     })
 
     it('guesses false if T in ISO8601 end date', function() {
@@ -26,7 +26,7 @@ describe('allDayDefault', function() {
         ]
       })
       var eventObj = currentCalendar.getEventById('1')
-      expect(eventObj.isAllDay).toEqual(false)
+      expect(eventObj.allDay).toEqual(false)
     })
 
     it('guesses true if ISO8601 start date with no time and unspecified end date', function() {
@@ -39,7 +39,7 @@ describe('allDayDefault', function() {
         ]
       })
       var eventObj = currentCalendar.getEventById('1')
-      expect(eventObj.isAllDay).toEqual(true)
+      expect(eventObj.allDay).toEqual(true)
     })
 
     it('guesses true if ISO8601 start and end date with no times', function() {
@@ -53,7 +53,7 @@ describe('allDayDefault', function() {
         ]
       })
       var eventObj = currentCalendar.getEventById('1')
-      expect(eventObj.isAllDay).toEqual(true)
+      expect(eventObj.allDay).toEqual(true)
     })
 
     it('guesses false if start is a unix timestamp (which implies it has a time)', function() {
@@ -68,7 +68,7 @@ describe('allDayDefault', function() {
       })
 
       var eventObj = currentCalendar.getEventById('1')
-      expect(eventObj.isAllDay).toEqual(false)
+      expect(eventObj.allDay).toEqual(false)
     })
 
     it('guesses false if end is a unix timestamp (which implies it has a time)', function() {
@@ -82,7 +82,7 @@ describe('allDayDefault', function() {
         ]
       })
       var eventObj = currentCalendar.getEventById('1')
-      expect(eventObj.isAllDay).toEqual(false)
+      expect(eventObj.allDay).toEqual(false)
     })
 
   })
@@ -100,7 +100,7 @@ describe('allDayDefault', function() {
         ]
       })
       var eventObj = currentCalendar.getEventById('1')
-      expect(eventObj.isAllDay).toEqual(false)
+      expect(eventObj.allDay).toEqual(false)
     })
 
     it('has no effect when an event\'s allDay is specified', function() {
@@ -110,12 +110,12 @@ describe('allDayDefault', function() {
           {
             id: '1',
             start: '2014-05-01T00:00:00',
-            isAllDay: true
+            allDay: true
           }
         ]
       })
       var eventObj = currentCalendar.getEventById('1')
-      expect(eventObj.isAllDay).toEqual(true)
+      expect(eventObj.allDay).toEqual(true)
     })
 
   })
@@ -139,7 +139,7 @@ describe('source.allDayDefault', function() {
       ]
     })
     var eventObj = currentCalendar.getEventById('1')
-    expect(eventObj.isAllDay).toEqual(false)
+    expect(eventObj.allDay).toEqual(false)
   })
 
   it('a true value can override the global allDayDefault', function() {
@@ -158,7 +158,7 @@ describe('source.allDayDefault', function() {
       ]
     })
     var eventObj = currentCalendar.getEventById('1')
-    expect(eventObj.isAllDay).toEqual(true)
+    expect(eventObj.allDay).toEqual(true)
   })
 
   it('a false value can override the global allDayDefault', function() {
@@ -177,7 +177,7 @@ describe('source.allDayDefault', function() {
       ]
     })
     var eventObj = currentCalendar.getEventById('1')
-    expect(eventObj.isAllDay).toEqual(false)
+    expect(eventObj.allDay).toEqual(false)
   })
 
   it('has no effect when an event\'s allDay is specified', function() {
@@ -189,14 +189,14 @@ describe('source.allDayDefault', function() {
             {
               id: '1',
               start: '2014-05-01',
-              isAllDay: false
+              allDay: false
             }
           ]
         }
       ]
     })
     var eventObj = currentCalendar.getEventById('1')
-    expect(eventObj.isAllDay).toEqual(false)
+    expect(eventObj.allDay).toEqual(false)
   })
 
 })

tests/automated/legacy/custom-view-class.js

@@ -39,7 +39,7 @@ describe('custom view class', function() {
 
       renderDateSelection(dateSpan) {
         expect(typeof dateSpan).toBe('object')
-        expect(dateSpan.isAllDay).toBe(true)
+        expect(dateSpan.allDay).toBe(true)
         expect(dateSpan.range.start instanceof Date).toBe(true)
         expect(dateSpan.range.end instanceof Date).toBe(true)
       }

tests/automated/legacy/dateClick.js

@@ -22,7 +22,7 @@ describe('dateClick', function() {
                 expect(arg.date instanceof Date).toEqual(true)
                 expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
                 expect(typeof arg.view).toEqual('object') // "
-                expect(arg.isAllDay).toEqual(true)
+                expect(arg.allDay).toEqual(true)
                 expect(arg.date).toEqualDate('2014-05-07')
                 expect(arg.dateStr).toEqual('2014-05-07')
                 done()
@@ -46,7 +46,7 @@ describe('dateClick', function() {
                 expect(arg.date instanceof Date).toEqual(true)
                 expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
                 expect(typeof arg.view).toEqual('object') // "
-                expect(arg.isAllDay).toEqual(true)
+                expect(arg.allDay).toEqual(true)
                 expect(arg.date).toEqualDate('2014-05-28')
                 expect(arg.dateStr).toEqual('2014-05-28')
                 done()
@@ -71,7 +71,7 @@ describe('dateClick', function() {
                 expect(arg.date instanceof Date).toEqual(true)
                 expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
                 expect(typeof arg.view).toEqual('object') // "
-                expect(arg.isAllDay).toEqual(false)
+                expect(arg.allDay).toEqual(false)
                 expect(arg.date).toEqualDate('2014-05-28T09:00:00Z')
                 expect(arg.dateStr).toEqual('2014-05-28T09:00:00Z')
                 done()
@@ -98,7 +98,7 @@ describe('dateClick', function() {
                 expect(arg.date instanceof Date).toEqual(true)
                 expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
                 expect(typeof arg.view).toEqual('object') // "
-                expect(arg.isAllDay).toEqual(false)
+                expect(arg.allDay).toEqual(false)
                 expect(arg.date).toEqualDate('2014-05-28T11:00:00Z')
                 expect(arg.dateStr).toEqual('2014-05-28T11:00:00Z')
                 done()
@@ -126,7 +126,7 @@ describe('dateClick', function() {
         expect(arg.date instanceof Date).toEqual(true)
         expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
         expect(typeof arg.view).toEqual('object') // "
-        expect(arg.isAllDay).toEqual(true)
+        expect(arg.allDay).toEqual(true)
         expect(arg.date).toEqualDate('2014-05-07')
         expect(arg.dateStr).toEqual('2014-05-07')
         done()
@@ -170,7 +170,7 @@ describe('dateClick', function() {
         expect(arg.date instanceof Date).toEqual(true)
         expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
         expect(typeof arg.view).toEqual('object') // "
-        expect(arg.isAllDay).toEqual(true)
+        expect(arg.allDay).toEqual(true)
         expect(arg.date).toEqualDate('2014-05-07')
         expect(arg.dateStr).toEqual('2014-05-07')
         done()

tests/automated/legacy/dayRender.js

@@ -9,7 +9,7 @@ describe('dayRender', function() {
       defaultDate: '2014-05-01',
       dayRender: function(arg) {
         expect(arg.date instanceof Date).toEqual(true)
-        expect(arg.isAllDay).toEqual(true)
+        expect(arg.allDay).toEqual(true)
         expect(formatIsoDay(arg.date)).toEqual(arg.el.getAttribute('data-date'))
         expect(arg.el).toBeInDOM()
       }

tests/automated/legacy/event-dnd.js

@@ -253,14 +253,14 @@ describe('eventDrop', function() {
 
             expect(arg.event.start).toEqualDate('2014-06-10T01:00:00Z')
             expect(arg.event.end).toBeNull()
-            expect(arg.event.isAllDay).toBe(false)
+            expect(arg.event.allDay).toBe(false)
 
             arg.revert()
             var event = currentCalendar.getEvents()[0]
 
             expect(event.start).toEqualDate('2014-06-11')
             expect(event.end).toBeNull()
-            expect(event.isAllDay).toBe(true)
+            expect(event.allDay).toBe(true)
 
             done()
           }
@@ -306,14 +306,14 @@ describe('eventDrop', function() {
 
             expect(arg.event.start).toEqualDate('2014-06-10')
             expect(arg.event.end).toBeNull()
-            expect(arg.event.isAllDay).toBe(true)
+            expect(arg.event.allDay).toBe(true)
 
             arg.revert()
             var event = currentCalendar.getEvents()[0]
 
             expect(event.start).toEqualDate('2014-06-11T01:00:00Z')
             expect(event.end).toBeNull()
-            expect(event.isAllDay).toBe(false)
+            expect(event.allDay).toBe(false)
 
             done()
           }

tests/automated/legacy/event-obj.js

@@ -98,9 +98,9 @@ describe('event object creation', function() {
     var event = init({
       start: '2014-05-01T01:00:00-12:00',
       end: '2014-05-02T01:00:00-12:00',
-      isAllDay: true
+      allDay: true
     })
-    expect(event.isAllDay).toEqual(true)
+    expect(event.allDay).toEqual(true)
     expect(event.start).toEqualDate('2014-05-01')
     expect(event.end).toEqualDate('2014-05-02')
   })
@@ -109,9 +109,9 @@ describe('event object creation', function() {
     var event = init({
       start: '2014-05-01',
       end: '2014-05-03',
-      isAllDay: false
+      allDay: false
     })
-    expect(event.isAllDay).toEqual(false)
+    expect(event.allDay).toEqual(false)
     expect(event.start).toEqualDate('2014-05-01T00:00:00Z')
     expect(event.end).toEqualDate('2014-05-03T00:00:00Z')
   })

tests/automated/legacy/event-resize.js

@@ -57,7 +57,7 @@ describe('eventResize', function() {
             options.events = [ {
               title: 'all-day event',
               start: '2014-06-11',
-              isAllDay: true
+              allDay: true
             } ]
 
             init(

tests/automated/legacy/eventLimit-popover.js

@@ -104,49 +104,49 @@ describe('eventLimit popover', function() {
             title: 'event01',
             start: '2012-03-22T11:00:00',
             end: '2012-03-22T11:30:00',
-            isAllDay: false
+            allDay: false
           },
           {
             id: '40607',
             title: 'event02',
             start: '2012-03-22T16:15:00',
             end: '2012-03-22T16:30:00',
-            isAllDay: false
+            allDay: false
           },
           {
             id: '40760',
             title: 'event03',
             start: '2012-03-22T16:00:00',
             end: '2012-03-22T16:15:00',
-            isAllDay: false
+            allDay: false
           },
           {
             id: '41284',
             title: 'event04',
             start: '2012-03-22T19:00:00',
             end: '2012-03-22T19:15:00',
-            isAllDay: false
+            allDay: false
           },
           {
             id: '41645',
             title: 'event05',
             start: '2012-03-22T11:30:00',
             end: '2012-03-22T12:00:00',
-            isAllDay: false
+            allDay: false
           },
           {
             id: '41679',
             title: 'event07',
             start: '2012-03-22T12:00:00',
             end: '2012-03-22T12:15:00',
-            isAllDay: false
+            allDay: false
           },
           {
             id: '42246',
             title: 'event08',
             start: '2012-03-22T16:45:00',
             end: '2012-03-22T17:00:00',
-            isAllDay: false
+            allDay: false
           }
         ]
       })
@@ -278,7 +278,7 @@ describe('eventLimit popover', function() {
         initCalendar({
           eventDrop: function(arg) {
             expect(arg.event.start).toEqualDate('2014-07-28')
-            expect(arg.event.isAllDay).toBe(true)
+            expect(arg.event.allDay).toBe(true)
             done()
           }
         })
@@ -307,7 +307,7 @@ describe('eventLimit popover', function() {
           events: testEvents,
           eventDrop: function(arg) {
             expect(arg.event.start).toEqualDate('2014-07-28T13:00:00Z')
-            expect(arg.event.isAllDay).toBe(false)
+            expect(arg.event.allDay).toBe(false)
             done()
           }
         })
@@ -331,7 +331,7 @@ describe('eventLimit popover', function() {
           scrollTime: '00:00:00',
           eventDrop: function(arg) {
             expect(arg.event.start).toEqualDate('2014-07-30T03:00:00Z')
-            expect(arg.event.isAllDay).toBe(false)
+            expect(arg.event.allDay).toBe(false)
             done()
           }
         })

tests/automated/legacy/external-dnd-advanced.js

@@ -358,7 +358,7 @@ describe('advanced external dnd', function() {
     options.drop = function(arg) {
       expect(arg.date instanceof Date).toBe(true)
       expect(arg.date).toEqualDate(dragToDate)
-      expect(arg.isAllDay).toBe(expectedAllDay)
+      expect(arg.allDay).toBe(expectedAllDay)
       expect(typeof arg.jsEvent).toBe('object')
     }
     options.eventReceive = function(arg) {

tests/automated/legacy/select-callback.js

@@ -31,7 +31,7 @@ describe('select callback', function() {
             expect(arg.end instanceof Date).toEqual(true)
             expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
             expect(typeof arg.view).toEqual('object') // "
-            expect(arg.isAllDay).toEqual(true)
+            expect(arg.allDay).toEqual(true)
             expect(arg.start).toEqualDate('2014-04-28')
             expect(arg.startStr).toEqual('2014-04-28')
             expect(arg.end).toEqualDate('2014-05-07')
@@ -53,7 +53,7 @@ describe('select callback', function() {
             expect(arg.end instanceof Date).toEqual(true)
             expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
             expect(typeof arg.view).toEqual('object') // "
-            expect(arg.isAllDay).toEqual(true)
+            expect(arg.allDay).toEqual(true)
             expect(arg.start).toEqualDate('2014-04-28')
             expect(arg.startStr).toEqual('2014-04-28')
             expect(arg.end).toEqualDate('2014-05-07')
@@ -79,7 +79,7 @@ describe('select callback', function() {
             expect(arg.end instanceof Date).toEqual(true)
             expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
             expect(typeof arg.view).toEqual('object') // "
-            expect(arg.isAllDay).toEqual(true)
+            expect(arg.allDay).toEqual(true)
             expect(arg.start).toEqualDate('2014-04-28')
             expect(arg.startStr).toEqual('2014-04-28')
             expect(arg.end).toEqualDate('2014-04-29')
@@ -108,7 +108,7 @@ describe('select callback', function() {
               expect(arg.end instanceof Date).toEqual(true)
               expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
               expect(typeof arg.view).toEqual('object') // "
-              expect(arg.isAllDay).toEqual(true)
+              expect(arg.allDay).toEqual(true)
               expect(arg.start).toEqualDate('2014-05-28')
               expect(arg.startStr).toEqual('2014-05-28')
               expect(arg.end).toEqualDate('2014-05-30')
@@ -130,7 +130,7 @@ describe('select callback', function() {
               expect(arg.end instanceof Date).toEqual(true)
               expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
               expect(typeof arg.view).toEqual('object') // "
-              expect(arg.isAllDay).toEqual(true)
+              expect(arg.allDay).toEqual(true)
               expect(arg.start).toEqualDate('2014-05-28')
               expect(arg.startStr).toEqual('2014-05-28')
               expect(arg.end).toEqualDate('2014-05-29')
@@ -153,7 +153,7 @@ describe('select callback', function() {
               expect(arg.end instanceof Date).toEqual(true)
               expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
               expect(typeof arg.view).toEqual('object') // "
-              expect(arg.isAllDay).toEqual(false)
+              expect(arg.allDay).toEqual(false)
               expect(arg.start).toEqualDate('2014-05-28T09:00:00Z')
               expect(arg.startStr).toEqual('2014-05-28T09:00:00Z')
               expect(arg.end).toEqualDate('2014-05-28T10:30:00Z')
@@ -175,7 +175,7 @@ describe('select callback', function() {
               expect(arg.end instanceof Date).toEqual(true)
               expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
               expect(typeof arg.view).toEqual('object') // "
-              expect(arg.isAllDay).toEqual(false)
+              expect(arg.allDay).toEqual(false)
               expect(arg.start).toEqualDate('2014-05-28T09:00:00Z')
               expect(arg.startStr).toEqual('2014-05-28T09:00:00Z')
               expect(arg.end).toEqualDate('2014-05-28T10:30:00Z')
@@ -201,7 +201,7 @@ describe('select callback', function() {
               expect(arg.end instanceof Date).toEqual(true)
               expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
               expect(typeof arg.view).toEqual('object') // "
-              expect(arg.isAllDay).toEqual(false)
+              expect(arg.allDay).toEqual(false)
               expect(arg.start).toEqualDate('2014-05-28T09:00:00Z')
               expect(arg.startStr).toEqual('2014-05-28T09:00:00Z')
               expect(arg.end).toEqualDate('2014-05-29T10:30:00Z')
@@ -224,7 +224,7 @@ describe('select callback', function() {
               expect(arg.end instanceof Date).toEqual(true)
               expect(typeof arg.jsEvent).toEqual('object') // TODO: more descrimination
               expect(typeof arg.view).toEqual('object') // "
-              expect(arg.isAllDay).toEqual(false)
+              expect(arg.allDay).toEqual(false)
               expect(arg.start).toEqualDate('2014-05-28T09:00:00Z')
               expect(arg.startStr).toEqual('2014-05-28T09:00:00Z')
               expect(arg.end).toEqualDate('2014-05-28T09:30:00Z')

tests/automated/legacy/select-method.js

@@ -40,7 +40,7 @@ describe('select method', function() {
             })
             it('fires a selection event', function() {
               options.select = function(arg) {
-                expect(arg.isAllDay).toEqual(true)
+                expect(arg.allDay).toEqual(true)
                 expect(arg.start).toEqualDate('2014-05-07')
                 expect(arg.end).toEqualDate('2014-05-09')
               }
@@ -79,7 +79,7 @@ describe('select method', function() {
           })
           it('fires a selection event', function() {
             options.select = function(arg) {
-              expect(arg.isAllDay).toEqual(false)
+              expect(arg.allDay).toEqual(false)
               expect(arg.start).toEqualDate('2014-05-07T06:00:00Z')
               expect(arg.end).toEqualDate('2014-05-09T06:00:00Z')
             }
@@ -148,7 +148,7 @@ describe('select method', function() {
             })
             it('fires a selection event', function() {
               options.select = function(arg) {
-                expect(arg.isAllDay).toEqual(true)
+                expect(arg.allDay).toEqual(true)
                 expect(arg.start).toEqualDate('2014-05-26')
                 expect(arg.end).toEqualDate('2014-05-28')
               }
@@ -171,7 +171,7 @@ describe('select method', function() {
             TODO: implement
             it('doesn\'t fire a selection event', function() {
               options.select = function(arg) {
-                expect(arg.isAllDay).toEqual(true);
+                expect(arg.allDay).toEqual(true);
                 expect(arg.start).toEqualDate('2014-05-26');
                 expect(arg.end).toEqualDate('2014-05-28');
               };

tests/automated/legacy/timeZone.js

@@ -40,11 +40,11 @@ describe('timeZone', function() {
     var allDayEvent = currentCalendar.getEventById('1')
     var timedEvent = currentCalendar.getEventById('2')
     var zonedEvent = currentCalendar.getEventById('3')
-    expect(allDayEvent.isAllDay).toEqual(true)
+    expect(allDayEvent.allDay).toEqual(true)
     expect(allDayEvent.start).toEqualDate('2014-05-02T00:00:00') // local
-    expect(timedEvent.isAllDay).toEqual(false)
+    expect(timedEvent.allDay).toEqual(false)
     expect(timedEvent.start).toEqualDate('2014-05-10T12:00:00') // local
-    expect(zonedEvent.isAllDay).toEqual(false)
+    expect(zonedEvent.allDay).toEqual(false)
     expect(zonedEvent.start).toEqualDate('2014-05-10T14:00:00+11:00')
   }
 
@@ -63,11 +63,11 @@ describe('timeZone', function() {
     var allDayEvent = currentCalendar.getEventById('1')
     var timedEvent = currentCalendar.getEventById('2')
     var zonedEvent = currentCalendar.getEventById('3')
-    expect(allDayEvent.isAllDay).toEqual(true)
+    expect(allDayEvent.allDay).toEqual(true)
     expect(allDayEvent.start).toEqualDate('2014-05-02')
-    expect(timedEvent.isAllDay).toEqual(false)
+    expect(timedEvent.allDay).toEqual(false)
     expect(timedEvent.start).toEqualDate('2014-05-10T12:00:00Z')
-    expect(zonedEvent.isAllDay).toEqual(false)
+    expect(zonedEvent.allDay).toEqual(false)
     expect(zonedEvent.start).toEqualDate('2014-05-10T14:00:00+11:00')
   }
 
@@ -86,11 +86,11 @@ describe('timeZone', function() {
     var allDayEvent = currentCalendar.getEventById('1')
     var timedEvent = currentCalendar.getEventById('2')
     var zonedEvent = currentCalendar.getEventById('3')
-    expect(allDayEvent.isAllDay).toEqual(true)
+    expect(allDayEvent.allDay).toEqual(true)
     expect(allDayEvent.start).toEqualDate('2014-05-02')
-    expect(timedEvent.isAllDay).toEqual(false)
+    expect(timedEvent.allDay).toEqual(false)
     expect(timedEvent.start).toEqualDate('2014-05-10T12:00:00Z')
-    expect(zonedEvent.isAllDay).toEqual(false)
+    expect(zonedEvent.allDay).toEqual(false)
     expect(zonedEvent.start).toEqualDate('2014-05-10T14:00:00Z') // coerced to UTC
   }
 
@@ -112,11 +112,11 @@ describe('timeZone', function() {
           var allDayEvent = currentCalendar.getEventById('1')
           var timedEvent = currentCalendar.getEventById('2')
           var zonedEvent = currentCalendar.getEventById('3')
-          expect(allDayEvent.isAllDay).toEqual(true)
+          expect(allDayEvent.allDay).toEqual(true)
           expect(allDayEvent.start).toEqualDate('2014-05-02')
-          expect(timedEvent.isAllDay).toEqual(false)
+          expect(timedEvent.allDay).toEqual(false)
           expect(timedEvent.start).toEqualDate('2014-05-10T12:00:00') // was parsed as LOCAL originally
-          expect(zonedEvent.isAllDay).toEqual(false)
+          expect(zonedEvent.allDay).toEqual(false)
           expect(zonedEvent.start).toEqualDate('2014-05-10T14:00:00+11:00')
 
           done()

tests/automated/lib/dnd-resize-utils.js

@@ -190,30 +190,30 @@ export function testSelection(options, start, end, expectSuccess, callback) {
   var dragEl
   var allowed
 
-  var isAllDay = false
+  var allDay = false
   var meta
   if (typeof start === 'string') {
     meta = FullCalendar.parseMarker(start)
-    isAllDay = isAllDay || meta.isTimeUnspecified
+    allDay = allDay || meta.isTimeUnspecified
     start = meta.marker
   }
   if (typeof end === 'string') {
     meta = FullCalendar.parseMarker(end)
-    isAllDay = isAllDay || meta.isTimeUnspecified
+    allDay = allDay || meta.isTimeUnspecified
     end = meta.marker
   }
 
   options.selectable = true
   options.select = function(arg) {
     successfulSelection =
-      arg.isAllDay === isAllDay &&
+      arg.allDay === allDay &&
       arg.start.valueOf() === start.valueOf() &&
       arg.end.valueOf() === end.valueOf()
   }
   spyOn(options, 'select').and.callThrough()
   initCalendar(options)
 
-  if (!isAllDay) {
+  if (!allDay) {
     firstDayEl = getTimeGridDayEls(start)
     lastDayEl = getTimeGridDayEls(end)
     firstSlatIndex = start.getUTCHours() * 2 + (start.getUTCMinutes() / 30) // assumes slotDuration:'30:00'