Răsfoiți Sursa

fixed changelog and code comments for v1.5.3

Adam Shaw 14 ani în urmă
părinte
comite
ce082b3a61
2 a modificat fișierele cu 11 adăugiri și 5 ștergeri
  1. 3 3
      changelog.txt
  2. 8 2
      src/common/HoverListener.js

+ 3 - 3
changelog.txt

@@ -1,7 +1,7 @@
 
-version 1.5.3 (11/21/11)
-	- fixed dragging issue with jQuery 1.7 (issue 1168)
-	- bundled with jQuery 1.7 and jQuery UI 1.8.16
+version 1.5.3 (2/6/12)
+	- fixed dragging issue with jQuery UI 1.8.16 (issue 1168)
+	- bundled with jQuery 1.7.1 and jQuery UI 1.8.17
 
 version 1.5.2 (8/21/11)
 	- correctly process UTC "Z" ISO8601 date strings (issue 750)

+ 8 - 2
src/common/HoverListener.js

@@ -20,7 +20,7 @@ function HoverListener(coordinateGrid) {
 	
 	
 	function mouse(ev) {
-		_fixUIEvent(ev);
+		_fixUIEvent(ev); // see below
 		var newCell = coordinateGrid.cell(ev.pageX, ev.pageY);
 		if (!newCell != !cell || newCell && (newCell.row != cell.row || newCell.col != cell.col)) {
 			if (newCell) {
@@ -45,7 +45,13 @@ function HoverListener(coordinateGrid) {
 }
 
 
-function _fixUIEvent(event) { // jQuery 1.7 workaround (for issue 1168)
+
+// this fix was only necessary for jQuery UI 1.8.16 (and jQuery 1.7 or 1.7.1)
+// upgrading to jQuery UI 1.8.17 (and using either jQuery 1.7 or 1.7.1) fixed the problem
+// but keep this in here for 1.8.17 users
+// and maybe remove it down the line
+
+function _fixUIEvent(event) { // for issue 1168
 	if (event.pageX === undefined) {
 		event.pageX = event.originalEvent.pageX;
 		event.pageY = event.originalEvent.pageY;