Browse Source

Merge pull request #7343 from Mugen87/sqrt

Avoid unnecessary Math.sqrt operations
Mr.doob 9 years ago
parent
commit
071418ab27
2 changed files with 3 additions and 3 deletions
  1. 2 2
      src/math/Matrix4.js
  2. 1 1
      src/math/Vector3.js

+ 2 - 2
src/math/Matrix4.js

@@ -341,7 +341,7 @@ THREE.Matrix4.prototype = {
 
 			z.subVectors( eye, target ).normalize();
 
-			if ( z.length() === 0 ) {
+			if ( z.lengthSq() === 0 ) {
 
 				z.z = 1;
 
@@ -349,7 +349,7 @@ THREE.Matrix4.prototype = {
 
 			x.crossVectors( up, z ).normalize();
 
-			if ( x.length() === 0 ) {
+			if ( x.lengthSq() === 0 ) {
 
 				z.x += 0.0001;
 				x.crossVectors( up, z ).normalize();

+ 1 - 1
src/math/Vector3.js

@@ -701,7 +701,7 @@ THREE.Vector3.prototype = {
 
 	angleTo: function ( v ) {
 
-		var theta = this.dot( v ) / ( this.length() * v.length() );
+		var theta = this.dot( v ) / ( Math.sqrt( this.lengthSq() * v.lengthSq() ) );
 
 		// clamp, to handle numerical problems