Selaa lähdekoodia

More clean up. (#23442)

* More clean up.

* Update VTKLoader.js

Co-authored-by: mrdoob <[email protected]>
Michael Herzog 3 vuotta sitten
vanhempi
commit
1637e9db57

+ 2 - 2
examples/jsm/controls/experimental/CameraControls.js

@@ -157,7 +157,7 @@ var CameraControls = function ( object, domElement ) {
 
 					vec.set( 0, 1, 0 ).applyQuaternion( scope.object.quaternion );
 
-					var factor = ( scope.enableDamping ) ? scope.dampingFactor : 1;
+					const factor = ( scope.enableDamping ) ? scope.dampingFactor : 1;
 
 					q.setFromAxisAngle( vec, sphericalDelta.theta * factor );
 
@@ -172,7 +172,7 @@ var CameraControls = function ( object, domElement ) {
 
 					vec.set( 1, 0, 0 ).applyQuaternion( scope.object.quaternion );
 
-					var factor = ( scope.enableDamping ) ? scope.dampingFactor : 1;
+					const factor = ( scope.enableDamping ) ? scope.dampingFactor : 1;
 
 					q.setFromAxisAngle( vec, sphericalDelta.phi * factor );
 

+ 2 - 2
examples/jsm/effects/AsciiEffect.js

@@ -49,7 +49,7 @@ class AsciiEffect {
 		this.render = function ( scene, camera ) {
 
 			renderer.render( scene, camera );
-			asciifyImage( renderer, oAscii );
+			asciifyImage( oAscii );
 
 		};
 
@@ -191,7 +191,7 @@ class AsciiEffect {
 
 		// convert img element to ascii
 
-		function asciifyImage( canvasRenderer, oAscii ) {
+		function asciifyImage( oAscii ) {
 
 			oCtx.clearRect( 0, 0, iWidth, iHeight );
 			oCtx.drawImage( oCanvasImg, 0, 0, iWidth, iHeight );

+ 6 - 6
examples/jsm/exporters/OBJExporter.js

@@ -261,17 +261,17 @@ class OBJExporter {
 
 				}
 
-			}
+				output += 'p ';
 
-			output += 'p ';
+				for ( let j = 1, l = vertices.count; j <= l; j ++ ) {
 
-			for ( let j = 1, l = vertices.count; j <= l; j ++ ) {
+					output += ( indexVertex + j ) + ' ';
 
-				output += ( indexVertex + j ) + ' ';
+				}
 
-			}
+				output += '\n';
 
-			output += '\n';
+			}
 
 			// update index
 			indexVertex += nbVertex;

+ 1 - 1
examples/jsm/exporters/PLYExporter.js

@@ -457,7 +457,7 @@ class PLYExporter {
 								uvs.getX( i ) + ' ' +
 								uvs.getY( i );
 
-						} else if ( includeUVs !== false ) {
+						} else {
 
 							line += ' 0 0';
 

+ 4 - 9
examples/jsm/loaders/3MFLoader.js

@@ -97,7 +97,6 @@ class ThreeMFLoader extends Loader {
 			let relsName;
 			let modelRelsName;
 			const modelPartNames = [];
-			const printTicketPartNames = [];
 			const texturesPartNames = [];
 
 			let modelRels;
@@ -134,10 +133,6 @@ class ThreeMFLoader extends Loader {
 
 					modelPartNames.push( file );
 
-				} else if ( file.match( /^3D\/Metadata\/.*\.xml$/ ) ) {
-
-					printTicketPartNames.push( file );
-
 				} else if ( file.match( /^3D\/Textures?\/.*/ ) ) {
 
 					texturesPartNames.push( file );
@@ -997,7 +992,7 @@ class ThreeMFLoader extends Loader {
 
 		}
 
-		function buildVertexColorMesh( colorgroup, triangleProperties, meshData, objects, objectData ) {
+		function buildVertexColorMesh( colorgroup, triangleProperties, meshData, objectData ) {
 
 			// geometry
 
@@ -1110,7 +1105,7 @@ class ThreeMFLoader extends Loader {
 
 					case 'vertexColors':
 						const colorgroup = modelData.resources.colorgroup[ resourceId ];
-						meshes.push( buildVertexColorMesh( colorgroup, triangleProperties, meshData, objects, objectData ) );
+						meshes.push( buildVertexColorMesh( colorgroup, triangleProperties, meshData, objectData ) );
 						break;
 
 					case 'default':
@@ -1154,7 +1149,7 @@ class ThreeMFLoader extends Loader {
 
 		}
 
-		function analyzeObject( modelData, meshData, objectData ) {
+		function analyzeObject( meshData, objectData ) {
 
 			const resourceMap = {};
 
@@ -1183,7 +1178,7 @@ class ThreeMFLoader extends Loader {
 
 			const group = new Group();
 
-			const resourceMap = analyzeObject( modelData, meshData, objectData );
+			const resourceMap = analyzeObject( meshData, objectData );
 			const meshes = buildMeshes( resourceMap, meshData, objects, modelData, textureData, objectData );
 
 			for ( let i = 0, l = meshes.length; i < l; i ++ ) {

+ 8 - 8
examples/jsm/loaders/EXRLoader.js

@@ -208,7 +208,7 @@ class EXRLoader extends DataTextureLoader {
 
 		}
 
-		function hufUnpackEncTable( uInt8Array, inDataView, inOffset, ni, im, iM, hcode ) {
+		function hufUnpackEncTable( uInt8Array, inOffset, ni, im, iM, hcode ) {
 
 			const p = inOffset;
 			let c = 0;
@@ -371,7 +371,7 @@ class EXRLoader extends DataTextureLoader {
 
 		const getCodeReturn = { c: 0, lc: 0 };
 
-		function getCode( po, rlc, c, lc, uInt8Array, inDataView, inOffset, outBuffer, outBufferOffset, outBufferEndOffset ) {
+		function getCode( po, rlc, c, lc, uInt8Array, inOffset, outBuffer, outBufferOffset, outBufferEndOffset ) {
 
 			if ( po == rlc ) {
 
@@ -595,7 +595,7 @@ class EXRLoader extends DataTextureLoader {
 
 		}
 
-		function hufDecode( encodingTable, decodingTable, uInt8Array, inDataView, inOffset, ni, rlc, no, outBuffer, outOffset ) {
+		function hufDecode( encodingTable, decodingTable, uInt8Array, inOffset, ni, rlc, no, outBuffer, outOffset ) {
 
 			let c = 0;
 			let lc = 0;
@@ -618,7 +618,7 @@ class EXRLoader extends DataTextureLoader {
 
 						lc -= pl.len;
 
-						getCode( pl.lit, rlc, c, lc, uInt8Array, inDataView, inOffset, outBuffer, outOffset, outBufferEndOffset );
+						getCode( pl.lit, rlc, c, lc, uInt8Array, inOffset, outBuffer, outOffset, outBufferEndOffset );
 
 						c = getCodeReturn.c;
 						lc = getCodeReturn.lc;
@@ -652,7 +652,7 @@ class EXRLoader extends DataTextureLoader {
 
 									lc -= l;
 
-									getCode( pl.p[ j ], rlc, c, lc, uInt8Array, inDataView, inOffset, outBuffer, outOffset, outBufferEndOffset );
+									getCode( pl.p[ j ], rlc, c, lc, uInt8Array, inOffset, outBuffer, outOffset, outBufferEndOffset );
 
 									c = getCodeReturn.c;
 									lc = getCodeReturn.lc;
@@ -690,7 +690,7 @@ class EXRLoader extends DataTextureLoader {
 
 					lc -= pl.len;
 
-					getCode( pl.lit, rlc, c, lc, uInt8Array, inDataView, inOffset, outBuffer, outOffset, outBufferEndOffset );
+					getCode( pl.lit, rlc, c, lc, uInt8Array, inOffset, outBuffer, outOffset, outBufferEndOffset );
 
 					c = getCodeReturn.c;
 					lc = getCodeReturn.lc;
@@ -734,7 +734,7 @@ class EXRLoader extends DataTextureLoader {
 
 			const ni = nCompressed - ( inOffset.value - initialInOffset );
 
-			hufUnpackEncTable( uInt8Array, inDataView, inOffset, ni, im, iM, freq );
+			hufUnpackEncTable( uInt8Array, inOffset, ni, im, iM, freq );
 
 			if ( nBits > 8 * ( nCompressed - ( inOffset.value - initialInOffset ) ) ) {
 
@@ -744,7 +744,7 @@ class EXRLoader extends DataTextureLoader {
 
 			hufBuildDecTable( freq, im, iM, hdec );
 
-			hufDecode( freq, hdec, uInt8Array, inDataView, inOffset, nBits, iM, nRaw, outBuffer, outOffset );
+			hufDecode( freq, hdec, uInt8Array, inOffset, nBits, iM, nRaw, outBuffer, outOffset );
 
 		}
 

+ 2 - 2
examples/jsm/loaders/LogLuvLoader.js

@@ -55,7 +55,7 @@ UTIF.decode = function ( buff, prm ) {
 	var bin = id == 'II' ? UTIF._binLE : UTIF._binBE;
 	bin.readUshort( data, offset ); offset += 2;
 
-	var ifdo = bin.readUint( data, offset ); offset += 4;
+	var ifdo = bin.readUint( data, offset );
 	var ifds = [];
 	while ( true ) {
 
@@ -339,7 +339,7 @@ UTIF._readIFD = function ( bin, data, offset, ifds, depth, prm ) {
 
 		ifd[ 't' + tag ] = arr;
 
-		if ( tag == 330 && ifd[ 't272' ] && ifd[ 't272' ][ 0 ] == 'DSLR-A100' ) { } else if ( tag == 330 || tag == 34665 || tag == 34853 || ( tag == 50740 && bin.readUshort( data, bin.readUint( arr, 0 ) ) < 300 ) || tag == 61440 ) {
+		if ( tag == 330 || tag == 34665 || tag == 34853 || ( tag == 50740 && bin.readUshort( data, bin.readUint( arr, 0 ) ) < 300 ) || tag == 61440 ) {
 
 			var oarr = tag == 50740 ? [ bin.readUint( arr, 0 ) ] : arr;
 			var subfd = [];

+ 1 - 2
examples/jsm/loaders/PCDLoader.js

@@ -141,8 +141,7 @@ class PCDLoader extends Loader {
 			if ( PCDheader.version !== null )
 				PCDheader.version = parseFloat( PCDheader.version[ 1 ] );
 
-			if ( PCDheader.fields !== null )
-				PCDheader.fields = PCDheader.fields[ 1 ].split( ' ' );
+			PCDheader.fields = ( PCDheader.fields !== null ) ? PCDheader.fields[ 1 ].split( ' ' ) : [];
 
 			if ( PCDheader.type !== null )
 				PCDheader.type = PCDheader.type[ 1 ].split( ' ' );

+ 13 - 10
examples/jsm/loaders/RGBMLoader.js

@@ -151,7 +151,7 @@ UPNG.toRGBA8 = function ( out ) {
 
 		frms.push( img.buffer.slice( 0 ) );
 
-		if ( frm.dispose == 0 ) {} else if ( frm.dispose == 1 ) UPNG._copyTile( empty, fw, fh, img, w, h, fx, fy, 0 );
+		if ( frm.dispose == 1 ) UPNG._copyTile( empty, fw, fh, img, w, h, fx, fy, 0 );
 		else if ( frm.dispose == 2 ) for ( var j = 0; j < len; j ++ ) img[ j ] = prev[ j ];
 
 	}
@@ -326,6 +326,7 @@ UPNG.decode = function ( buff ) {
 	var out = { tabs: {}, frames: [] };
 	var dd = new Uint8Array( data.length ), doff = 0;	 // put all IDAT data into it
 	var fd, foff = 0;	// frames
+	var text, keyw, bfr;
 
 	var mgck = [ 0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a ];
 	for ( var i = 0; i < 8; i ++ ) if ( data[ i ] != mgck[ i ] ) throw new Error( 'The input is not a PNG file!' );
@@ -387,12 +388,12 @@ UPNG.decode = function ( buff ) {
 
 			if ( out.tabs[ type ] == null ) out.tabs[ type ] = {};
 			var nz = bin.nextZero( data, offset );
-			var keyw = bin.readASCII( data, offset, nz - offset );
-			var text, tl = offset + len - nz - 1;
+			keyw = bin.readASCII( data, offset, nz - offset );
+			var tl = offset + len - nz - 1;
 			if ( type == 'tEXt' ) text = bin.readASCII( data, nz + 1, tl );
 			else {
 
-				var bfr = UPNG.decode._inflate( data.slice( nz + 2, nz + 2 + tl ) );
+				bfr = UPNG.decode._inflate( data.slice( nz + 2, nz + 2 + tl ) );
 				text = bin.readUTF8( bfr, 0, bfr.length );
 
 			}
@@ -404,17 +405,17 @@ UPNG.decode = function ( buff ) {
 			if ( out.tabs[ type ] == null ) out.tabs[ type ] = {};
 			var nz = 0, off = offset;
 			nz = bin.nextZero( data, off );
-			var keyw = bin.readASCII( data, off, nz - off ); off = nz + 1;
+			keyw = bin.readASCII( data, off, nz - off ); off = nz + 1;
 			var cflag = data[ off ]; off += 2;
 			nz = bin.nextZero( data, off );
 			bin.readASCII( data, off, nz - off ); off = nz + 1;
 			nz = bin.nextZero( data, off );
 			bin.readUTF8( data, off, nz - off ); off = nz + 1;
-			var text, tl = len - ( off - offset );
+			var tl = len - ( off - offset );
 			if ( cflag == 0 ) text = bin.readUTF8( data, off, tl );
 			else {
 
-				var bfr = UPNG.decode._inflate( data.slice( off, off + tl ) );
+				bfr = UPNG.decode._inflate( data.slice( off, off + tl ) );
 				text = bin.readUTF8( bfr, 0, bfr.length );
 
 			}
@@ -809,6 +810,8 @@ UPNG.decode._readInterlace = function ( data, out ) {
 		UPNG.decode._filterZero( data, out, di, sw, sh );
 
 		var y = 0, row = starting_row[ pass ];
+		var val;
+
 		while ( row < h ) {
 
 			var col = starting_col[ pass ];
@@ -818,21 +821,21 @@ UPNG.decode._readInterlace = function ( data, out ) {
 
 				if ( bpp == 1 ) {
 
-					var val = data[ cdi >> 3 ]; val = ( val >> ( 7 - ( cdi & 7 ) ) ) & 1;
+					val = data[ cdi >> 3 ]; val = ( val >> ( 7 - ( cdi & 7 ) ) ) & 1;
 					img[ row * bpl + ( col >> 3 ) ] |= ( val << ( 7 - ( ( col & 7 ) << 0 ) ) );
 
 				}
 
 				if ( bpp == 2 ) {
 
-					var val = data[ cdi >> 3 ]; val = ( val >> ( 6 - ( cdi & 7 ) ) ) & 3;
+					val = data[ cdi >> 3 ]; val = ( val >> ( 6 - ( cdi & 7 ) ) ) & 3;
 					img[ row * bpl + ( col >> 2 ) ] |= ( val << ( 6 - ( ( col & 3 ) << 1 ) ) );
 
 				}
 
 				if ( bpp == 4 ) {
 
-					var val = data[ cdi >> 3 ]; val = ( val >> ( 4 - ( cdi & 7 ) ) ) & 15;
+					val = data[ cdi >> 3 ]; val = ( val >> ( 4 - ( cdi & 7 ) ) ) & 15;
 					img[ row * bpl + ( col >> 1 ) ] |= ( val << ( 4 - ( ( col & 1 ) << 2 ) ) );
 
 				}

+ 0 - 3
examples/jsm/loaders/VTKLoader.js

@@ -346,8 +346,6 @@ class VTKLoader extends Loader {
 			let normals = [];
 			let indices = [];
 
-			// Going to make a big array of strings
-			const vtk = [];
 			let index = 0;
 
 			function findString( buffer, start ) {
@@ -386,7 +384,6 @@ class VTKLoader extends Loader {
 
 				} else if ( line.indexOf( 'POINTS' ) === 0 ) {
 
-					vtk.push( line );
 					// Add the points
 					const numberOfPoints = parseInt( line.split( ' ' )[ 1 ], 10 );
 

+ 2 - 2
examples/jsm/renderers/SVGRenderer.js

@@ -227,7 +227,7 @@ class SVGRenderer {
 
 					if ( _clipBox.intersectsBox( _elemBox ) === true ) {
 
-						renderLine( _v1, _v2, element, material );
+						renderLine( _v1, _v2, material );
 
 					}
 
@@ -397,7 +397,7 @@ class SVGRenderer {
 
 		}
 
-		function renderLine( v1, v2, element, material ) {
+		function renderLine( v1, v2, material ) {
 
 			const path = 'M' + convert( v1.positionScreen.x ) + ',' + convert( v1.positionScreen.y ) + 'L' + convert( v2.positionScreen.x ) + ',' + convert( v2.positionScreen.y );
 

+ 0 - 2
manual/examples/resources/lut-reader.js

@@ -87,12 +87,10 @@ export function parseCSP(str) {
   }
 
   // read ranges
-  const ranges = [];
   for (let i = 0; i < 3; ++i) {
     ++lineNdx;
     const input = splitToNumbers(lines[lineNdx++]);
     const output = splitToNumbers(lines[lineNdx++]);
-    ranges.push({input, output});
     if (input.length !== 2 || output.length !== 2 ||
         input[0] !== 0 || input[1] !==  1 ||
         output[0] !== 0 || output[1] !== 1) {

+ 37 - 37
test/unit/utils/qunit-utils.js

@@ -31,7 +31,7 @@ QUnit.assert.fail = function ( message ) {
 
 QUnit.assert.numEqual = function ( actual, expected, message ) {
 
-	var diff = Math.abs( actual - expected );
+	const diff = Math.abs( actual - expected );
 	message = message || ( actual + ' should be equal to ' + expected );
 	this.pushResult( {
 		result: diff < 0.1,
@@ -44,9 +44,9 @@ QUnit.assert.numEqual = function ( actual, expected, message ) {
 
 QUnit.assert.equalKey = function ( obj, ref, key ) {
 
-	var actual = obj[ key ];
-	var expected = ref[ key ];
-	var message = actual + ' should be equal to ' + expected + ' for key "' + key + '"';
+	const actual = obj[ key ];
+	const expected = ref[ key ];
+	const message = actual + ' should be equal to ' + expected + ' for key "' + key + '"';
 	this.pushResult( {
 		result: actual == expected,
 		actual: actual,
@@ -58,10 +58,10 @@ QUnit.assert.equalKey = function ( obj, ref, key ) {
 
 QUnit.assert.smartEqual = function ( actual, expected, message ) {
 
-	var cmp = new SmartComparer();
+	const cmp = new SmartComparer();
 
-	var same = cmp.areEqual( actual, expected );
-	var msg = cmp.getDiagnostic() || message;
+	const same = cmp.areEqual( actual, expected );
+	const msg = cmp.getDiagnostic() || message;
 
 	this.pushResult( {
 		result: same,
@@ -79,11 +79,11 @@ QUnit.assert.smartEqual = function ( actual, expected, message ) {
 function checkGeometryClone( geom ) {
 
 	// Clone
-	var copy = geom.clone();
+	const copy = geom.clone();
 	QUnit.assert.notEqual( copy.uuid, geom.uuid, 'clone uuid should differ from original' );
 	QUnit.assert.notEqual( copy.id, geom.id, 'clone id should differ from original' );
 
-	var differingProp = getDifferingProp( geom, copy );
+	let differingProp = getDifferingProp( geom, copy );
 	QUnit.assert.ok( differingProp === undefined, 'properties are equal' );
 
 	differingProp = getDifferingProp( copy, geom );
@@ -96,14 +96,14 @@ function checkGeometryClone( geom ) {
 
 function getDifferingProp( geometryA, geometryB ) {
 
-	var geometryKeys = Object.keys( geometryA );
-	var cloneKeys = Object.keys( geometryB );
+	const geometryKeys = Object.keys( geometryA );
+	const cloneKeys = Object.keys( geometryB );
 
-	var differingProp = undefined;
+	let differingProp = undefined;
 
-	for ( var i = 0, l = geometryKeys.length; i < l; i ++ ) {
+	for ( let i = 0, l = geometryKeys.length; i < l; i ++ ) {
 
-		var key = geometryKeys[ i ];
+		const key = geometryKeys[ i ];
 
 		if ( cloneKeys.indexOf( key ) < 0 ) {
 
@@ -126,7 +126,7 @@ function checkGeometryJsonWriting( geom, json ) {
 	QUnit.assert.equalKey( geom, json, 'uuid' );
 	QUnit.assert.equal( json.id, undefined, 'should not persist id' );
 
-	var params = geom.parameters;
+	const params = geom.parameters;
 	if ( ! params ) {
 
 		return;
@@ -134,8 +134,8 @@ function checkGeometryJsonWriting( geom, json ) {
 	}
 
 	// All parameters from geometry should be persisted.
-	var keys = Object.keys( params );
-	for ( var i = 0, l = keys.length; i < l; i ++ ) {
+	let keys = Object.keys( params );
+	for ( let i = 0, l = keys.length; i < l; i ++ ) {
 
 		QUnit.assert.equalKey( params, json, keys[ i ] );
 
@@ -143,11 +143,11 @@ function checkGeometryJsonWriting( geom, json ) {
 
 	// All parameters from json should be transfered to the geometry.
 	// json is flat. Ignore first level json properties that are not parameters.
-	var notParameters = [ 'metadata', 'uuid', 'type' ];
-	var keys = Object.keys( json );
-	for ( var i = 0, l = keys.length; i < l; i ++ ) {
+	const notParameters = [ 'metadata', 'uuid', 'type' ];
+	keys = Object.keys( json );
+	for ( let i = 0, l = keys.length; i < l; i ++ ) {
 
-		var key = keys[ i ];
+		const key = keys[ i ];
 		if ( notParameters.indexOf( key ) === - 1 ) QUnit.assert.equalKey( params, json, key );
 
 	}
@@ -157,18 +157,18 @@ function checkGeometryJsonWriting( geom, json ) {
 // Check parsing and reconstruction of json geometry
 function checkGeometryJsonReading( json, geom ) {
 
-	var wrap = [ json ];
+	const wrap = [ json ];
 
-	var loader = new ObjectLoader();
-	var output = loader.parseGeometries( wrap );
+	const loader = new ObjectLoader();
+	const output = loader.parseGeometries( wrap );
 
 	QUnit.assert.ok( output[ geom.uuid ], 'geometry matching source uuid not in output' );
 	// QUnit.assert.smartEqual( output[ geom.uuid ], geom, 'Reconstruct geometry from ObjectLoader' );
 
-	var differing = getDifferingProp( output[ geom.uuid ], geom );
+	const differing = getDifferingProp( output[ geom.uuid ], geom );
 	if ( differing ) console.log( differing );
 
-	var differingProp = getDifferingProp( output[ geom.uuid ], geom );
+	let differingProp = getDifferingProp( output[ geom.uuid ], geom );
 	QUnit.assert.ok( differingProp === undefined, 'properties are equal' );
 
 	differingProp = getDifferingProp( geom, output[ geom.uuid ] );
@@ -179,7 +179,7 @@ function checkGeometryJsonReading( json, geom ) {
 // Verify geom -> json -> geom
 function checkGeometryJsonRoundtrip( geom ) {
 
-	var json = geom.toJSON();
+	const json = geom.toJSON();
 	checkGeometryJsonWriting( geom, json );
 	checkGeometryJsonReading( json, geom );
 
@@ -189,9 +189,9 @@ function checkGeometryJsonRoundtrip( geom ) {
 // Run common geometry tests.
 function runStdGeometryTests( assert, geometries ) {
 
-	for ( var i = 0, l = geometries.length; i < l; i ++ ) {
+	for ( let i = 0, l = geometries.length; i < l; i ++ ) {
 
-		var geom = geometries[ i ];
+		const geom = geometries[ i ];
 
 		// Clone
 		checkGeometryClone( geom );
@@ -210,9 +210,9 @@ function runStdGeometryTests( assert, geometries ) {
 // Run common light tests.
 function runStdLightTests( assert, lights ) {
 
-	for ( var i = 0, l = lights.length; i < l; i ++ ) {
+	for ( let i = 0, l = lights.length; i < l; i ++ ) {
 
-		var light = lights[ i ];
+		const light = lights[ i ];
 
 		// copy and clone
 		checkLightCopyClone( assert, light );
@@ -233,7 +233,7 @@ function runStdLightTests( assert, lights ) {
 function checkLightCopyClone( assert, light ) {
 
 	// copy
-	var newLight = new light.constructor( 0xc0ffee );
+	const newLight = new light.constructor( 0xc0ffee );
 	newLight.copy( light );
 
 	QUnit.assert.notEqual( newLight.uuid, light.uuid, 'Copied light\'s UUID differs from original' );
@@ -247,7 +247,7 @@ function checkLightCopyClone( assert, light ) {
 	);
 
 	// Clone
-	var clone = light.clone(); // better get a new var
+	const clone = light.clone(); // better get a new var
 	QUnit.assert.notEqual( clone.uuid, light.uuid, 'Cloned light\'s UUID differs from original' );
 	QUnit.assert.notEqual( clone.id, light.id, 'Clone light\'s id differs from original' );
 	QUnit.assert.smartEqual( clone, light, 'Clone light is equal to original' );
@@ -272,7 +272,7 @@ function checkLightJsonWriting( assert, light, json ) {
 
 	assert.equal( json.metadata.version, '4.5', 'check metadata version' );
 
-	var object = json.object;
+	const object = json.object;
 	assert.equalKey( light, object, 'type' );
 	assert.equalKey( light, object, 'uuid' );
 	assert.equal( object.id, undefined, 'should not persist id' );
@@ -282,8 +282,8 @@ function checkLightJsonWriting( assert, light, json ) {
 // Check parsing and reconstruction of json Light
 function checkLightJsonReading( assert, json, light ) {
 
-	var loader = new ObjectLoader();
-	var outputLight = loader.parse( json );
+	const loader = new ObjectLoader();
+	const outputLight = loader.parse( json );
 
 	assert.smartEqual( outputLight, light, 'Reconstruct Light from ObjectLoader' );
 
@@ -292,7 +292,7 @@ function checkLightJsonReading( assert, json, light ) {
 // Verify light -> json -> light
 function checkLightJsonRoundtrip( assert, light ) {
 
-	var json = light.toJSON();
+	const json = light.toJSON();
 	checkLightJsonWriting( assert, light, json );
 	checkLightJsonReading( assert, json, light );