Merge pull request #18518 from juliendargelos/css3object-generic-renderer

Add generic Renderer to Object3D and use it when extending for css renderers

examples/jsm/renderers/CSS2DRenderer.d.ts

@@ -9,8 +9,8 @@ export class CSS2DObject extends Object3D {
 	constructor( element: HTMLElement );
 	element: HTMLElement;
 
-	onBeforeRender: (renderer: CSS2DRenderer, scene: Scene, camera: Camera) => void;
- 	onAfterRender: (renderer: CSS2DRenderer, scene: Scene, camera: Camera) => void;
+	onBeforeRender: <Renderer = CSS2DRenderer>(renderer: Renderer, scene: Scene, camera: Camera) => void;
+ 	onAfterRender: <Renderer = CSS2DRenderer>(renderer: Renderer, scene: Scene, camera: Camera) => void;
 
 }
 

examples/jsm/renderers/CSS3DRenderer.d.ts

@@ -9,8 +9,8 @@ export class CSS3DObject extends Object3D {
 	constructor( element: HTMLElement );
 	element: HTMLElement;
 
-	onBeforeRender: (renderer: CSS3DRenderer, scene: Scene, camera: Camera) => void;
-	onAfterRender: (renderer: CSS3DRenderer, scene: Scene, camera: Camera) => void;
+	onBeforeRender: <Renderer = CSS3DRenderer>(renderer: Renderer, scene: Scene, camera: Camera) => void;
+	onAfterRender: <Renderer = CSS3DRenderer>(renderer: Renderer, scene: Scene, camera: Camera) => void;
 
 }
 

src/core/Object3D.d.ts

@@ -153,8 +153,8 @@ export class Object3D extends EventDispatcher {
 	/**
 	 * Calls before rendering object
 	 */
-	onBeforeRender: (
-		renderer: WebGLRenderer,
+	onBeforeRender: <Renderer = WebGLRenderer>(
+		renderer: Renderer,
 		scene: Scene,
 		camera: Camera,
 		geometry: Geometry | BufferGeometry,
@@ -165,8 +165,8 @@ export class Object3D extends EventDispatcher {
 	/**
 	 * Calls after rendering object
 	 */
-	onAfterRender: (
-		renderer: WebGLRenderer,
+	onAfterRender: <Renderer = WebGLRenderer>(
+		renderer: Renderer,
 		scene: Scene,
 		camera: Camera,
 		geometry: Geometry | BufferGeometry,