首页 发现 帮助
登录
javascript
/
three.js
镜像自地址 https://github.com/tazdij/three.js.git
2
0
派生 0
文件 工单管理 0 Wiki
浏览代码

Clean up lgtm alerts.

Mugen87 5 年之前
父节点
4b10afa503
当前提交
20a2d146ac
共有 6 个文件被更改，包括 4 次插入 和 42 次删除
合并视图 显示文件统计
  1. 0 1
      examples/webgl_buffergeometry_instancing_interleaved.html
  2. 1 11
      examples/webgl_furnace_test.html
  3. 1 8
      examples/webgl_materials_envmaps_exr.html
  4. 1 1
      examples/webgl_materials_nodes.html
  5. 0 10
      examples/webgl_materials_variations_physical.html
  6. 1 11
      src/renderers/WebGLRenderer.js

+ 0 - 1
examples/webgl_buffergeometry_instancing_interleaved.html
查看文件 

@@ -33,7 +33,6 @@
 
 
 
 		var container, stats;
 
 		var container, stats;
 
 		var camera, scene, renderer, mesh;
 
 		var camera, scene, renderer, mesh;
 
-		var offsetAttribute, orientationAttribute;
 
 
 
 		var instances = 5000;
 
 		var instances = 5000;
 
 		var lastTime = 0;
 
 		var lastTime = 0;

+ 1 - 11
examples/webgl_furnace_test.html
查看文件 

@@ -5,15 +5,6 @@
 
 		<meta charset="utf-8">
 
 		<meta charset="utf-8">
 
 		<meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0">
 
 		<meta name="viewport" content="width=device-width, user-scalable=no, minimum-scale=1.0, maximum-scale=1.0">
 
 		<link type="text/css" rel="stylesheet" href="main.css">
 
 		<link type="text/css" rel="stylesheet" href="main.css">
 
-		<style>
 
-			body {
 
-				color: #444;
 
-			}
 
-			a {
 
-				color: #44f;
 
-			}
 
-		</style>
 
-
 
 	</head>
 
 	</head>
 
 	<body>
 
 	<body>
 
 
 
@@ -30,8 +21,7 @@
 
 
 
 			import { PMREMGenerator } from './jsm/pmrem/PMREMGenerator.js';
 
 			import { PMREMGenerator } from './jsm/pmrem/PMREMGenerator.js';
 
 
 
-			var scene, camera, renderer, envMap, radianceMap;
 
-			var right = 8;
 
+			var scene, camera, renderer, radianceMap;
 
 
 
 			function init() {
 
 			function init() {

+ 1 - 8
examples/webgl_materials_envmaps_exr.html
查看文件 

@@ -77,20 +77,13 @@
 
 
 
 					pmremGenerator.dispose();
 
 					pmremGenerator.dispose();
 
 
 
-				}
 
+				};
 
 
 
 				new EXRLoader()
 
 				new EXRLoader()
 
 					.setDataType( THREE.FloatType )
 
 					.setDataType( THREE.FloatType )
 
 					.load( 'textures/piz_compressed.exr', function ( texture ) {
 
 					.load( 'textures/piz_compressed.exr', function ( texture ) {
 
 
 
-						var options = {
 
-							generateMipmaps: false,
 
-							minFilter: THREE.LinearFilter,
 
-							magFilter: THREE.LinearFilter
 
-						};
 
-
 
 						exrCubeRenderTarget = pmremGenerator.fromEquirectangular( texture );
 
 						exrCubeRenderTarget = pmremGenerator.fromEquirectangular( texture );
 
-
 
 						exrBackground = exrCubeRenderTarget.texture;
 
 						exrBackground = exrCubeRenderTarget.texture;
 
 
 
 						texture.dispose();
 
 						texture.dispose();

+ 1 - 1
examples/webgl_materials_nodes.html
查看文件 

@@ -69,7 +69,7 @@
 
 
 
 			}
 
 			}
 
 
 
-			var premTexture, pmremCube, pmremGenerator, premSize = 1024;
 
+			var premTexture, pmremCube;
 
 
 
 			function updatePREM( textureCube ) {
 
 			function updatePREM( textureCube ) {

+ 0 - 10
examples/webgl_materials_variations_physical.html
查看文件 

@@ -45,16 +45,6 @@
 
 
 
 				//
 
 				//
 
 
 
-				var genCubeUrls = function ( prefix, postfix ) {
 
-
 
-					return [
 
-						prefix + 'px' + postfix, prefix + 'nx' + postfix,
 
-						prefix + 'py' + postfix, prefix + 'ny' + postfix,
 
-						prefix + 'pz' + postfix, prefix + 'nz' + postfix
 
-					];
 
-
 
-				};
 
-
 
 				scene = new THREE.Scene();
 
 				scene = new THREE.Scene();
 
 
 
 				var hdrCubeRenderTarget = null;
 
 				var hdrCubeRenderTarget = null;

+ 1 - 11
src/renderers/WebGLRenderer.js
查看文件 

@@ -782,17 +782,7 @@ function WebGLRenderer( parameters ) {
 
 
 
 		//
 
 		//
 
 
 
-		var dataCount = Infinity;
 
-
 
-		if ( index !== null ) {
 
-
 
-			dataCount = index.count;
 
-
 
-		} else if ( position !== undefined ) {
 
-
 
-			dataCount = position.count;
 
-
 
-		}
 
+		var dataCount = ( index !== null ) ? index.count : position.count;
 
 
 
 		var rangeStart = geometry.drawRange.start * rangeFactor;
 
 		var rangeStart = geometry.drawRange.start * rangeFactor;
 
 		var rangeCount = geometry.drawRange.count * rangeFactor;
 
 		var rangeCount = geometry.drawRange.count * rangeFactor;