Browse Source

Fixed some lgtm alerts.

Mr.doob 8 years ago
parent
commit
270fcb4ac1
2 changed files with 10 additions and 15 deletions
  1. 9 14
      examples/js/loaders/PCDLoader.js
  2. 1 1
      examples/webgl_loader_collada_skinning.html

+ 9 - 14
examples/js/loaders/PCDLoader.js

@@ -48,7 +48,7 @@ THREE.PCDLoader.prototype = {
 
 
 			var text = '';
 			var text = '';
 
 
-			for ( var i = 0, il = data.byteLength; i < il; i ++ ) {
+			for ( var i = 0, l = data.byteLength; i < l; i ++ ) {
 
 
 				text += String.fromCharCode( charArray[ i ] );
 				text += String.fromCharCode( charArray[ i ] );
 
 
@@ -64,8 +64,6 @@ THREE.PCDLoader.prototype = {
 			var result1 = data.search( /[\r\n]DATA\s(\S*)\s/i );
 			var result1 = data.search( /[\r\n]DATA\s(\S*)\s/i );
 			var result2 = /[\r\n]DATA\s(\S*)\s/i.exec( data.substr( result1 - 1 ) );
 			var result2 = /[\r\n]DATA\s(\S*)\s/i.exec( data.substr( result1 - 1 ) );
 
 
-			var i, l;
-
 			PCDheader.data = result2[ 1 ];
 			PCDheader.data = result2[ 1 ];
 			PCDheader.headerLen = result2[ 0 ].length + result1;
 			PCDheader.headerLen = result2[ 0 ].length + result1;
 			PCDheader.str = data.substr( 0, PCDheader.headerLen );
 			PCDheader.str = data.substr( 0, PCDheader.headerLen );
@@ -134,7 +132,7 @@ THREE.PCDLoader.prototype = {
 
 
 				PCDheader.count = [];
 				PCDheader.count = [];
 
 
-				for ( i = 0, l = PCDheader.fields.length; i < l; i ++ ) {
+				for ( var i = 0, l = PCDheader.fields.length; i < l; i ++ ) {
 
 
 					PCDheader.count.push( 1 );
 					PCDheader.count.push( 1 );
 
 
@@ -146,7 +144,7 @@ THREE.PCDLoader.prototype = {
 
 
 			var sizeSum = 0;
 			var sizeSum = 0;
 
 
-			for ( i = 0, l = PCDheader.fields.length; i < l; i ++ ) {
+			for ( var i = 0, l = PCDheader.fields.length; i < l; i ++ ) {
 
 
 				if ( PCDheader.data === 'ascii' ) {
 				if ( PCDheader.data === 'ascii' ) {
 
 
@@ -169,9 +167,6 @@ THREE.PCDLoader.prototype = {
 
 
 		}
 		}
 
 
-		var dataView, offset;
-		var i, l;
-
 		var textData = binarryToStr( data );
 		var textData = binarryToStr( data );
 
 
 		// parse header (always ascii format)
 		// parse header (always ascii format)
@@ -188,11 +183,11 @@ THREE.PCDLoader.prototype = {
 
 
 		if ( PCDheader.data === 'ascii' ) {
 		if ( PCDheader.data === 'ascii' ) {
 
 
-			offset = PCDheader.offset;
+			var offset = PCDheader.offset;
 			var pcdData = textData.substr( PCDheader.headerLen );
 			var pcdData = textData.substr( PCDheader.headerLen );
 			var lines = pcdData.split( '\n' );
 			var lines = pcdData.split( '\n' );
 
 
-			for ( i = 0, l = lines.length; i < l; i ++ ) {
+			for ( var i = 0, l = lines.length; i < l; i ++ ) {
 
 
 				var line = lines[ i ].split( ' ' );
 				var line = lines[ i ].split( ' ' );
 
 
@@ -207,7 +202,7 @@ THREE.PCDLoader.prototype = {
 				if ( offset.rgb !== undefined ) {
 				if ( offset.rgb !== undefined ) {
 
 
 					var c = new Float32Array( [ parseFloat( line[ offset.rgb ] ) ] );
 					var c = new Float32Array( [ parseFloat( line[ offset.rgb ] ) ] );
-					dataview = new DataView( c.buffer, 0 );
+					var dataview = new DataView( c.buffer, 0 );
 					color.push( dataview.getUint8( 0 ) / 255.0 );
 					color.push( dataview.getUint8( 0 ) / 255.0 );
 					color.push( dataview.getUint8( 1 ) / 255.0 );
 					color.push( dataview.getUint8( 1 ) / 255.0 );
 					color.push( dataview.getUint8( 2 ) / 255.0 );
 					color.push( dataview.getUint8( 2 ) / 255.0 );
@@ -237,10 +232,10 @@ THREE.PCDLoader.prototype = {
 
 
 		if ( PCDheader.data === 'binary' ) {
 		if ( PCDheader.data === 'binary' ) {
 
 
-			dataview = new DataView( data, PCDheader.headerLen );
-			offset = PCDheader.offset;
+			var dataview = new DataView( data, PCDheader.headerLen );
+			var offset = PCDheader.offset;
 
 
-			for ( i = 0, row = 0; i < PCDheader.points; i ++, row += PCDheader.rowSize ) {
+			for ( var i = 0, row = 0; i < PCDheader.points; i ++, row += PCDheader.rowSize ) {
 
 
 				if ( offset.x !== undefined ) {
 				if ( offset.x !== undefined ) {
 
 

+ 1 - 1
examples/webgl_loader_collada_skinning.html

@@ -46,7 +46,7 @@
 
 
 			if ( ! Detector.webgl ) Detector.addGetWebGLMessage();
 			if ( ! Detector.webgl ) Detector.addGetWebGLMessage();
 
 
-			var container, stats, clock;
+			var container, stats, clock, controls;
 			var camera, scene, renderer, mixer;
 			var camera, scene, renderer, mixer;
 
 
 			init();
 			init();