Michael Herzog 3 роки тому
батько
коміт
2a9f44140e

+ 1 - 1
src/renderers/WebGLRenderer.js

@@ -305,7 +305,7 @@ function WebGLRenderer( parameters = {} ) {
 		clipping = new WebGLClipping( properties );
 		programCache = new WebGLPrograms( _this, cubemaps, cubeuvmaps, extensions, capabilities, bindingStates, clipping );
 		materials = new WebGLMaterials( properties );
-		renderLists = new WebGLRenderLists( properties );
+		renderLists = new WebGLRenderLists();
 		renderStates = new WebGLRenderStates( extensions, capabilities );
 		background = new WebGLBackground( _this, cubemaps, state, objects, _premultipliedAlpha );
 		shadowMap = new WebGLShadowMap( _this, objects, capabilities );

+ 4 - 4
src/renderers/webgl/WebGLRenderLists.js

@@ -47,7 +47,7 @@ function reversePainterSortStable( a, b ) {
 }
 
 
-function WebGLRenderList( properties ) {
+function WebGLRenderList() {
 
 	const renderItems = [];
 	let renderItemsIndex = 0;
@@ -188,7 +188,7 @@ function WebGLRenderList( properties ) {
 
 }
 
-function WebGLRenderLists( properties ) {
+function WebGLRenderLists() {
 
 	let lists = new WeakMap();
 
@@ -198,14 +198,14 @@ function WebGLRenderLists( properties ) {
 
 		if ( lists.has( scene ) === false ) {
 
-			list = new WebGLRenderList( properties );
+			list = new WebGLRenderList();
 			lists.set( scene, [ list ] );
 
 		} else {
 
 			if ( renderCallDepth >= lists.get( scene ).length ) {
 
-				list = new WebGLRenderList( properties );
+				list = new WebGLRenderList();
 				lists.get( scene ).push( list );
 
 			} else {

+ 9 - 17
test/unit/src/renderers/webgl/WebGLRenderLists.tests.js

@@ -1,7 +1,6 @@
 /* global QUnit */
 
 import { WebGLRenderLists, WebGLRenderList } from '../../../../../src/renderers/webgl/WebGLRenderLists';
-import { WebGLProperties } from '../../../../../src/renderers/webgl/WebGLProperties';
 import { Scene } from '../../../../../src/scenes/Scene';
 
 export default QUnit.module( 'Renderers', () => {
@@ -11,20 +10,18 @@ export default QUnit.module( 'Renderers', () => {
 		QUnit.module( 'WebGLRenderLists', () => {
 
 			// PUBLIC STUFF
-			QUnit.test( "get", ( assert ) => {
+			QUnit.test( 'get', ( assert ) => {
 
-				var properties = new WebGLProperties();
-
-				var renderLists = new WebGLRenderLists( properties );
+				var renderLists = new WebGLRenderLists();
 				var sceneA = new Scene();
 				var sceneB = new Scene();
 
 				var listA = renderLists.get( sceneA );
 				var listB = renderLists.get( sceneB );
 
-				assert.propEqual( listA, new WebGLRenderList( properties ), "listA is type of WebGLRenderList." );
-				assert.propEqual( listB, new WebGLRenderList( properties ), "listB is type of WebGLRenderList." );
-				assert.ok( listA !== listB, "Render lists are different." );
+				assert.propEqual( listA, new WebGLRenderList(), 'listA is type of WebGLRenderList.' );
+				assert.propEqual( listB, new WebGLRenderList(), 'listB is type of WebGLRenderList.' );
+				assert.ok( listA !== listB, 'Render lists are different.' );
 
 
 			} );
@@ -36,8 +33,7 @@ export default QUnit.module( 'Renderers', () => {
 
 			QUnit.test( 'init', ( assert ) => {
 
-				var properties = new WebGLProperties();
-				var list = new WebGLRenderList( properties );
+				var list = new WebGLRenderList();
 
 				assert.ok( list.transparent.length === 0, 'Transparent list defaults to length 0.' );
 				assert.ok( list.opaque.length === 0, 'Opaque list defaults to length 0.' );
@@ -57,9 +53,7 @@ export default QUnit.module( 'Renderers', () => {
 
 			QUnit.test( 'push', ( assert ) => {
 
-				var properties = new WebGLProperties();
-
-				var list = new WebGLRenderList( properties );
+				var list = new WebGLRenderList();
 				var objA = { id: 'A', renderOrder: 0 };
 				var matA = { transparent: true };
 				var geoA = {};
@@ -152,8 +146,7 @@ export default QUnit.module( 'Renderers', () => {
 
 			QUnit.test( 'unshift', ( assert ) => {
 
-				var properties = new WebGLProperties();
-				var list = new WebGLRenderList( properties );
+				var list = new WebGLRenderList();
 				var objA = { id: 'A', renderOrder: 0 };
 				var matA = { transparent: true };
 				var geoA = {};
@@ -247,8 +240,7 @@ export default QUnit.module( 'Renderers', () => {
 
 			QUnit.test( 'sort', ( assert ) => {
 
-				var properties = new WebGLProperties();
-				var list = new WebGLRenderList( properties );
+				var list = new WebGLRenderList();
 				var items = [ { id: 4 }, { id: 5 }, { id: 2 }, { id: 3 } ];
 
 				items.forEach( item => {