Pārlūkot izejas kodu

ColladaLoader: Clean up.

Mr.doob 3 gadi atpakaļ
vecāks
revīzija
418d19b82b
1 mainītis faili ar 9 papildinājumiem un 7 dzēšanām
  1. 9 7
      examples/jsm/loaders/ColladaLoader.js

+ 9 - 7
examples/jsm/loaders/ColladaLoader.js

@@ -10,6 +10,7 @@ import {
 	Euler,
 	Euler,
 	FileLoader,
 	FileLoader,
 	Float32BufferAttribute,
 	Float32BufferAttribute,
+	FrontSide,
 	Group,
 	Group,
 	Line,
 	Line,
 	LineBasicMaterial,
 	LineBasicMaterial,
@@ -33,6 +34,7 @@ import {
 	SkinnedMesh,
 	SkinnedMesh,
 	SpotLight,
 	SpotLight,
 	TextureLoader,
 	TextureLoader,
+	Vector2,
 	Vector3,
 	Vector3,
 	VectorKeyframeTrack
 	VectorKeyframeTrack
 } from '../../../build/three.module.js';
 } from '../../../build/three.module.js';
@@ -1466,6 +1468,7 @@ class ColladaLoader extends Loader {
 		}
 		}
 
 
 		function parseEffectExtraTechniqueBump( xml ) {
 		function parseEffectExtraTechniqueBump( xml ) {
+
 			var data = {};
 			var data = {};
 
 
 			for ( var i = 0, l = xml.childNodes.length; i < l; i ++ ) {
 			for ( var i = 0, l = xml.childNodes.length; i < l; i ++ ) {
@@ -1554,7 +1557,6 @@ class ColladaLoader extends Loader {
 
 
 			const effect = getEffect( data.url );
 			const effect = getEffect( data.url );
 			const technique = effect.profile.technique;
 			const technique = effect.profile.technique;
-			const extra = effect.profile.extra;
 
 
 			let material;
 			let material;
 
 
@@ -1751,21 +1753,21 @@ class ColladaLoader extends Loader {
 
 
 			if ( technique.extra !== undefined && technique.extra.technique !== undefined ) {
 			if ( technique.extra !== undefined && technique.extra.technique !== undefined ) {
 
 
-				let techniques = technique.extra.technique;
+				const techniques = technique.extra.technique;
 
 
-				for ( let k in techniques ) {
+				for ( const k in techniques ) {
 
 
-					let v = techniques[k];
+					const v = techniques[ k ];
 
 
-					switch (k) {
+					switch ( k ) {
 
 
 						case 'double_sided':
 						case 'double_sided':
-							material.side = ( v === 1 ? THREE.DoubleSide : THREE.FrontSide );
+							material.side = ( v === 1 ? DoubleSide : FrontSide );
 							break;
 							break;
 
 
 						case 'bump':
 						case 'bump':
 							material.normalMap = getTexture( v.texture );
 							material.normalMap = getTexture( v.texture );
-							material.normalScale = new THREE.Vector2( 1, 1 );
+							material.normalScale = new Vector2( 1, 1 );
 							break;
 							break;
 
 
 					}
 					}