Browse Source

Merge pull request #4810 from srifqi/patch-1

Update BoxHelper.js
Mr.doob 11 years ago
parent
commit
5e1af76601
1 changed files with 19 additions and 17 deletions
  1. 19 17
      src/extras/helpers/BoxHelper.js

+ 19 - 17
src/extras/helpers/BoxHelper.js

@@ -25,23 +25,25 @@ THREE.BoxHelper = function ( object ) {
 
 	// TODO: Wouldn't be nice if Line had .segments?
 
-	var geometry = new THREE.Geometry();
-	geometry.vertices.push(
-		vertices[ 0 ], vertices[ 1 ],
-		vertices[ 1 ], vertices[ 2 ],
-		vertices[ 2 ], vertices[ 3 ],
-		vertices[ 3 ], vertices[ 0 ],
-
-		vertices[ 4 ], vertices[ 5 ],
-		vertices[ 5 ], vertices[ 6 ],
-		vertices[ 6 ], vertices[ 7 ],
-		vertices[ 7 ], vertices[ 4 ],
-
-		vertices[ 0 ], vertices[ 4 ],
-		vertices[ 1 ], vertices[ 5 ],
-		vertices[ 2 ], vertices[ 6 ],
-		vertices[ 3 ], vertices[ 7 ]
-	);
+	var geometry = new THREE.BufferGeometry();
+	geometry.addAttribute( 'position', new THREE.BufferAttribute(
+		new Float32Array([
+			vertices[ 0 ], vertices[ 1 ],
+			vertices[ 1 ], vertices[ 2 ],
+			vertices[ 2 ], vertices[ 3 ],
+			vertices[ 3 ], vertices[ 0 ],
+
+			vertices[ 4 ], vertices[ 5 ],
+			vertices[ 5 ], vertices[ 6 ],
+			vertices[ 6 ], vertices[ 7 ],
+			vertices[ 7 ], vertices[ 4 ],
+
+			vertices[ 0 ], vertices[ 4 ],
+			vertices[ 1 ], vertices[ 5 ],
+			vertices[ 2 ], vertices[ 6 ],
+			vertices[ 3 ], vertices[ 7 ]
+		])
+	, 3 ) );
 
 	THREE.Line.call( this, geometry, new THREE.LineBasicMaterial( { color: 0xffff00 } ), THREE.LinePieces );