Merge pull request #18974 from webglzhang/dev

LineGeometry, LineSegmentsGeometry: Fix Bugs

examples/js/lines/LineGeometry.js

@@ -77,7 +77,7 @@ THREE.LineGeometry.prototype = Object.assign( Object.create( THREE.LineSegmentsG
 
 		} else if ( geometry.isBufferGeometry ) {
 
-			this.setPositions( geometry.position.array ); // assumes non-indexed
+			this.setPositions( geometry.attributes.position.array ); // assumes non-indexed
 
 		}
 

examples/js/lines/LineSegmentsGeometry.js

@@ -133,7 +133,7 @@ THREE.LineSegmentsGeometry.prototype = Object.assign( Object.create( THREE.Insta
 
 	},
 
-	fromLineSegements: function ( lineSegments ) {
+	fromLineSegments: function ( lineSegments ) {
 
 		var geometry = lineSegments.geometry;
 
@@ -143,7 +143,7 @@ THREE.LineSegmentsGeometry.prototype = Object.assign( Object.create( THREE.Insta
 
 		} else if ( geometry.isBufferGeometry ) {
 
-			this.setPositions( geometry.position.array ); // assumes non-indexed
+			this.setPositions( geometry.attributes.position.array ); // assumes non-indexed
 
 		}
 

examples/jsm/lines/LineGeometry.js

@@ -80,7 +80,7 @@ LineGeometry.prototype = Object.assign( Object.create( LineSegmentsGeometry.prot
 
 		} else if ( geometry.isBufferGeometry ) {
 
-			this.setPositions( geometry.position.array ); // assumes non-indexed
+			this.setPositions( geometry.attributes.position.array ); // assumes non-indexed
 
 		}
 

examples/jsm/lines/LineSegmentsGeometry.d.ts

@@ -16,7 +16,7 @@ export class LineSegmentsGeometry extends InstancedBufferGeometry {
 	computeBoundingBox(): void;
 	computeBoundingSphere(): void;
 	fromEdgesGeometry( geometry: WireframeGeometry ): this;
-	fromLineSegements( lineSegments: LineSegments ): this;
+	fromLineSegments( lineSegments: LineSegments ): this;
 	fromMesh( mesh: Mesh ): this;
 	fromWireframeGeometry( geometry: EdgesGeometry ): this;
 	setColors( array: number[] | Float32Array ): this;

examples/jsm/lines/LineSegmentsGeometry.js

@@ -144,7 +144,7 @@ LineSegmentsGeometry.prototype = Object.assign( Object.create( InstancedBufferGe
 
 	},
 
-	fromLineSegements: function ( lineSegments ) {
+	fromLineSegments: function ( lineSegments ) {
 
 		var geometry = lineSegments.geometry;
 
@@ -154,7 +154,7 @@ LineSegmentsGeometry.prototype = Object.assign( Object.create( InstancedBufferGe
 
 		} else if ( geometry.isBufferGeometry ) {
 
-			this.setPositions( geometry.position.array ); // assumes non-indexed
+			this.setPositions( geometry.attributes.position.array ); // assumes non-indexed
 
 		}