Global: Fix more LGTM errors. (#23346)

docs/scenes/material-browser.html

@@ -261,7 +261,6 @@
 
 				return function () {
 
-					material.vertexColors = material.vertexColors;
 					material.side = parseInt( material.side ); //Ensure number
 					material.needsUpdate = true;
 					geometry.attributes.position.needsUpdate = true;
@@ -454,7 +453,7 @@
 
 			}
 
-			function guiMeshMatcapMaterial( gui, mesh, material ) {
+			function guiMeshMatcapMaterial( gui, mesh, material, geometry ) {
 
 				const data = {
 					color: material.color.getHex(),
@@ -644,7 +643,7 @@
 
 						material = new THREE.MeshToonMaterial( { color: 0x049EF4, gradientMap: gradientMaps.threeTone } );
 						guiMaterial( gui, mesh, material, geometry );
-						guiMeshToonMaterial( gui, mesh, material, geometry );
+						guiMeshToonMaterial( gui, mesh, material );
 
 						// only use a single point light
 
@@ -691,7 +690,7 @@
 
 						material = new THREE.MeshDepthMaterial();
 						guiMaterial( gui, mesh, material, geometry );
-						guiMeshDepthMaterial( gui, mesh, material, geometry );
+						guiMeshDepthMaterial( gui, mesh, material );
 
 						return material;
 
@@ -757,7 +756,7 @@
 			light3.position.set( - 100, - 200, - 100 );
 			scene.add( light3 );
 
-			guiScene( gui, scene, camera );
+			guiScene( gui, scene );
 
 			const geometry = new THREE.TorusKnotGeometry( 10, 3, 200, 32 ).toNonIndexed();
 

manual/examples/tips-preservedrawingbuffer.html

@@ -115,7 +115,7 @@ function main() {
   const temp = new THREE.Vector3();
   function setPosition(e) {
     const pos = getCanvasRelativePosition(e);
-    const x = pos.x / canvas.width  *  2 - 1;
+    const x = pos.x / canvas.width * 2 - 1;
     const y = pos.y / canvas.height * -2 + 1;
     temp.set(x, y, 0).unproject(camera);
     state.x = temp.x;
@@ -132,4 +132,3 @@ function main() {
 main();
 </script>
 </html>
-

manual/index.html

@@ -151,12 +151,12 @@
 
 			// Activate content and title change on browser navigation
 
-			window.onpopstate = function() {
+			window.onpopstate = function () {
 
 				updateNavigation();
 				createNewIframe();
 
-			}
+			};
 
 			// Create the navigation panel and configure the iframe
 

test/unit/src/core/BufferGeometry.tests.js

@@ -350,7 +350,7 @@ export default QUnit.module( 'Core', () => {
 
 			var bs = getBSForVertices( [ - 10, 0, 0, 10, 0, 0 ] );
 
-			assert.ok( bs.radius === ( 10 + 10 ) / 2, 'radius is equal to deltaMinMax / 2' );
+			assert.ok( bs.radius === 10, 'radius is equal to deltaMinMax / 2' );
 			assert.ok( bs.center.x === 0 && bs.center.y === 0 && bs.center.y === 0, 'bounding sphere is at ( 0, 0, 0 )' );
 
 			var bs = getBSForVertices( [ - 5, 11, - 3, 5, - 11, 3 ] );

test/unit/src/core/Object3D.tests.js

@@ -536,7 +536,7 @@ export default QUnit.module( 'Core', () => {
 			var b = new Object3D();
 			var expectedSingle = new Vector3( x, y, z );
 			var expectedParent = new Vector3( x, y, 0 );
-			var expectedChild = new Vector3( x, y, 7 + ( z - z ) );
+			var expectedChild = new Vector3( x, y, 7 );
 			var position = new Vector3();
 
 			a.translateX( x );

test/unit/src/math/Euler.tests.js

@@ -404,8 +404,6 @@ export default QUnit.module( 'Maths', () => {
 
 			var f = function () {
 
-				var b = true;
-
 			};
 
 			var a = new Euler( 11, 12, 13, 'XYZ' );

test/unit/src/renderers/WebGLRenderer.tests.js

@@ -1,7 +1,7 @@
 /* global QUnit */
 
 import { WebGLRenderer } from '../../../../src/renderers/WebGLRenderer.js';
-
+/*
 var customWebGLContext = function () {
 
 	this.DEPTH_BUFFER_BIT = 256;
@@ -586,7 +586,7 @@ var customWebGLContext = function () {
 
 
 };
-
+*/
 export default QUnit.module( 'Renderers', () => {
 
 	QUnit.module( 'WebGLRenderer-webonly', () => {

test/unit/src/renderers/webgl/WebGLExtensions.tests.js

@@ -32,7 +32,7 @@ export default QUnit.module( 'Renderers', () => {
 
 				const gl = new WebglContextMock();
 				const extensions = new WebGLExtensions( gl );
-				assert.ok( extensions !== undefined );
+				assert.ok( typeof extensions === 'object' );
 
 			} );
 

test/unit/utils/qunit-utils.js

@@ -165,15 +165,13 @@ function checkGeometryJsonReading( json, geom ) {
 	QUnit.assert.ok( output[ geom.uuid ], 'geometry matching source uuid not in output' );
 	// QUnit.assert.smartEqual( output[ geom.uuid ], geom, 'Reconstruct geometry from ObjectLoader' );
 
-	var differing = getDifferingProp( output[ geom.uuid ], geom, [ 'bones' ] );
+	var differing = getDifferingProp( output[ geom.uuid ], geom );
 	if ( differing ) console.log( differing );
 
-	var excludedProperties = [ 'bones' ];
-
-	var differingProp = getDifferingProp( output[ geom.uuid ], geom, excludedProperties );
+	var differingProp = getDifferingProp( output[ geom.uuid ], geom );
 	QUnit.assert.ok( differingProp === undefined, 'properties are equal' );
 
-	differingProp = getDifferingProp( geom, output[ geom.uuid ], excludedProperties );
+	differingProp = getDifferingProp( geom, output[ geom.uuid ] );
 	QUnit.assert.ok( differingProp === undefined, 'properties are equal' );
 
 }