Browse Source

rename loadListener, errorListener to onInternalLoad, onInternalError, declare with "regular" function syntax

Max Wagner 7 years ago
parent
commit
6d916aed6b
1 changed files with 10 additions and 12 deletions
  1. 10 12
      src/loaders/ImageLoader.js

+ 10 - 12
src/loaders/ImageLoader.js

@@ -46,12 +46,10 @@ Object.assign( ImageLoader.prototype, {
 
 		var image = document.createElementNS( 'http://www.w3.org/1999/xhtml', 'img' );
 
-		var loadListener, errorListener;
+		function onInternalLoad() {
 
-		loadListener = function () {
-
-			image.removeEventListener( 'load', loadListener, false );
-			image.removeEventListener( 'error', errorListener, false );
+			image.removeEventListener( 'load', onInternalLoad, false );
+			image.removeEventListener( 'error', onInternalError, false );
 
 			Cache.add( url, this );
 
@@ -59,21 +57,21 @@ Object.assign( ImageLoader.prototype, {
 
 			scope.manager.itemEnd( url );
 
-		};
+		}
 
-		errorListener = function ( event ) {
+		function onInternalError( event ) {
 
-			image.removeEventListener( 'load', loadListener, false );
-			image.removeEventListener( 'error', errorListener, false );
+			image.removeEventListener( 'load', onInternalLoad, false );
+			image.removeEventListener( 'error', onInternalError, false );
 
 			if ( onError ) onError( event );
 
 			scope.manager.itemEnd( url );
 			scope.manager.itemError( url );
 
-		};
+		}
 
-		image.addEventListener( 'load', loadListener, false );
+		image.addEventListener( 'load', onInternalLoad, false );
 
 		/*
 		image.addEventListener( 'progress', function ( event ) {
@@ -83,7 +81,7 @@ Object.assign( ImageLoader.prototype, {
 		}, false );
 		*/
 
-		image.addEventListener( 'error', errorListener, false );
+		image.addEventListener( 'error', onInternalError, false );
 
 		if ( url.substr( 0, 5 ) !== 'data:' ) {