Merge pull request #17636 from nh2/issue-17635-fix-file-loader-caching-on-http-failure

FileLoader: Fix error response bodies being cached as results

src/loaders/FileLoader.js

@@ -172,8 +172,6 @@ FileLoader.prototype = Object.assign( Object.create( Loader.prototype ), {
 
 				var response = this.response;
 
-				Cache.add( url, response );
-
 				var callbacks = loading[ url ];
 
 				delete loading[ url ];
@@ -185,6 +183,10 @@ FileLoader.prototype = Object.assign( Object.create( Loader.prototype ), {
 
 					if ( this.status === 0 ) console.warn( 'THREE.FileLoader: HTTP Status 0 received.' );
 
+					// Add to cache only on HTTP success, so that we do not cache
+					// error response bodies as proper responses to requests.
+					Cache.add( url, response );
+
 					for ( var i = 0, il = callbacks.length; i < il; i ++ ) {
 
 						var callback = callbacks[ i ];