浏览代码

Fixed jquery dependency in OBJMTLLoader. Fixed variable redeclaration in OBJLoader. Fixed unreachable code in GeometryExporter warnings.

This Closure compiling of JS files from the examples already starts to be useful ;)
alteredq 13 年之前
父节点
当前提交
8109156a64
共有 3 个文件被更改,包括 18 次插入17 次删除
  1. 5 5
      examples/js/exporters/GeometryExporter.js
  2. 3 3
      examples/js/loaders/OBJLoader.js
  3. 10 9
      examples/js/loaders/OBJMTLLoader.js

+ 5 - 5
examples/js/exporters/GeometryExporter.js

@@ -66,18 +66,18 @@ THREE.GeometryExporter.prototype = {
 
 			}
 
+			/*
 			if ( hasFaceUv ) {
 
-				/*
 				var uv = geometry.faceUvs[ 0 ][ i ];
 				uvs[ 0 ].push( uv.u, uv.v );
-				*/
 
 			}
+			*/
 
+			/*
 			if ( hasFaceVertexUv ) {
 
-				/*
 				var uvs = geometry.faceVertexUvs[ 0 ][ i ];
 
 				if ( isTriangle ) {
@@ -98,9 +98,9 @@ THREE.GeometryExporter.prototype = {
 					);
 
 				}
-				*/
 
 			}
+			*/
 
 			if ( hasFaceNormal ) {
 
@@ -146,7 +146,7 @@ THREE.GeometryExporter.prototype = {
 
 				var hash = x.toString() + y.toString() + z.toString();
 
-				if ( normalsHash[ hash ] !== undefined ) { 
+				if ( normalsHash[ hash ] !== undefined ) {
 
 					return normalsHash[ hash ];
 

+ 3 - 3
examples/js/loaders/OBJLoader.js

@@ -122,11 +122,11 @@ THREE.OBJLoader.prototype = {
 
 		}
 
-		var data = data.split( '\no ');
+		var splitData = data.split( '\no ' );
 
-		for ( var i = 0, l = data.length; i < l; i ++ ) {
+		for ( var i = 0, l = splitData.length; i < l; i ++ ) {
 
-			var object = data[ i ];
+			var object = splitData[ i ];
 
 			var geometry = new THREE.Geometry();
 

+ 10 - 9
examples/js/loaders/OBJMTLLoader.js

@@ -474,34 +474,35 @@ THREE.OBJMTLLoader.prototype = {
 			} else if ( line.startsWith( "o " ) ) {
 
 				// Object
+
 				var object_name = line.substring(2);
-				//object_name = $.trim(object_name);
+				object_name = object_name.trim();
 
-			} else if (line.startsWith("s ")) {
+			} else if ( line.startsWith( "s ") ) {
 
 				// Smooth shading
 
-			} else if (line.startsWith("mtllib ")) {
+			} else if ( line.startsWith( "mtllib ") ) {
 
 				// mtl file
 
-				if (mtllibCallback) {
+				if ( mtllibCallback ) {
 
-					var mtlfile = line.substring(7);
-					mtlfile = $.trim(mtlfile);
-					mtllibCallback(mtlfile);
+					var mtlfile = line.substring( 7 );
+					mtlfile = mtlfile.trim();
+					mtllibCallback( mtlfile );
 
 				}
 
 			} else {
 
-				console.error("Unhandled line " + line);
+				console.error( "Unhandled line " + line );
 
 			}
 
 		}
 
-		finalize_mesh(final_model, cur_mesh);
+		finalize_mesh( final_model, cur_mesh );
 
 		return final_model;