Browse Source

address reviewer comments

Almar Klein 7 years ago
parent
commit
821ca40a8c

+ 1 - 0
examples/files.js

@@ -173,6 +173,7 @@ var files = {
 		"webgl_materials_texture_manualmipmap",
 		"webgl_materials_texture_partialupdate",
 		"webgl_materials_texture_rotation",
+		"webgl_materials_texture3d_volume1",
 		"webgl_materials_translucency",
 		"webgl_materials_transparency",
 		"webgl_materials_variations_basic",

+ 9 - 7
examples/js/shaders/VolumeShader.js

@@ -1,10 +1,12 @@
-// Author: Almar Klein
-// Description: Shaders to render 3D volumes using raycasting.
-// The applied techniques are based on similar implementations in the Visvis and Vispy projects.
-// This is not the only approach, therefore it's marked 1.
-
-
-THREE.ShaderLib[ 'volumerender1' ] = {
+/**
+ * @author Almar Klein / http://almarklein.org
+ *
+ * Shaders to render 3D volumes using raycasting.
+ * The applied techniques are based on similar implementations in the Visvis and Vispy projects.
+ * This is not the only approach, therefore it's marked 1.
+ */
+
+THREE.VolumeRenderShader1 = {
 	uniforms: {
         "u_size": { value: [1, 1, 1] },
         "u_renderstyle": { value: 0 },

+ 1 - 1
examples/webgl_materials_texture3d_volume1.html

@@ -125,7 +125,7 @@
 								  }
 
 				// Material (shaders) to render the volume using raycasting
-				var volmaterial = new THREE.ShaderMaterial( THREE.ShaderLib['volumerender1'] );
+				var volmaterial = new THREE.ShaderMaterial( THREE.VolumeRenderShader1 );
 				volmaterial.side = THREE.BackSide;  // The volume shader uses the backface as its "reference point"
 
 				// Apply standard volume material uniform info