Browse Source

use recommended compile sequence (#27055)

Co-authored-by: aardgoose <[email protected]>
aardgoose 1 year ago
parent
commit
84cd768c7c
1 changed files with 9 additions and 8 deletions
  1. 9 8
      examples/jsm/renderers/webgl/WebGLBackend.js

+ 9 - 8
examples/jsm/renderers/webgl/WebGLBackend.js

@@ -605,12 +605,6 @@ class WebGLBackend extends Backend {
 		gl.shaderSource( shader, code );
 		gl.shaderSource( shader, code );
 		gl.compileShader( shader );
 		gl.compileShader( shader );
 
 
-		if ( gl.getShaderParameter( shader, gl.COMPILE_STATUS ) === false ) {
-
-			console.error( 'THREE.WebGLBackend:', gl.getShaderInfoLog( shader ) );
-
-		}
-
 		this.set( program, {
 		this.set( program, {
 			shaderGPU: shader
 			shaderGPU: shader
 		} );
 		} );
@@ -633,14 +627,21 @@ class WebGLBackend extends Backend {
 		const { fragmentProgram, vertexProgram } = pipeline;
 		const { fragmentProgram, vertexProgram } = pipeline;
 
 
 		const programGPU = gl.createProgram();
 		const programGPU = gl.createProgram();
-		gl.attachShader( programGPU, this.get( fragmentProgram ).shaderGPU );
-		gl.attachShader( programGPU, this.get( vertexProgram ).shaderGPU );
+
+		const fragmentShader = this.get( fragmentProgram ).shaderGPU;
+		const vertexShader = this.get( vertexProgram ).shaderGPU;
+
+		gl.attachShader( programGPU, fragmentShader );
+		gl.attachShader( programGPU, vertexShader );
 		gl.linkProgram( programGPU );
 		gl.linkProgram( programGPU );
 
 
 		if ( gl.getProgramParameter( programGPU, gl.LINK_STATUS ) === false ) {
 		if ( gl.getProgramParameter( programGPU, gl.LINK_STATUS ) === false ) {
 
 
 			console.error( 'THREE.WebGLBackend:', gl.getProgramInfoLog( programGPU ) );
 			console.error( 'THREE.WebGLBackend:', gl.getProgramInfoLog( programGPU ) );
 
 
+			console.error( 'THREE.WebGLBackend:', gl.getShaderInfoLog( fragmentShader ) );
+			console.error( 'THREE.WebGLBackend:', gl.getShaderInfoLog( vertexShader ) );
+
 		}
 		}
 
 
 		gl.useProgram( programGPU );
 		gl.useProgram( programGPU );