Browse Source

Updated with additional changes from code review requests

Hectate 8 years ago
parent
commit
9043a6b610

+ 5 - 5
docs/api/extras/helpers/PolarGridHelper.html

@@ -20,7 +20,7 @@
 		<code>var radius = 10;
 		<code>var radius = 10;
 		var radials = 16;
 		var radials = 16;
 		var circles = 8;
 		var circles = 8;
-		var divisions = 50;
+		var divisions = 64;
 
 
 		var helper = new THREE.PolarGridHelper( radius, radials, circles, divisions );
 		var helper = new THREE.PolarGridHelper( radius, radials, circles, divisions );
 		scene.add( helper );
 		scene.add( helper );
@@ -32,10 +32,10 @@
 
 
 		<h3>[name]( [page:Number radius], [page:Number radials], [page:Number circles], [page:Number divisions], [page:Color color1], [page:Color color2] )</h3>
 		<h3>[name]( [page:Number radius], [page:Number radials], [page:Number circles], [page:Number divisions], [page:Color color1], [page:Color color2] )</h3>
 		<div>
 		<div>
-		radius -- The radius of the polar grid. This can be any positive number. <br />
-		radials -- The number of radial lines. This can be any positive integer. <br />
-		circles -- The number of circles. This can be any positive integer. <br />
-		divisions -- The number of line segments used for each circle. This can be any positive integer that is 3 or greater. <br />
+		radius -- The radius of the polar grid. This can be any positive number. Default is 10.<br />
+		radials -- The number of radial lines. This can be any positive integer. Default is 16.<br />
+		circles -- The number of circles. This can be any positive integer. Default is 8.<br />
+		divisions -- The number of line segments used for each circle. This can be any positive integer that is 3 or greater. Default is 64.<br />
 		color1 -- The first color used for grid elements. This can be a [page:Color], a hexadecimal value and an CSS-Color name. Default is 0x444444 <br />
 		color1 -- The first color used for grid elements. This can be a [page:Color], a hexadecimal value and an CSS-Color name. Default is 0x444444 <br />
 		color2 -- The second color used for grid elements. This can be a [page:Color], a hexadecimal value and an CSS-Color name. Default is 0x888888
 		color2 -- The second color used for grid elements. This can be a [page:Color], a hexadecimal value and an CSS-Color name. Default is 0x888888
 		</div>
 		</div>

+ 1 - 1
examples/webgl_helpers.html

@@ -50,7 +50,7 @@
 				gridHelper.position.x = - 150;
 				gridHelper.position.x = - 150;
 				scene.add( gridHelper );
 				scene.add( gridHelper );
 
 
-				var polarGridHelper = new THREE.PolarGridHelper( 200, 16, 8, 50, 0x0000ff, 0x808080 );
+				var polarGridHelper = new THREE.PolarGridHelper( 200, 16, 8, 64, 0x0000ff, 0x808080 );
 				polarGridHelper.position.y = - 150;
 				polarGridHelper.position.y = - 150;
 				polarGridHelper.position.x = 200;
 				polarGridHelper.position.x = 200;
 				scene.add( polarGridHelper );
 				scene.add( polarGridHelper );

+ 2 - 2
src/extras/helpers/PolarGridHelper.js

@@ -16,7 +16,7 @@ function PolarGridHelper( radius, radials, circles, divisions, color1, color2 )
     radius = radius || 10;
     radius = radius || 10;
     radials = radials || 16;
     radials = radials || 16;
     circles = circles || 8;
     circles = circles || 8;
-    divisions = divisions || 50;
+    divisions = divisions || 64;
     color1 = new Color( color1 !== undefined ? color1 : 0x444444 );
     color1 = new Color( color1 !== undefined ? color1 : 0x444444 );
     color2 = new Color( color2 !== undefined ? color2 : 0x888888 );
     color2 = new Color( color2 !== undefined ? color2 : 0x888888 );
 
 
@@ -92,4 +92,4 @@ function PolarGridHelper( radius, radials, circles, divisions, color1, color2 )
 PolarGridHelper.prototype = Object.create( LineSegments.prototype );
 PolarGridHelper.prototype = Object.create( LineSegments.prototype );
 PolarGridHelper.prototype.constructor = PolarGridHelper;
 PolarGridHelper.prototype.constructor = PolarGridHelper;
 
 
-export { PolarGridHelper };
+export { PolarGridHelper };