Browse Source

Merge pull request #17224 from gkjohnson/events-gc

Reuse "added" and "removed" event
Mr.doob 6 years ago
parent
commit
96e0a5260b
1 changed files with 4 additions and 2 deletions
  1. 4 2
      src/core/Object3D.js

+ 4 - 2
src/core/Object3D.js

@@ -20,6 +20,8 @@ var _object3DId = 0;
 var _m1, _q1, _v1;
 var _m1, _q1, _v1;
 var _xAxis, _yAxis, _zAxis;
 var _xAxis, _yAxis, _zAxis;
 var _target, _position, _scale, _quaternion;
 var _target, _position, _scale, _quaternion;
+var _addedEvent = { type: 'added' };
+var _removedEvent = { type: 'removed' };
 
 
 function Object3D() {
 function Object3D() {
 
 
@@ -354,7 +356,7 @@ Object3D.prototype = Object.assign( Object.create( EventDispatcher.prototype ),
 			object.parent = this;
 			object.parent = this;
 			this.children.push( object );
 			this.children.push( object );
 
 
-			object.dispatchEvent( { type: 'added' } );
+			object.dispatchEvent( _addedEvent );
 
 
 		} else {
 		} else {
 
 
@@ -387,7 +389,7 @@ Object3D.prototype = Object.assign( Object.create( EventDispatcher.prototype ),
 			object.parent = null;
 			object.parent = null;
 			this.children.splice( index, 1 );
 			this.children.splice( index, 1 );
 
 
-			object.dispatchEvent( { type: 'removed' } );
+			object.dispatchEvent( _removedEvent );
 
 
 		}
 		}