UniformsUtils: Skip cloning textures of render targets and report warning. (#25560)

* .

.

* .

* .

* Update UniformsUtils.js

* Update UniformsUtils.tests.js

* Update UniformsUtils.tests.js

* Update UniformsUtils.tests.js

* Update UniformsLib.html

---------

Co-authored-by: Michael Herzog <[email protected]>

src/renderers/shaders/UniformsUtils.js

@@ -21,7 +21,16 @@ export function cloneUniforms( src ) {
 				property.isVector2 || property.isVector3 || property.isVector4 ||
 				property.isTexture || property.isQuaternion ) ) {
 
-				dst[ u ][ p ] = property.clone();
+				if ( property.isRenderTargetTexture ) {
+
+					console.warn( 'UniformsUtils: Textures of render targets cannot be cloned via cloneUniforms() or mergeUniforms().' );
+					dst[ u ][ p ] = null;
+
+				} else {
+
+					dst[ u ][ p ] = property.clone();
+
+				}
 
 			} else if ( Array.isArray( property ) ) {
 

test/unit/src/renderers/shaders/UniformsUtils.tests.js

@@ -1,6 +1,16 @@
 /* global QUnit */
 
 import { UniformsUtils } from '../../../../../src/renderers/shaders/UniformsUtils.js';
+import { Color } from '../../../../../src/math/Color.js';
+import { Vector2 } from '../../../../../src/math/Vector2.js';
+import { Vector3 } from '../../../../../src/math/Vector3.js';
+import { Vector4 } from '../../../../../src/math/Vector4.js';
+import { Matrix3 } from '../../../../../src/math/Matrix3.js';
+import { Matrix4 } from '../../../../../src/math/Matrix4.js';
+import { Quaternion } from '../../../../../src/math/Quaternion.js';
+import { Texture } from '../../../../../src/textures/Texture.js';
+import { CubeReflectionMapping, UVMapping } from '../../../../../src/constants.js';
+import { CONSOLE_LEVEL } from '../../../utils/console-wrapper.js';
 
 export default QUnit.module( 'Renderers', () => {
 
@@ -29,12 +39,110 @@ export default QUnit.module( 'Renderers', () => {
 			} );
 
 			// PUBLIC
-			QUnit.todo( 'cloneUniforms', ( assert ) => {
+			QUnit.test( 'cloneUniforms copies values', ( assert ) => {
+
+				const uniforms = {
+					floatValue: { value: 1.23 },
+					intValue: { value: 1 },
+					boolValue: { value: true },
+					colorValue: { value: new Color(0xFF00FF) },
+					vector2Value: { value: new Vector2(1, 2) },
+					vector3Value: { value: new Vector3(1, 2, 3) },
+					vector4Value: { value: new Vector4(1, 2, 3, 4) },
+					matrix3Value: { value: new Matrix3() },
+					matrix4Value: { value: new Matrix4() },
+					quatValue: { value: new Quaternion(1, 2, 3, 4) },
+					arrayValue: { value: [1, 2, 3, 4] },
+					textureValue: { value: new Texture(null, CubeReflectionMapping) },
+				};
+
+				const uniformClones = UniformsUtils.clone(uniforms);
+	
+				assert.ok( uniforms.floatValue.value === uniformClones.floatValue.value );
+				assert.ok( uniforms.intValue.value === uniformClones.intValue.value );
+				assert.ok( uniforms.boolValue.value === uniformClones.boolValue.value );
+				assert.ok( uniforms.colorValue.value.equals(uniformClones.colorValue.value) );
+				assert.ok( uniforms.vector2Value.value.equals(uniformClones.vector2Value.value) );
+				assert.ok( uniforms.vector3Value.value.equals(uniformClones.vector3Value.value) );
+				assert.ok( uniforms.vector4Value.value.equals(uniformClones.vector4Value.value) );
+				assert.ok( uniforms.matrix3Value.value.equals(uniformClones.matrix3Value.value) );
+				assert.ok( uniforms.matrix4Value.value.equals(uniformClones.matrix4Value.value) );
+				assert.ok( uniforms.quatValue.value.equals(uniformClones.quatValue.value) );
+				assert.ok( uniforms.textureValue.value.source.uuid === uniformClones.textureValue.value.source.uuid );
+				assert.ok( uniforms.textureValue.value.mapping === uniformClones.textureValue.value.mapping );
+				for ( let i = 0; i < uniforms.arrayValue.value.length; ++i ) {
+					assert.ok( uniforms.arrayValue.value[i] === uniformClones.arrayValue.value[i] );
+				}
+			} );
 
-				assert.ok( false, 'everything\'s gonna be alright' );
+			QUnit.test( 'cloneUniforms clones properties', ( assert ) => {
+
+				const uniforms = {
+					floatValue: { value: 1.23 },
+					intValue: { value: 1 },
+					boolValue: { value: true },
+					colorValue: { value: new Color(0xFF00FF) },
+					vector2Value: { value: new Vector2(1, 2) },
+					vector3Value: { value: new Vector3(1, 2, 3) },
+					vector4Value: { value: new Vector4(1, 2, 3, 4) },
+					matrix3Value: { value: new Matrix3() },
+					matrix4Value: { value: new Matrix4() },
+					quatValue: { value: new Quaternion(1, 2, 3, 4) },
+					arrayValue: { value: [1, 2, 3, 4] },
+					textureValue: { value: new Texture(null, CubeReflectionMapping) },
+				};
+	
+				const uniformClones = UniformsUtils.clone(uniforms);
+
+				// Modify the originals
+				uniforms.floatValue.value = 123.0;
+				uniforms.intValue.value = 123;
+				uniforms.boolValue.value = false;
+				uniforms.colorValue.value.r = 123.0;
+				uniforms.vector2Value.value.x = 123.0;
+				uniforms.vector3Value.value.x = 123.0;
+				uniforms.vector4Value.value.x = 123.0;
+				uniforms.matrix3Value.value.elements[0] = 123.0;
+				uniforms.matrix4Value.value.elements[0] = 123.0;
+				uniforms.quatValue.value.x = 123.0;
+				uniforms.arrayValue.value[0] = 123.0;
+				uniforms.textureValue.value.mapping = UVMapping;
+
+				assert.ok( uniforms.floatValue.value !== uniformClones.floatValue.value );
+				assert.ok( uniforms.intValue.value !== uniformClones.intValue.value );
+				assert.ok( uniforms.boolValue.value !== uniformClones.boolValue.value );
+				assert.ok( !uniforms.colorValue.value.equals(uniformClones.colorValue.value) );
+				assert.ok( !uniforms.vector2Value.value.equals(uniformClones.vector2Value.value) );
+				assert.ok( !uniforms.vector3Value.value.equals(uniformClones.vector3Value.value) );
+				assert.ok( !uniforms.vector4Value.value.equals(uniformClones.vector4Value.value) );
+				assert.ok( !uniforms.matrix3Value.value.equals(uniformClones.matrix3Value.value) );
+				assert.ok( !uniforms.matrix4Value.value.equals(uniformClones.matrix4Value.value) );
+				assert.ok( !uniforms.quatValue.value.equals(uniformClones.quatValue.value) );
+				assert.ok( uniforms.textureValue.value.mapping !== uniformClones.textureValue.value.mapping );
+				assert.ok( uniforms.arrayValue.value[0] !== uniformClones.arrayValue.value[0] );
+
+				// Texture source remains same
+				assert.ok( uniforms.textureValue.value.source.uuid === uniformClones.textureValue.value.source.uuid );
+
+			} );
+
+			QUnit.test( 'cloneUniforms skips render target textures', ( assert ) => {
+
+				const uniforms = {
+					textureValue: { value: new Texture(null, CubeReflectionMapping) },
+				};
+
+				uniforms.textureValue.value.isRenderTargetTexture = true;
+
+				console.level = CONSOLE_LEVEL.OFF;
+				const uniformClones = UniformsUtils.clone(uniforms);
+				console.level = CONSOLE_LEVEL.DEFAULT;
+
+				assert.ok( uniformClones.textureValue.value === null );
 
 			} );
 
+
 			QUnit.todo( 'mergeUniforms', ( assert ) => {
 
 				assert.ok( false, 'everything\'s gonna be alright' );