Переглянути джерело

fixed: Consider marking event handler as 'passive' to make the page more responsive (#25374)

* Update Viewport.js

* Update EditorControls.js

* Update EditorControls.js

* Update codemirror.js

* Update ui.js
puxiao 2 роки тому
батько
коміт
ab772203d5

+ 3 - 3
editor/js/EditorControls.js

@@ -258,7 +258,7 @@ class EditorControls extends THREE.EventDispatcher {
 
 		domElement.addEventListener( 'contextmenu', contextmenu );
 		domElement.addEventListener( 'dblclick', onMouseUp );
-		domElement.addEventListener( 'wheel', onMouseWheel );
+		domElement.addEventListener( 'wheel', onMouseWheel, { passive: false } );
 
 		domElement.addEventListener( 'pointerdown', onPointerDown );
 
@@ -347,8 +347,8 @@ class EditorControls extends THREE.EventDispatcher {
 
 		}
 
-		domElement.addEventListener( 'touchstart', touchStart );
-		domElement.addEventListener( 'touchmove', touchMove );
+		domElement.addEventListener( 'touchstart', touchStart, { passive: false } );
+		domElement.addEventListener( 'touchmove', touchMove, { passive: false } );
 
 	}
 

+ 1 - 1
editor/js/Viewport.js

@@ -279,7 +279,7 @@ function Viewport( editor ) {
 	}
 
 	container.dom.addEventListener( 'mousedown', onMouseDown );
-	container.dom.addEventListener( 'touchstart', onTouchStart );
+	container.dom.addEventListener( 'touchstart', onTouchStart, { passive: false } );
 	container.dom.addEventListener( 'dblclick', onDoubleClick );
 
 	// controls need to be added *after* main logic,

+ 1 - 1
editor/js/libs/codemirror/codemirror.js

@@ -533,7 +533,7 @@
 
   var on = function(emitter, type, f) {
     if (emitter.addEventListener) {
-      emitter.addEventListener(type, f, false);
+      emitter.addEventListener(type, f, { passive: false });
     } else if (emitter.attachEvent) {
       emitter.attachEvent("on" + type, f);
     } else {

+ 1 - 1
editor/js/libs/ui.js

@@ -694,7 +694,7 @@ class UINumber extends UIElement {
 
 		this.dom.addEventListener( 'keydown', onKeyDown );
 		this.dom.addEventListener( 'mousedown', onMouseDown );
-		this.dom.addEventListener( 'touchstart', onTouchStart );
+		this.dom.addEventListener( 'touchstart', onTouchStart, { passive: false } );
 		this.dom.addEventListener( 'change', onChange );
 		this.dom.addEventListener( 'focus', onFocus );
 		this.dom.addEventListener( 'blur', onBlur );