瀏覽代碼

Clean up.

Mr.doob 8 年之前
父節點
當前提交
b22bb0c7d4
共有 2 個文件被更改,包括 8 次插入11 次删除
  1. 2 7
      src/math/Matrix3.js
  2. 6 4
      src/math/Matrix4.js

+ 2 - 7
src/math/Matrix3.js

@@ -63,15 +63,10 @@ Object.assign( Matrix3.prototype, {
 
 	copy: function ( m ) {
 
+		var te = this.elements;
 		var me = m.elements;
 
-		this.set(
-
-			me[ 0 ], me[ 3 ], me[ 6 ],
-			me[ 1 ], me[ 4 ], me[ 7 ],
-			me[ 2 ], me[ 5 ], me[ 8 ]
-
-		);
+		for ( var i = 0; i < 9; i ++ ) te[ i ] = me[ i ];
 
 		return this;
 

+ 6 - 4
src/math/Matrix4.js

@@ -72,7 +72,10 @@ Object.assign( Matrix4.prototype, {
 
 	copy: function ( m ) {
 
-		for ( var i = 0; i < 16; i ++ ) this.elements[ i ] = m.elements[ i ];
+		var te = this.elements;
+		var me = m.elements;
+
+		for ( var i = 0; i < 16; i ++ ) te[ i ] = me[ i ];
 
 		return this;
 
@@ -80,8 +83,7 @@ Object.assign( Matrix4.prototype, {
 
 	copyPosition: function ( m ) {
 
-		var te = this.elements;
-		var me = m.elements;
+		var te = this.elements, me = m.elements;
 
 		te[ 12 ] = me[ 12 ];
 		te[ 13 ] = me[ 13 ];
@@ -147,7 +149,7 @@ Object.assign( Matrix4.prototype, {
 
 	makeRotationFromEuler: function ( euler ) {
 
-		if ( (euler && euler.isEuler) === false ) {
+		if ( ( euler && euler.isEuler ) === false ) {
 
 			console.error( 'THREE.Matrix: .makeRotationFromEuler() now expects a Euler rotation rather than a Vector3 and order.' );