Browse Source

Fixed sticky orbit controlls when disabled.

Aki Rodic 4 years ago
parent
commit
b8e3cdfbd5
2 changed files with 6 additions and 10 deletions
  1. 3 5
      examples/js/controls/OrbitControls.js
  2. 3 5
      examples/jsm/controls/OrbitControls.js

+ 3 - 5
examples/js/controls/OrbitControls.js

@@ -800,8 +800,6 @@ THREE.OrbitControls = function ( object, domElement ) {
 
 
 	function onPointerUp( event ) {
 	function onPointerUp( event ) {
 
 
-		if ( scope.enabled === false ) return;
-
 		switch ( event.pointerType ) {
 		switch ( event.pointerType ) {
 
 
 			case 'mouse':
 			case 'mouse':
@@ -961,13 +959,13 @@ THREE.OrbitControls = function ( object, domElement ) {
 
 
 	function onMouseUp( event ) {
 	function onMouseUp( event ) {
 
 
+		scope.domElement.ownerDocument.removeEventListener( 'pointermove', onPointerMove, false );
+		scope.domElement.ownerDocument.removeEventListener( 'pointerup', onPointerUp, false );
+
 		if ( scope.enabled === false ) return;
 		if ( scope.enabled === false ) return;
 
 
 		handleMouseUp( event );
 		handleMouseUp( event );
 
 
-		scope.domElement.ownerDocument.removeEventListener( 'pointermove', onPointerMove, false );
-		scope.domElement.ownerDocument.removeEventListener( 'pointerup', onPointerUp, false );
-
 		scope.dispatchEvent( endEvent );
 		scope.dispatchEvent( endEvent );
 
 
 		state = STATE.NONE;
 		state = STATE.NONE;

+ 3 - 5
examples/jsm/controls/OrbitControls.js

@@ -810,8 +810,6 @@ var OrbitControls = function ( object, domElement ) {
 
 
 	function onPointerUp( event ) {
 	function onPointerUp( event ) {
 
 
-		if ( scope.enabled === false ) return;
-
 		switch ( event.pointerType ) {
 		switch ( event.pointerType ) {
 
 
 			case 'mouse':
 			case 'mouse':
@@ -971,13 +969,13 @@ var OrbitControls = function ( object, domElement ) {
 
 
 	function onMouseUp( event ) {
 	function onMouseUp( event ) {
 
 
+		scope.domElement.ownerDocument.removeEventListener( 'pointermove', onPointerMove, false );
+		scope.domElement.ownerDocument.removeEventListener( 'pointerup', onPointerUp, false );
+
 		if ( scope.enabled === false ) return;
 		if ( scope.enabled === false ) return;
 
 
 		handleMouseUp( event );
 		handleMouseUp( event );
 
 
-		scope.domElement.ownerDocument.removeEventListener( 'pointermove', onPointerMove, false );
-		scope.domElement.ownerDocument.removeEventListener( 'pointerup', onPointerUp, false );
-
 		scope.dispatchEvent( endEvent );
 		scope.dispatchEvent( endEvent );
 
 
 		state = STATE.NONE;
 		state = STATE.NONE;