Home Explore Help
Sign In
javascript
/
three.js
mirror of https://github.com/tazdij/three.js.git
2
0
Fork 0
Files Issues 0 Wiki
Browse Source

Examples: Fix `monaco-editor` (#28201)

sunag 1 year ago
parent
50d4f74070
commit
c5c42fb7d0
5 changed files with 7 additions and 10 deletions
Split View Show Diff Stats
  1. 2 0
      examples/jsm/nodes/materials/NodeMaterial.js
  2. 2 7
      examples/webgpu_tsl_editor.html
  3. 1 1
      examples/webgpu_tsl_transpiler.html
  4. 1 1
      playground/elements/CodeEditorElement.js
  5. 1 1
      playground/index.html

+ 2 - 0
examples/jsm/nodes/materials/NodeMaterial.js
View File 

@@ -146,6 +146,8 @@ class NodeMaterial extends ShaderMaterial {
 
 
 	setupClipping( builder ) {
 
 
+		if ( builder.clippingContext === null ) return null;
 
+
 
 		const { globalClippingCount, localClippingCount } = builder.clippingContext;
 
 
 		let result = null;

+ 2 - 7
examples/webgpu_tsl_editor.html
View File 

@@ -59,7 +59,6 @@
 
 			import WebGPURenderer from 'three/addons/renderers/webgpu/WebGPURenderer.js';
 
 			import WGSLNodeBuilder from 'three/addons/renderers/webgpu/nodes/WGSLNodeBuilder.js';
 
 			import GLSLNodeBuilder from 'three/addons/renderers/webgl/nodes/GLSLNodeBuilder.js';
 
-			import GLSL1NodeBuilder from 'three/addons/renderers/webgl-legacy/nodes/GLSL1NodeBuilder.js';
 
 
 			import { GUI } from 'three/addons/libs/lil-gui.module.min.js';
 
 
@@ -109,7 +108,7 @@
 
 
 				// editor
 
 
-				window.require.config( { paths: { 'vs': 'https://cdn.jsdelivr.net/npm/monaco-editor@latest/min/vs' } } );
 
+				window.require.config( { paths: { 'vs': 'https://cdn.jsdelivr.net/npm/monaco-editor@0.48.0/min/vs' } } );
 
 
 				require( [ 'vs/editor/editor.main' ], () => {
 
 
@@ -196,10 +195,6 @@ output = vec4( finalColor, opacity );
 
 
 								NodeBuilder = GLSLNodeBuilder;
 
 
-							} else {
 
-
 
-								NodeBuilder = GLSL1NodeBuilder;
 
-
 
 							}
 
 
 							nodeBuilder = new NodeBuilder( mesh, renderer );
 
@@ -238,7 +233,7 @@ output = vec4( finalColor, opacity );
 
 
 					const gui = new GUI();
 
 
-					gui.add( options, 'output', [ 'WGSL', 'GLSL ES 3.0', 'GLSL' ] ).onChange( build );
 
+					gui.add( options, 'output', [ 'WGSL', 'GLSL ES 3.0' ] ).onChange( build );
 
 					gui.add( options, 'shader', [ 'vertex', 'fragment' ] ).onChange( showCode );
 
 
 					gui.add( options, 'outputColorSpace', [ THREE.LinearSRGBColorSpace, THREE.SRGBColorSpace ] ).onChange( ( value ) => {

+ 1 - 1
examples/webgpu_tsl_transpiler.html
View File 

@@ -50,7 +50,7 @@
 
 
 				// editor
 
 
-				window.require.config( { paths: { 'vs': 'https://cdn.jsdelivr.net/npm/monaco-editor@latest/min/vs' } } );
 
+				window.require.config( { paths: { 'vs': 'https://cdn.jsdelivr.net/npm/monaco-editor@0.48.0/min/vs' } } );
 
 
 				require( [ 'vs/editor/editor.main' ], () => {

+ 1 - 1
playground/elements/CodeEditorElement.js
View File 

@@ -22,7 +22,7 @@ export class CodeEditorElement extends Element {
 
 
 		this.editor = null; // async
 
 
-		window.require.config( { paths: { 'vs': 'https://cdn.jsdelivr.net/npm/monaco-editor@latest/min/vs' } } );
 
+		window.require.config( { paths: { 'vs': 'https://cdn.jsdelivr.net/npm/monaco-editor@0.48.0/min/vs' } } );
 
 
 		require( [ 'vs/editor/editor.main' ], () => {

+ 1 - 1
playground/index.html
View File 

@@ -92,7 +92,7 @@
 
 	</head>
 
 	<body>
 
 
-		<script src="https://cdn.jsdelivr.net/npm/monaco-editor@latest/min/vs/loader.min.js"></script>
 
+		<script src="https://cdn.jsdelivr.net/npm/monaco-editor@0.48.0/min/vs/loader.min.js"></script>
 
 
 		<script type="importmap">
 
 			{