Browse Source

Fix Euler accessors

Tristan VALCKE 8 years ago
parent
commit
e0f8526922
1 changed files with 48 additions and 28 deletions
  1. 48 28
      src/math/Euler.js

+ 48 - 28
src/math/Euler.js

@@ -22,63 +22,83 @@ Euler.RotationOrders = [ 'XYZ', 'YZX', 'ZXY', 'XZY', 'YXZ', 'ZYX' ];
 
 Euler.DefaultOrder = 'XYZ';
 
-Object.assign( Euler.prototype, {
+Object.defineProperties( Euler.prototype, {
 
-	constructor: Euler,
+	"x" : {
 
-	isEuler: true,
+		get: function () {
 
-	get x () {
+			return this._x;
 
-		return this._x;
+		},
 
-	},
+		set: function ( value ) {
 
-	set x ( value ) {
+			this._x = value;
+			this.onChangeCallback();
 
-		this._x = value;
-		this.onChangeCallback();
+		}
 
 	},
 
-	get y () {
+	"y" : {
 
-		return this._y;
+		get: function () {
 
-	},
+			return this._y;
 
-	set y ( value ) {
+		},
 
-		this._y = value;
-		this.onChangeCallback();
+		set: function ( value ) {
+
+			this._y = value;
+			this.onChangeCallback();
+
+		}
 
 	},
 
-	get z () {
+	"z" : {
 
-		return this._z;
+		get: function () {
 
-	},
+			return this._z;
 
-	set z ( value ) {
+		},
 
-		this._z = value;
-		this.onChangeCallback();
+		set: function ( value ) {
+
+			this._z = value;
+			this.onChangeCallback();
+
+		}
 
 	},
 
-	get order () {
+	"order" : {
 
-		return this._order;
+		get: function () {
 
-	},
+			return this._order;
 
-	set order ( value ) {
+		},
 
-		this._order = value;
-		this.onChangeCallback();
+		set: function ( value ) {
 
-	},
+			this._order = value;
+			this.onChangeCallback();
+
+		}
+
+	}
+
+});
+
+Object.assign( Euler.prototype, {
+
+	constructor: Euler,
+
+	isEuler: true,
 
 	set: function ( x, y, z, order ) {