Browse Source

ArcballControls: Rename _tbCenter to target. (#22678)

Michael Herzog 3 years ago
parent
commit
e1da50de18
1 changed files with 8 additions and 8 deletions
  1. 8 8
      examples/jsm/controls/ArcballControls.js

+ 8 - 8
examples/jsm/controls/ArcballControls.js

@@ -79,6 +79,7 @@ class ArcballControls extends Object3D {
 		this.camera = null;
 		this.camera = null;
 		this.domElement = domElement;
 		this.domElement = domElement;
 		this.scene = scene;
 		this.scene = scene;
+		this.target = new Vector3( 0, 0, 0 );
 
 
 		this.mouseActions = [];
 		this.mouseActions = [];
 		this._mouseOp = null;
 		this._mouseOp = null;
@@ -204,7 +205,6 @@ class ArcballControls extends Object3D {
 		this.maxZoom = Infinity;
 		this.maxZoom = Infinity;
 
 
 		//trackball parameters
 		//trackball parameters
-		this._tbCenter = new Vector3( 0, 0, 0 );
 		this._tbRadius = 1;
 		this._tbRadius = 1;
 
 
 		//FSA
 		//FSA
@@ -2193,7 +2193,7 @@ class ArcballControls extends Object3D {
 	 */
 	 */
 	setCamera = ( camera ) => {
 	setCamera = ( camera ) => {
 
 
-		camera.lookAt( this._tbCenter );
+		camera.lookAt( this.target );
 		camera.updateMatrix();
 		camera.updateMatrix();
 
 
 		//setting state
 		//setting state
@@ -2211,11 +2211,11 @@ class ArcballControls extends Object3D {
 		this._zoomState = this._zoom0;
 		this._zoomState = this._zoom0;
 
 
 		this._initialNear = camera.near;
 		this._initialNear = camera.near;
-		this._nearPos0 = camera.position.distanceTo( this._tbCenter ) - camera.near;
+		this._nearPos0 = camera.position.distanceTo( this.target ) - camera.near;
 		this._nearPos = this._initialNear;
 		this._nearPos = this._initialNear;
 
 
 		this._initialFar = camera.far;
 		this._initialFar = camera.far;
-		this._farPos0 = camera.position.distanceTo( this._tbCenter ) - camera.far;
+		this._farPos0 = camera.position.distanceTo( this.target ) - camera.far;
 		this._farPos = this._initialFar;
 		this._farPos = this._initialFar;
 
 
 		this._up0.copy( camera.up );
 		this._up0.copy( camera.up );
@@ -2226,7 +2226,7 @@ class ArcballControls extends Object3D {
 
 
 		//making gizmos
 		//making gizmos
 		this._tbRadius = this.calculateTbRadius( camera );
 		this._tbRadius = this.calculateTbRadius( camera );
-		this.makeGizmos( this._tbCenter, this._tbRadius );
+		this.makeGizmos( this.target, this._tbRadius );
 
 
 	};
 	};
 
 
@@ -2728,12 +2728,12 @@ class ArcballControls extends Object3D {
 	 */
 	 */
 	setTarget = ( x, y, z ) => {
 	setTarget = ( x, y, z ) => {
 
 
-		this._tbCenter.set( x, y, z );
+		this.target.set( x, y, z );
 		this._gizmos.position.set( x, y, z );	//for correct radius calculation
 		this._gizmos.position.set( x, y, z );	//for correct radius calculation
 		this._tbRadius = this.calculateTbRadius( this.camera );
 		this._tbRadius = this.calculateTbRadius( this.camera );
 
 
-		this.makeGizmos( this._tbCenter, this._tbRadius );
-		this.camera.lookAt( this._tbCenter );
+		this.makeGizmos( this.target, this._tbRadius );
+		this.camera.lookAt( this.target );
 
 
 	};
 	};