Browse Source

NodeBuilder: Fix `construct()` node data (#26533)

* NodeBuilder: Fix construct() node data

* cleanup

* cleanup
sunag 2 years ago
parent
commit
e5426b0514
1 changed files with 6 additions and 4 deletions
  1. 6 4
      examples/jsm/nodes/core/NodeBuilder.js

+ 6 - 4
examples/jsm/nodes/core/NodeBuilder.js

@@ -563,17 +563,19 @@ class NodeBuilder {
 
 		if ( nodeData === undefined ) {
 
-			nodeData = { vertex: {}, fragment: {}, compute: {} };
+			nodeData = {};
 
 			cache.setNodeData( node, nodeData );
 
 		}
 
-		return shaderStage !== null ? nodeData[ shaderStage ] : nodeData;
+		if ( nodeData[ shaderStage ] === undefined ) nodeData[ shaderStage ] = {};
+
+		return nodeData[ shaderStage ];
 
 	}
 
-	getNodeProperties( node, shaderStage = this.shaderStage ) {
+	getNodeProperties( node, shaderStage = 'any' ) {
 
 		const nodeData = this.getDataFromNode( node, shaderStage );
 
@@ -650,7 +652,7 @@ class NodeBuilder {
 
 	getVaryingFromNode( node, type ) {
 
-		const nodeData = this.getDataFromNode( node, null );
+		const nodeData = this.getDataFromNode( node, 'any' );
 
 		let nodeVarying = nodeData.varying;