Home Explore Help
Sign In
javascript
/
three.js
mirror of https://github.com/tazdij/three.js.git
2
0
Fork 0
Files Issues 0 Wiki
Browse Source

ConeGeometry: Clean up (#9917)

* ConeGeometry: Clean up

* ConeBufferGeometry: Added missing parameter

* ConeBufferGeometry: Fixed comment
Michael Herzog 8 years ago
parent
bc48aed587
commit
fa281c33dd
4 changed files with 10 additions and 22 deletions
Split View Show Diff Stats
  1. 1 1
      docs/api/geometries/ConeBufferGeometry.html
  2. 1 1
      docs/api/geometries/ConeGeometry.html
  3. 5 11
      src/geometries/ConeBufferGeometry.js
  4. 3 9
      src/geometries/ConeGeometry.js

+ 1 - 1
docs/api/geometries/ConeBufferGeometry.html
View File 

@@ -8,7 +8,7 @@
 
 		<link type="text/css" rel="stylesheet" href="page.css" />
 
 	</head>
 
 	<body>
 
-		[page:BufferGeometry] &rarr;
 
+		[page:CylinderBufferGeometry] &rarr;
 
 
 		<h1>[name]</h1>

+ 1 - 1
docs/api/geometries/ConeGeometry.html
View File 

@@ -8,7 +8,7 @@
 
 		<link type="text/css" rel="stylesheet" href="page.css" />
 
 	</head>
 
 	<body>
 
-		[page:Geometry] &rarr;
 
+		[page:CylinderGeometry] &rarr;
 
 
 		<h1>[name]</h1>

+ 5 - 11
src/geometries/ConeBufferGeometry.js
View File 

@@ -1,19 +1,12 @@
 
-import { BufferGeometry } from '../core/BufferGeometry';
 
 import { CylinderBufferGeometry } from './CylinderBufferGeometry';
 
 
-/*
 
+/**
 
  * @author: abelnation / http://github.com/abelnation
 
  */
 
 
-function ConeBufferGeometry(
 
-	radius, height,
 
-	radialSegments, heightSegments,
 
-	openEnded, thetaStart, thetaLength ) {
 
+function ConeBufferGeometry( radius, height, radialSegments, heightSegments, openEnded, thetaStart, thetaLength ) {
 
 
-	CylinderBufferGeometry.call( this,
 
-		0, radius, height,
 
-		radialSegments, heightSegments,
 
-		openEnded, thetaStart, thetaLength );
 
+	CylinderBufferGeometry.call( this, 0, radius, height, radialSegments, heightSegments, openEnded, thetaStart, thetaLength );
 
 
 	this.type = 'ConeBufferGeometry';
 
 
@@ -22,13 +15,14 @@ function ConeBufferGeometry(
 
 		height: height,
 
 		radialSegments: radialSegments,
 
 		heightSegments: heightSegments,
 
+		openEnded: openEnded,
 
 		thetaStart: thetaStart,
 
 		thetaLength: thetaLength
 
 	};
 
 
 }
 
 
-ConeBufferGeometry.prototype = Object.create( BufferGeometry.prototype );
 
+ConeBufferGeometry.prototype = Object.create( CylinderBufferGeometry.prototype );
 
 ConeBufferGeometry.prototype.constructor = ConeBufferGeometry;

+ 3 - 9
src/geometries/ConeGeometry.js
View File 

@@ -4,15 +4,9 @@ import { CylinderGeometry } from './CylinderGeometry';
 
  * @author abelnation / http://github.com/abelnation
 
  */
 
 
-function ConeGeometry(
 
-	radius, height,
 
-	radialSegments, heightSegments,
 
-	openEnded, thetaStart, thetaLength ) {
 
-
 
-	CylinderGeometry.call( this,
 
-		0, radius, height,
 
-		radialSegments, heightSegments,
 
-		openEnded, thetaStart, thetaLength );
 
+function ConeGeometry( radius, height, radialSegments, heightSegments, openEnded, thetaStart, thetaLength ) {
 
+
 
+	CylinderGeometry.call( this, 0, radius, height, radialSegments, heightSegments, openEnded, thetaStart, thetaLength );
 
 
 	this.type = 'ConeGeometry';