Build 1.0.3

Source code of PascalCoin build 1.0.3

README.md

@@ -38,6 +38,16 @@ If you like it, consider a donation using BitCoin:
 
 History:
 
+Build 1.0.3.0 - 2016-09-08
+--------------------------
+- Important changes to database 
+- Peer cache
+- Issues with Connections
+- More stable
+- Miner key selector
+- Invalid local time detector
+
+
 Build 1.0.2.0 - 2016-08-31
 --------------------------
 - Improved hashing speed

README.txt

@@ -38,6 +38,16 @@ If you like it, consider a donation using BitCoin:
 
 History:
 
+Build 1.0.3.0 - 2016-09-08
+--------------------------
+- Important changes to database 
+- Peer cache
+- Issues with Connections
+- More stable
+- Miner key selector
+- Invalid local time detector
+
+
 Build 1.0.2.0 - 2016-08-31
 --------------------------
 - Improved hashing speed

Units/Forms/UFRMOperation.dfm

@@ -110,10 +110,6 @@ object FRMOperation: TFRMOperation
     TabOrder = 1
     object tsOperation: TTabSheet
       TabVisible = False
-      ExplicitLeft = 0
-      ExplicitTop = 0
-      ExplicitWidth = 0
-      ExplicitHeight = 0
       object gbOperation: TGroupBox
         Left = 13
         Top = 8
@@ -448,10 +444,6 @@ object FRMOperation: TFRMOperation
     object tsGlobalError: TTabSheet
       ImageIndex = 1
       TabVisible = False
-      ExplicitLeft = 0
-      ExplicitTop = 0
-      ExplicitWidth = 0
-      ExplicitHeight = 0
       object lblGlobalErrors: TLabel
         Left = 40
         Top = 50

Units/Forms/UFRMPascalCoinWalletConfig.dfm

@@ -96,14 +96,15 @@ object FRMPascalCoinWalletConfig: TFRMPascalCoinWalletConfig
     Height = 17
     Caption = 'Save log file'
     TabOrder = 8
+    OnClick = cbSaveLogFilesClick
   end
   object cbShowLogs: TCheckBox
     Left = 15
-    Top = 382
+    Top = 397
     Width = 97
     Height = 17
     Caption = 'Show logs'
-    TabOrder = 9
+    TabOrder = 10
   end
   object bbOk: TBitBtn
     Left = 171
@@ -113,7 +114,7 @@ object FRMPascalCoinWalletConfig: TFRMPascalCoinWalletConfig
     DoubleBuffered = True
     Kind = bkOK
     ParentDoubleBuffered = False
-    TabOrder = 10
+    TabOrder = 11
     OnClick = bbOkClick
   end
   object bbCancel: TBitBtn
@@ -124,7 +125,7 @@ object FRMPascalCoinWalletConfig: TFRMPascalCoinWalletConfig
     DoubleBuffered = True
     Kind = bkCancel
     ParentDoubleBuffered = False
-    TabOrder = 11
+    TabOrder = 12
   end
   object udInternetServerPort: TUpDown
     Left = 226
@@ -231,7 +232,7 @@ object FRMPascalCoinWalletConfig: TFRMPascalCoinWalletConfig
     Width = 171
     Height = 17
     Caption = 'Show Modal Messages'
-    TabOrder = 12
+    TabOrder = 13
   end
   object udCPUs: TUpDown
     Left = 226
@@ -260,7 +261,7 @@ object FRMPascalCoinWalletConfig: TFRMPascalCoinWalletConfig
     Width = 334
     Height = 121
     Caption = ' Miner Private Key: '
-    TabOrder = 13
+    TabOrder = 14
     object rbGenerateANewPrivateKeyEachBlock: TRadioButton
       Left = 20
       Top = 20
@@ -294,4 +295,12 @@ object FRMPascalCoinWalletConfig: TFRMPascalCoinWalletConfig
       TabOrder = 3
     end
   end
+  object cbSaveDebugLogs: TCheckBox
+    Left = 31
+    Top = 377
+    Width = 97
+    Height = 17
+    Caption = 'Save debug logs too'
+    TabOrder = 9
+  end
 end

Units/Forms/UFRMPascalCoinWalletConfig.pas

@@ -46,9 +46,11 @@ type
     rbUseARandomKey: TRadioButton;
     rbMineAllwaysWithThisKey: TRadioButton;
     cbPrivateKeyToMine: TComboBox;
+    cbSaveDebugLogs: TCheckBox;
     procedure FormCreate(Sender: TObject);
     procedure bbOkClick(Sender: TObject);
     procedure bbUpdatePasswordClick(Sender: TObject);
+    procedure cbSaveLogFilesClick(Sender: TObject);
   private
     FAppParams: TAppParams;
     FWalletKeys: TWalletKeys;
@@ -93,6 +95,7 @@ begin
   AppParams.ParamByName[CT_PARAM_AutomaticMineWhenConnectedToNodes].SetAsBoolean(cbAutomaticMiningWhenConnectedToNodes.Checked );
   AppParams.ParamByName[CT_PARAM_SaveLogFiles].SetAsBoolean(cbSaveLogFiles.Checked );
   AppParams.ParamByName[CT_PARAM_ShowLogs].SetAsBoolean(cbShowLogs.Checked );
+  AppParams.ParamByName[CT_PARAM_SaveDebugLogs].SetAsBoolean(cbSaveDebugLogs.Checked);
   AppParams.ParamByName[CT_PARAM_MinerName].SetAsString(ebMinerName.Text);
   AppParams.ParamByName[CT_PARAM_ShowModalMessages].SetAsBoolean(cbShowModalMessages.Checked);
   AppParams.ParamByName[CT_PARAM_MaxCPUs].SetAsInteger(udCPUs.Position);
@@ -126,6 +129,11 @@ begin
   UpdateWalletConfig;
 end;
 
+procedure TFRMPascalCoinWalletConfig.cbSaveLogFilesClick(Sender: TObject);
+begin
+  cbSaveDebugLogs.Enabled := cbSaveLogFiles.Checked;
+end;
+
 procedure TFRMPascalCoinWalletConfig.FormCreate(Sender: TObject);
 begin
   lblDefaultInternetServerPort.Caption := Format('(Default %d)',[CT_NetServer_Port]);
@@ -156,6 +164,7 @@ begin
     UpdateWalletConfig;
     cbSaveLogFiles.Checked := AppParams.ParamByName[CT_PARAM_SaveLogFiles].GetAsBoolean(false);
     cbShowLogs.Checked := AppParams.ParamByName[CT_PARAM_ShowLogs].GetAsBoolean(false);
+    cbSaveDebugLogs.Checked := AppParams.ParamByName[CT_PARAM_SaveDebugLogs].GetAsBoolean(false);
     ebMinerName.Text := AppParams.ParamByName[CT_PARAM_MinerName].GetAsString('');
     cbShowModalMessages.Checked := AppParams.ParamByName[CT_PARAM_ShowModalMessages].GetAsBoolean(false);
     udCPUs.Position := AppParams.ParamByName[CT_PARAM_MaxCPUs].GetAsInteger(1);
@@ -164,6 +173,7 @@ begin
       TLog.NewLog(lterror,ClassName,'Exception at SetAppParams: '+E.Message);
     end;
   End;
+  cbSaveLogFilesClick(nil);
 end;
 
 procedure TFRMPascalCoinWalletConfig.SetWalletKeys(const Value: TWalletKeys);

Units/Forms/UFRMWallet.dfm

@@ -327,12 +327,12 @@ object FRMWallet: TFRMWallet
       ParentFont = False
       OnClick = lblReceivedMessagesClick
     end
-    object Label15: TLabel
-      Left = 721
+    object lblBuild: TLabel
+      Left = 717
       Top = 6
-      Width = 112
+      Width = 49
       Height = 23
-      Caption = 'TEST MODE'
+      Caption = 'Build'
       Font.Charset = DEFAULT_CHARSET
       Font.Color = clWindowText
       Font.Height = -19
@@ -343,7 +343,7 @@ object FRMWallet: TFRMWallet
     object cbAllowMining: TCheckBox
       Left = 620
       Top = 10
-      Width = 97
+      Width = 91
       Height = 17
       Caption = 'Allow Mining'
       TabOrder = 0
@@ -375,16 +375,20 @@ object FRMWallet: TFRMWallet
     Top = 91
     Width = 899
     Height = 448
-    ActivePage = tsAccountsExplorer
+    ActivePage = tsNodeStats
     Align = alClient
     TabOrder = 2
     OnChange = PageControlChange
     object tsAccountsExplorer: TTabSheet
       Caption = 'Accounts Explorer'
+      ExplicitLeft = 0
+      ExplicitTop = 0
+      ExplicitWidth = 0
+      ExplicitHeight = 0
       object Splitter1: TSplitter
         Left = 380
-        Top = 41
-        Height = 379
+        Top = 66
+        Height = 354
         ExplicitLeft = 390
         ExplicitTop = 140
         ExplicitHeight = 100
@@ -393,9 +397,16 @@ object FRMWallet: TFRMWallet
         Left = 0
         Top = 0
         Width = 891
-        Height = 41
+        Height = 66
         Align = alTop
         TabOrder = 0
+        object Label18: TLabel
+          Left = 11
+          Top = 35
+          Width = 61
+          Height = 13
+          Caption = 'Find account'
+        end
         object cbMyPrivateKeys: TComboBox
           Left = 260
           Top = 7
@@ -414,21 +425,36 @@ object FRMWallet: TFRMWallet
           TabOrder = 1
           OnClick = cbExploreMyAccountsClick
         end
+        object ebFindAccountNumber: TEdit
+          Left = 87
+          Top = 32
+          Width = 83
+          Height = 21
+          TabOrder = 2
+          OnChange = ebFindAccountNumberChange
+          OnExit = ebFindAccountNumberExit
+        end
       end
       object dgAccountOperations: TDrawGrid
         Left = 383
-        Top = 41
+        Top = 66
         Width = 508
-        Height = 379
+        Height = 354
         Align = alClient
         TabOrder = 1
         OnDblClick = MiDecodePayloadClick
+        RowHeights = (
+          24
+          24
+          24
+          24
+          24)
       end
       object pnlAccounts: TPanel
         Left = 0
-        Top = 41
+        Top = 66
         Width = 380
-        Height = 379
+        Height = 354
         Align = alLeft
         BevelOuter = bvNone
         TabOrder = 2
@@ -436,7 +462,7 @@ object FRMWallet: TFRMWallet
           Left = 0
           Top = 0
           Width = 380
-          Height = 345
+          Height = 320
           Align = alLeft
           TabOrder = 0
           OnClick = dgAccountsClick
@@ -451,7 +477,7 @@ object FRMWallet: TFRMWallet
         end
         object pnlAccountsInfo: TPanel
           Left = 0
-          Top = 345
+          Top = 320
           Width = 380
           Height = 34
           Align = alBottom
@@ -1014,10 +1040,10 @@ object FRMWallet: TFRMWallet
   end
   object ImageListIcons: TImageList
     Height = 48
-    Left = 90
-    Top = 155
+    Left = 105
+    Top = 180
     Bitmap = {
-      494C0101020008009C0010003000FFFFFFFFFF10FFFFFFFFFFFFFFFF424D3600
+      494C010102000800C00010003000FFFFFFFFFF10FFFFFFFFFFFFFFFF424D3600
       0000000000003600000028000000400000003000000001002000000000000030
       0000000000000000000000000000000000000000000000000000000000000000
       0000000000000000002A292929D60B0B0BF4111111EE0000006B000000000000

Units/Forms/UFRMWallet.pas

@@ -32,11 +32,13 @@ Const
   CT_PARAM_MinerPrivateKeyType = 'MinerPrivateKeyType';
   CT_PARAM_MinerPrivateKeySelectedPublicKey = 'MinerPrivateKeySelectedPublicKey';
   CT_PARAM_SaveLogFiles = 'SaveLogFiles';
+  CT_PARAM_SaveDebugLogs = 'SaveDebugLogs';
   CT_PARAM_ShowLogs = 'ShowLogs';
   CT_PARAM_MinerName = 'MinerName';
   CT_PARAM_FirstTime = 'FirstTime';
   CT_PARAM_ShowModalMessages = 'ShowModalMessages';
   CT_PARAM_MaxCPUs = 'MaxCPUs';
+  CT_PARAM_PeerCache = 'PeerCache';
 
 type
   TStringListAux = Class(TStringList)
@@ -143,7 +145,9 @@ type
     lblAccountsCount: TLabel;
     lblAccountsBalance: TLabel;
     lblReceivedMessages: TLabel;
-    Label15: TLabel;
+    lblBuild: TLabel;
+    ebFindAccountNumber: TEdit;
+    Label18: TLabel;
     procedure FormCreate(Sender: TObject);
     procedure FormDestroy(Sender: TObject);
     procedure TimerUpdateStatusTimer(Sender: TObject);
@@ -171,6 +175,8 @@ type
     procedure ApplicationEventsMinimize(Sender: TObject);
     procedure bbSendAMessageClick(Sender: TObject);
     procedure lblReceivedMessagesClick(Sender: TObject);
+    procedure ebFindAccountNumberChange(Sender: TObject);
+    procedure ebFindAccountNumberExit(Sender: TObject);
   private
     FMinersBlocksFound: Integer;
     procedure SetMinersBlocksFound(const Value: Integer);
@@ -191,14 +197,11 @@ type
     FOperationsDBGrid : TOperationsDBGrid;
     FBlockChainDBGrid : TBlockChainDBGrid;
     FMinerPrivateKeyType : TMinerPrivateKey;
-    FMemoNetConnections : TStringListAux;
-    FMemoBlackListNodes : TStringListAux;
-    FMemoAvailableNodeServers : TStringListAux;
     FUpdating : Boolean;
     FMessagesUnreadCount : Integer;
     Procedure CheckMining;
     Procedure OnNewAccount(Sender : TObject);
-    Procedure OnReceivedHelloResponse(Sender : TObject);
+    Procedure OnReceivedHelloMessage(Sender : TObject);
     Procedure OnNetStatisticsChanged(Sender : TObject);
     procedure OnNewLog(logtype : TLogType; Time : TDateTime; ThreadID : Cardinal; Const sender, logtext : AnsiString);
     procedure OnMinerNewBlockFound(sender : TMinerThread; Operations : TPCOperationsComp);
@@ -249,7 +252,6 @@ procedure TThreadActivate.BCExecute;
 begin
   // Read Operations saved from disk
   TNode.Node.Bank.DiskRestoreFromOperations(CT_MaxBlock);
-  // Activating server
   TNode.Node.AutoDiscoverNodes(CT_Discover_IPs);
   TNode.Node.NetServer.Active := true;
   FRMWallet.UpdateAccounts;
@@ -278,9 +280,10 @@ begin
     // Creating Node:
     FNode := TNode.Node;
     FNode.NetServer.Port := FAppParams.ParamByName[CT_PARAM_InternetServerPort].GetAsInteger(CT_NetServer_Port);
+    FNode.PeerCache := FAppParams.ParamByName[CT_PARAM_PeerCache].GetAsString('')+';'+CT_Discover_IPs;
     // Check Database
     FNode.Bank.StorageClass := TDBStorage;
-    TDBStorage(FNode.Bank.Storage).AccessFileName := TFolderHelper.GetPascalCoinDataFolder+'\pascalcoin.mdb';
+    TDBStorage(FNode.Bank.Storage).AccessFileName := TFolderHelper.GetPascalCoinDataFolder+'\pascalcoinB03.mdb';
     // Init Grid
     FAccountsGrid.Node := FNode;
     FWalletKeys.OnChanged := OnWalletChanged;
@@ -296,7 +299,7 @@ begin
     FBlockChainDBGrid.AdoConnection := TDBStorage(FNode.Bank.Storage).ADOConnection;
     FBlockChainDBGrid.DBGrid := dbGridBlockChain;
     // Init TNode
-    TNetData.NetData.OnReceivedHelloResponse := OnReceivedHelloResponse;
+    TNetData.NetData.OnReceivedHelloMessage := OnReceivedHelloMessage;
     TNetData.NetData.OnStatisticsChanged := OnNetStatisticsChanged;
     TNetData.NetData.OnNetConnectionsUpdated := onNetConnectionsUpdated;
     TNetData.NetData.OnNodeServersUpdated := OnNetNodeServersUpdated;
@@ -360,7 +363,7 @@ begin
     for i := 0 to lbNetConnections.Items.Count - 1 do begin
       if lbNetConnections.Selected[i] then begin
         nc := TNetConnection(lbNetconnections.Items.Objects[i]);
-        if TNetData.NetData.ConnectionExists(nc) then begin
+        if TNetData.NetData.ConnectionExistsAndActive(nc) then begin
           FNode.SendNodeMessage(nc,m,errors);
           memoMessages.Lines.Add(DateTimeToStr(now)+' Sent to '+nc.Client.RemoteHost+':'+nc.Client.RemotePort+' > '+m);
         end;
@@ -368,7 +371,7 @@ begin
     end;
   end else begin
     nc := TNetConnection(lbNetconnections.Items.Objects[lbNetconnections.ItemIndex]);
-    if TNetData.NetData.ConnectionExists(nc) then begin
+    if TNetData.NetData.ConnectionExistsAndActive(nc) then begin
       FNode.SendNodeMessage(nc,m,errors);
       memoMessages.Lines.Add(DateTimeToStr(now)+' Sent to '+nc.Client.RemoteHost+':'+nc.Client.RemotePort+' > '+m);
     end;
@@ -440,9 +443,12 @@ procedure TFRMWallet.CheckMining;
   begin
     if ForceMining then exit;
     // Stop mining
-    mtl := FNode.MinerThreads.LockList('TFRMWallet.CheckMining stop');
+    mtl := FNode.MinerThreads.LockList;
     try
       for i:=mtl.Count-1 downto 0 do begin
+        if Not TMinerThread(mtl[i]).Paused then begin
+          TLog.NewLog(ltinfo,ClassName,'Stoping miner');
+        end;
         TMinerThread(mtl[i]).Paused := true;
       end;
     finally
@@ -465,10 +471,13 @@ begin
     ) then begin
     if (cbAllowMining.checked) Or (ForceMining) then begin
       n := 0;
-      mtl := FNode.MinerThreads.LockList('TFRMWallet.CheckMining base');
+      mtl := FNode.MinerThreads.LockList;
       try
         for i:=mtl.Count-1 downto 0 do begin
-          if TMinerThread(mtl[i]).Paused then TMinerThread(mtl[i]).Paused := false;
+          if TMinerThread(mtl[i]).Paused then begin
+            TMinerThread(mtl[i]).Paused := false;
+            TLog.NewLog(ltinfo,ClassName,'Starting miner');
+          end;
           inc(n);
         end;
         if n<FMaxCPUs then begin
@@ -586,6 +595,31 @@ begin
   if key=#13 then  ebFilterOperationsAccountExit(Nil);
 end;
 
+procedure TFRMWallet.ebFindAccountNumberChange(Sender: TObject);
+Var an : Cardinal;
+begin
+  if Trim(ebFindAccountNumber.Text)='' then begin
+    ebFindAccountNumber.Color := clWindow;
+    ebFindAccountNumber.Font.Color := clDkGray;
+  end else if TAccountComp.AccountTxtNumberToAccountNumber(ebFindAccountNumber.Text,an) then begin
+    ebFindAccountNumber.Color := clWindow;
+    if FAccountsGrid.MoveRowToAccount(an) then begin
+      ebFindAccountNumber.Font.Color := clWindowText;
+    end else begin
+      ebFindAccountNumber.Font.Color := clRed;
+    end;
+  end else begin
+    // Invalid value
+    ebFindAccountNumber.Color := clRed;
+    ebFindAccountNumber.Font.Color := clWindowText;
+  end;
+end;
+
+procedure TFRMWallet.ebFindAccountNumberExit(Sender: TObject);
+begin
+  ebFindAccountNumber.Text := '';
+end;
+
 function TFRMWallet.ForceMining: Boolean;
 begin
   Result := false;
@@ -593,14 +627,12 @@ end;
 
 procedure TFRMWallet.FormCreate(Sender: TObject);
 Var i : Integer;
+  fvi : TFileVersionInfo;
 begin
   if CPUCount>1 then FMaxCPUs := CPUCount-1
   else FMaxCPUs := 1;
   FMessagesUnreadCount := 0;
   lblReceivedMessages.Visible := false;
-  FMemoNetConnections := TStringListAux.Create;
-  FMemoBlackListNodes := TStringListAux.Create;
-  FMemoAvailableNodeServers := TStringListAux.Create;
   memoNetConnections.Lines.Clear;
   memoNetServers.Lines.Clear;
   memoNetBlackLists.Lines.Clear;
@@ -657,6 +689,8 @@ begin
     'Double click the system tray icon to restore Pascal Coin';
   TrayIcon.BalloonFlags := bfInfo;
   MinersBlocksFound := 0;
+  fvi := TFolderHelper.GetTFileVersionInfo(Application.ExeName);
+  lblBuild.Caption := 'Build: '+fvi.FileVersion;
 end;
 
 procedure TFRMWallet.FormDestroy(Sender: TObject);
@@ -675,7 +709,7 @@ begin
   FOperationsGrid.Node := Nil;
   FPendingOperationsGrid.Node := Nil;
   FAccountsGrid.Node := Nil;
-  TNetData.NetData.OnReceivedHelloResponse := Nil;
+  TNetData.NetData.OnReceivedHelloMessage := Nil;
   TNetData.NetData.OnStatisticsChanged := Nil;
   TNetData.NetData.OnNetConnectionsUpdated := Nil;
   TNetData.NetData.OnNodeServersUpdated := Nil;
@@ -697,7 +731,7 @@ begin
   FNodeNotifyEvents.Free;
   //
   step := 'Assigning Nil to TNetData';
-  TNetData.NetData.OnReceivedHelloResponse := Nil;
+  TNetData.NetData.OnReceivedHelloMessage := Nil;
   TNetData.NetData.OnStatisticsChanged := Nil;
 
   step := 'Destroying grids operators';
@@ -723,9 +757,6 @@ begin
   step := 'Processing messages 2';
   Application.ProcessMessages;
   step := 'Destroying stringslist';
-  FMemoNetConnections.Free;
-  FMemoBlackListNodes.Free;
-  FMemoAvailableNodeServers.Free;
   Except
     On E:Exception do begin
       TLog.NewLog(lterror,Classname,'Error destroying Form step: '+step+' Errors ('+E.ClassName+'): ' +E.Message);
@@ -878,9 +909,9 @@ Var i,j : integer;
  l : TList;
  strings : TStrings;
 begin
-  l := TNetData.NetData.BlackList.LockList('TFRMWallet.OnNetBlackListUpdated');
+  l := TNetData.NetData.BlackList.LockList;
   try
-    strings := FMemoBlackListNodes;
+    strings := memoNetBlackLists.Lines;
     strings.BeginUpdate;
     Try
       strings.Clear;
@@ -910,11 +941,12 @@ Const CT_BooleanToString : Array[Boolean] of String = ('False','True');
 Var i : integer;
  NC : TNetConnection;
  l : TList;
+ sClientApp : String;
  strings, sNSC, sRS, sDisc : TStrings;
 begin
-  l := TNetData.NetData.NetConnections.LockList('TFRMWallet.OnNetConnectionsUpdated');
+  l := TNetData.NetData.NetConnections.LockList;
   try
-    strings := FMemoNetConnections;
+    strings := memoNetConnections.Lines;
     sNSC := TStringList.Create;
     sRS := TStringList.Create;
     sDisc := TStringList.Create;
@@ -922,16 +954,19 @@ begin
     Try
       for i := 0 to l.Count - 1 do begin
         NC := l[i];
+        if (NC.ClientAppVersion='') then sClientApp:='(old version)'
+        else sClientApp := 'Version:'+NC.ClientAppVersion;
+
         if NC.Connected then begin
           if NC is TNetServerClient then begin
-            sNSC.Add(Format('Client: IP:%s:%s Sent/Received:%d/%d Bytes - Active since %s',
-              [NC.Client.RemoteHost,NC.Client.RemotePort,NC.Client.BytesSent,NC.Client.BytesReceived,DateTimeElapsedTime(NC.CreatedTime)]));
+            sNSC.Add(Format('Client: IP:%s:%s Sent/Received:%d/%d Bytes - %s - Active since %s',
+              [NC.Client.RemoteHost,NC.Client.RemotePort,NC.Client.BytesSent,NC.Client.BytesReceived,sClientApp,DateTimeElapsedTime(NC.CreatedTime)]));
           end else begin
-            if NC.IsMyselfServer then sNSC.Add(Format('MySelf IP:%s:%s Sent/Received:%d/%d Bytes - Active since %s',
-              [NC.Client.RemoteHost,NC.Client.RemotePort,NC.Client.BytesSent,NC.Client.BytesReceived,DateTimeElapsedTime(NC.CreatedTime)]))
+            if NC.IsMyselfServer then sNSC.Add(Format('MySelf IP:%s:%s Sent/Received:%d/%d Bytes - %s - Active since %s',
+              [NC.Client.RemoteHost,NC.Client.RemotePort,NC.Client.BytesSent,NC.Client.BytesReceived,sClientApp,DateTimeElapsedTime(NC.CreatedTime)]))
             else begin
-              sRS.Add(Format('Remote Server: IP:%s:%s Sent/Received:%d/%d Bytes - Active since %s',
-              [NC.Client.RemoteHost,NC.Client.RemotePort,NC.Client.BytesSent,NC.Client.BytesReceived,DateTimeElapsedTime(NC.CreatedTime)]));
+              sRS.Add(Format('Remote Server: IP:%s:%s Sent/Received:%d/%d Bytes - %s - Active since %s',
+              [NC.Client.RemoteHost,NC.Client.RemotePort,NC.Client.BytesSent,NC.Client.BytesReceived,sClientApp,DateTimeElapsedTime(NC.CreatedTime)]));
             end;
           end;
         end else begin
@@ -972,9 +1007,9 @@ Var i : integer;
  strings : TStrings;
  s : String;
 begin
-  l := TNetData.NetData.NodeServers.LockList('TFRMWallet.OnNetNodeServersUpdated');
+  l := TNetData.NetData.NodeServers.LockList;
   try
-    strings := FMemoAvailableNodeServers;
+    strings := memoNetServers.Lines;
     strings.BeginUpdate;
     Try
       strings.Clear;
@@ -1014,8 +1049,8 @@ begin
       StatusBar.Panels[0].Text := 'Active (Port '+Inttostr(FNode.NetServer.Port)+')';
     end else StatusBar.Panels[0].Text := 'Server stopped';
     NS := TNetData.NetData.NetStatistics;
-    StatusBar.Panels[1].Text := Format('Connections:%d (%d) Clients:%d Servers:%d - Rcvd:%d Bytes Send:%d Bytes',
-      [NS.ActiveConnections,NS.TotalConnections,NS.ClientsConnections,NS.ServersConnections,NS.BytesReceived,NS.BytesSend]);
+    StatusBar.Panels[1].Text := Format('Connections:%d Clients:%d Servers:%d - Rcvd:%d Bytes Send:%d Bytes',
+      [NS.ActiveConnections,NS.ClientsConnections,NS.ServersConnections,NS.BytesReceived,NS.BytesSend]);
   end else begin
     StatusBar.Panels[0].Text := '';
     StatusBar.Panels[1].Text := '';
@@ -1050,28 +1085,44 @@ procedure TFRMWallet.OnNodeMessageEvent(NetConnection: TNetConnection; MessageDa
 Var s : String;
 begin
   inc(FMessagesUnreadCount);
-  s := DateTimeToStr(now)+' Message received from '+NetConnection.Client.RemoteHost+':'+NetConnection.Client.RemotePort;
-  memoMessages.Lines.Add(DateTimeToStr(now)+' Message received from '+NetConnection.Client.RemoteHost+':'+NetConnection.Client.RemotePort+' Length '+inttostr(Length(MessageData))+' bytes');
-  memoMessages.Lines.Add('RECEIVED> '+MessageData);
-  if FAppParams.ParamByName[CT_PARAM_ShowModalMessages].GetAsBoolean(false) then begin
-    s := DateTimeToStr(now)+' Message from '+NetConnection.Client.RemoteHost+':'+NetConnection.Client.RemotePort+#10+
-       'Length '+inttostr(length(MessageData))+' bytes'+#10+#10;
-    if TCrypto.IsHumanReadable(MessageData) then begin
-       s := s + MessageData;
-    end else begin
-       s := s +'Value in hexadecimal:'+#10+
-            TCrypto.ToHexaString(MessageData);
+  if Assigned(NetConnection) then begin
+    s := DateTimeToStr(now)+' Message received from '+NetConnection.Client.RemoteHost+':'+NetConnection.Client.RemotePort;
+    memoMessages.Lines.Add(DateTimeToStr(now)+' Message received from '+NetConnection.Client.RemoteHost+':'+NetConnection.Client.RemotePort+' Length '+inttostr(Length(MessageData))+' bytes');
+    memoMessages.Lines.Add('RECEIVED> '+MessageData);
+    if FAppParams.ParamByName[CT_PARAM_ShowModalMessages].GetAsBoolean(false) then begin
+      s := DateTimeToStr(now)+' Message from '+NetConnection.Client.RemoteHost+':'+NetConnection.Client.RemotePort+#10+
+         'Length '+inttostr(length(MessageData))+' bytes'+#10+#10;
+      if TCrypto.IsHumanReadable(MessageData) then begin
+         s := s + MessageData;
+      end else begin
+         s := s +'Value in hexadecimal:'+#10+
+              TCrypto.ToHexaString(MessageData);
+      end;
+      Application.MessageBox(PChar(s),PChar(Application.Title),MB_ICONINFORMATION+MB_OK);
     end;
-    Application.MessageBox(PChar(s),PChar(Application.Title),MB_ICONINFORMATION+MB_OK);
+  end else begin
+    memoMessages.Lines.Add(DateTimeToStr(now)+' Internal message: '+MessageData);
   end;
   if FMessagesUnreadCount>1 then lblReceivedMessages.Caption := Format('You have received %d messages',[FMessagesUnreadCount])
   else lblReceivedMessages.Caption := 'You have received 1 message';
   lblReceivedMessages.Visible := true;
 end;
 
-procedure TFRMWallet.OnReceivedHelloResponse(Sender: TObject);
+procedure TFRMWallet.OnReceivedHelloMessage(Sender: TObject);
+Var nsarr : TNodeServerAddressArray;
+  i : Integer;
+  s : AnsiString;
 begin
   CheckMining;
+  // Update node servers Peer Cache
+  nsarr := TNetData.NetData.GetValidNodeServers;
+  s := '';
+  for i := low(nsarr) to High(nsarr) do begin
+    if (s<>'') then s := s+';';
+    s := s + nsarr[i].ip+':'+IntToStr( nsarr[i].port );
+  end;
+  FAppParams.ParamByName[CT_PARAM_PeerCache].SetAsString(s);
+  TNode.Node.PeerCache := s;
 end;
 
 procedure TFRMWallet.OnWalletChanged(Sender: TObject);
@@ -1133,18 +1184,6 @@ begin
     UpdateConnectionStatus;
     UpdateBlockChainState;
     UpdateNodeStatus;
-    If (FMemoNetConnections.UpdateCount=0) And (FMemoNetConnections.Count>0) then begin
-      memoNetConnections.Lines.Assign(FMemoNetConnections);
-      FMemoNetConnections.Clear;
-    end;
-    If (FMemoAvailableNodeServers.UpdateCount=0) And (FMemoAvailableNodeServers.Count>0) then begin
-      memoNetServers.Lines.Assign(FMemoAvailableNodeServers);
-      FMemoAvailableNodeServers.Clear;
-    end;
-    If (FMemoBlackListNodes.UpdateCount=0) And (FMemoBlackListNodes.Count>0) then begin
-      memoNetBlackLists.Lines.Assign(FMemoBlackListNodes);
-      FMemoBlackListNodes.Clear;
-    end;
   Except
     On E:Exception do begin
       E.Message := 'Exception at TimerUpdate '+E.ClassName+': '+E.Message;
@@ -1211,7 +1250,7 @@ Var i : integer;
  NC : TNetConnection;
  l : TList;
 begin
-  l := TNetData.NetData.NetConnections.LockList('TFRMWallet.UpdateAvailableConnections');
+  l := TNetData.NetData.NetConnections.LockList;
   try
     lbNetConnections.Items.BeginUpdate;
     Try
@@ -1267,7 +1306,7 @@ begin
         CT_CalcNewTargetBlocksAverage * 2 ,FormatFloat('0.0',FNode.Bank.GetActualTargetSecondsAverage(CT_CalcNewTargetBlocksAverage * 2)),
         CT_CalcNewTargetBlocksAverage DIV 2,FormatFloat('0.0',FNode.Bank.GetActualTargetSecondsAverage(CT_CalcNewTargetBlocksAverage DIV 2)),
         CT_CalcNewTargetBlocksAverage DIV 4,FormatFloat('0.0',FNode.Bank.GetActualTargetSecondsAverage(CT_CalcNewTargetBlocksAverage DIV 4))]);
-    mtl := FNode.MinerThreads.LockList('TFRMWallet.UpdateBlockChainState');
+    mtl := FNode.MinerThreads.LockList;
     try
       mc := mtl.Count;
       If mc>0 then begin
@@ -1312,7 +1351,8 @@ begin
     if PageControl.ActivePage = tsLogs then PageControl.ActivePage := tsAccountsExplorer;
   end else FLog.OnNewLog := OnNewLog;
   if FAppParams.ParamByName[CT_PARAM_SaveLogFiles].GetAsBoolean(false) then begin
-    FLog.SaveTypes := CT_TLogTypes_DEFAULT;
+    if FAppParams.ParamByName[CT_PARAM_SaveDebugLogs].GetAsBoolean(false) then FLog.SaveTypes := CT_TLogTypes_ALL
+    else FLog.SaveTypes := CT_TLogTypes_DEFAULT;
     FLog.FileName := TFolderHelper.GetPascalCoinDataFolder+'\PascalCointWallet.log';
   end else begin
     FLog.SaveTypes := [];

Units/PascalCoin/UAccounts.pas

@@ -60,6 +60,12 @@ Type
   end;
   PBlockAccount = ^TBlockAccount;
 
+  { Estimated TAccount size:
+    4 + 200 (max aprox) + 8 + 4 + 4 = 220 max aprox
+    Estimated TBlockAccount size:
+    4 + (5 * 220) + 4 + 32 = 1140 max aprox
+  }
+
   TPCSafeBox = Class;
 
   // This is a class to quickly find accountkeys and their respective account number/s
@@ -851,7 +857,7 @@ begin
     TLog.NewLog(lterror,Classname,'IS LOCKED !!!');
     raise Exception.Create('IS LOCKED !!!');
   end;
-  TPCThread.ProtectEnterCriticalSection(Self,'StartThreadSafe',FLock);
+  TPCThread.ProtectEnterCriticalSection(Self,FLock);
   FIsLocked := true;
 end;
 

Units/PascalCoin/UBlockChain.pas

@@ -338,7 +338,7 @@ Var
   buffer, pow: AnsiString;
   i : Integer;
 begin
-  TPCThread.ProtectEnterCriticalSection(Self,'AddNewBlockChainBlock',FBankLock);
+  TPCThread.ProtectEnterCriticalSection(Self,FBankLock);
   Try
     Result := False;
     errors := '';
@@ -517,7 +517,7 @@ begin
     TLog.NewLog(lterror,Classname,'Is Restoring!!!');
     raise Exception.Create('Is restoring!');
   end;
-  TPCThread.ProtectEnterCriticalSection(Self,'DiskRestoreFromOperations',FBankLock);
+  TPCThread.ProtectEnterCriticalSection(Self,FBankLock);
   try
     FIsRestoringFromFile := true;
     try
@@ -706,7 +706,7 @@ begin
   Clear;
   Result := SafeBox.LoadFromStream(Stream,LastReadBlock,errors);
   if Result then begin
-    TPCThread.ProtectEnterCriticalSection(Self,'LoadFromStream',FBankLock);
+    TPCThread.ProtectEnterCriticalSection(Self,FBankLock);
     try
       op := TPCOperationsComp.Create(Self);
       try
@@ -736,7 +736,7 @@ end;
 
 function TPCBank.LoadOperations(Operations: TPCOperationsComp; Block: Cardinal): Boolean;
 begin
-  TPCThread.ProtectEnterCriticalSection(Self,'LoadOperations',FBankLock);
+  TPCThread.ProtectEnterCriticalSection(Self,FBankLock);
   try
     Result := Storage.LoadBlockChainBlock(Operations,Block);
   finally
@@ -940,12 +940,12 @@ end;
 
 procedure TPCOperationsComp.Calc_Digest_Operations;
 var ms : TMemoryStream;
-  i: Cardinal;
   buff: AnsiString;
 begin
   ms := TMemoryStream.Create;
   try
     ms.WriteBuffer(FOperationsHashTree.HashTree[1],length(FOperationsHashTree.HashTree));
+    // Note about fee: Fee is stored in 8 bytes, but only digest first 4 low bytes
     ms.Write(FOperationBlock.fee,4);
     SetLength(FDigest_Operations,ms.Size);
     ms.Position := 0;
@@ -1103,7 +1103,19 @@ end;
 
 function TPCOperationsComp.IncrementNOnce: Boolean;
 begin
-  nonce := nonce + 1;
+  // Important note:
+  // In Build version 1.0.0 to 1.0.2 of PascalCoin the wallet stored nOnce data in an
+  // Access database as an Integer.
+  // There is a limitation of int values in Access that they can't be greater
+  // than MAXINT, so to preventing miners to fall only mines within nonce 0..MaxInt
+  // This limitation is not in the protocol, so in future versions of
+  // PascalCoin nonce can be a full unsigned 4 bytes value.
+  // Note: Build 1.0.3 corrects this issue storing nOnce as a String, but
+  // to prevent old miners working on a fork, for now applying MaxInt
+  // Starting at build (1.0.4) MaxInt will be a full unsigned 4 bytes value.
+  if nonce<MaxInt then
+    nonce := nonce + 1
+  else nonce := 0;
   Result := FOperationBlock.proof_of_work < FBank.FActualTargetHash;
 end;
 
@@ -1171,7 +1183,7 @@ begin
   Stream.Read(FOperationBlock.block, Sizeof(FOperationBlock.block));
 
   if TStreamOp.ReadAnsiString(Stream, m) < 0 then exit;
-  FOperationBlock.account_key := TAccountComp.RawString2Accountkey(m); // String2Addresskey(m);
+  FOperationBlock.account_key := TAccountComp.RawString2Accountkey(m);
   if Stream.Read(FOperationBlock.reward, Sizeof(FOperationBlock.reward)) < 0 then exit;
   if Stream.Read(FOperationBlock.fee, Sizeof(FOperationBlock.fee)) < 0 then exit;
   if Stream.Read(FOperationBlock.timestamp, Sizeof(FOperationBlock.timestamp)) < 0 then exit;
@@ -1391,9 +1403,16 @@ begin
 end;
 
 procedure TPCOperationsComp.SetBlockPayload(const Value: TRawBytes);
+Var i : Integer;
 begin
   if Value=FOperationBlock.block_payload then exit;
   if Length(Value)>CT_MaxPayloadSize then Exit;
+  // Checking Miner Payload valid chars
+  for i := 1 to length(Value) do begin
+    if Not (Value[i] in [#32..#254]) then begin
+      exit;
+    end;
+  end;
   FOperationBlock.block_payload := Value;
   CalcProofOfWork(true,FOperationBlock.proof_of_work);
 end;
@@ -1435,6 +1454,19 @@ begin
       exit;
     end;
   end;
+  // Checking Miner payload size
+  if length(BlockPayload)>CT_MaxPayloadSize then begin
+    errors := 'Invalid Miner Payload length: '+inttostr(Length(BlockPayload));
+    exit;
+  end;
+  // Checking Miner Payload valid chars
+  for i := 1 to length(BlockPayload) do begin
+    if Not (BlockPayload[i] in [#32..#254]) then begin
+      errors := 'Invalid Miner Payload character at pos '+inttostr(i)+' value:'+inttostr(ord(BlockPayload[i]));
+      exit;
+    end;
+  end;
+
   CalcProofOfWork(true,FOperationBlock.proof_of_work);
   if Not AnsiSameStr(OperationBlock.proof_of_work,lastpow) then begin
     errors := 'Invalid Proof of work calculation';
@@ -1509,7 +1541,7 @@ end;
 procedure TOperationsHashTree.AddOperationToHashTree(op: TPCOperation);
 Var l : TList;
 begin
-  l := FHashTreeOperations.LockList('TOperationsHashTree.AddOperationToHashTree');
+  l := FHashTreeOperations.LockList;
   try
     InternalAddOperationToHashTree(l,op);
   finally
@@ -1522,7 +1554,7 @@ var op : TPCOperation;
   l : TList;
   i : Integer;
 begin
-  l := FHashTreeOperations.LockList('TOperationsHashTree.ClearHastThree');
+  l := FHashTreeOperations.LockList;
   try
     Try
       for i := 0 to l.Count - 1 do begin
@@ -1549,8 +1581,8 @@ begin
   end;
 
   ClearHastThree;
-  lme := FHashTreeOperations.LockList('TOperationsHashTree.CopyFromHashTree me');
-  lsender := Sender.FHashTreeOperations.LockList('TOperationsHashTree.CopyFromHashTree sender');
+  lme := FHashTreeOperations.LockList;
+  lsender := Sender.FHashTreeOperations.LockList;
   try
     ms := TMemoryStream.Create;
     Try
@@ -1588,7 +1620,7 @@ end;
 function TOperationsHashTree.GetOperation(index: Integer): TPCOperation;
 Var l : TList;
 begin
-  l := FHashTreeOperations.LockList('TOperationsHashTree.GetOperation');
+  l := FHashTreeOperations.LockList;
   try
     Result := TPCOperation(l[index]);
   finally
@@ -1602,7 +1634,7 @@ Var l,intl : TList;
   i,j : Integer;
 begin
   List.Clear;
-  l := FHashTreeOperations.LockList('TOperationsHashTree.GetOperationsAffectingAccount');
+  l := FHashTreeOperations.LockList;
   try
     intl := TList.Create;
     try
@@ -1643,7 +1675,7 @@ end;
 function TOperationsHashTree.OperationsCount: Integer;
 Var l : TList;
 begin
-  l := FHashTreeOperations.LockList('TOperationsHashTree.OperationsCount');
+  l := FHashTreeOperations.LockList;
   try
     Result := l.Count;
   finally

Units/PascalCoin/UConst.pas

@@ -69,6 +69,8 @@ Const
   CT_Op_Changekey = $02;
   CT_Op_Recover = $03;
 
+  CT_ClientAppVersion : AnsiString = '1.0.3';
+
   CT_Discover_IPs =  'bpascal1.dynamic-dns.net;bpascal2.dynamic-dns.net;pascalcoin1.ddns.net;pascalcoin2.ddns.net;pascalcoin1.dynamic-dns.net;pascalcoin1.dns1.us';
 
   CT_TRUE_FALSE : Array[Boolean] Of AnsiString = ('FALSE','TRUE');

Units/PascalCoin/UCrypto.pas

@@ -65,9 +65,7 @@ Type
     Class function HexaToRaw(const HexaString : AnsiString) : TRawBytes;
     Class function DoSha256(p : PAnsiChar; plength : Cardinal) : TRawBytes; overload;
     Class function DoSha256(const TheMessage : AnsiString) : TRawBytes; overload;
-    Class function DoDoubleSha256(p : PAnsiChar; plength : Cardinal) : TRawBytes; overload;
     Class procedure DoDoubleSha256(p : PAnsiChar; plength : Cardinal; Var ResultSha256 : TRawBytes); overload;
-    Class function DoDoubleSha256(const TheMessage : AnsiString) : TRawBytes; overload;
     Class function DoRipeMD160(const TheMessage : AnsiString) : TRawBytes;
     Class function PrivateKey2Hexa(Key : PEC_KEY) : AnsiString;
     Class function ECDSASign(Key : PEC_KEY; const digest : AnsiString) : TECDSA_SIG;
@@ -315,23 +313,6 @@ end;
 
 { TCrypto }
 
-class function TCrypto.DoDoubleSha256(const TheMessage: AnsiString): TRawBytes;
-begin
-  Result := DoSha256(DoSha256(TheMessage));
-end;
-
-class function TCrypto.DoDoubleSha256(p: PAnsiChar; plength: Cardinal): TRawBytes;
-Var PS,PS1 : PAnsiChar;
-  PC : PAnsiChar;
-begin
-  SetLength(Result,32);
-  PS := @Result[1];
-  GetMem(PS1,32);
-  SHA256(p,plength,PS1);
-  SHA256(PS1,32,PS);
-  FreeMem(PS1,32);
-end;
-
 { New at Build 1.0.2
   Note: Delphi is slowly when working with Strings (allowing space)... so to
   increase speed we use a String as a pointer, and only increase speed if

Units/PascalCoin/UDBStorage.pas

@@ -47,13 +47,13 @@ Const
   CT_TblFld_BlockChain_id = 'idblockchain';
   CT_TblFld_BlockChain_block = 'block';
   CT_TblFld_BlockChain_accountkey = 'accountkey';
-  CT_TblFld_BlockChain_reward = 'reward';
-  CT_TblFld_BlockChain_fee = 'fee';
+  CT_TblFld_BlockChain_s_reward = 's_reward';
+  CT_TblFld_BlockChain_s_fee = 's_fee';
   CT_TblFld_BlockChain_protocol_version = 'protocol_version';
   CT_TblFld_BlockChain_protocol_available = 'protocol_available';
-  CT_TblFld_BlockChain_timestamp = 'timestamp';
-  CT_TblFld_BlockChain_compact_target = 'compact_target';
-  CT_TblFld_BlockChain_nonce = 'nonce';
+  CT_TblFld_BlockChain_s_timestamp = 's_timestamp';
+  CT_TblFld_BlockChain_s_compact_target = 's_compact_target';
+  CT_TblFld_BlockChain_s_nonce = 's_nonce';
   CT_TblFld_BlockChain_rawpayload = 'rawpayload';
   CT_TblFld_BlockChain_safe_box_hash = 'safe_box_hash';
   CT_TblFld_BlockChain_operations_hash = 'operations_hash';
@@ -65,15 +65,15 @@ Const
   CT_TblFld_Operations_id = 'idoperation';
   CT_TblFld_Operations_optype = 'optype';
   CT_TblFld_Operations_block = 'block';
-  CT_TblFld_Operations_timestamp = 'timestamp';
+  CT_TblFld_Operations_s_timestamp = 's_timestamp';
   CT_TblFld_Operations_nopblock = 'nopblock';
   CT_TblFld_Operations_account = 'account';
   CT_TblFld_Operations_other_account = 'other_account';
   CT_TblFld_Operations_n_operation = 'n_operation';
   CT_TblFld_Operations_optype_op = 'optype_op';
-  CT_TblFld_Operations_amount = 'amount';
-  CT_TblFld_Operations_fee = 'fee';
-  CT_TblFld_Operations_balance = 'balance';
+  CT_TblFld_Operations_s_amount = 's_amount';
+  CT_TblFld_Operations_s_fee = 's_fee';
+  CT_TblFld_Operations_s_balance = 's_balance';
   CT_TblFld_Operations_rawpayload = 'payload';
   CT_TblFld_Operations_newaccountkey = 'newaccountkey';
   CT_TblFld_Operations_orphan = 'orphan';
@@ -134,7 +134,7 @@ Type
     Property AccessFileName : AnsiString read FAccessFileName write SetAccessFileName;
     Function SQL_UPDATE(const TblName : AnsiString; Const SetValue : AnsiString; const Where : String): Boolean;
     Function SQL_DELETE(const TblName : AnsiString; const Where : String): Boolean;
-    Function ValueToSql(const Value : Variant) : String;
+    Class Function ValueToSql(const Value : Variant) : String;
     Procedure CopyConfiguration(Const CopyFrom : TStorage); override;
     Property ADOConnection : TADOConnection read FAdoConnection;
     Class Function DBPayloadToReadableText(Const DBRawPayload : TRawBytes; Var ReadableText : AnsiString) : Boolean;
@@ -561,13 +561,13 @@ begin
       aux := TCrypto.ToHexaString( TAccountComp.AccountKey2RawString(Operations.OperationBlock.account_key) );
       if (length(aux)>255) then aux := copy(aux,1,252)+'...';
       ds.FieldByName(CT_TblFld_BlockChain_accountkey).Value := Copy(aux,1,255);
-      ds.FieldByName(CT_TblFld_BlockChain_reward).Value := Operations.OperationBlock.reward;
-      ds.FieldByName(CT_TblFld_BlockChain_fee).Value := Operations.OperationBlock.fee;
+      ds.FieldByName(CT_TblFld_BlockChain_s_reward).Value := Format('%.18d', [Operations.OperationBlock.reward] );
+      ds.FieldByName(CT_TblFld_BlockChain_s_fee).Value := Format('%.18d', [Operations.OperationBlock.fee] );
       ds.FieldByName(CT_TblFld_BlockChain_protocol_version).Value := Operations.OperationBlock.protocol_version;
       ds.FieldByName(CT_TblFld_BlockChain_protocol_available).Value := Operations.OperationBlock.protocol_available;
-      ds.FieldByName(CT_TblFld_BlockChain_timestamp).Value := Operations.OperationBlock.timestamp;
-      ds.FieldByName(CT_TblFld_BlockChain_compact_target).Value := Operations.OperationBlock.compact_target;
-      ds.FieldByName(CT_TblFld_BlockChain_nonce).Value := Operations.OperationBlock.nonce;
+      ds.FieldByName(CT_TblFld_BlockChain_s_timestamp).Value := Format('%.10d', [Operations.OperationBlock.timestamp] );
+      ds.FieldByName(CT_TblFld_BlockChain_s_compact_target).Value := Format('%.10d', [Operations.OperationBlock.compact_target] );
+      ds.FieldByName(CT_TblFld_BlockChain_s_nonce).Value := Format('%.10d', [Operations.OperationBlock.nonce] );
       DBRawToStringField(ds.FieldByName(CT_TblFld_BlockChain_rawpayload),Operations.OperationBlock.block_payload);
       ds.FieldByName(CT_TblFld_BlockChain_safe_box_hash).Value := TCrypto.ToHexaString( Operations.OperationBlock.initial_safe_box_hash );
       ds.FieldByName(CT_TblFld_BlockChain_operations_hash).Value := TCrypto.ToHexaString( Operations.OperationBlock.operations_hash );
@@ -587,16 +587,16 @@ begin
       ds.Insert;
       ds.FieldByName(CT_TblFld_Operations_optype).Value := 0;
       ds.FieldByName(CT_TblFld_Operations_block).Value := Operations.OperationBlock.block;
-      ds.FieldByName(CT_TblFld_Operations_timestamp).Value := Operations.OperationBlock.timestamp;
+      ds.FieldByName(CT_TblFld_Operations_s_timestamp).Value := Format('%.10d', [Operations.OperationBlock.timestamp] );
       ds.FieldByName(CT_TblFld_Operations_nopblock).Value := -1;
       ds.FieldByName(CT_TblFld_Operations_optype_op).Value := 0;
-      ds.FieldByName(CT_TblFld_Operations_fee).Value := 0;
+      ds.FieldByName(CT_TblFld_Operations_s_fee).Value := '0';
       ds.FieldByName(CT_TblFld_Operations_orphan).Value := vOrphan;
       ds.FieldByName(CT_TblFld_Operations_n_operation).Value := 0;
       ds.FieldByName(CT_TblFld_Operations_account).Value := Operations.OperationBlock.block * CT_AccountsPerBlock;
       ds.FieldByName(CT_TblFld_Operations_other_account).Value := Operations.OperationBlock.block * CT_AccountsPerBlock;
-      ds.FieldByName(CT_TblFld_Operations_amount).Value := Operations.OperationBlock.reward+Operations.OperationBlock.fee;
-      ds.FieldByName(CT_TblFld_Operations_balance).Value := Operations.OperationBlock.reward+Operations.OperationBlock.fee;
+      ds.FieldByName(CT_TblFld_Operations_s_amount).Value := Format('%.18d', [Operations.OperationBlock.reward+Operations.OperationBlock.fee] );
+      ds.FieldByName(CT_TblFld_Operations_s_balance).Value := Format('%.18d', [Operations.OperationBlock.reward+Operations.OperationBlock.fee] );
       ds.Post;
       // Insert operations
       for i := 0 to Operations.Count-1 do begin
@@ -604,42 +604,42 @@ begin
         op := Operations.Operation[i];
         ds.FieldByName(CT_TblFld_Operations_optype).Value := op.OpType;
         ds.FieldByName(CT_TblFld_Operations_block).Value := Operations.OperationBlock.block;
-        ds.FieldByName(CT_TblFld_Operations_timestamp).Value := Operations.OperationBlock.timestamp;
+        ds.FieldByName(CT_TblFld_Operations_s_timestamp).Value := Format('%.10d', [Operations.OperationBlock.timestamp] );
         ds.FieldByName(CT_TblFld_Operations_nopblock).Value := i;
         ds.FieldByName(CT_TblFld_Operations_optype_op).Value := 0;
-        ds.FieldByName(CT_TblFld_Operations_fee).Value := (-1)*op.OperationFee; // Fee is a Negative number
+        ds.FieldByName(CT_TblFld_Operations_s_fee).Value := Format('%.18d', [(-1)*op.OperationFee] ); // Fee is a Negative number
         ds.FieldByName(CT_TblFld_Operations_orphan).Value := vOrphan;
         case op.OpType of
           CT_Op_Transaction : Begin
             ds.FieldByName(CT_TblFld_Operations_n_operation).Value := TOpTransaction(op).Data.n_operation;
             ds.FieldByName(CT_TblFld_Operations_account).Value :=  TOpTransaction(op).Data.sender;
             ds.FieldByName(CT_TblFld_Operations_other_account).Value :=  TOpTransaction(op).Data.target;
-            ds.FieldByName(CT_TblFld_Operations_amount).Value := (-1)*TOpTransaction(op).Data.amount;
+            ds.FieldByName(CT_TblFld_Operations_s_amount).Value := Format('%.18d', [(-1)*TOpTransaction(op).Data.amount] );
             DBRawToStringField(ds.FieldByName(CT_TblFld_Operations_rawpayload),TOpTransaction(op).Data.payload);
-            ds.FieldByName(CT_TblFld_Operations_balance).Value := GetOperationBalance(i,TOpTransaction(op).Data.sender);
+            ds.FieldByName(CT_TblFld_Operations_s_balance).Value := Format('%.18d', [GetOperationBalance(i,TOpTransaction(op).Data.sender)] );
             ds.Post;
             ds.Insert;
             ds.FieldByName(CT_TblFld_Operations_optype).Value := op.OpType;
             ds.FieldByName(CT_TblFld_Operations_block).Value := Operations.OperationBlock.block;
-            ds.FieldByName(CT_TblFld_Operations_timestamp).Value := Operations.OperationBlock.timestamp;
+            ds.FieldByName(CT_TblFld_Operations_s_timestamp).Value := Format('%.10d', [Operations.OperationBlock.timestamp] );
             ds.FieldByName(CT_TblFld_Operations_nopblock).Value := i;
             ds.FieldByName(CT_TblFld_Operations_optype_op).Value := 1; // Receive transaction
-            ds.FieldByName(CT_TblFld_Operations_fee).Value := 0;  // No fee for receiver
-            ds.FieldByName(CT_TblFld_Operations_balance).Value := GetOperationBalance(i,TOpTransaction(op).Data.target);
+            ds.FieldByName(CT_TblFld_Operations_s_fee).Value := '0';  // No fee for receiver
+            ds.FieldByName(CT_TblFld_Operations_s_balance).Value := Format('%.18d', [GetOperationBalance(i,TOpTransaction(op).Data.target)] );
             ds.FieldByName(CT_TblFld_Operations_orphan).Value := vOrphan;
             ds.FieldByName(CT_TblFld_Operations_n_operation).Value := 0; // No n_operation for receiver
             ds.FieldByName(CT_TblFld_Operations_account).Value :=  TOpTransaction(op).Data.target;
             ds.FieldByName(CT_TblFld_Operations_other_account).Value :=  TOpTransaction(op).Data.sender;
-            ds.FieldByName(CT_TblFld_Operations_amount).Value := TOpTransaction(op).Data.amount;
+            ds.FieldByName(CT_TblFld_Operations_s_amount).Value := Format('%.18d', [TOpTransaction(op).Data.amount] );
             DBRawToStringField(ds.FieldByName(CT_TblFld_Operations_rawpayload),TOpTransaction(op).Data.payload);
             ds.Post;
           End;
           CT_Op_Changekey : Begin
             ds.FieldByName(CT_TblFld_Operations_n_operation).Value := TOpChangeKey(op).Data.n_operation;
             ds.FieldByName(CT_TblFld_Operations_account).Value :=  TOpChangeKey(op).Data.account;
-            ds.FieldByName(CT_TblFld_Operations_amount).Value := 0;
+            ds.FieldByName(CT_TblFld_Operations_s_amount).Value := '0';
             DBRawToStringField(ds.FieldByName(CT_TblFld_Operations_rawpayload),TOpChangeKey(op).Data.payload);
-            ds.FieldByName(CT_TblFld_Operations_balance).Value := GetOperationBalance(i,TOpChangeKey(op).Data.account); //Operations.bank.SafeBox.Account( TOpChangeKey(op).Data.account ).balance;
+            ds.FieldByName(CT_TblFld_Operations_s_balance).Value := Format('%.18d', [GetOperationBalance(i,TOpChangeKey(op).Data.account)] );
             aux := TCrypto.ToHexaString( TAccountComp.AccountKey2RawString(TOpChangeKey(op).Data.new_accountkey) );
             if (length(aux)>255) then aux := copy(aux,1,252)+'...';
             ds.FieldByName(CT_TblFld_Operations_newaccountkey).Value := Copy(aux,1,255);
@@ -648,8 +648,8 @@ begin
           CT_Op_Recover : Begin
             ds.FieldByName(CT_TblFld_Operations_n_operation).Value := TOpRecoverFounds(op).Data.n_operation;
             ds.FieldByName(CT_TblFld_Operations_account).Value :=  TOpRecoverFounds(op).Data.account;
-            ds.FieldByName(CT_TblFld_Operations_amount).Value := 0;
-            ds.FieldByName(CT_TblFld_Operations_balance).Value := GetOperationBalance(i,TOpRecoverFounds(op).Data.account); //Operations.bank.SafeBox.Account( TOpRecoverFounds(op).Data.account ).balance;
+            ds.FieldByName(CT_TblFld_Operations_s_amount).Value := '0';
+            ds.FieldByName(CT_TblFld_Operations_s_balance).Value := Format('%.18d', [GetOperationBalance(i,TOpRecoverFounds(op).Data.account)] );
             ds.Post;
           End;
         else raise Exception.Create('Development error: OpType not available to save to the Database '+Inttostr(Op.OpType));
@@ -683,10 +683,10 @@ begin
     where := where + ' AND ('+CT_TblFld_BlockChain_block+'<='+IntToStr(block_end)+')';
   end;
   if (dateStart>1000) then begin
-    where := where + ' AND ('+CT_TblFld_BlockChain_timestamp+'>='+IntToStr(UnivDateTimeToUnix(DateTime2UnivDateTime(dateStart)))+')';
+    where := where + ' AND ('+CT_TblFld_BlockChain_s_timestamp+'>='+TDBStorage.ValueToSql(Format('%.10d', [UnivDateTimeToUnix(DateTime2UnivDateTime(dateStart))]))+')';
   end;
   if (dateEnd>1000) then begin
-    where := where + ' AND ('+CT_TblFld_BlockChain_timestamp+'<'+IntToStr(UnivDateTimeToUnix(DateTime2UnivDateTime(dateEnd+1)))+')';
+    where := where + ' AND ('+CT_TblFld_BlockChain_s_timestamp+'<'+ValueToSql(Format('%.10d', [UnivDateTimeToUnix(DateTime2UnivDateTime(dateEnd+1))]))+')';
   end;
 
   Result := 'SELECT '+sqltop+' * '+
@@ -722,7 +722,7 @@ begin
           OPR := CT_TOperationResume_NUL;
           OPR.Block := ds.FieldByName(CT_TblFld_Operations_block).AsInteger;
           OPR.AffectedAccount := account_number;
-          OPR.time := ds.FieldByName(CT_TblFld_BlockChain_timestamp).AsInteger;
+          OPR.time := StrToIntDef( ds.FieldByName(CT_TblFld_BlockChain_s_timestamp).AsString,0);
           case ds.FieldByName(CT_TblFld_Operations_optype).AsInteger of
             0 : OPR.OperationTxt := 'Blockchain reward';
             CT_Op_Transaction : begin
@@ -741,9 +741,9 @@ begin
           else
             OPR.OperationTxt := 'Unknown OpType:'+Inttostr(ds.FieldByName(CT_TblFld_Operations_optype).AsInteger);
           end;
-          OPR.Amount := ds.FieldByName(CT_TblFld_Operations_amount).AsLargeInt;
-          OPR.Fee := ds.FieldByName(CT_TblFld_Operations_fee).AsLargeInt;
-          OPR.Balance := ds.FieldByName(CT_TblFld_Operations_balance).AsLargeInt;
+          OPR.Amount := StrToInt64Def( ds.FieldByName(CT_TblFld_Operations_s_amount).AsString ,0 );
+          OPR.Fee := StrToInt64Def( ds.FieldByName(CT_TblFld_Operations_s_fee).AsString ,0);
+          OPR.Balance := StrToInt64Def( ds.FieldByName(CT_TblFld_Operations_s_balance).AsString ,0);
           DBStringFieldToRaw(ds.FieldByName(CT_TblFld_Operations_rawpayload),OPR.OriginalPayload);
           If DBPayloadToReadableText(OPR.OriginalPayload,spayload) then OPR.PrintablePayload := spayload
           else OPR.PrintablePayload := TCrypto.ToHexaString(OPR.OriginalPayload);
@@ -777,10 +777,10 @@ begin
     where := where + ' AND ('+CT_TblFld_Operations_block+'<='+IntToStr(block_end)+')';
   end;
   if (dateStart>1000) then begin
-    where := where + ' AND ('+CT_TblFld_Operations_timestamp+'>='+IntToStr(UnivDateTimeToUnix(DateTime2UnivDateTime(dateStart)))+')';
+    where := where + ' AND ('+CT_TblFld_Operations_s_timestamp+'>='+ValueToSql( Format('%.10d', [UnivDateTimeToUnix(DateTime2UnivDateTime(dateStart))]))+')';
   end;
   if (dateEnd>1000) then begin
-    where := where + ' AND ('+CT_TblFld_Operations_timestamp+'<'+IntToStr(UnivDateTimeToUnix(DateTime2UnivDateTime(dateEnd+1)))+')';
+    where := where + ' AND ('+CT_TblFld_Operations_s_timestamp+'<'+ValueToSql( Format('%.10d', [UnivDateTimeToUnix(DateTime2UnivDateTime(dateEnd+1))]))+')';
   end;
 
   Result := 'SELECT '+sqltop+' * '+
@@ -878,7 +878,7 @@ begin
   End;
 end;
 
-function TDBStorage.ValueToSql(const Value: Variant): String;
+class function TDBStorage.ValueToSql(const Value: Variant): String;
 Var decs,ths : Char;
   dates,times : char;
 begin
@@ -911,7 +911,7 @@ begin
            Else Result := 'FALSE'
                       End;
          varString,varOleStr,varUString  : Begin
-             Result := VarToStr(Value);
+             Result := ''''+VarToStr(Value)+'''';
            End;
       Else // Case
         Raise Exception.Create('Invalid variant Type: '+InttoHex(VarType(Value),8));
@@ -941,7 +941,7 @@ Var P : POperationResume;
   i : Integer;
   l : TList;
 begin
-  l := FList.LockList('TOperationsResumeList.Clear');
+  l := FList.LockList;
   try
     for i := 0 to l.Count - 1 do begin
       P := l[i];
@@ -956,7 +956,7 @@ end;
 function TOperationsResumeList.Count: Integer;
 Var l : TList;
 begin
-  l := FList.LockList('TOperationsResumeList.Count');
+  l := FList.LockList;
   Try
     Result := l.Count;
   Finally
@@ -973,7 +973,7 @@ procedure TOperationsResumeList.Delete(index: Integer);
 Var P : POperationResume;
   l : TList;
 begin
-  l := FList.LockList('TOperationsResumeList.Delete');
+  l := FList.LockList;
   Try
     P := l[index];
     l.Delete(index);
@@ -993,7 +993,7 @@ end;
 function TOperationsResumeList.GetOperationResume(index: Integer): TOperationResume;
 Var l : TList;
 begin
-  l := FList.LockList('TOperationsResumeList.GetOperationResume');
+  l := FList.LockList;
   try
     if index<l.Count then Result := POperationResume(l[index])^
     else Result := CT_TOperationResume_NUL;

Units/PascalCoin/UMiner.pas

@@ -129,7 +129,7 @@ begin
     Try
       if Terminated then exit;
       winner := false;
-      TPCThread.ProtectEnterCriticalSection(Self,'Mining process',FLock);
+      TPCThread.ProtectEnterCriticalSection(Self,FLock);
       try
         FOperations.UpdateTimestamp;
         FOperations.AccountKey := FAccountKey;
@@ -187,7 +187,7 @@ end;
 
 function TMinerThread.MinerLockOperations: TPCOperationsComp;
 begin
-  TPCThread.ProtectEnterCriticalSection(Self,'MinerLockOperations',FLock);
+  TPCThread.ProtectEnterCriticalSection(Self,FLock);
   Result := FOperations;
 end;
 

Units/PascalCoin/UNode.pas

@@ -38,6 +38,7 @@ Type
     FNetServer : TNetServer;
     FMinerThreads : TPCThreadList;
     FBCBankNotify : TPCBankNotify;
+    FPeerCache : AnsiString;
     Procedure OnBankNewBlock(Sender : TObject);
     Procedure StartLocking(MaxWaitMilliseconds : Cardinal);
     Procedure EndLocking;
@@ -68,6 +69,7 @@ Type
     Procedure AutoDiscoverNodes(Const ips : AnsiString);
     Function IsBlockChainValid(var WhyNot : AnsiString) : Boolean;
     Function IsReady(Var CurrentProcess : AnsiString) : Boolean;
+    Property PeerCache : AnsiString read FPeerCache write FPeerCache;
   End;
 
   TNodeNotifyEvents = Class;
@@ -181,7 +183,7 @@ begin
     if Result then begin
       FOperations.SanitizeOperations;
       // Notify to all clients and other miners
-      mtl := FMinerThreads.LockList('TNode.AddNewBlockChain - Notify clients');
+      mtl := FMinerThreads.LockList;
       try
         for i := 0 to mtl.Count - 1 do begin
           if (mtl[i]<>SenderMiner) then begin
@@ -223,7 +225,7 @@ begin
           SenderMiner.MinerUnLockOperations(true);
         end;
         // Reset others:
-        mtl := FMinerThreads.LockList('TNode.AddNewBlockChain - Reset others');
+        mtl := FMinerThreads.LockList;
         try
           for i := 0 to mtl.Count - 1 do begin
             if (TMinerThread(mtl[i])<>SenderMiner) then begin
@@ -301,7 +303,7 @@ begin
       end;
       if Result=0 then exit;
       // Send to miners
-      mtl := FMinerThreads.LockList('TNode.AddOperations');
+      mtl := FMinerThreads.LockList;
       Try
         for i := 0 to mtl.Count - 1 do begin
           operationscomp := TMinerThread(mtl[i]).MinerLockOperations;
@@ -376,7 +378,7 @@ Var i,j : Integer;
   ips_string : AnsiString;
   nsa : TNodeServerAddress;
 begin
-  ips_string := ips;
+  ips_string := ips+';'+PeerCache;
   repeat
     If GetIp(ips_string,nsa) then begin
       TNetData.NetData.AddServer(nsa);
@@ -411,7 +413,7 @@ procedure TNode.DeleteMiner(index: Integer);
 Var m : TMinerThread;
   mtl : TList;
 begin
-  mtl := FMinerThreads.LockList('TNode.DeleteMiner');
+  mtl := FMinerThreads.LockList;
   Try
     m := TMinerThread(mtl[index]);
     m.Suspended := false;
@@ -517,7 +519,7 @@ end;
 function TNode.MinersCount : Integer;
 Var mtl : TList;
 begin
-  mtl := FMinerThreads.LockList('TNode.MinersCount');
+  mtl := FMinerThreads.LockList;
   Try
     Result := mtl.Count;
   Finally
@@ -720,8 +722,9 @@ end;
 
 procedure TThreadNodeNotifyNewBlock.BCExecute;
 begin
-  If Not TNetData.NetData.ConnectionExists(FNetConnection) then begin
-    TLog.NewLog(ltdebug,Classname,'Connection not exists');
+  If Not TNetData.NetData.ConnectionExistsAndActive(FNetConnection) then begin
+    TLog.NewLog(ltdebug,Classname,'Connection not active');
+    exit;
   end;
   TLog.NewLog(ltdebug,ClassName,'Sending new block found to '+FNetConnection.Client.RemoteHost+':'+FNetConnection.Client.RemotePort);
   FNetConnection.Send_NewBlockFound;
@@ -742,8 +745,9 @@ end;
 
 procedure TThreadNodeNotifyOperations.BCExecute;
 begin
-  If Not TNetData.NetData.ConnectionExists(FNetConnection) then begin
-    TLog.NewLog(ltdebug,Classname,'Connection not exists');
+  If Not TNetData.NetData.ConnectionExistsAndActive(FNetConnection) then begin
+    TLog.NewLog(ltdebug,Classname,'Connection not active');
+    exit;
   end;
   if FOperationsHashTree.OperationsCount<=0 then exit;
   TLog.NewLog(ltdebug,ClassName,'Sending '+inttostr(FOperationsHashTree.OperationsCount)+' Operations to '+FNetConnection.Client.RemoteHost+':'+FNetConnection.Client.RemotePort);

Units/PascalCoin/UThread.pas

@@ -23,6 +23,7 @@ Type
   TPCThreadClass = Class of TPCThread;
   TPCThread = Class(TThread)
   private
+    FDebugStep: String;
   protected
     procedure DoTerminate; override;
     procedure Execute; override;
@@ -32,7 +33,8 @@ Type
     Class function ThreadCount : Integer;
     Class function GetThread(index : Integer) : TPCThread;
     Class function TerminateAllThreads : Integer;
-    Class Procedure ProtectEnterCriticalSection(Const Sender : TObject; Const Subject : String; var Lock : TRTLCriticalSection);
+    Class Procedure ProtectEnterCriticalSection(Const Sender : TObject; var Lock : TRTLCriticalSection);
+    Property DebugStep : String read FDebugStep write FDebugStep;
   End;
 
   TPCThreadList = class
@@ -45,7 +47,7 @@ Type
     procedure Add(Item: Pointer; Const Subject : String);
     procedure Clear;
     procedure Remove(Item: Pointer); inline;
-    function LockList(Const Subject : String): TList;
+    function LockList: TList;
     procedure UnlockList; inline;
   end;
 
@@ -67,24 +69,25 @@ end;
 procedure TPCThread.Execute;
 Var l : TList;
 begin
+  FDebugStep := '';
   _threads.Add(Self,'TPCThread.Execute');
   try
-    TLog.NewLog(ltdebug,Classname,'Starting Thread');
+//    TLog.NewLog(ltdebug,Classname,'Starting Thread');
     Try
       Try
         BCExecute;
       Except
         On E:Exception do begin
-          TLog.NewLog(lterror,Classname,'Exception inside a Thread ('+E.ClassName+'): '+E.Message);
+          TLog.NewLog(lterror,Classname,'Exception inside a Thread at step: '+FDebugStep+' ('+E.ClassName+'): '+E.Message);
           Raise;
         end;
       End;
     Finally
-      TLog.NewLog(ltdebug,Classname,'Finalizing Thread');
+//      TLog.NewLog(ltdebug,Classname,'Finalizing Thread');
     End;
   finally
     if (Assigned(_threads)) then begin
-      l := _threads.LockList('TPCThread.Execute');
+      l := _threads.LockList;
       Try
         l.Remove(Self);
       Finally
@@ -98,7 +101,7 @@ class function TPCThread.GetThread(index: Integer): TPCThread;
 Var l : TList;
 begin
   Result := Nil;
-  l := _threads.LockList('TPCThread.GetThread');
+  l := _threads.LockList;
   try
     if (index<0) or (index>=l.Count) then exit;
     Result := TPCThread(l[index]);
@@ -107,14 +110,14 @@ begin
   end;
 end;
 
-class procedure TPCThread.ProtectEnterCriticalSection(Const Sender : TObject; Const Subject : String; var Lock: TRTLCriticalSection);
+class procedure TPCThread.ProtectEnterCriticalSection(Const Sender : TObject; var Lock: TRTLCriticalSection);
 begin
   if Not TryEnterCriticalSection(Lock) then begin
-    TLog.NewLog(ltdebug,Sender.Classname,Format('Locked critical section (WAIT):'+Subject+' LockCount:%d RecursionCount:%d Semaphore:%d LockOwnerThread:%s',[
-      Lock.LockCount,Lock.RecursionCount,Lock.LockSemaphore,IntToHex(Lock.OwningThread,8) ]));
+//    TLog.NewLog(ltdebug,Sender.Classname,Format('Locked critical section (WAIT): LockCount:%d RecursionCount:%d Semaphore:%d LockOwnerThread:%s',[
+//      Lock.LockCount,Lock.RecursionCount,Lock.LockSemaphore,IntToHex(Lock.OwningThread,8) ]));
     EnterCriticalSection(Lock);
-    TLog.NewLog(ltdebug,Sender.Classname,Format('UnLocked critical section (ENTER):'+Subject+' LockCount:%d RecursionCount:%d Semaphore:%d LockOwnerThread:%s',[
-      Lock.LockCount,Lock.RecursionCount,Lock.LockSemaphore,IntToHex(Lock.OwningThread,8) ]));
+//    TLog.NewLog(ltdebug,Sender.Classname,Format('UnLocked critical section (ENTER): LockCount:%d RecursionCount:%d Semaphore:%d LockOwnerThread:%s',[
+//      Lock.LockCount,Lock.RecursionCount,Lock.LockSemaphore,IntToHex(Lock.OwningThread,8) ]));
   end;
 end;
 
@@ -124,7 +127,7 @@ Var l : TList;
 begin
   Result := -1;
   if Not Assigned(_threads) then exit;
-  l := _threads.LockList('TPCThread.TerminateAllThreads');
+  l := _threads.LockList;
   try
     for i :=l.Count - 1 downto 0 do begin
       TPCThread(l[i]).Terminate;
@@ -142,7 +145,7 @@ Var l : TList;
 begin
   Result := -1;
   if Not Assigned(_threads) then exit;
-  l := _threads.LockList('TPCThread.ThreadClassFound');
+  l := _threads.LockList;
   try
     for Result := 0 to l.Count - 1 do begin
       if (TPCThread(l[Result]) is tclass) And ((l[Result])<>Exclude) then exit;
@@ -156,7 +159,7 @@ end;
 class function TPCThread.ThreadCount: Integer;
 Var l : TList;
 begin
-  l := _threads.LockList('TPCThread.ThreadCount');
+  l := _threads.LockList;
   try
     Result := l.Count;
   finally
@@ -168,7 +171,7 @@ end;
 
 procedure TPCThreadList.Add(Item: Pointer; Const Subject : String);
 begin
-  LockList('TPCThreadList.Add - '+Subject);
+  LockList;
   Try
     FList.Add(Item);
   Finally
@@ -178,7 +181,7 @@ end;
 
 procedure TPCThreadList.Clear;
 begin
-  LockList('TPCThreadList.Clear');
+  LockList;
   Try
     FList.Clear;
   Finally
@@ -194,7 +197,7 @@ end;
 
 destructor TPCThreadList.Destroy;
 begin
-  LockList('TPCThreadList.Destroy');
+  LockList;
   try
     FList.Free;
     inherited Destroy;
@@ -204,15 +207,15 @@ begin
   end;
 end;
 
-function TPCThreadList.LockList(Const Subject : String): TList;
+function TPCThreadList.LockList: TList;
 begin
-  TPCThread.ProtectEnterCriticalSection(Self,Subject,FLock);
+  TPCThread.ProtectEnterCriticalSection(Self,FLock);
   Result := FList;
 end;
 
 procedure TPCThreadList.Remove(Item: Pointer);
 begin
-  LockList('TPCThreadList.Remove');
+  LockList;
   try
     FList.Remove(Item);
   finally

Units/Utils/UAppParams.pas

@@ -297,6 +297,8 @@ end;
 
 procedure TAppParam.SetAsString(StringValue: AnsiString);
 begin
+  if (FParamType=ptString) And (GetAsString('')=StringValue) then exit;
+
   FParamType := ptString;
   FValue := StringValue;
   If Assigned(FAppParams) then FAppParams.Save;

Units/Utils/UGridUtils.pas

@@ -31,7 +31,6 @@ Type
   TOrderedCardinalList = Class
   private
     FOrderedList : TList;
-    Function Find(const Value: Cardinal; var Index: Integer): Boolean;
   public
     Constructor Create;
     Destructor Destroy; override;
@@ -40,6 +39,7 @@ Type
     Procedure Clear;
     Function Get(index : Integer) : Cardinal;
     Function Count : Integer;
+    Function Find(const Value: Cardinal; var Index: Integer): Boolean;
   End;
 
   TAccountsGrid = Class(TComponent)
@@ -71,6 +71,7 @@ Type
     Procedure LoadFromStream(Stream : TStream);
     Property ShowAllAccounts : Boolean read FShowAllAccounts write SetShowAllAccounts;
     Property AccountsBalance : Int64 read FAccountsBalance;
+    Function MoveRowToAccount(nAccount : Cardinal) : Boolean;
   End;
 
   TOperationsGrid = Class(TComponent)
@@ -312,6 +313,44 @@ begin
   Result := FAccountsList;
 end;
 
+function TAccountsGrid.MoveRowToAccount(nAccount: Cardinal): Boolean;
+Var oal : TOrderedCardinalList;
+  idx : Integer;
+begin
+  Result := false;
+  if Not Assigned(FDrawGrid) then exit;
+  if Not Assigned(Node) then exit;
+  if FDrawGrid.RowCount<=1 then exit;
+  if FShowAllAccounts then begin
+    If (FDrawGrid.RowCount>nAccount+1) And (nAccount>=0) And (nAccount<Node.Bank.AccountsCount) then begin
+      FDrawGrid.Row := nAccount+1;
+      Result := true;
+    end else begin
+      FDrawGrid.Row := FDrawGrid.RowCount-1;
+    end;
+  end else begin
+    oal := LockAccountsList;
+    try
+      If oal.Find(nAccount,idx) then begin
+        If FDrawGrid.RowCount>idx+1 then begin
+          FDrawGrid.Row := idx+1;
+          Result := true;
+        end else begin
+          FDrawGrid.Row := FDrawGrid.RowCount-1;
+        end;
+      end else begin
+        If FDrawGrid.RowCount>idx+1 then begin
+          FDrawGrid.Row := idx+1;
+        end else begin
+          FDrawGrid.Row := FDrawGrid.RowCount-1;
+        end;
+      end;
+    finally
+      UnlockAccountsList;
+    end;
+  end;
+end;
+
 procedure TAccountsGrid.Notification(AComponent: TComponent;
   Operation: TOperation);
 begin
@@ -729,7 +768,7 @@ end;
 procedure TOperationsGrid.SetNode(const Value: TNode);
 begin
   FNodeNotifyEvents.Node := Value;
-  InitGrid;
+  UpdateAccountOperations; // New Build 1.0.3
 end;
 
 procedure TOperationsGrid.SetPendingOperations(const Value: Boolean);
@@ -842,10 +881,12 @@ begin
   fld.FieldName := CT_TblFld_Operations_block;
   fld.DataSet := FQrySQL;
   fld.Visible := false;
-  fld := TIntegerField.Create(FQrySQL);
-  fld.FieldName := CT_TblFld_Operations_timestamp;
+  //
+  fld := TStringField.Create(FQrySQL);
+  fld.FieldName := CT_TblFld_Operations_s_timestamp;
   fld.DataSet := FQrySQL;
   fld.Visible := false;
+  //
   fld := TIntegerField.Create(FQrySQL);
   fld.FieldName := CT_TblFld_Operations_optype;
   fld.DataSet := FQrySQL;
@@ -885,15 +926,34 @@ begin
   fld.FieldKind := fkCalculated;
   fld.DataSet := FQrySQL;
   TStringField(fld).Size := 600;
-  fld := TIntegerField.Create(FQrySQL);
-  fld.FieldName := CT_TblFld_Operations_amount;
+  //
+  fld := TStringField.Create(FQrySQL);
+  fld.FieldName := CT_TblFld_Operations_s_amount;
   fld.DataSet := FQrySQL;
-  fld := TIntegerField.Create(FQrySQL);
-  fld.FieldName := CT_TblFld_Operations_fee;
+  fld := TLargeintField.Create(FQrySQL);
+  fld.FieldName := 'amount';
+  fld.Calculated := true;
+  fld.FieldKind := fkCalculated;
   fld.DataSet := FQrySQL;
-  fld := TIntegerField.Create(FQrySQL);
-  fld.FieldName := CT_TblFld_Operations_balance;
+
+  fld := TStringField.Create(FQrySQL);
+  fld.FieldName := CT_TblFld_Operations_s_fee;
+  fld.DataSet := FQrySQL;
+  fld := TLargeintField.Create(FQrySQL);
+  fld.FieldName := 'fee';
+  fld.Calculated := true;
+  fld.FieldKind := fkCalculated;
   fld.DataSet := FQrySQL;
+
+  fld := TStringField.Create(FQrySQL);
+  fld.FieldName := CT_TblFld_Operations_s_balance;
+  fld.DataSet := FQrySQL;
+  fld := TLargeintField.Create(FQrySQL);
+  fld.FieldName := 'balance';
+  fld.Calculated := true;
+  fld.FieldKind := fkCalculated;
+  fld.DataSet := FQrySQL;
+
   fld := TStringField.Create(FQrySQL);
   fld.FieldName := CT_TblFld_Operations_rawpayload;
   fld.DataSet := FQrySQL;
@@ -955,9 +1015,9 @@ begin
     else c.Brush.Color := clGradientInactiveCaption
   else c.Brush.Color := clWindow;
   c.FillRect(Rect);
-  if SameText(Column.FieldName,CT_TblFld_Operations_amount) Or
-     SameText(Column.FieldName,CT_TblFld_Operations_fee) Or
-     SameText(Column.FieldName,CT_TblFld_Operations_balance)
+  if SameText(Column.FieldName,'amount') Or
+     SameText(Column.FieldName,'fee') Or
+     SameText(Column.FieldName,'balance')
       then begin
     c.FillRect(Rect);
     if Column.Field.AsLargeInt>0 then c.Font.Color := ClGreen
@@ -990,7 +1050,7 @@ Var fld : TField;
   s : AnsiString;
 begin
   fld := DataSet.FieldByName('datetime');
-  fld.AsDateTime :=  UnivDateTime2LocalDateTime(UnixToUnivDateTime(DataSet.FieldByName(CT_TblFld_Operations_timestamp).AsInteger));
+  fld.AsDateTime :=  UnivDateTime2LocalDateTime(UnixToUnivDateTime( StrToIntDef( DataSet.FieldByName(CT_TblFld_Operations_s_timestamp).AsString, 0)));
   fld := DataSet.FieldByName('op_account');
   fld.AsString := TAccountComp.AccountNumberToAccountTxtNumber(DataSet.FieldByName(CT_TblFld_Operations_account).AsInteger);
   fld := DataSet.FieldByName('payload_txt');
@@ -1000,6 +1060,14 @@ begin
   end else begin
     fld.AsString := TCrypto.ToHexaString(raw);
   end;
+  //
+  fld := DataSet.FieldByName('amount');
+  TLargeintField(fld).Value := StrToInt64Def(Dataset.FieldByName(CT_TblFld_Operations_s_amount).AsString,0);
+  fld := DataSet.FieldByName('balance');
+  TLargeintField(fld).Value := StrToInt64Def(Dataset.FieldByName(CT_TblFld_Operations_s_balance).AsString,0);
+  fld := DataSet.FieldByName('fee');
+  TLargeintField(fld).Value := StrToInt64Def(Dataset.FieldByName(CT_TblFld_Operations_s_fee).AsString,0);
+
   fld := DataSet.FieldByName('operation');
           case dataset.FieldByName(CT_TblFld_Operations_optype).AsInteger of
             0 : fld.AsString := 'Blockchain reward';
@@ -1029,7 +1097,7 @@ begin
     exit;
   end;
   FNeedRefreshSQL := false;
-  sql := TDBStorage.GetOperationsFromAccountSQL(AccountNumber,BlockStart,BlockEnd,DateStart,DateEnd, 0,0);
+  sql := TDBStorage.GetOperationsFromAccountSQL(AccountNumber,BlockStart,BlockEnd,DateStart,DateEnd, 0,50000);
   If FQrySQL.Connection=Nil then exit;
   if Node=Nil then exit;
   if FDBGrid=Nil then exit;
@@ -1135,9 +1203,9 @@ begin
     AddColumn('datetime','Date/Time',120);
     AddColumn('op_account','Account',70);
     AddColumn('operation','Operation',150);
-    AddColumn(CT_TblFld_Operations_amount,'Amount',80);
-    AddColumn(CT_TblFld_Operations_fee,'Fee',60);
-    AddColumn(CT_TblFld_Operations_balance,'Balance',80);
+    AddColumn('amount','Amount',80);
+    AddColumn('fee','Fee',60);
+    AddColumn('balance','Balance',80);
     AddColumn('payload_txt','Payload',280);
     RefreshData;
   end;
@@ -1158,7 +1226,8 @@ begin
   FRM := TFRMPayloadDecoder.Create(FDBGrid.Owner);
   try
     TDBStorage.DBStringFieldToRaw(FQrySQL.FieldByName(CT_TblFld_Operations_rawpayload),raw);
-    FRM.Init(FQrySQL.FieldByName(CT_TblFld_Operations_block).AsInteger,FQrySQL.FieldByName(CT_TblFld_Operations_timestamp).AsInteger,
+    FRM.Init(FQrySQL.FieldByName(CT_TblFld_Operations_block).AsInteger,
+      StrToIntDef( FQrySQL.FieldByName(CT_TblFld_Operations_s_timestamp).AsString,0),
       FQrySQL.FieldByName('operation').AsString,
       raw,WalletKeys,AppParams);
     FRM.ShowModal;
@@ -1191,20 +1260,20 @@ begin
   fld.FieldName := CT_TblFld_BlockChain_block;
   fld.DataSet := FQrySQL;
   fld.Visible := true;
-  fld := TIntegerField.Create(FQrySQL);
-  fld.FieldName := CT_TblFld_BlockChain_timestamp;
+  fld := TStringField.Create(FQrySQL);
+  fld.FieldName := CT_TblFld_BlockChain_s_timestamp;
   fld.DataSet := FQrySQL;
   fld.Visible := false;
-  fld := TIntegerField.Create(FQrySQL);
-  fld.FieldName := CT_TblFld_BlockChain_reward;
+  fld := TStringField.Create(FQrySQL);
+  fld.FieldName := CT_TblFld_BlockChain_s_reward;
   fld.DataSet := FQrySQL;
   fld.Visible := true;
-  fld := TIntegerField.Create(FQrySQL);
-  fld.FieldName := CT_TblFld_BlockChain_fee;
+  fld := TStringField.Create(FQrySQL);
+  fld.FieldName := CT_TblFld_BlockChain_s_fee;
   fld.DataSet := FQrySQL;
   fld.Visible := true;
-  fld := TIntegerField.Create(FQrySQL);
-  fld.FieldName := CT_TblFld_BlockChain_compact_target;
+  fld := TStringField.Create(FQrySQL);
+  fld.FieldName := CT_TblFld_BlockChain_s_compact_target;
   fld.DataSet := FQrySQL;
   fld.Visible := true;
   fld := TIntegerField.Create(FQrySQL);
@@ -1233,6 +1302,18 @@ begin
   fld.DataSet := FQrySQL;
   TStringField(fld).Size := 8;
 
+  fld := TLargeintField.Create(FQrySQL);
+  fld.FieldName := 'reward';
+  fld.Calculated := true;
+  fld.FieldKind := fkCalculated;
+  fld.DataSet := FQrySQL;
+
+  fld := TLargeintField.Create(FQrySQL);
+  fld.FieldName := 'fee';
+  fld.Calculated := true;
+  fld.FieldKind := fkCalculated;
+  fld.DataSet := FQrySQL;
+
   fld := TStringField.Create(FQrySQL);
   fld.FieldName := CT_TblFld_BlockChain_rawpayload;
   fld.DataSet := FQrySQL;
@@ -1299,8 +1380,8 @@ begin
     else c.Brush.Color := clGradientInactiveCaption
   else c.Brush.Color := clWindow;
   c.FillRect(Rect);
-  if SameText(Column.FieldName,CT_TblFld_BlockChain_reward) Or
-     SameText(Column.FieldName,CT_TblFld_BlockChain_fee)
+  if SameText(Column.FieldName,'reward') Or
+     SameText(Column.FieldName,'fee')
       then begin
     c.FillRect(Rect);
     if Column.Field.AsLargeInt>0 then c.Font.Color := ClGreen
@@ -1333,9 +1414,11 @@ Var fld : TField;
   s : AnsiString;
 begin
   fld := DataSet.FieldByName('datetime');
-  fld.AsDateTime :=  UnivDateTime2LocalDateTime(UnixToUnivDateTime(DataSet.FieldByName(CT_TblFld_BlockChain_timestamp).AsInteger));
+  fld.AsDateTime :=  UnivDateTime2LocalDateTime(UnixToUnivDateTime(StrToIntDef( DataSet.FieldByName(CT_TblFld_BlockChain_s_timestamp).AsString,0)));
   fld := DataSet.FieldByName('target');
-  fld.AsString :=  IntToHex(DataSet.FieldByName(CT_TblFld_BlockChain_compact_target).AsInteger,8);
+  fld.AsString :=  IntToHex(StrToIntDef( DataSet.FieldByName(CT_TblFld_BlockChain_s_compact_target).AsString,0),8);
+  DataSet.FieldByName('reward').AsLargeInt := StrToIntDef(DataSet.FieldByName(CT_TblFld_BlockChain_s_reward).AsString,0);
+  DataSet.FieldByName('fee').AsLargeInt := StrToIntDef(DataSet.FieldByName(CT_TblFld_BlockChain_s_fee).AsString,0);
   fld := DataSet.FieldByName('payload_decoded');
   TDBStorage.DBStringFieldToRaw(DataSet.FieldByName(CT_TblFld_BlockChain_rawpayload),raw);
   If TDBStorage.DBPayloadToReadableText(raw,s) then begin
@@ -1353,7 +1436,7 @@ begin
     exit;
   end;
   FNeedRefreshSQL := false;
-  sql := TDBStorage.GetBlockChainSQL(BlockStart,BlockEnd,DateStart,DateEnd, 0,100);
+  sql := TDBStorage.GetBlockChainSQL(BlockStart,BlockEnd,DateStart,DateEnd, 0,300);
   If FQrySQL.Connection=Nil then exit;
   if Node=Nil then exit;
   if FDBGrid=Nil then exit;
@@ -1449,8 +1532,8 @@ begin
     AddColumn(CT_TblFld_BlockChain_block,'Block',50);
     AddColumn('datetime','Date/Time',120);
     AddColumn(CT_TblFld_BlockChain_operations_count,'Ops.',50);
-    AddColumn(CT_TblFld_BlockChain_reward,'Reward',80);
-    AddColumn(CT_TblFld_BlockChain_fee,'Fee',60);
+    AddColumn('reward','Reward',80);
+    AddColumn('fee','Fee',60);
     AddColumn('target','Target',65);
     AddColumn(CT_TblFld_BlockChain_safe_box_hash,'Safe Box Hash',350);
     AddColumn('payload_decoded','Miner Payload',150);