* handle for ... in on arrays of constant correctly, resolves also #25838

+ tests

git-svn-id: trunk@27039 -

.gitattributes

@@ -11348,6 +11348,8 @@ tests/test/tforin22.pp svneol=native#text/pascal
 tests/test/tforin23.pp svneol=native#text/pascal
 tests/test/tforin24.pp svneol=native#text/pascal
 tests/test/tforin25.pp svneol=native#text/pascal
+tests/test/tforin26.pp svneol=native#text/pascal
+tests/test/tforin27.pp svneol=native#text/pascal
 tests/test/tforin3.pp svneol=native#text/pascal
 tests/test/tforin4.pp svneol=native#text/pascal
 tests/test/tforin5.pp svneol=native#text/pascal

compiler/nflw.pas

@@ -579,7 +579,8 @@ implementation
               end;
           end;
 
-        if (node_complexity(expression) > 1) and not is_open_array(expression.resultdef) then
+        if (node_complexity(expression) > 1) and
+          not(is_open_array(expression.resultdef)) and not(is_array_of_const(expression.resultdef)) then
           begin
             { create a temp variable for expression }
             arrayvar := ctempcreatenode.create(

tests/test/tforin26.pp

@@ -0,0 +1,21 @@
+{$mode objfpc}
+Function Write(Const Args: Array of const) : Integer;
+
+Var
+  V : TVarRec;
+begin
+  result:=0;
+  For V in Args do
+    begin
+      if V.VType<>vtInteger then
+        halt(1);
+      inc(result);
+    end;
+end;
+
+begin
+  if Write([1,2,3,4])<>4 then
+    halt(1);
+  writeln('ok');
+end.
+

tests/test/tforin27.pp

@@ -0,0 +1,32 @@
+{$mode objfpc}
+type
+  TIntegerDynArray = array of Integer;
+
+Function Write(Const Args: TIntegerDynArray) : Integer;
+
+function GetArgs : TIntegerDynArray;
+  begin
+    GetArgs:=Args;
+  end;
+
+Var
+  I : Integer;
+begin
+  result:=0;
+  For I in GetArgs do
+    begin
+      inc(result,i);
+      inc(result);
+    end;
+end;
+
+var
+  IntegerDynArray : TIntegerDynArray;
+
+begin
+  SetLength(IntegerDynArray,4);
+  if Write(IntegerDynArray)<>4 then
+    halt(1);
+  writeln('ok');
+end.
+