regvars.pas 22 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582
  1. {
  2. $Id$
  3. Copyright (c) 1998-2000 by Florian Klaempfl and Jonas Maebe
  4. This unit handles register variable allocation
  5. This program is free software; you can redistribute it and/or modify
  6. it under the terms of the GNU General Public License as published by
  7. the Free Software Foundation; either version 2 of the License, or
  8. (at your option) any later version.
  9. This program is distributed in the hope that it will be useful,
  10. but WITHOUT ANY WARRANTY; without even the implied warranty of
  11. MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
  12. GNU General Public License for more details.
  13. You should have received a copy of the GNU General Public License
  14. along with this program; if not, write to the Free Software
  15. Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  16. ****************************************************************************
  17. }
  18. unit regvars;
  19. {$i defines.inc}
  20. interface
  21. uses
  22. aasm,
  23. node,
  24. symsym,
  25. cpubase;
  26. procedure assign_regvars(p: tnode);
  27. procedure load_regvars(asml: TAAsmoutput; p: tnode);
  28. procedure cleanup_regvars(asml: TAAsmoutput);
  29. {$ifdef i386}
  30. procedure store_regvar(asml: TAAsmoutput; reg: tregister);
  31. procedure load_regvar(asml: TAAsmoutput; vsym: pvarsym);
  32. procedure load_regvar_reg(asml: TAAsmoutput; reg: tregister);
  33. procedure load_all_regvars(asml: TAAsmoutput);
  34. {$endif i386}
  35. implementation
  36. uses
  37. globtype,systems,comphook,
  38. cutils,cobjects,verbose,globals,
  39. symconst,symbase,symtype,symdef,types,
  40. hcodegen,cpuasm,tgcpu;
  41. var
  42. parasym : boolean;
  43. procedure searchregvars(p : pnamedindexobject);
  44. var
  45. i,j,k : longint;
  46. begin
  47. if (psym(p)^.typ=varsym) and (vo_regable in pvarsym(p)^.varoptions) then
  48. begin
  49. j:=pvarsym(p)^.refs;
  50. { parameter get a less value }
  51. if parasym then
  52. begin
  53. if cs_littlesize in aktglobalswitches then
  54. dec(j,1)
  55. else
  56. dec(j,100);
  57. end;
  58. { walk through all momentary register variables }
  59. for i:=1 to maxvarregs do
  60. begin
  61. with pregvarinfo(aktprocsym^.definition^.regvarinfo)^ do
  62. if ((regvars[i]=nil) or (j>regvars_refs[i])) and (j>0) then
  63. begin
  64. for k:=maxvarregs-1 downto i do
  65. begin
  66. regvars[k+1]:=regvars[k];
  67. regvars_para[k+1]:=regvars_para[k];
  68. regvars_refs[k+1]:=regvars_refs[k];
  69. end;
  70. { calc the new refs
  71. pvarsym(p)^.refs:=j; }
  72. regvars[i]:=pvarsym(p);
  73. regvars_para[i]:=parasym;
  74. regvars_refs[i]:=j;
  75. break;
  76. end;
  77. end;
  78. end;
  79. end;
  80. procedure searchfpuregvars(p : pnamedindexobject);
  81. var
  82. i,j,k : longint;
  83. begin
  84. if (psym(p)^.typ=varsym) and (vo_fpuregable in pvarsym(p)^.varoptions) then
  85. begin
  86. j:=pvarsym(p)^.refs;
  87. { parameter get a less value }
  88. if parasym then
  89. begin
  90. if cs_littlesize in aktglobalswitches then
  91. dec(j,1)
  92. else
  93. dec(j,100);
  94. end;
  95. { walk through all momentary register variables }
  96. for i:=1 to maxfpuvarregs do
  97. begin
  98. with pregvarinfo(aktprocsym^.definition^.regvarinfo)^ do
  99. if ((fpuregvars[i]=nil) or (j>fpuregvars_refs[i])) and (j>0) then
  100. begin
  101. for k:=maxfpuvarregs-1 downto i do
  102. begin
  103. fpuregvars[k+1]:=fpuregvars[k];
  104. fpuregvars_para[k+1]:=fpuregvars_para[k];
  105. fpuregvars_refs[k+1]:=fpuregvars_refs[k];
  106. end;
  107. { calc the new refs
  108. pvarsym(p)^.refs:=j; }
  109. fpuregvars[i]:=pvarsym(p);
  110. fpuregvars_para[i]:=parasym;
  111. fpuregvars_refs[i]:=j;
  112. break;
  113. end;
  114. end;
  115. end;
  116. end;
  117. {$ifdef i386}
  118. function reg32(reg: tregister): tregister;
  119. begin
  120. case regsize(reg) of
  121. S_B: reg32 := reg8toreg32(reg);
  122. S_W: reg32 := reg16toreg32(reg);
  123. S_L: reg32 := reg;
  124. end;
  125. end;
  126. {$else i386}
  127. function reg32(reg: tregister): tregister;
  128. begin
  129. reg32 := reg;
  130. end;
  131. {$endif i386}
  132. procedure assign_regvars(p: tnode);
  133. { register variables }
  134. var
  135. regvarinfo: pregvarinfo;
  136. i: longint;
  137. begin
  138. { max. optimizations }
  139. { only if no asm is used }
  140. { and no try statement }
  141. if (cs_regalloc in aktglobalswitches) and
  142. ((procinfo^.flags and (pi_uses_asm or pi_uses_exceptions))=0) then
  143. begin
  144. new(regvarinfo);
  145. fillchar(regvarinfo^,sizeof(regvarinfo^),0);
  146. aktprocsym^.definition^.regvarinfo := regvarinfo;
  147. if (p.registers32<4) then
  148. begin
  149. parasym:=false;
  150. symtablestack^.foreach({$ifdef FPCPROCVAR}@{$endif}searchregvars);
  151. { copy parameter into a register ? }
  152. parasym:=true;
  153. symtablestack^.next^.foreach({$ifdef FPCPROCVAR}@{$endif}searchregvars);
  154. { hold needed registers free }
  155. for i:=maxvarregs downto maxvarregs-p.registers32+1 do
  156. begin
  157. regvarinfo^.regvars[i]:=nil;
  158. regvarinfo^.regvars_para[i] := false;
  159. end;
  160. { now assign register }
  161. for i:=1 to maxvarregs-p.registers32 do
  162. begin
  163. if assigned(regvarinfo^.regvars[i]) and
  164. (reg_pushes[varregs[i]] < regvarinfo^.regvars[i]^.refs) then
  165. begin
  166. { register is no longer available for }
  167. { expressions }
  168. { search the register which is the most }
  169. { unused }
  170. usableregs:=usableregs-[varregs[i]];
  171. is_reg_var[varregs[i]]:=true;
  172. dec(c_usableregs);
  173. { possibly no 32 bit register are needed }
  174. { call by reference/const ? }
  175. if (regvarinfo^.regvars[i]^.varspez in [vs_var,vs_out]) or
  176. ((regvarinfo^.regvars[i]^.varspez=vs_const) and
  177. push_addr_param(regvarinfo^.regvars[i]^.vartype.def)) then
  178. begin
  179. regvarinfo^.regvars[i]^.reg:=varregs[i];
  180. end
  181. else
  182. if (regvarinfo^.regvars[i]^.vartype.def^.deftype in [orddef,enumdef]) and
  183. (porddef(regvarinfo^.regvars[i]^.vartype.def)^.size=1) then
  184. begin
  185. {$ifdef i386}
  186. regvarinfo^.regvars[i]^.reg:=reg32toreg8(varregs[i]);
  187. {$endif}
  188. end
  189. else
  190. if (regvarinfo^.regvars[i]^.vartype.def^.deftype in [orddef,enumdef]) and
  191. (porddef(regvarinfo^.regvars[i]^.vartype.def)^.size=2) then
  192. begin
  193. {$ifdef i386}
  194. regvarinfo^.regvars[i]^.reg:=reg32toreg16(varregs[i]);
  195. {$endif}
  196. end
  197. else
  198. begin
  199. regvarinfo^.regvars[i]^.reg:=varregs[i];
  200. end;
  201. if regvarinfo^.regvars_para[i] then
  202. unused:=unused - [regvarinfo^.regvars[i]^.reg];
  203. { procedure uses this register }
  204. {$ifdef i386}
  205. usedinproc:=usedinproc or ($80 shr byte(varregs[i]));
  206. {$endif i386}
  207. {$ifdef m68k}
  208. usedinproc:=usedinproc or ($800 shr word(varregs[i]));
  209. {$endif m68k}
  210. end
  211. else
  212. begin
  213. regvarinfo^.regvars[i] := nil;
  214. regvarinfo^.regvars_para[i] := false;
  215. end;
  216. end;
  217. end;
  218. if ((p.registersfpu+1)<maxfpuvarregs) then
  219. begin
  220. parasym:=false;
  221. symtablestack^.foreach({$ifdef FPCPROCVAR}@{$endif}searchfpuregvars);
  222. {$ifdef dummy}
  223. { copy parameter into a register ? }
  224. parasym:=true;
  225. symtablestack^.next^.foreach({$ifdef FPCPROCVAR}@{$endif}searchregvars);
  226. {$endif dummy}
  227. { hold needed registers free }
  228. { in non leaf procedures we must be very careful }
  229. { with assigning registers }
  230. if aktmaxfpuregisters=-1 then
  231. begin
  232. if (procinfo^.flags and pi_do_call)<>0 then
  233. begin
  234. for i:=maxfpuvarregs downto 2 do
  235. regvarinfo^.fpuregvars[i]:=nil;
  236. end
  237. else
  238. begin
  239. for i:=maxfpuvarregs downto maxfpuvarregs-p.registersfpu do
  240. regvarinfo^.fpuregvars[i]:=nil;
  241. end;
  242. end
  243. else
  244. begin
  245. for i:=aktmaxfpuregisters+1 to maxfpuvarregs do
  246. regvarinfo^.fpuregvars[i]:=nil;
  247. end;
  248. { now assign register }
  249. for i:=1 to maxfpuvarregs do
  250. begin
  251. if assigned(regvarinfo^.fpuregvars[i]) then
  252. begin
  253. {$ifdef i386}
  254. { reserve place on the FPU stack }
  255. regvarinfo^.fpuregvars[i]^.reg:=correct_fpuregister(R_ST0,i-1);
  256. {$endif i386}
  257. {$ifdef m68k}
  258. regvarinfo^.fpuregvars[i]^.reg:=fpuvarregs[i];
  259. {$endif m68k}
  260. end;
  261. end;
  262. end;
  263. end;
  264. end;
  265. {$ifdef i386}
  266. procedure store_regvar(asml: TAAsmoutput; reg: tregister);
  267. var
  268. i: longint;
  269. hr: preference;
  270. regvarinfo: pregvarinfo;
  271. vsym: pvarsym;
  272. begin
  273. regvarinfo := pregvarinfo(aktprocsym^.definition^.regvarinfo);
  274. if not assigned(regvarinfo) then
  275. exit;
  276. for i := 1 to maxvarregs do
  277. if assigned(regvarinfo^.regvars[i]) and
  278. (reg32(regvarinfo^.regvars[i]^.reg) = reg) then
  279. begin
  280. if regvar_loaded[reg32(reg)] then
  281. begin
  282. vsym := pvarsym(regvarinfo^.regvars[i]);
  283. new(hr);
  284. reset_reference(hr^);
  285. if vsym^.owner^.symtabletype in [inlinelocalsymtable,localsymtable] then
  286. hr^.offset:=-vsym^.address+vsym^.owner^.address_fixup
  287. else hr^.offset:=vsym^.address+vsym^.owner^.address_fixup;
  288. hr^.base:=procinfo^.framepointer;
  289. asml.concat(Taicpu.op_reg_ref(A_MOV,regsize(vsym^.reg),vsym^.reg,hr));
  290. asml.concat(Tairegalloc.dealloc(reg32(reg)));
  291. regvar_loaded[reg32(reg)] := false;
  292. end;
  293. break;
  294. end;
  295. end;
  296. procedure load_regvar(asml: TAAsmoutput; vsym: pvarsym);
  297. var
  298. hr: preference;
  299. opsize: topsize;
  300. opcode: tasmop;
  301. begin
  302. if not regvar_loaded[reg32(vsym^.reg)] then
  303. begin
  304. asml.concat(Tairegalloc.alloc(reg32(vsym^.reg)));
  305. { zero the regvars because the upper 48bits must be clear }
  306. { for 8bits vars when using them with btrl }
  307. { don't care about sign extension, since the upper 24/16 }
  308. { bits won't be adapted when doing maths anyway (JM) }
  309. case regsize(vsym^.reg) of
  310. S_L:
  311. begin
  312. opsize := S_L;
  313. opcode := A_MOV;
  314. end;
  315. S_W:
  316. begin
  317. opsize := S_WL;
  318. opcode := A_MOVZX;
  319. end;
  320. S_B:
  321. begin
  322. opsize := S_BL;
  323. opcode := A_MOVZX;
  324. end;
  325. end;
  326. asml.concat(Tairegalloc.alloc(reg32(vsym^.reg)));
  327. new(hr);
  328. reset_reference(hr^);
  329. if vsym^.owner^.symtabletype in [inlinelocalsymtable,localsymtable] then
  330. hr^.offset:=-vsym^.address+vsym^.owner^.address_fixup
  331. else hr^.offset:=vsym^.address+vsym^.owner^.address_fixup;
  332. hr^.base:=procinfo^.framepointer;
  333. asml.concat(Taicpu.op_ref_reg(opcode,opsize,hr,reg32(vsym^.reg)));
  334. regvar_loaded[reg32(vsym^.reg)] := true;
  335. end;
  336. end;
  337. procedure load_regvar_reg(asml: TAAsmoutput; reg: tregister);
  338. var
  339. i: longint;
  340. regvarinfo: pregvarinfo;
  341. begin
  342. regvarinfo := pregvarinfo(aktprocsym^.definition^.regvarinfo);
  343. if not assigned(regvarinfo) then
  344. exit;
  345. reg := reg32(reg);
  346. for i := 1 to maxvarregs do
  347. if assigned(regvarinfo^.regvars[i]) and
  348. (reg32(regvarinfo^.regvars[i]^.reg) = reg) then
  349. load_regvar(asml,pvarsym(regvarinfo^.regvars[i]))
  350. end;
  351. procedure load_all_regvars(asml: TAAsmoutput);
  352. var
  353. i: longint;
  354. regvarinfo: pregvarinfo;
  355. begin
  356. regvarinfo := pregvarinfo(aktprocsym^.definition^.regvarinfo);
  357. if not assigned(regvarinfo) then
  358. exit;
  359. for i := 1 to maxvarregs do
  360. if assigned(regvarinfo^.regvars[i]) and
  361. (reg32(regvarinfo^.regvars[i]^.reg) in [R_EAX,R_EBX,R_ECX,R_EDX]) then
  362. load_regvar(asml,pvarsym(regvarinfo^.regvars[i]))
  363. end;
  364. {$endif i386}
  365. procedure load_regvars(asml: TAAsmoutput; p: tnode);
  366. var
  367. i: longint;
  368. {hr : preference;}
  369. regvarinfo: pregvarinfo;
  370. begin
  371. if (cs_regalloc in aktglobalswitches) and
  372. ((procinfo^.flags and (pi_uses_asm or pi_uses_exceptions))=0) then
  373. begin
  374. regvarinfo := pregvarinfo(aktprocsym^.definition^.regvarinfo);
  375. { can happen when inlining assembler procedures (JM) }
  376. if not assigned(regvarinfo) then
  377. exit;
  378. {$ifdef m68k}
  379. for i:=1 to maxvarregs do
  380. begin
  381. { parameter must be load }
  382. if regvarinfo^.regvars_para[i] then
  383. begin
  384. { procinfo is there actual, }
  385. { because we can't never be in a }
  386. { nested procedure }
  387. { when loading parameter to reg }
  388. new(hr);
  389. reset_reference(hr^);
  390. hr^.offset:=pvarsym(regvarinfo^.regvars[i])^.address+procinfo^.para_offset;
  391. hr^.base:=procinfo^.framepointer;
  392. asml.concat(Taicpu,op_ref_reg(A_MOVE,regsize(regvarinfo^.regvars[i]^.reg),
  393. hr,regvarinfo^.regvars[i]^.reg)));
  394. end
  395. end;
  396. {$endif m68k}
  397. for i:=1 to maxvarregs do
  398. begin
  399. if assigned(regvarinfo^.regvars[i]) then
  400. begin
  401. if cs_asm_source in aktglobalswitches then
  402. asml.insert(Tai_asm_comment.Create(strpnew(regvarinfo^.regvars[i]^.name+
  403. ' with weight '+tostr(regvarinfo^.regvars[i]^.refs)+' assigned to register '+
  404. reg2str(regvarinfo^.regvars[i]^.reg))));
  405. if (status.verbosity and v_debug)=v_debug then
  406. Message3(cg_d_register_weight,reg2str(regvarinfo^.regvars[i]^.reg),
  407. tostr(regvarinfo^.regvars[i]^.refs),regvarinfo^.regvars[i]^.name);
  408. end;
  409. end;
  410. for i:=1 to maxfpuvarregs do
  411. begin
  412. if assigned(regvarinfo^.fpuregvars[i]) then
  413. begin
  414. {$ifdef i386}
  415. { reserve place on the FPU stack }
  416. regvarinfo^.fpuregvars[i]^.reg:=correct_fpuregister(R_ST0,i-1);
  417. asml.concat(Taicpu.op_none(A_FLDZ,S_NO));
  418. {$endif i386}
  419. {$ifdef dummy}
  420. { parameter must be load }
  421. if regvarinfo^.fpuregvars_para[i] then
  422. begin
  423. { procinfo is there actual, }
  424. { because we can't never be in a }
  425. { nested procedure }
  426. { when loading parameter to reg }
  427. new(hr);
  428. reset_reference(hr^);
  429. hr^.offset:=pvarsym(regvarinfo^.regvars[i])^.address+procinfo^.para_offset;
  430. hr^.base:=procinfo^.framepointer;
  431. {$ifdef i386}
  432. asml.concat(Taicpu,op_ref_reg(A_MOV,regsize(regvarinfo^.regvars[i]^.reg),
  433. hr,regvarinfo^.regvars[i]^.reg)));
  434. {$endif i386}
  435. {$ifdef m68k}
  436. asml.concat(Taicpu,op_ref_reg(A_MOVE,regsize(regvarinfo^.regvars[i]^.reg),
  437. hr,regvarinfo^.regvars[i]^.reg)));
  438. {$endif m68k}
  439. end;
  440. {$endif dummy}
  441. end;
  442. end;
  443. if assigned(p) then
  444. if cs_asm_source in aktglobalswitches then
  445. asml.insert(Tai_asm_comment.Create(strpnew(tostr(p.registersfpu)+
  446. ' registers on FPU stack used by temp. expressions')));
  447. for i:=1 to maxfpuvarregs do
  448. begin
  449. if assigned(regvarinfo^.fpuregvars[i]) then
  450. begin
  451. if cs_asm_source in aktglobalswitches then
  452. asml.insert(Tai_asm_comment.Create(strpnew(regvarinfo^.fpuregvars[i]^.name+
  453. ' with weight '+tostr(regvarinfo^.fpuregvars[i]^.refs)+' assigned to register '+
  454. reg2str(regvarinfo^.fpuregvars[i]^.reg))));
  455. if (status.verbosity and v_debug)=v_debug then
  456. Message3(cg_d_register_weight,reg2str(regvarinfo^.fpuregvars[i]^.reg),
  457. tostr(regvarinfo^.fpuregvars[i]^.refs),regvarinfo^.fpuregvars[i]^.name);
  458. end;
  459. end;
  460. if cs_asm_source in aktglobalswitches then
  461. asml.insert(Tai_asm_comment.Create(strpnew('Register variable assignment:')));
  462. end;
  463. end;
  464. procedure cleanup_regvars(asml: TAAsmoutput);
  465. var
  466. i: longint;
  467. begin
  468. {$ifdef i386}
  469. { can happen when inlining assembler procedures (JM) }
  470. if not assigned(aktprocsym^.definition^.regvarinfo) then
  471. exit;
  472. if (cs_regalloc in aktglobalswitches) and
  473. ((procinfo^.flags and (pi_uses_asm or pi_uses_exceptions))=0) then
  474. with pregvarinfo(aktprocsym^.definition^.regvarinfo)^ do
  475. begin
  476. for i:=1 to maxfpuvarregs do
  477. if assigned(fpuregvars[i]) then
  478. { ... and clean it up }
  479. asml.concat(Taicpu.op_reg(A_FSTP,S_NO,R_ST0));
  480. for i := 1 to maxvarregs do
  481. if assigned(regvars[i]) and
  482. (regvar_loaded[reg32(regvars[i]^.reg)]) then
  483. asml.concat(Tairegalloc.dealloc(reg32(regvars[i]^.reg)));
  484. end;
  485. {$endif i386}
  486. end;
  487. end.
  488. {
  489. $Log$
  490. Revision 1.15 2000-12-25 00:07:28 peter
  491. + new tlinkedlist class (merge of old tstringqueue,tcontainer and
  492. tlinkedlist objects)
  493. Revision 1.14 2000/12/05 11:44:32 jonas
  494. + new integer regvar handling, should be much more efficient
  495. Revision 1.13 2000/11/29 00:30:39 florian
  496. * unused units removed from uses clause
  497. * some changes for widestrings
  498. Revision 1.12 2000/11/04 14:25:21 florian
  499. + merged Attila's changes for interfaces, not tested yet
  500. Revision 1.11 2000/10/31 22:02:51 peter
  501. * symtable splitted, no real code changes
  502. Revision 1.10 2000/10/14 10:14:52 peter
  503. * moehrendorf oct 2000 rewrite
  504. Revision 1.9 2000/10/01 19:48:25 peter
  505. * lot of compile updates for cg11
  506. Revision 1.8 2000/09/30 16:08:45 peter
  507. * more cg11 updates
  508. Revision 1.7 2000/09/30 13:08:16 jonas
  509. * regvars are now zeroed at the start of their life if they contain an 8
  510. or 16bit var/parameter, because the full 32bits are used if they are
  511. necessary for a btrl instruction
  512. Revision 1.6 2000/09/24 15:06:27 peter
  513. * use defines.inc
  514. Revision 1.5 2000/08/27 16:11:52 peter
  515. * moved some util functions from globals,cobjects to cutils
  516. * splitted files into finput,fmodule
  517. Revision 1.4 2000/08/17 11:07:51 jonas
  518. * fixed crash when inlining assembler procedures with -Or
  519. Revision 1.3 2000/08/04 05:52:00 jonas
  520. * correct version (I also had a regvars.pp locally, which was used
  521. instead of the regvars.pas on CVS, so I didn't notice the errors :( )
  522. Revision 1.2 2000/08/03 14:36:47 jonas
  523. * fixed inserting of allocated register for regvars (only those for
  524. parameters were done, and sometimes even the wrong ones)
  525. Revision 1.1 2000/08/03 13:17:25 jonas
  526. + allow regvars to be used inside inlined procs, which required the
  527. following changes:
  528. + load regvars in genentrycode/free them in genexitcode (cgai386)
  529. * moved all regvar related code to new regvars unit
  530. + added pregvarinfo type to hcodegen
  531. + added regvarinfo field to tprocinfo (symdef/symdefh)
  532. * deallocate the regvars of the caller in secondprocinline before
  533. inlining the called procedure and reallocate them afterwards
  534. }